Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set cache patching default time as 5 hours #18430

Conversation

koderjoker
Copy link
Member

@koderjoker koderjoker commented Mar 28, 2022

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @koderjoker Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 28, 2022

    Swagger Validation Report

    ️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.Cache/stable/2020-12-01/redis.json#L2397:9
    Old: Microsoft.Cache/stable/2020-12-01/redis.json#L2397:9
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Cache/CheckNameAvailability'
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L68
    R4009 - RequiredReadOnlySystemData The response of operation:'Redis_Create' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L172
    R4009 - RequiredReadOnlySystemData The response of operation:'Redis_Update' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L236
    R4009 - RequiredReadOnlySystemData The response of operation:'Redis_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L345
    R4009 - RequiredReadOnlySystemData The response of operation:'FirewallRules_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L828
    R4009 - RequiredReadOnlySystemData The response of operation:'FirewallRules_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L899
    R4009 - RequiredReadOnlySystemData The response of operation:'PatchSchedules_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L1067
    R4009 - RequiredReadOnlySystemData The response of operation:'PatchSchedules_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L1208
    R4009 - RequiredReadOnlySystemData The response of operation:'LinkedServer_Create' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L1273
    R4009 - RequiredReadOnlySystemData The response of operation:'LinkedServer_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L1399
    R4009 - RequiredReadOnlySystemData The response of operation:'PrivateEndpointConnections_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L1562
    R4009 - RequiredReadOnlySystemData The response of operation:'PrivateEndpointConnections_Put' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L1613
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2323
    R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Cache/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L37
    R4037 - MissingTypeObject The schema 'Sku' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L1784
    R4037 - MissingTypeObject The schema 'RedisCommonProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L1824
    R4037 - MissingTypeObject The schema 'RedisCreateProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L1946
    R4037 - MissingTypeObject The schema 'RedisUpdateProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L1978
    R4037 - MissingTypeObject The schema 'RedisProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L1993
    R4037 - MissingTypeObject The schema 'RedisCreateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2073
    R4037 - MissingTypeObject The schema 'RedisUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2109
    R4037 - MissingTypeObject The schema 'RedisAccessKeys' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2126
    R4037 - MissingTypeObject The schema 'RedisFirewallRule' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2141
    R4037 - MissingTypeObject The schema 'RedisFirewallRuleProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2167
    R4037 - MissingTypeObject The schema 'RedisFirewallRuleListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2184
    R4037 - MissingTypeObject The schema 'RedisResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2201
    R4037 - MissingTypeObject The schema 'RedisInstanceDetails' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2226
    R4037 - MissingTypeObject The schema 'RedisListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2264
    R4037 - MissingTypeObject The schema 'RedisRegenerateKeyParameters' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2281
    R4037 - MissingTypeObject The schema 'RedisRebootParameters' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2301
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
    ️❌ModelValidation: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in Operations_List.
    Url: Microsoft.Cache/stable/2020-12-01/redis.json#L38:14
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 28, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go-track2 - armredis - 0.4.0
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-redis - 13.1.0
    ️✔️azure-sdk-for-go - redis/mgmt/2021-06-01/redis - v62.3.0
    azure-sdk-for-go - redis/mgmt/2020-12-01/redis - v62.3.0
    +	Type of `CommonProperties.RedisConfiguration` has been changed from `map[string]*string` to `*CommonPropertiesRedisConfiguration`
    +	Type of `CreateProperties.RedisConfiguration` has been changed from `map[string]*string` to `*CommonPropertiesRedisConfiguration`
    +	Type of `Properties.RedisConfiguration` has been changed from `map[string]*string` to `*CommonPropertiesRedisConfiguration`
    +	Type of `UpdateProperties.RedisConfiguration` has been changed from `map[string]*string` to `*CommonPropertiesRedisConfiguration`
    azure-sdk-for-go - redis/mgmt/2020-06-01/redis - v62.3.0
    +	Type of `CommonProperties.RedisConfiguration` has been changed from `map[string]*string` to `*CommonPropertiesRedisConfiguration`
    +	Type of `CreateProperties.RedisConfiguration` has been changed from `map[string]*string` to `*CommonPropertiesRedisConfiguration`
    +	Type of `Properties.RedisConfiguration` has been changed from `map[string]*string` to `*CommonPropertiesRedisConfiguration`
    +	Type of `UpdateProperties.RedisConfiguration` has been changed from `map[string]*string` to `*CommonPropertiesRedisConfiguration`
    ️✔️azure-sdk-for-go - redis/mgmt/2018-03-01/redis - v62.3.0
    ️✔️azure-sdk-for-go - redis/mgmt/2017-10-01/redis - v62.3.0
    ️✔️azure-sdk-for-go - redis/mgmt/2017-02-01/redis - v62.3.0
    ️✔️azure-sdk-for-go - redis/mgmt/2016-04-01/redis - v62.3.0
    ️✔️azure-sdk-for-go - redis/mgmt/2015-08-01/redis - v62.3.0
    ️✔️azure-sdk-for-go - preview/redis/mgmt/2019-07-01-preview/redis - v62.3.0
    ️❌ azure-sdk-for-net failed [Detail]
    • Failed [Logs]Release - Generate from 50d804b. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-6.0
      command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/redis/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • Microsoft.Azure.Management.Redis [View full logs]  [Release SDK Changes]
      cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Generated/AsyncOperationStatusOperationsExtensions.cs(36,27): error CS0246: The type or namespace name 'OperationStatus' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Microsoft.Azure.Management.Redis.csproj]
      cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Generated/AsyncOperationStatusOperationsExtensions.cs(56,38): error CS0246: The type or namespace name 'OperationStatus' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Microsoft.Azure.Management.Redis.csproj]
      cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Generated/AsyncOperationStatusOperations.cs(83,50): error CS0246: The type or namespace name 'OperationStatus' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Microsoft.Azure.Management.Redis.csproj]
      cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Generated/IAsyncOperationStatusOperations.cs(50,37): error CS0246: The type or namespace name 'OperationStatus' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Microsoft.Azure.Management.Redis.csproj]
      cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Generated/AsyncOperationStatusOperations.cs(83,50): error CS0246: The type or namespace name 'OperationStatus' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Microsoft.Azure.Management.Redis.csproj]
      cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Generated/IAsyncOperationStatusOperations.cs(50,37): error CS0246: The type or namespace name 'OperationStatus' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Microsoft.Azure.Management.Redis.csproj]
      cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Generated/AsyncOperationStatusOperationsExtensions.cs(36,27): error CS0246: The type or namespace name 'OperationStatus' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Microsoft.Azure.Management.Redis.csproj]
      cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Generated/AsyncOperationStatusOperationsExtensions.cs(56,38): error CS0246: The type or namespace name 'OperationStatus' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Microsoft.Azure.Management.Redis.csproj]
      cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Generated/AsyncOperationStatusOperationsExtensions.cs(36,27): error CS0246: The type or namespace name 'OperationStatus' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Microsoft.Azure.Management.Redis.csproj]
      cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Generated/AsyncOperationStatusOperationsExtensions.cs(56,38): error CS0246: The type or namespace name 'OperationStatus' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Microsoft.Azure.Management.Redis.csproj]
      cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Generated/AsyncOperationStatusOperations.cs(83,50): error CS0246: The type or namespace name 'OperationStatus' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Microsoft.Azure.Management.Redis.csproj]
      cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Generated/IAsyncOperationStatusOperations.cs(50,37): error CS0246: The type or namespace name 'OperationStatus' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Microsoft.Azure.Management.Redis.csproj]
      cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Generated/AsyncOperationStatusOperations.cs(83,50): error CS0246: The type or namespace name 'OperationStatus' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Microsoft.Azure.Management.Redis.csproj]
      cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Generated/IAsyncOperationStatusOperations.cs(50,37): error CS0246: The type or namespace name 'OperationStatus' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Microsoft.Azure.Management.Redis.csproj]
      cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Generated/AsyncOperationStatusOperationsExtensions.cs(36,27): error CS0246: The type or namespace name 'OperationStatus' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Microsoft.Azure.Management.Redis.csproj]
      cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Generated/AsyncOperationStatusOperationsExtensions.cs(56,38): error CS0246: The type or namespace name 'OperationStatus' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Microsoft.Azure.Management.Redis.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Generated/AsyncOperationStatusOperationsExtensions.cs(36,27): error CS0246: The type or namespace name 'OperationStatus' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Microsoft.Azure.Management.Redis.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Generated/AsyncOperationStatusOperationsExtensions.cs(56,38): error CS0246: The type or namespace name 'OperationStatus' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Microsoft.Azure.Management.Redis.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Generated/AsyncOperationStatusOperations.cs(83,50): error CS0246: The type or namespace name 'OperationStatus' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Microsoft.Azure.Management.Redis.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Generated/IAsyncOperationStatusOperations.cs(50,37): error CS0246: The type or namespace name 'OperationStatus' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Microsoft.Azure.Management.Redis.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Generated/AsyncOperationStatusOperations.cs(83,50): error CS0246: The type or namespace name 'OperationStatus' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Microsoft.Azure.Management.Redis.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Generated/IAsyncOperationStatusOperations.cs(50,37): error CS0246: The type or namespace name 'OperationStatus' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Microsoft.Azure.Management.Redis.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Generated/AsyncOperationStatusOperationsExtensions.cs(36,27): error CS0246: The type or namespace name 'OperationStatus' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Microsoft.Azure.Management.Redis.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Generated/AsyncOperationStatusOperationsExtensions.cs(56,38): error CS0246: The type or namespace name 'OperationStatus' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Microsoft.Azure.Management.Redis.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Generated/AsyncOperationStatusOperationsExtensions.cs(36,27): error CS0246: The type or namespace name 'OperationStatus' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Microsoft.Azure.Management.Redis.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Generated/AsyncOperationStatusOperationsExtensions.cs(56,38): error CS0246: The type or namespace name 'OperationStatus' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Microsoft.Azure.Management.Redis.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Generated/AsyncOperationStatusOperations.cs(83,50): error CS0246: The type or namespace name 'OperationStatus' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Microsoft.Azure.Management.Redis.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Generated/IAsyncOperationStatusOperations.cs(50,37): error CS0246: The type or namespace name 'OperationStatus' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Microsoft.Azure.Management.Redis.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Generated/AsyncOperationStatusOperations.cs(83,50): error CS0246: The type or namespace name 'OperationStatus' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Microsoft.Azure.Management.Redis.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Generated/IAsyncOperationStatusOperations.cs(50,37): error CS0246: The type or namespace name 'OperationStatus' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Microsoft.Azure.Management.Redis.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Generated/AsyncOperationStatusOperationsExtensions.cs(36,27): error CS0246: The type or namespace name 'OperationStatus' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Microsoft.Azure.Management.Redis.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Generated/AsyncOperationStatusOperationsExtensions.cs(56,38): error CS0246: The type or namespace name 'OperationStatus' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/redis/Microsoft.Azure.Management.Redis/src/Microsoft.Azure.Management.Redis.csproj]
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 50d804b. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] npm notice
      cmderr	[automation_generate.sh] npm notice New patch version of npm available! 8.5.0 -> 8.5.5
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.5.5>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.5.5` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-redis [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation group AsyncOperationStatusOperations
      info	[Changelog]   - Model RedisCommonPropertiesRedisConfiguration has a new parameter zonal_configuration
      info	[Changelog]   - Model RedisPatchSchedule has a new parameter location
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 50d804b. SDK Automation 14.0.0
      command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️redis/mgmt/2021-06-01/redis [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️redis/mgmt/2020-12-01/redis [View full logs
      Only show 14 items here, please refer to log for details.
      info	[Changelog]
      info	[Changelog] - Type of `Properties.RedisConfiguration` has been changed from `map[string]*string` to `*CommonPropertiesRedisConfiguration`
      info	[Changelog] - Type of `UpdateProperties.RedisConfiguration` has been changed from `map[string]*string` to `*CommonPropertiesRedisConfiguration`
      info	[Changelog] - Type of `CreateProperties.RedisConfiguration` has been changed from `map[string]*string` to `*CommonPropertiesRedisConfiguration`
      info	[Changelog] - Type of `CommonProperties.RedisConfiguration` has been changed from `map[string]*string` to `*CommonPropertiesRedisConfiguration`
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New function `*CommonPropertiesRedisConfiguration.UnmarshalJSON([]byte) error`
      info	[Changelog] - New function `CommonPropertiesRedisConfiguration.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New struct `CommonPropertiesRedisConfiguration`
      info	[Changelog] - New field `Location` in struct `PatchSchedule`
      info	[Changelog]
      info	[Changelog] Total 4 breaking change(s), 5 additive change(s).
    • ️✔️redis/mgmt/2020-06-01/redis [View full logs
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `UpdateProperties.RedisConfiguration` has been changed from `map[string]*string` to `*CommonPropertiesRedisConfiguration`
      info	[Changelog] - Type of `CommonProperties.RedisConfiguration` has been changed from `map[string]*string` to `*CommonPropertiesRedisConfiguration`
      info	[Changelog] - Type of `CreateProperties.RedisConfiguration` has been changed from `map[string]*string` to `*CommonPropertiesRedisConfiguration`
      info	[Changelog] - Type of `Properties.RedisConfiguration` has been changed from `map[string]*string` to `*CommonPropertiesRedisConfiguration`
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New function `CommonPropertiesRedisConfiguration.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `*CommonPropertiesRedisConfiguration.UnmarshalJSON([]byte) error`
      info	[Changelog] - New struct `CommonPropertiesRedisConfiguration`
      info	[Changelog]
      info	[Changelog] Total 4 breaking change(s), 4 additive change(s).
    • ️✔️redis/mgmt/2018-03-01/redis [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️redis/mgmt/2017-10-01/redis [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️redis/mgmt/2017-02-01/redis [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️redis/mgmt/2016-04-01/redis [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️redis/mgmt/2015-08-01/redis [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/redis/mgmt/2019-07-01-preview/redis [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 50d804b. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armredis [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New function `NewAsyncOperationStatusClient(string, azcore.TokenCredential, *arm.ClientOptions) *AsyncOperationStatusClient`
      info	[Changelog] - New function `*AsyncOperationStatusClient.Get(context.Context, string, string, *AsyncOperationStatusClientGetOptions) (AsyncOperationStatusClientGetResponse, error)`
      info	[Changelog] - New function `ErrorDetailAutoGenerated.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `*OperationStatus.UnmarshalJSON([]byte) error`
      info	[Changelog] - New function `OperationStatus.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `OperationStatusResult.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `*OperationStatusResult.UnmarshalJSON([]byte) error`
      info	[Changelog] - New struct `AsyncOperationStatusClient`
      info	[Changelog] - New struct `AsyncOperationStatusClientGetOptions`
      info	[Changelog] - New struct `AsyncOperationStatusClientGetResponse`
      info	[Changelog] - New struct `AsyncOperationStatusClientGetResult`
      info	[Changelog] - New struct `ErrorAdditionalInfo`
      info	[Changelog] - New struct `ErrorDetailAutoGenerated`
      info	[Changelog] - New struct `OperationStatus`
      info	[Changelog] - New struct `OperationStatusResult`
      info	[Changelog] - New field `ZonalConfiguration` in struct `CommonPropertiesRedisConfiguration`
      info	[Changelog] - New field `Location` in struct `PatchSchedule`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 25 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 50d804b. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      cmderr	[automation_init.sh] npm WARN deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
      cmderr	[automation_init.sh] deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
      cmderr	[automation_init.sh] deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
      cmderr	[automation_init.sh]  WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-rediscache [View full logs]  [Release SDK Changes]
      info	[Changelog]
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 50d804b. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @koderjoker, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @openapi-workflow-bot
    Copy link

    Hi @koderjoker, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @@ -2397,7 +2397,8 @@
    "maintenanceWindow": {
    "type": "string",
    "format": "duration",
    "description": "ISO8601 timespan specifying how much time cache patching can take. "
    "description": "ISO8601 timespan specifying how much time cache patching can take.",
    "default": "PT5H"
    Copy link
    Contributor

    @priyankarking priyankarking Mar 28, 2022

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    is it kind of read-only property also, as user is not setting it?

    Copy link
    Member Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Actually the user can set this property, it's the existence of its default value that raised the issue

    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    thanks for info.

    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Mar 28, 2022
    @koderjoker
    Copy link
    Member Author

    Hi @chunyu3, the section for which required checks for Model Validation are failing aren't part of the changes in my PR. Could you please ignore the failing required check 'Swagger ModelValidation', apply the 'Approved-ModelValidation' label and merge in my pull request? Thanks!

    Please also refer to previous occurrence: #17687 (comment)

    @chunyu3
    Copy link
    Member

    chunyu3 commented Mar 30, 2022

    Model Validation failure are not caused by the changes in this PR. Ignore the failing required check 'Swagger ModelValidation', apply the 'Approved-ModelValidation' label .Thanks!

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-ModelValidation CI-FixRequiredOnFailure FixS360
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants