[Hub Generated] Review request for Microsoft.DataFactory to add version stable/2018-06-01 #18439

naddonik · 2022-03-28T19:33:05Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2022-03-28T19:33:08Z

Hi, @naddonik Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2022-03-28T19:33:08Z

Swagger Validation Report

️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.9.3)
- current:stable/2018-06-01/entityTypes compared with base:stable/2018-06-01/entityTypes
- current:stable/2018-06-01/datafactory.json compared with base:stable/2018-06-01/datafactory.json

Rule	Message
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4368:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4413:5

️⚠️LintDiff: 1 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.12.3 , classic-openapi-validator v1.2.4 )
- datafactory/resource-manager/readme.md tag:package-2018-06
Linted configuring files (Based on target branch, openapi-validator v1.12.3 , classic-openapi-validator v1.2.4 )
- datafactory/resource-manager/readme.md tag:package-2018-06

The following errors/warnings are introduced by current PR:

Rule	Message
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5605

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4872
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L6058
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L6183
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L6642
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L6646
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L6678
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L6803
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L6897
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L6901
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L6917
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.DataFactory/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L36
`❌` R4037 - MissingTypeObject	The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4558
`❌` R4037 - MissingTypeObject	The schema 'SubResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4599
`❌` R4037 - MissingTypeObject	The schema 'SubResourceDebugResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4625
`❌` R4037 - MissingTypeObject	The schema 'IntegrationRuntimeReference' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4756
`❌` R4037 - MissingTypeObject	The schema 'IntegrationRuntimeReference' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4756
`❌` R4037 - MissingTypeObject	The schema 'IntegrationRuntimeReference' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4756
`❌` R4037 - MissingTypeObject	The schema 'IntegrationRuntimeResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4780
`❌` R4037 - MissingTypeObject	The schema 'IntegrationRuntimeDebugResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4797
`❌` R4037 - MissingTypeObject	The schema 'IntegrationRuntimeStatusResponse' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4814
`❌` R4037 - MissingTypeObject	The schema 'FactoryRepoUpdate' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5297
`❌` R4037 - MissingTypeObject	The schema 'GitHubAccessTokenRequest' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5310
`❌` R4037 - MissingTypeObject	The schema 'GitHubAccessTokenResponse' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5335
`❌` R4037 - MissingTypeObject	The schema 'UserAccessPolicy' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5344
`❌` R4037 - MissingTypeObject	The schema 'AccessPolicyResponse' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5369
`❌` R4037 - MissingTypeObject	The schema 'FactoryProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5386
`❌` R4037 - MissingTypeObject	The schema 'EncryptionConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5449
`❌` R4037 - MissingTypeObject	The schema 'CMKIdentityDefinition' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5474
`❌` R4037 - MissingTypeObject	The schema 'PipelineReference' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5542
`❌` R4037 - MissingTypeObject	The schema 'PipelineReference' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5542

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

datafactory/resource-manager/readme.md#package-2018-06

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-03-28T19:33:09Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

️✔️azure-sdk-for-go-track2 - armdatafactory - 0.5.0
️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-datafactory - 2.3.0
❌azure-sdk-for-go - datafactory/mgmt/2018-06-01/datafactory - Approved - v63.2.0

+	Function `SQLServerStoredProcedureActivityTypeProperties.MarshalJSON` has been removed
+	Type of `SQLServerStoredProcedureActivityTypeProperties.StoredProcedureParameters` has been changed from `map[string]*StoredProcedureParameter` to `interface{}`

❌azure-sdk-for-go - preview/datafactory/mgmt/2017-09-01-preview/datafactory - Approved - v63.2.0

+	Const `Initial` has been removed
+	Const `Limited` has been removed
+	Const `ManagedIntegrationRuntimeNodeStatusAvailable` has been removed
+	Const `ManagedIntegrationRuntimeNodeStatusRecycling` has been removed
+	Const `ManagedIntegrationRuntimeNodeStatusStarting` has been removed
+	Const `ManagedIntegrationRuntimeNodeStatusUnavailable` has been removed
+	Const `NeedRegistration` has been removed
+	Const `Offline` has been removed
+	Const `Online` type has been changed from `IntegrationRuntimeState` to `DynamicsDeploymentType`
+	Const `Started` type has been changed from `IntegrationRuntimeState` to `TriggerRuntimeState`
+	Const `Starting` type has been changed from `IntegrationRuntimeState` to `ManagedIntegrationRuntimeNodeStatus`
+	Const `Stopped` type has been changed from `IntegrationRuntimeState` to `TriggerRuntimeState`
+	Const `Stopping` has been removed
+	Const `TriggerRuntimeStateDisabled` has been removed
+	Const `TriggerRuntimeStateStarted` has been removed
+	Const `TriggerRuntimeStateStopped` has been removed
+	Type of `AzureSearchIndexSink.WriteBehavior` has been changed from `interface{}` to `AzureSearchIndexWriteBehaviorType`
+	Type of `CassandraSource.ConsistencyLevel` has been changed from `interface{}` to `CassandraSourceReadConsistencyLevels`
+	Type of `DatasetDeflateCompression.Level` has been changed from `interface{}` to `DatasetCompressionLevel`
+	Type of `DatasetGZipCompression.Level` has been changed from `interface{}` to `DatasetCompressionLevel`
+	Type of `DatasetZipDeflateCompression.Level` has been changed from `interface{}` to `DatasetCompressionLevel`
+	Type of `DynamicsLinkedServiceTypeProperties.AuthenticationType` has been changed from `interface{}` to `DynamicsAuthenticationType`
+	Type of `DynamicsLinkedServiceTypeProperties.DeploymentType` has been changed from `interface{}` to `DynamicsDeploymentType`
+	Type of `DynamicsSink.WriteBehavior` has been changed from `interface{}` to `*string`
+	Type of `PolybaseSettings.RejectType` has been changed from `interface{}` to `PolybaseSettingsRejectType`
+	Type of `SalesforceSink.WriteBehavior` has been changed from `interface{}` to `SalesforceSinkWriteBehavior`
+	Type of `SalesforceSource.ReadBehavior` has been changed from `interface{}` to `SalesforceSourceReadBehavior`
+	Type of `SapCloudForCustomerSink.WriteBehavior` has been changed from `interface{}` to `SapCloudForCustomerSinkWriteBehavior`
+	Type of `StoredProcedureParameter.Type` has been changed from `interface{}` to `StoredProcedureParameterType`

️❌ azure-powershell failed [Detail]

❌Failed [Logs]Release - Generate from 61d12d5. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

❌Az.datafactory [View full logs] [Release SDK Changes]

️❌ azure-sdk-for-net failed [Detail]

❌Failed [Logs]Release - Generate from 61d12d5. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/datafactory/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] No usable version of the libssl was found
cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
warn	Skip package processing as generation is failed

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 61d12d5. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-datafactory [View full logs] [Release SDK Changes]

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group GlobalParametersOperations
info	[Changelog]   - Model DataFlowSink has a new parameter rejected_data_linked_service
info	[Changelog]   - Model ExecuteDataFlowActivity has a new parameter source_staging_concurrency
info	[Changelog]   - Model ExecuteDataFlowActivityTypeProperties has a new parameter source_staging_concurrency
info	[Changelog]   - Model ExecutePowerQueryActivityTypeProperties has a new parameter source_staging_concurrency
info	[Changelog]   - Model ExecuteWranglingDataflowActivity has a new parameter source_staging_concurrency
info	[Changelog]   - Model Factory has a new parameter purview_configuration
info	[Changelog]   - Model PowerQuerySink has a new parameter rejected_data_linked_service

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 61d12d5. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
cmderr	[generate.py] [ForkJoinPool-1-worker-3] INFO com.azure.core.test.implementation.TestingHelpers - Environment variable 'AZURE_TEST_MODE' has not been set yet. Using 'Playback' mode.

️✔️azure-resourcemanager-datafactory [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 61d12d5. SDK Automation 14.0.0

command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️datafactory/mgmt/2018-06-01/datafactory [View full logs] [Release SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New function `GlobalParametersClient.ListByFactory(context.Context, string, string) (GlobalParameterListResponsePage, error)`
info	[Changelog] - New function `GlobalParametersClient.GetSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `GlobalParametersClient.ListByFactoryComplete(context.Context, string, string) (GlobalParameterListResponseIterator, error)`
info	[Changelog] - New function `GlobalParametersClient.DeletePreparer(context.Context, string, string, string) (*http.Request, error)`
info	[Changelog] - New function `GlobalParameterListResponseIterator.Value() GlobalParameterResource`
info	[Changelog] - New function `GlobalParametersClient.GetPreparer(context.Context, string, string, string) (*http.Request, error)`
info	[Changelog] - New function `GlobalParameterResource.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `GlobalParametersClient.DeleteSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `GlobalParametersClient.CreateOrUpdateSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `*GlobalParameterListResponsePage.Next() error`
info	[Changelog] - New function `GlobalParametersClient.GetResponder(*http.Response) (GlobalParameterResource, error)`
info	[Changelog] - New function `GlobalParametersClient.ListByFactoryResponder(*http.Response) (GlobalParameterListResponse, error)`
info	[Changelog] - New function `GlobalParameterListResponse.IsEmpty() bool`
info	[Changelog] - New function `GlobalParameterListResponseIterator.Response() GlobalParameterListResponse`
info	[Changelog] - New function `GlobalParameterListResponseIterator.NotDone() bool`
info	[Changelog] - New function `*GlobalParameterListResponsePage.NextWithContext(context.Context) error`
info	[Changelog] - New function `NewGlobalParameterListResponseIterator(GlobalParameterListResponsePage) GlobalParameterListResponseIterator`
info	[Changelog] - New function `GlobalParameterListResponsePage.Values() []GlobalParameterResource`
info	[Changelog] - New function `GlobalParametersClient.Delete(context.Context, string, string, string) (autorest.Response, error)`
info	[Changelog] - New function `GlobalParametersClient.DeleteResponder(*http.Response) (autorest.Response, error)`
info	[Changelog] - New function `GlobalParametersClient.Get(context.Context, string, string, string) (GlobalParameterResource, error)`
info	[Changelog] - New function `NewGlobalParametersClientWithBaseURI(string, string) GlobalParametersClient`
info	[Changelog] - New function `GlobalParametersClient.ListByFactoryPreparer(context.Context, string, string) (*http.Request, error)`
info	[Changelog] - New function `NewGlobalParameterListResponsePage(GlobalParameterListResponse, func(context.Context, GlobalParameterListResponse) (GlobalParameterListResponse, error)) GlobalParameterListResponsePage`
info	[Changelog] - New function `GlobalParameterListResponsePage.NotDone() bool`
info	[Changelog] - New function `*GlobalParameterListResponseIterator.NextWithContext(context.Context) error`
info	[Changelog] - New function `NewGlobalParametersClient(string) GlobalParametersClient`
info	[Changelog] - New function `GlobalParametersClient.ListByFactorySender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `GlobalParametersClient.CreateOrUpdate(context.Context, string, string, string, GlobalParameterResource) (GlobalParameterResource, error)`
info	[Changelog] - New function `GlobalParameterListResponsePage.Response() GlobalParameterListResponse`
info	[Changelog] - New function `*GlobalParameterListResponseIterator.Next() error`
info	[Changelog] - New function `GlobalParametersClient.CreateOrUpdateResponder(*http.Response) (GlobalParameterResource, error)`
info	[Changelog] - New function `GlobalParametersClient.CreateOrUpdatePreparer(context.Context, string, string, string, GlobalParameterResource) (*http.Request, error)`
info	[Changelog] - New struct `GlobalParameterListResponse`
info	[Changelog] - New struct `GlobalParameterListResponseIterator`
info	[Changelog] - New struct `GlobalParameterListResponsePage`
info	[Changelog] - New struct `GlobalParameterResource`
info	[Changelog] - New struct `GlobalParametersClient`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 43 additive change(s).

️✔️preview/datafactory/mgmt/2017-09-01-preview/datafactory [View full logs]

Only show 60 items here, please refer to log for details.

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `LOCALONE`
info	[Changelog] - New const `TWO`
info	[Changelog] - New const `Decimal`
info	[Changelog] - New const `Upload`
info	[Changelog] - New const `Upsert`
info	[Changelog] - New const `IntegrationRuntimeStateLimited`
info	[Changelog] - New const `IntegrationRuntimeStateStarting`
info	[Changelog] - New const `EACHQUORUM`
info	[Changelog] - New const `QUORUM`
info	[Changelog] - New const `Merge`
info	[Changelog] - New const `THREE`
info	[Changelog] - New const `Int`
info	[Changelog] - New const `Available`
info	[Changelog] - New const `Date`
info	[Changelog] - New const `LOCALQUORUM`
info	[Changelog] - New const `String`
info	[Changelog] - New const `Ifd`
info	[Changelog] - New const `SapCloudForCustomerSinkWriteBehaviorInsert`
info	[Changelog] - New const `Value`
info	[Changelog] - New const `ALL`
info	[Changelog] - New const `IntegrationRuntimeStateStarted`
info	[Changelog] - New const `Unavailable`
info	[Changelog] - New const `IntegrationRuntimeStateInitial`
info	[Changelog] - New const `Query`
info	[Changelog] - New const `Fastest`
info	[Changelog] - New const `SERIAL`
info	[Changelog] - New const `OnPremisesWithIfd`
info	[Changelog] - New const `IntegrationRuntimeStateStopped`
info	[Changelog] - New const `Percentage`
info	[Changelog] - New const `Boolean`
info	[Changelog] - New const `IntegrationRuntimeStateOnline`
info	[Changelog] - New const `GUID`
info	[Changelog] - New const `IntegrationRuntimeStateStopping`
info	[Changelog] - New const `Insert`
info	[Changelog] - New const `Recycling`
info	[Changelog] - New const `LOCALSERIAL`
info	[Changelog] - New const `Optimal`
info	[Changelog] - New const `Office365`
info	[Changelog] - New const `QueryAll`
info	[Changelog] - New const `IntegrationRuntimeStateOffline`
info	[Changelog] - New const `SapCloudForCustomerSinkWriteBehaviorUpdate`
info	[Changelog] - New const `ONE`
info	[Changelog] - New const `IntegrationRuntimeStateNeedRegistration`
info	[Changelog] - New const `Int64`
info	[Changelog] - New const `Disabled`
info	[Changelog] - New function `PossibleAzureSearchIndexWriteBehaviorTypeValues() []AzureSearchIndexWriteBehaviorType`
info	[Changelog] - New function `PossiblePolybaseSettingsRejectTypeValues() []PolybaseSettingsRejectType`
info	[Changelog] - New function `PossibleSapCloudForCustomerSinkWriteBehaviorValues() []SapCloudForCustomerSinkWriteBehavior`
info	[Changelog] - New function `PossibleSalesforceSinkWriteBehaviorValues() []SalesforceSinkWriteBehavior`
info	[Changelog] - New function `PossibleDynamicsDeploymentTypeValues() []DynamicsDeploymentType`
info	[Changelog] - New function `PossibleCassandraSourceReadConsistencyLevelsValues() []CassandraSourceReadConsistencyLevels`
info	[Changelog] - New function `PossibleStoredProcedureParameterTypeValues() []StoredProcedureParameterType`
info	[Changelog] - New function `PossibleDynamicsAuthenticationTypeValues() []DynamicsAuthenticationType`
info	[Changelog] - New function `PossibleDatasetCompressionLevelValues() []DatasetCompressionLevel`
info	[Changelog] - New function `PossibleSalesforceSourceReadBehaviorValues() []SalesforceSourceReadBehavior`
info	[Changelog] - New field `DisableCertValidation` in struct `WebActivityTypeProperties`
info	[Changelog]
info	[Changelog] Total 28 breaking change(s), 56 additive change(s).

️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 61d12d5. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️armdatafactory [View full logs] [Release SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New function `GlobalParameterResource.MarshalJSON() ([]byte, error)`
info	[Changelog] - New struct `GlobalParameterListResponse`
info	[Changelog] - New struct `GlobalParameterResource`
info	[Changelog] - New struct `GlobalParametersClientCreateOrUpdateOptions`
info	[Changelog] - New struct `GlobalParametersClientCreateOrUpdateResponse`
info	[Changelog] - New struct `GlobalParametersClientDeleteOptions`
info	[Changelog] - New struct `GlobalParametersClientDeleteResponse`
info	[Changelog] - New struct `GlobalParametersClientGetOptions`
info	[Changelog] - New struct `GlobalParametersClientGetResponse`
info	[Changelog] - New struct `GlobalParametersClientListByFactoryOptions`
info	[Changelog] - New struct `GlobalParametersClientListByFactoryResponse`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 21 additive change(s).

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs]Release - Generate from 61d12d5. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh] npm WARN deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh] deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh]  @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh]  deprecated @azure/storage-blob@10.5.0: This version has been deprecated, please upgrade to the version tagged as latest
cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-datafactory [View full logs] [Release SDK Changes]

azure-arm-datafactory-10.6.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group GlobalParameters
info	[Changelog]   - Added Interface GlobalParameterListResponse
info	[Changelog]   - Added Interface GlobalParametersCreateOrUpdateOptionalParams
info	[Changelog]   - Added Interface GlobalParametersDeleteOptionalParams
info	[Changelog]   - Added Interface GlobalParametersGetOptionalParams
info	[Changelog]   - Added Interface GlobalParametersListByFactoryNextOptionalParams
info	[Changelog]   - Added Interface GlobalParametersListByFactoryOptionalParams
info	[Changelog]   - Added Interface PurviewConfiguration
info	[Changelog]   - Added Type Alias GlobalParameterResource
info	[Changelog]   - Added Type Alias GlobalParametersCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias GlobalParametersGetResponse
info	[Changelog]   - Added Type Alias GlobalParametersListByFactoryNextResponse
info	[Changelog]   - Added Type Alias GlobalParametersListByFactoryResponse
info	[Changelog]   - Interface ExecuteDataFlowActivityTypeProperties has a new optional parameter sourceStagingConcurrency
info	[Changelog]   - Class DataFactoryManagementClient has a new parameter globalParameters
info	[Changelog]   - Type Alias ExecuteDataFlowActivity has a new parameter sourceStagingConcurrency
info	[Changelog]   - Type Alias ExecuteWranglingDataflowActivity has a new parameter sourceStagingConcurrency
info	[Changelog]   - Type Alias Factory has a new parameter purviewConfiguration
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 61d12d5. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️datafactory [View full logs] [Release Schema Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2022-03-28T19:33:09Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-workflow-bot · 2022-03-28T19:35:07Z

Hi @naddonik, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

openapi-workflow-bot · 2022-04-12T20:46:58Z

NewApiVersionRequired reason:

A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

openapi-workflow-bot · 2022-04-14T19:07:31Z

Hi, @naddonik your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

naddonik · 2022-04-14T21:15:38Z

I am not sure why SDK azure-sdk-for-net check is failing with Permission Denied error

openapi-workflow-bot · 2022-04-22T02:33:13Z

Hi @naddonik, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

leni-msft · 2022-04-22T02:35:34Z

@fengzhou-msft @tadelesh please check .net sdk generation failure and go sdk breaking changes

Added Global Parameters CRUD APIs

0ce29cb

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Mar 28, 2022

Kevin Naddoni added 2 commits March 28, 2022 13:51

Small JSON fix

c8c3a43

Updated Global parameters definitions

e33ee64

openapi-pipeline-app bot added the NewApiVersionRequired label Apr 12, 2022

Small typo fix

fb97e46

Kevin Naddoni added 7 commits April 13, 2022 08:45

Added spec and fixed delete

f1efdf4

Correct path

af67500

Fixed casing

f93cf84

Added references

7faf2ca

Small case fix

bc3428f

Small fix and prettier cleanup

60a77a6

Added type object

f3b6b38

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label Apr 14, 2022

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 14, 2022

naddonik requested a review from leni-msft April 14, 2022 21:09

leni-msft added the BreakingChangeReviewRequired label Apr 22, 2022

naddonik marked this pull request as ready for review May 2, 2022 18:09

naddonik requested review from Frey-Wang, zhangyd2015 and davidzhaoyue as code owners May 2, 2022 18:09

openapi-assignment-bot bot assigned leni-msft May 2, 2022

Frey-Wang approved these changes May 18, 2022

View reviewed changes

tadelesh added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label May 18, 2022

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label May 19, 2022

lmazuel merged commit 61d12d5 into Azure:main May 20, 2022

Jingshu923 mentioned this pull request May 23, 2022

[DataFactory]Added new features into 6.2.0 Azure/azure-sdk-for-net#28916

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.DataFactory to add version stable/2018-06-01 #18439

[Hub Generated] Review request for Microsoft.DataFactory to add version stable/2018-06-01 #18439

naddonik commented Mar 28, 2022 •

edited

Loading

openapi-workflow-bot bot commented Mar 28, 2022

openapi-pipeline-app bot commented Mar 28, 2022 •

edited

Loading

openapi-pipeline-app bot commented Mar 28, 2022 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented Mar 28, 2022

openapi-workflow-bot bot commented Mar 28, 2022

openapi-workflow-bot bot commented Apr 12, 2022

openapi-workflow-bot bot commented Apr 14, 2022

naddonik commented Apr 14, 2022

openapi-workflow-bot bot commented Apr 22, 2022

leni-msft commented Apr 22, 2022

[Hub Generated] Review request for Microsoft.DataFactory to add version stable/2018-06-01 #18439

[Hub Generated] Review request for Microsoft.DataFactory to add version stable/2018-06-01 #18439

Conversation

naddonik commented Mar 28, 2022 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Mar 28, 2022

openapi-pipeline-app bot commented Mar 28, 2022 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Mar 28, 2022 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented Mar 28, 2022

openapi-workflow-bot bot commented Mar 28, 2022

openapi-workflow-bot bot commented Apr 12, 2022

openapi-workflow-bot bot commented Apr 14, 2022

naddonik commented Apr 14, 2022

openapi-workflow-bot bot commented Apr 22, 2022

leni-msft commented Apr 22, 2022

naddonik commented Mar 28, 2022 •

edited

Loading

openapi-pipeline-app bot commented Mar 28, 2022 •

edited

Loading

openapi-pipeline-app bot commented Mar 28, 2022 •

edited

Loading