-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rebranding api docs from asc to mdfc #18500
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ub.com/ariklin/azure-rest-api-specs into azure-rest-api-specs-securitySolutions
@ruowan - please consider my recent modifications. |
ruowan
approved these changes
May 13, 2022
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
The model validation and semantic validation is not introduced in this PR. I add approved label. But @ariklin pls fix prettier check error |
@ruowan - prettier check pass, thnak you for your help |
LGTM, merged. @ariklin |
This was referenced May 17, 2022
Closed
kayousef-zz
pushed a commit
to kayousef-zz/azure-rest-api-specs
that referenced
this pull request
Dec 20, 2022
* Copy solutions files from 2015-06-01-preview * update API version * update readme * Add required to ExternalSecuritySolution * add new swagger files * fix errors1 * fix2 * fix 3 * fix 4 * fix4 * fix4 * fix conflict * fix conflict2 * fix conflict4 * fix conflict 6 * fix conflict 7 * ttt * rrr * aaa * bbb * fix 10 * Prettier check * update readme * fix reference error * fix comment * fix conflict * fic conflict2 * fix conflict3 * fix conflict4 * remove files * delete externalSecuritySolutions * add assessments.json * fix readme.md * Fix validation errors 1 * Fix validation errors 2 * merge * Fix validation errors 3 * Fix validation errors 4 * Fix validation errors 5 * Fix validation errors 5 * Fix validation errors 5 * Fix validation errors 6 * Fix validation errors 4 * Fix validation errors 7 * Fix validation errors 8 * Fix validation errors 9 * Fix validation errors 10 * fix validation errors 11 * fix validation errors 11 * ix validation errors 12 * ix validation errors 13 * fix validation errors 14 * Fix validation errors 15 * Fix validation errors 16 * run prettier * Defining the APIs for the new NSP resource * test * SecuritySolution test * 2 * org * 1 * Rebranding effort * Update SecuritySolutions.json * Delete readme.md * ASC to MDC - rebranding * 1 * merge3 * update5 * update readme * update6 * update 6 * fix securitySolution * Create SecuritySolutions.json Co-authored-by: Arik Riklin <arik.riklin@microsoft.com> Co-authored-by: Hari Prasad Perabattula <harics24@users.noreply.github.com> Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com>
kayousef-zz
pushed a commit
to kayousef-zz/azure-rest-api-specs
that referenced
this pull request
Dec 21, 2022
* Copy solutions files from 2015-06-01-preview * update API version * update readme * Add required to ExternalSecuritySolution * add new swagger files * fix errors1 * fix2 * fix 3 * fix 4 * fix4 * fix4 * fix conflict * fix conflict2 * fix conflict4 * fix conflict 6 * fix conflict 7 * ttt * rrr * aaa * bbb * fix 10 * Prettier check * update readme * fix reference error * fix comment * fix conflict * fic conflict2 * fix conflict3 * fix conflict4 * remove files * delete externalSecuritySolutions * add assessments.json * fix readme.md * Fix validation errors 1 * Fix validation errors 2 * merge * Fix validation errors 3 * Fix validation errors 4 * Fix validation errors 5 * Fix validation errors 5 * Fix validation errors 5 * Fix validation errors 6 * Fix validation errors 4 * Fix validation errors 7 * Fix validation errors 8 * Fix validation errors 9 * Fix validation errors 10 * fix validation errors 11 * fix validation errors 11 * ix validation errors 12 * ix validation errors 13 * fix validation errors 14 * Fix validation errors 15 * Fix validation errors 16 * run prettier * Defining the APIs for the new NSP resource * test * SecuritySolution test * 2 * org * 1 * Rebranding effort * Update SecuritySolutions.json * Delete readme.md * ASC to MDC - rebranding * 1 * merge3 * update5 * update readme * update6 * update 6 * fix securitySolution * Create SecuritySolutions.json Co-authored-by: Arik Riklin <arik.riklin@microsoft.com> Co-authored-by: Hari Prasad Perabattula <harics24@users.noreply.github.com> Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.