Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebranding api docs from asc to mdfc #18500

Merged
merged 95 commits into from
May 17, 2022
Merged

rebranding api docs from asc to mdfc #18500

merged 95 commits into from
May 17, 2022

Conversation

ariklin
Copy link
Contributor

@ariklin ariklin commented Mar 31, 2022

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@ariklin
Copy link
Contributor Author

ariklin commented May 10, 2022

@ruowan - please consider my recent modifications.

@ruowan
Copy link
Member

ruowan commented May 13, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ruowan
Copy link
Member

ruowan commented May 13, 2022

The model validation and semantic validation is not introduced in this PR. I add approved label. But @ariklin pls fix prettier check error

@ruowan ruowan self-requested a review May 13, 2022 03:31
@ariklin
Copy link
Contributor Author

ariklin commented May 15, 2022

@ruowan - prettier check pass, thnak you for your help

@ruowan
Copy link
Member

ruowan commented May 17, 2022

LGTM, merged. @ariklin

@ruowan ruowan merged commit 9896393 into Azure:main May 17, 2022
kayousef-zz pushed a commit to kayousef-zz/azure-rest-api-specs that referenced this pull request Dec 20, 2022
* Copy solutions files from 2015-06-01-preview

* update API version

* update readme

* Add required to ExternalSecuritySolution

* add new swagger files

* fix errors1

* fix2

* fix 3

* fix 4

* fix4

* fix4

* fix conflict

* fix conflict2

* fix conflict4

* fix conflict 6

* fix conflict 7

* ttt

* rrr

* aaa

* bbb

* fix 10

* Prettier check

* update readme

* fix reference error

* fix comment

* fix conflict

* fic conflict2

* fix conflict3

* fix conflict4

* remove files

* delete externalSecuritySolutions

* add assessments.json

* fix readme.md

* Fix validation errors 1

* Fix validation errors 2

* merge

* Fix validation errors 3

* Fix validation errors 4

* Fix validation errors 5

* Fix validation errors 5

* Fix validation errors 5

* Fix validation errors 6

* Fix validation errors 4

* Fix validation errors 7

* Fix validation errors 8

* Fix validation errors 9

* Fix validation errors 10

* fix validation errors 11

* fix validation errors 11

* ix validation errors 12

* ix validation errors 13

* fix validation errors 14

* Fix validation errors 15

* Fix validation errors 16

* run prettier

* Defining the APIs for the new NSP resource

* test

* SecuritySolution test

* 2

* org

* 1

* Rebranding effort

* Update SecuritySolutions.json

* Delete readme.md

* ASC to MDC - rebranding

* 1

* merge3

* update5

* update readme

* update6

* update 6

* fix securitySolution

* Create SecuritySolutions.json

Co-authored-by: Arik Riklin <arik.riklin@microsoft.com>
Co-authored-by: Hari Prasad Perabattula <harics24@users.noreply.github.com>
Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com>
kayousef-zz pushed a commit to kayousef-zz/azure-rest-api-specs that referenced this pull request Dec 21, 2022
* Copy solutions files from 2015-06-01-preview

* update API version

* update readme

* Add required to ExternalSecuritySolution

* add new swagger files

* fix errors1

* fix2

* fix 3

* fix 4

* fix4

* fix4

* fix conflict

* fix conflict2

* fix conflict4

* fix conflict 6

* fix conflict 7

* ttt

* rrr

* aaa

* bbb

* fix 10

* Prettier check

* update readme

* fix reference error

* fix comment

* fix conflict

* fic conflict2

* fix conflict3

* fix conflict4

* remove files

* delete externalSecuritySolutions

* add assessments.json

* fix readme.md

* Fix validation errors 1

* Fix validation errors 2

* merge

* Fix validation errors 3

* Fix validation errors 4

* Fix validation errors 5

* Fix validation errors 5

* Fix validation errors 5

* Fix validation errors 6

* Fix validation errors 4

* Fix validation errors 7

* Fix validation errors 8

* Fix validation errors 9

* Fix validation errors 10

* fix validation errors 11

* fix validation errors 11

* ix validation errors 12

* ix validation errors 13

* fix validation errors 14

* Fix validation errors 15

* Fix validation errors 16

* run prettier

* Defining the APIs for the new NSP resource

* test

* SecuritySolution test

* 2

* org

* 1

* Rebranding effort

* Update SecuritySolutions.json

* Delete readme.md

* ASC to MDC - rebranding

* 1

* merge3

* update5

* update readme

* update6

* update 6

* fix securitySolution

* Create SecuritySolutions.json

Co-authored-by: Arik Riklin <arik.riklin@microsoft.com>
Co-authored-by: Hari Prasad Perabattula <harics24@users.noreply.github.com>
Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants