Changing AD structure so the secret can be created properly #18507

sureleo · 2022-03-31T20:16:09Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2022-03-31T20:16:12Z

Hi, @sureleo Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2022-03-31T20:16:12Z

Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.9.3)
- current:preview/2022-03-01-preview/sqlManagedInstances.json compared with base:preview/2022-03-01-preview/sqlManagedInstances.json

Rule	Message
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'keytab' renamed or removed? New: Microsoft.AzureArcData/preview/2022-03-01-preview/sqlManagedInstances.json#L91:7 Old: Microsoft.AzureArcData/preview/2022-03-01-preview/sqlManagedInstances.json#L91:7

️⚠️LintDiff: 0 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.12.2 , classic-openapi-validator v1.2.3 )
- azurearcdata/resource-manager/readme.md tag:package-preview-2022-03
Linted configuring files (Based on target branch, openapi-validator v1.12.2 , classic-openapi-validator v1.2.3 )
- azurearcdata/resource-manager/readme.md tag:package-preview-2022-03

The following errors/warnings exist before current PR submission:

Rule	Message
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: dev Location: Microsoft.AzureArcData/preview/2022-03-01-preview/sqlManagedInstances.json#L65

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️❌CredScan: 0 Errors, 0 Warnings failed [Detail]

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

azurearcdata/resource-manager/readme.md#package-preview-2022-03

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2022-03-31T20:16:12Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2022-03-31T20:16:13Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go-track2 - armazurearcdata - 0.3.0

️✔️azure-sdk-for-go - azurearcdata/mgmt/2021-11-01/azurearcdata - v63.0.0
️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-azurearcdata - 1.0.0

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 071bf83. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.5.0 -> 8.6.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.6.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.6.0` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-azurearcdata [View full logs] [Release SDK Changes]

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group ActiveDirectoryConnectorsOperations
info	[Changelog]   - Added operation group PostgresInstancesOperations
info	[Changelog]   - Model DataControllerUpdate has a new parameter properties
info	[Changelog]   - Model ProxyResource has a new parameter system_data
info	[Changelog]   - Model Resource has a new parameter system_data
info	[Changelog]   - Model SqlManagedInstanceProperties has a new parameter active_directory_information
info	[Changelog]   - Model SqlServerInstanceProperties has a new parameter esu_expiration_date
info	[Changelog]   - Model SqlServerInstanceProperties has a new parameter host_type

️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 071bf83. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-azurearcdata [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 071bf83. SDK Automation 14.0.0

command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️azurearcdata/mgmt/2021-11-01/azurearcdata [View full logs] [Release SDK Changes]
```
info	[Changelog] This is a new package
info	[Changelog]
```

️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 071bf83. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️armazurearcdata [View full logs] [Release SDK Changes] Breaking Change Detected

Only show 120 items here, please refer to log for details.

info	[Changelog] - New function `*ActiveDirectoryConnectorsClientDeletePoller.ResumeToken() (string, error)`
info	[Changelog] - New function `*ActiveDirectoryConnectorsClientDeletePoller.Done() bool`
info	[Changelog] - New function `ActiveDirectoryConnectorsClientDeletePollerResponse.PollUntilDone(context.Context, time.Duration) (ActiveDirectoryConnectorsClientDeleteResponse, error)`
info	[Changelog] - New function `PostgresInstance.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `*ActiveDirectoryConnectorsClientDeletePoller.Poll(context.Context) (*http.Response, error)`
info	[Changelog] - New function `*PostgresInstancesClientListPager.Err() error`
info	[Changelog] - New function `*ActiveDirectoryConnectorsClientCreatePoller.ResumeToken() (string, error)`
info	[Changelog] - New function `HostType.ToPtr() *HostType`
info	[Changelog] - New function `PostgresInstancesClientDeletePollerResponse.PollUntilDone(context.Context, time.Duration) (PostgresInstancesClientDeleteResponse, error)`
info	[Changelog] - New function `*ActiveDirectoryConnectorsClientListPager.Err() error`
info	[Changelog] - New function `*PostgresInstancesClientDeletePollerResponse.Resume(context.Context, *PostgresInstancesClient, string) error`
info	[Changelog] - New function `PossibleHostTypeValues() []HostType`
info	[Changelog] - New function `PostgresInstanceListResult.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `ActiveDirectoryConnectorStatus.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `*ActiveDirectoryConnectorsClient.BeginDelete(context.Context, string, string, string, *ActiveDirectoryConnectorsClientBeginDeleteOptions) (ActiveDirectoryConnectorsClientDeletePollerResponse, error)`
info	[Changelog] - New function `NewPostgresInstancesClient(string, azcore.TokenCredential, *arm.ClientOptions) *PostgresInstancesClient`
info	[Changelog] - New function `*PostgresInstancesClientCreatePoller.Done() bool`
info	[Changelog] - New function `*PostgresInstancesClientDeletePoller.Poll(context.Context) (*http.Response, error)`
info	[Changelog] - New function `*PostgresInstancesClientCreatePollerResponse.Resume(context.Context, *PostgresInstancesClient, string) error`
info	[Changelog] - New function `*PostgresInstancesClientListByResourceGroupPager.Err() error`
info	[Changelog] - New function `*PostgresInstancesClientCreatePoller.Poll(context.Context) (*http.Response, error)`
info	[Changelog] - New function `NewActiveDirectoryConnectorsClient(string, azcore.TokenCredential, *arm.ClientOptions) *ActiveDirectoryConnectorsClient`
info	[Changelog] - New function `*PostgresInstancesClientCreatePoller.FinalResponse(context.Context) (PostgresInstancesClientCreateResponse, error)`
info	[Changelog] - New function `*ActiveDirectoryConnectorsClient.Get(context.Context, string, string, string, *ActiveDirectoryConnectorsClientGetOptions) (ActiveDirectoryConnectorsClientGetResponse, error)`
info	[Changelog] - New function `*ActiveDirectoryConnectorsClientCreatePollerResponse.Resume(context.Context, *ActiveDirectoryConnectorsClient, string) error`
info	[Changelog] - New function `*ActiveDirectoryConnectorsClientCreatePoller.Poll(context.Context) (*http.Response, error)`
info	[Changelog] - New function `*PostgresInstancesClient.BeginCreate(context.Context, string, string, PostgresInstance, *PostgresInstancesClientBeginCreateOptions) (PostgresInstancesClientCreatePollerResponse, error)`
info	[Changelog] - New function `*PostgresInstancesClientListPager.NextPage(context.Context) bool`
info	[Changelog] - New function `*ActiveDirectoryConnectorsClientDeletePoller.FinalResponse(context.Context) (ActiveDirectoryConnectorsClientDeleteResponse, error)`
info	[Changelog] - New function `*PostgresInstancesClientListPager.PageResponse() PostgresInstancesClientListResponse`
info	[Changelog] - New function `ActiveDirectoryDomainControllers.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `*ActiveDirectoryConnectorsClientListPager.PageResponse() ActiveDirectoryConnectorsClientListResponse`
info	[Changelog] - New function `PostgresInstanceUpdate.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `*PostgresInstancesClientListByResourceGroupPager.NextPage(context.Context) bool`
info	[Changelog] - New function `*ActiveDirectoryConnectorsClientCreatePoller.FinalResponse(context.Context) (ActiveDirectoryConnectorsClientCreateResponse, error)`
info	[Changelog] - New function `*PostgresInstancesClientDeletePoller.FinalResponse(context.Context) (PostgresInstancesClientDeleteResponse, error)`
info	[Changelog] - New function `ActiveDirectoryConnectorsClientCreatePollerResponse.PollUntilDone(context.Context, time.Duration) (ActiveDirectoryConnectorsClientCreateResponse, error)`
info	[Changelog] - New function `*PostgresInstancesClientDeletePoller.Done() bool`
info	[Changelog] - New function `*ActiveDirectoryConnectorsClient.List(string, string, *ActiveDirectoryConnectorsClientListOptions) *ActiveDirectoryConnectorsClientListPager`
info	[Changelog] - New function `*PostgresInstancesClientCreatePoller.ResumeToken() (string, error)`
info	[Changelog] - New function `*PostgresInstancesClientListByResourceGroupPager.PageResponse() PostgresInstancesClientListByResourceGroupResponse`
info	[Changelog] - New function `*PostgresInstancesClient.ListByResourceGroup(string, *PostgresInstancesClientListByResourceGroupOptions) *PostgresInstancesClientListByResourceGroupPager`
info	[Changelog] - New function `PostgresInstanceProperties.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `ActiveDirectoryConnectorListResult.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `*PostgresInstancesClient.BeginDelete(context.Context, string, string, *PostgresInstancesClientBeginDeleteOptions) (PostgresInstancesClientDeletePollerResponse, error)`
info	[Changelog] - New function `*ActiveDirectoryConnectorsClientDeletePollerResponse.Resume(context.Context, *ActiveDirectoryConnectorsClient, string) error`
info	[Changelog] - New function `*ActiveDirectoryConnectorsClient.BeginCreate(context.Context, string, string, string, ActiveDirectoryConnectorResource, *ActiveDirectoryConnectorsClientBeginCreateOptions) (ActiveDirectoryConnectorsClientCreatePollerResponse, error)`
info	[Changelog] - New function `*PostgresInstancesClient.Get(context.Context, string, string, *PostgresInstancesClientGetOptions) (PostgresInstancesClientGetResponse, error)`
info	[Changelog] - New function `*PostgresInstancesClient.List(*PostgresInstancesClientListOptions) *PostgresInstancesClientListPager`
info	[Changelog] - New function `ActiveDirectoryConnectorDNSDetails.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `PostgresInstancesClientCreatePollerResponse.PollUntilDone(context.Context, time.Duration) (PostgresInstancesClientCreateResponse, error)`
info	[Changelog] - New function `*ActiveDirectoryConnectorsClientCreatePoller.Done() bool`
info	[Changelog] - New function `*PostgresInstanceProperties.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `*PostgresInstancesClientDeletePoller.ResumeToken() (string, error)`
info	[Changelog] - New function `*ActiveDirectoryConnectorStatus.UnmarshalJSON([]byte) error`
info	[Changelog] - New struct `ActiveDirectoryConnectorDNSDetails`
info	[Changelog] - New struct `ActiveDirectoryConnectorDomainDetails`
info	[Changelog] - New struct `ActiveDirectoryConnectorListResult`
info	[Changelog] - New struct `ActiveDirectoryConnectorProperties`
info	[Changelog] - New struct `ActiveDirectoryConnectorResource`
info	[Changelog] - New struct `ActiveDirectoryConnectorSpec`
info	[Changelog] - New struct `ActiveDirectoryConnectorStatus`
info	[Changelog] - New struct `ActiveDirectoryConnectorsClient`
info	[Changelog] - New struct `ActiveDirectoryConnectorsClientBeginCreateOptions`
info	[Changelog] - New struct `ActiveDirectoryConnectorsClientBeginDeleteOptions`
info	[Changelog] - New struct `ActiveDirectoryConnectorsClientCreatePoller`
info	[Changelog] - New struct `ActiveDirectoryConnectorsClientCreatePollerResponse`
info	[Changelog] - New struct `ActiveDirectoryConnectorsClientCreateResponse`
info	[Changelog] - New struct `ActiveDirectoryConnectorsClientCreateResult`
info	[Changelog] - New struct `ActiveDirectoryConnectorsClientDeletePoller`
info	[Changelog] - New struct `ActiveDirectoryConnectorsClientDeletePollerResponse`
info	[Changelog] - New struct `ActiveDirectoryConnectorsClientDeleteResponse`
info	[Changelog] - New struct `ActiveDirectoryConnectorsClientGetOptions`
info	[Changelog] - New struct `ActiveDirectoryConnectorsClientGetResponse`
info	[Changelog] - New struct `ActiveDirectoryConnectorsClientGetResult`
info	[Changelog] - New struct `ActiveDirectoryConnectorsClientListOptions`
info	[Changelog] - New struct `ActiveDirectoryConnectorsClientListPager`
info	[Changelog] - New struct `ActiveDirectoryConnectorsClientListResponse`
info	[Changelog] - New struct `ActiveDirectoryConnectorsClientListResult`
info	[Changelog] - New struct `ActiveDirectoryDomainController`
info	[Changelog] - New struct `ActiveDirectoryDomainControllers`
info	[Changelog] - New struct `ActiveDirectoryInformation`
info	[Changelog] - New struct `CommonSKU`
info	[Changelog] - New struct `KeytabInformation`
info	[Changelog] - New struct `PostgresInstance`
info	[Changelog] - New struct `PostgresInstanceListResult`
info	[Changelog] - New struct `PostgresInstanceProperties`
info	[Changelog] - New struct `PostgresInstanceSKU`
info	[Changelog] - New struct `PostgresInstanceUpdate`
info	[Changelog] - New struct `PostgresInstancesClient`
info	[Changelog] - New struct `PostgresInstancesClientBeginCreateOptions`
info	[Changelog] - New struct `PostgresInstancesClientBeginDeleteOptions`
info	[Changelog] - New struct `PostgresInstancesClientCreatePoller`
info	[Changelog] - New struct `PostgresInstancesClientCreatePollerResponse`
info	[Changelog] - New struct `PostgresInstancesClientCreateResponse`
info	[Changelog] - New struct `PostgresInstancesClientCreateResult`
info	[Changelog] - New struct `PostgresInstancesClientDeletePoller`
info	[Changelog] - New struct `PostgresInstancesClientDeletePollerResponse`
info	[Changelog] - New struct `PostgresInstancesClientDeleteResponse`
info	[Changelog] - New struct `PostgresInstancesClientGetOptions`
info	[Changelog] - New struct `PostgresInstancesClientGetResponse`
info	[Changelog] - New struct `PostgresInstancesClientGetResult`
info	[Changelog] - New struct `PostgresInstancesClientListByResourceGroupOptions`
info	[Changelog] - New struct `PostgresInstancesClientListByResourceGroupPager`
info	[Changelog] - New struct `PostgresInstancesClientListByResourceGroupResponse`
info	[Changelog] - New struct `PostgresInstancesClientListByResourceGroupResult`
info	[Changelog] - New struct `PostgresInstancesClientListOptions`
info	[Changelog] - New struct `PostgresInstancesClientListPager`
info	[Changelog] - New struct `PostgresInstancesClientListResponse`
info	[Changelog] - New struct `PostgresInstancesClientListResult`
info	[Changelog] - New struct `PostgresInstancesClientUpdateOptions`
info	[Changelog] - New struct `PostgresInstancesClientUpdateResponse`
info	[Changelog] - New struct `PostgresInstancesClientUpdateResult`
info	[Changelog] - New struct `ProxyResource`
info	[Changelog] - New field `ActiveDirectoryInformation` in struct `SQLManagedInstanceProperties`
info	[Changelog] - New field `Properties` in struct `DataControllerUpdate`
info	[Changelog] - New field `HostType` in struct `SQLServerInstanceProperties`
info	[Changelog] - New field `EsuExpirationDate` in struct `SQLServerInstanceProperties`
info	[Changelog]
info	[Changelog] Total 16 breaking change(s), 188 additive change(s).

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs]Release - Generate from 071bf83. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh] WARN deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh]  deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh]  @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh]  @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-azurearcdata [View full logs] [Release SDK Changes]
- azure-arm-azurearcdata-1.0.0-beta.1.tgz
```
info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
```

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 071bf83. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/azurearcdata/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.AzureArcData [View full logs] [Release SDK Changes]
```
warn	Skip artifact folder because it doesn't exist: artifacts/packages
```

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 071bf83. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️azurearcdata [View full logs] [Release Schema Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2022-03-31T20:19:28Z

Hi @sureleo, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

sureleo · 2022-03-31T21:49:03Z

@changlong-liu We did include a breaking change in this PR. However, the api-version hasn't been exposed to any external customer and it is completely behind the feature flag.

Let me know we would still need to get breaking reviewer approval from ARM team. I have submitted an intake.

Regarding the credscan, It seems all of the issues that are introduced are not by me (or my service). Can you please take a look?

Detected 1 issue(s) in D:\a\_work\1\azure-rest-api-specs\specification\cognitiveservices\data-plane\AnomalyDetector\preview\v1.1-preview\examples\GetModel.json
Detected 1 issue(s) in D:\a\_work\1\azure-rest-api-specs\specification\cognitiveservices\data-plane\AnomalyDetector\preview\v1.1-preview\examples\GetResult.json
Detected 1 issue(s) in D:\a\_work\1\azure-rest-api-specs\specification\cognitiveservices\data-plane\AnomalyDetector\preview\v1.1-preview\examples\TrainModel.json
Detected 2 issue(s) in D:\a\_work\1\azure-rest-api-specs\specification\cognitiveservices\data-plane\AnomalyDetector\preview\v1.1-preview.1\MultivariateAnomalyDetector.json
Detected 1 issue(s) in D:\a\_work\1\azure-rest-api-specs\specification\cognitiveservices\data-plane\AnomalyDetector\preview\v1.1-preview.1\examples\DetectAnomaly.json
Detected 1 issue(s) in D:\a\_work\1\azure-rest-api-specs\specification\cognitiveservices\data-plane\AnomalyDetector\preview\v1.1-preview.1\examples\GetModel.json
Detected 1 issue(s) in D:\a\_work\1\azure-rest-api-specs\specification\cognitiveservices\data-plane\AnomalyDetector\preview\v1.1-preview.1\examples\GetResult.json
Detected 1 issue(s) in D:\a\_work\1\azure-rest-api-specs\specification\cognitiveservices\data-plane\AnomalyDetector\preview\v1.1-preview.1\examples\TrainModel.json
Detected 2 issue(s) in D:\a\_work\1\azure-rest-api-specs\specification\cognitiveservices\data-plane\AnomalyDetector\preview\v1.1-preview\MultivariateAnomalyDetector.json
Detected 1 issue(s) in D:\a\_work\1\azure-rest-api-specs\specification\cognitiveservices\data-plane\AnomalyDetector\preview\v1.1-preview\examples\DetectAnomaly.json
Detected 1 issue(s) in D:\a\_work\1\azure-rest-api-specs\specification\cognitiveservices\data-plane\TranslatorText\stable\v3.0\TranslatorText.json
Detected 1 issue(s) in D:\a\_work\1\azure-rest-api-specs\specification\security\resource-manager\Microsoft.Security\preview\2020-01-01-preview\examples\Connectors\CreateUpdateGcpCredentialsConnectorSubscription_example.json
Detected 3 issue(s) in D:\a\_work\1\azure-rest-api-specs\specification\streamanalytics\resource-manager\Microsoft.StreamAnalytics\preview\2017-04-01-preview\examples\Output_Create_DataWarehouse.json
Detected 1 issue(s) in D:\a\_work\1\azure-rest-api-specs\specification\streamanalytics\resource-manager\Microsoft.StreamAnalytics\preview\2021-10-01-preview\examples\Output_Create_DataWarehouse.json
Detected 1 issue(s) in D:\a\_work\1\azure-rest-api-specs\specification\streamanalytics\resource-manager\Microsoft.StreamAnalytics\stable\2020-03-01\examples\Output_Create_DataWarehouse.json

changlong-liu · 2022-04-02T07:57:12Z

/azp run

azure-pipelines · 2022-04-02T07:57:21Z

Azure Pipelines successfully started running 1 pipeline(s).

changlong-liu · 2022-04-02T08:02:44Z

@changlong-liu We did include a breaking change in this PR. However, the api-version hasn't been exposed to any external customer and it is completely behind the feature flag.

Let me know we would still need to get breaking reviewer approval from ARM team. I have submitted an intake.

Regarding the credscan, It seems all of the issues that are introduced are not by me (or my service). Can you please take a look?

Detected 1 issue(s) in D:\a\_work\1\azure-rest-api-specs\specification\cognitiveservices\data-plane\AnomalyDetector\preview\v1.1-preview\examples\GetModel.json
Detected 1 issue(s) in D:\a\_work\1\azure-rest-api-specs\specification\cognitiveservices\data-plane\AnomalyDetector\preview\v1.1-preview\examples\GetResult.json
Detected 1 issue(s) in D:\a\_work\1\azure-rest-api-specs\specification\cognitiveservices\data-plane\AnomalyDetector\preview\v1.1-preview\examples\TrainModel.json
Detected 2 issue(s) in D:\a\_work\1\azure-rest-api-specs\specification\cognitiveservices\data-plane\AnomalyDetector\preview\v1.1-preview.1\MultivariateAnomalyDetector.json
Detected 1 issue(s) in D:\a\_work\1\azure-rest-api-specs\specification\cognitiveservices\data-plane\AnomalyDetector\preview\v1.1-preview.1\examples\DetectAnomaly.json
Detected 1 issue(s) in D:\a\_work\1\azure-rest-api-specs\specification\cognitiveservices\data-plane\AnomalyDetector\preview\v1.1-preview.1\examples\GetModel.json
Detected 1 issue(s) in D:\a\_work\1\azure-rest-api-specs\specification\cognitiveservices\data-plane\AnomalyDetector\preview\v1.1-preview.1\examples\GetResult.json
Detected 1 issue(s) in D:\a\_work\1\azure-rest-api-specs\specification\cognitiveservices\data-plane\AnomalyDetector\preview\v1.1-preview.1\examples\TrainModel.json
Detected 2 issue(s) in D:\a\_work\1\azure-rest-api-specs\specification\cognitiveservices\data-plane\AnomalyDetector\preview\v1.1-preview\MultivariateAnomalyDetector.json
Detected 1 issue(s) in D:\a\_work\1\azure-rest-api-specs\specification\cognitiveservices\data-plane\AnomalyDetector\preview\v1.1-preview\examples\DetectAnomaly.json
Detected 1 issue(s) in D:\a\_work\1\azure-rest-api-specs\specification\cognitiveservices\data-plane\TranslatorText\stable\v3.0\TranslatorText.json
Detected 1 issue(s) in D:\a\_work\1\azure-rest-api-specs\specification\security\resource-manager\Microsoft.Security\preview\2020-01-01-preview\examples\Connectors\CreateUpdateGcpCredentialsConnectorSubscription_example.json
Detected 3 issue(s) in D:\a\_work\1\azure-rest-api-specs\specification\streamanalytics\resource-manager\Microsoft.StreamAnalytics\preview\2017-04-01-preview\examples\Output_Create_DataWarehouse.json
Detected 1 issue(s) in D:\a\_work\1\azure-rest-api-specs\specification\streamanalytics\resource-manager\Microsoft.StreamAnalytics\preview\2021-10-01-preview\examples\Output_Create_DataWarehouse.json
Detected 1 issue(s) in D:\a\_work\1\azure-rest-api-specs\specification\streamanalytics\resource-manager\Microsoft.StreamAnalytics\stable\2020-03-01\examples\Output_Create_DataWarehouse.json

Hi @sureleo , the breaking change is fine for me since it's in latest preview version

) * Changing AD structure so the secret can be created properly * update examples * prettier fix * Adding descriptions Co-authored-by: Shuo Li <shul@microsoft.com>

Changing AD structure so the secret can be created properly

74a82de

openapi-pipeline-app bot added the BreakingChangeReviewRequired label Mar 31, 2022

update examples

59fc30d

openapi-sdkautomation bot mentioned this pull request Mar 31, 2022

[AutoPR azurearcdata] Changing AD structure so the secret can be created properly AzureSDKAutomation/azure-resource-manager-schemas#6095

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go-V2 label Mar 31, 2022

shul-msft added 2 commits March 31, 2022 14:00

prettier fix

bb86916

Adding descriptions

6cb8bed

sureleo marked this pull request as ready for review March 31, 2022 21:41

openapi-assignment-bot bot assigned changlong-liu Mar 31, 2022

changlong-liu removed the BreakingChangeReviewRequired label Apr 2, 2022

openapi-pipeline-app bot added the BreakingChangeReviewRequired label Apr 2, 2022

mikekistler added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Apr 4, 2022

changlong-liu approved these changes Apr 5, 2022

View reviewed changes

changlong-liu merged commit 071bf83 into Azure:main Apr 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changing AD structure so the secret can be created properly #18507

Changing AD structure so the secret can be created properly #18507

sureleo commented Mar 31, 2022 •

edited

Loading

openapi-workflow-bot bot commented Mar 31, 2022

openapi-pipeline-app bot commented Mar 31, 2022 •

edited

Loading

openapi-workflow-bot bot commented Mar 31, 2022

openapi-pipeline-app bot commented Mar 31, 2022 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented Mar 31, 2022

sureleo commented Mar 31, 2022

changlong-liu commented Apr 2, 2022

azure-pipelines bot commented Apr 2, 2022

changlong-liu commented Apr 2, 2022

Changing AD structure so the secret can be created properly #18507

Changing AD structure so the secret can be created properly #18507

Conversation

sureleo commented Mar 31, 2022 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Mar 31, 2022

openapi-pipeline-app bot commented Mar 31, 2022 • edited Loading

Swagger Validation Report

openapi-workflow-bot bot commented Mar 31, 2022

openapi-pipeline-app bot commented Mar 31, 2022 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented Mar 31, 2022

sureleo commented Mar 31, 2022

changlong-liu commented Apr 2, 2022

azure-pipelines bot commented Apr 2, 2022

changlong-liu commented Apr 2, 2022

sureleo commented Mar 31, 2022 •

edited

Loading

openapi-pipeline-app bot commented Mar 31, 2022 •

edited

Loading

openapi-pipeline-app bot commented Mar 31, 2022 •

edited

Loading