Add Stack HCI CLI settings #18563

necusjz · 2022-04-06T03:22:02Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2022-04-06T03:22:05Z

Hi, @necusjz Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-workflow-bot · 2022-04-06T03:22:06Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2022-04-06T03:22:06Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

Linted configuring files (Based on source branch, openapi-validator v1.12.2 , classic-openapi-validator v1.2.3 )
- azurestackhci/resource-manager/readme.md tag:default
Linted configuring files (Based on target branch, openapi-validator v1.12.2 , classic-openapi-validator v1.2.3 )
- azurestackhci/resource-manager/readme.md tag:default

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-04-06T03:22:07Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go-track2 - armazurestackhci - 0.3.0

+	Function `ErrorDetail.MarshalJSON` has been removed
+	Struct `ErrorAdditionalInfo` has been removed
+	Struct `ErrorDetail` has been removed
+	Struct `ErrorResponse` has been removed
+	Type of `ExtensionParameters.ProtectedSettings` has been changed from `map[string]interface{}` to `interface{}`
+	Type of `ExtensionParameters.Settings` has been changed from `map[string]interface{}` to `interface{}`

️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-azurestackhci - 6.1.0b1
️✔️azure-sdk-for-go - azurestackhci/mgmt/2022-01-01/azurestackhci - v63.1.0
️✔️azure-sdk-for-go - azurestackhci/mgmt/2020-10-01/azurestackhci - v63.1.0
️✔️azure-sdk-for-go - preview/azurestackhci/mgmt/2021-01-01-preview/azurestackhci - v63.1.0
️✔️azure-sdk-for-go - preview/azurestackhci/mgmt/2020-03-01-preview/azurestackhci - v63.1.0

️️✔️ azure-powershell succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 805e16a. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

️✔️Az.StackHci [View full logs] [Release SDK Changes]
- Az.StackHci.0.1.0.nupkg

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 805e16a. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-azurestackhci [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation ArcSettingsOperations.begin_create_identity
info	[Changelog]   - Added operation ArcSettingsOperations.generate_password
info	[Changelog]   - Added operation ArcSettingsOperations.update
info	[Changelog]   - Added operation ClustersOperations.begin_create_identity
info	[Changelog]   - Added operation ClustersOperations.begin_delete
info	[Changelog]   - Added operation ClustersOperations.begin_upload_certificate
info	[Changelog]   - Model ArcSetting has a new parameter arc_application_client_id
info	[Changelog]   - Model ArcSetting has a new parameter arc_application_object_id
info	[Changelog]   - Model ArcSetting has a new parameter arc_application_tenant_id
info	[Changelog]   - Model ArcSetting has a new parameter arc_service_principal_object_id
info	[Changelog]   - Model ArcSetting has a new parameter connectivity_properties
info	[Changelog]   - Model Cluster has a new parameter aad_application_object_id
info	[Changelog]   - Model Cluster has a new parameter aad_service_principal_object_id
info	[Changelog]   - Model Cluster has a new parameter service_endpoint
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Removed operation ClustersOperations.delete

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 805e16a. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.

️✔️azure-resourcemanager-azurestackhci [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 805e16a. SDK Automation 14.0.0

command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️azurestackhci/mgmt/2022-01-01/azurestackhci [View full logs] [Release SDK Changes]
```
info	[Changelog] This is a new package
info	[Changelog]
```

️✔️azurestackhci/mgmt/2020-10-01/azurestackhci [View full logs]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `Application`
info	[Changelog] - New const `User`
info	[Changelog] - New const `ManagedIdentity`
info	[Changelog] - New const `Key`
info	[Changelog] - New function `PossibleCreatedByTypeValues() []CreatedByType`
info	[Changelog] - New struct `SystemData`
info	[Changelog] - New anonymous field `*SystemData` in struct `Cluster`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 8 additive change(s).

️✔️preview/azurestackhci/mgmt/2021-01-01-preview/azurestackhci [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️preview/azurestackhci/mgmt/2020-03-01-preview/azurestackhci [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 805e16a. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️armazurestackhci [View full logs] [Release SDK Changes]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs]Release - Generate from 805e16a. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh] deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh] deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh]  @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh] WARN deprecated @azure/storage-blob@10.5.0: This version has been deprecated, please upgrade to the version tagged as latest
cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-azurestackhci [View full logs] [Release SDK Changes] Breaking Change Detected

azure-arm-azurestackhci-3.0.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation ArcSettings.beginCreateIdentity
info	[Changelog]   - Added operation ArcSettings.beginCreateIdentityAndWait
info	[Changelog]   - Added operation ArcSettings.generatePassword
info	[Changelog]   - Added operation ArcSettings.update
info	[Changelog]   - Added operation Clusters.beginCreateIdentity
info	[Changelog]   - Added operation Clusters.beginCreateIdentityAndWait
info	[Changelog]   - Added operation Clusters.beginDelete
info	[Changelog]   - Added operation Clusters.beginDeleteAndWait
info	[Changelog]   - Added operation Clusters.beginUploadCertificate
info	[Changelog]   - Added operation Clusters.beginUploadCertificateAndWait
info	[Changelog]   - Added Interface ArcConnectivityProperties
info	[Changelog]   - Added Interface ArcIdentityResponse
info	[Changelog]   - Added Interface ArcSettingsCreateIdentityOptionalParams
info	[Changelog]   - Added Interface ArcSettingsGeneratePasswordOptionalParams
info	[Changelog]   - Added Interface ArcSettingsPatch
info	[Changelog]   - Added Interface ArcSettingsUpdateOptionalParams
info	[Changelog]   - Added Interface ClusterIdentityResponse
info	[Changelog]   - Added Interface ClustersCreateIdentityOptionalParams
info	[Changelog]   - Added Interface ClustersUploadCertificateOptionalParams
info	[Changelog]   - Added Interface PasswordCredential
info	[Changelog]   - Added Interface RawCertificateData
info	[Changelog]   - Added Interface UploadCertificateRequest
info	[Changelog]   - Added Type Alias ArcSettingsCreateIdentityResponse
info	[Changelog]   - Added Type Alias ArcSettingsGeneratePasswordResponse
info	[Changelog]   - Added Type Alias ArcSettingsUpdateResponse
info	[Changelog]   - Added Type Alias ClustersCreateIdentityResponse
info	[Changelog]   - Interface ClustersDeleteOptionalParams has a new optional parameter resumeFrom
info	[Changelog]   - Interface ClustersDeleteOptionalParams has a new optional parameter updateIntervalInMs
info	[Changelog]   - Type Alias ArcSetting has a new parameter arcApplicationClientId
info	[Changelog]   - Type Alias ArcSetting has a new parameter arcApplicationTenantId
info	[Changelog]   - Type Alias ArcSetting has a new parameter arcServicePrincipalObjectId
info	[Changelog]   - Type Alias ArcSetting has a new parameter arcApplicationObjectId
info	[Changelog]   - Type Alias ArcSetting has a new parameter connectivityProperties
info	[Changelog]   - Type Alias Cluster has a new parameter aadApplicationObjectId
info	[Changelog]   - Type Alias Cluster has a new parameter aadServicePrincipalObjectId
info	[Changelog]   - Type Alias Cluster has a new parameter serviceEndpoint
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Removed operation Clusters.delete

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 805e16a. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation

️✔️azurestackhci [View full logs]

_{Posted by Swagger Pipeline | How to fix these errors?}

ghost · 2022-04-24T16:02:04Z

Hi, @necusjz. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

ghost · 2022-05-15T16:02:34Z

Hi, @necusjz. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

necusjz · 2022-05-19T08:12:34Z

@leni-msft, sorry to bother you again, could you help us merge this CLI-only PR? Thanks!

add stack hci settings

3658c47

necusjz requested a review from zhoxing-ms April 6, 2022 03:22

necusjz requested review from jsntcy and qiaozha as code owners April 6, 2022 03:22

openapi-assignment-bot bot assigned tianxchen-ms Apr 6, 2022

openapi-pipeline-app bot added the CI-BreakingChange-Go-V2 label Apr 6, 2022

necusjz requested a review from kairu-ms April 7, 2022 01:27

ghost added no-recent-activity and removed no-recent-activity labels Apr 24, 2022

ghost added no-recent-activity and removed no-recent-activity labels May 15, 2022

kairu-ms approved these changes May 19, 2022

View reviewed changes

necusjz assigned leni-msft and unassigned tianxchen-ms May 19, 2022

leni-msft merged commit 805e16a into Azure:main May 19, 2022

azure-sdk mentioned this pull request May 19, 2022

[ReleasePR armazurestackhci] Migrate to net track2 for some resource-manager readmes batch 2 Azure/azure-sdk-for-go#17529

Closed

openapi-pipeline-app bot removed the CI-BreakingChange-Go-V2 label May 19, 2022

azure-sdk mentioned this pull request May 19, 2022

[ReleasePR track2_azure-mgmt-azurestackhci] merge 2023-08-01-preview API version to main repo Azure/azure-sdk-for-python#23946

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label May 19, 2022

azure-sdk mentioned this pull request May 19, 2022

[ReleasePR azurestackhci/mgmt/2022-01-01/azurestackhci] [Go]Add batch tag 05/19 Azure/azure-sdk-for-go#17530

Closed

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label May 19, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Stack HCI CLI settings #18563

Add Stack HCI CLI settings #18563

necusjz commented Apr 6, 2022 •

edited

Loading

openapi-workflow-bot bot commented Apr 6, 2022

openapi-workflow-bot bot commented Apr 6, 2022

openapi-pipeline-app bot commented Apr 6, 2022 •

edited

Loading

openapi-pipeline-app bot commented Apr 6, 2022 •

edited

Loading

Breaking Changes Tracking

ghost commented Apr 24, 2022

ghost commented May 15, 2022

necusjz commented May 19, 2022

Add Stack HCI CLI settings #18563

Add Stack HCI CLI settings #18563

Conversation

necusjz commented Apr 6, 2022 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Apr 6, 2022

openapi-workflow-bot bot commented Apr 6, 2022

openapi-pipeline-app bot commented Apr 6, 2022 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Apr 6, 2022 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

ghost commented Apr 24, 2022

ghost commented May 15, 2022

necusjz commented May 19, 2022

necusjz commented Apr 6, 2022 •

edited

Loading

openapi-pipeline-app bot commented Apr 6, 2022 •

edited

Loading

openapi-pipeline-app bot commented Apr 6, 2022 •

edited

Loading