-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cross-tenant feature #18718
add cross-tenant feature #18718
Conversation
Hi, @parkhyukjun89 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Rule | Message |
---|---|
R4037 - MissingTypeObject |
The schema 'EncryptionSetProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-03-02/DiskRP/diskEncryptionSet.json#L378 |
R4037 - MissingTypeObject |
The schema 'EncryptionSetIdentity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-03-02/DiskRP/diskEncryptionSet.json#L424 |
R4037 - MissingTypeObject |
The schema 'KeyForDiskEncryptionSet' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-03-02/DiskRP/diskEncryptionSet.json#L500 |
R4037 - MissingTypeObject |
The schema 'DiskEncryptionSet' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-03-02/DiskRP/diskEncryptionSet.json#L516 |
R4037 - MissingTypeObject |
The schema 'DiskEncryptionSetUpdate' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-03-02/DiskRP/diskEncryptionSet.json#L533 |
R4037 - MissingTypeObject |
The schema 'DiskEncryptionSetUpdateProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-03-02/DiskRP/diskEncryptionSet.json#L552 |
R4037 - MissingTypeObject |
The schema 'DiskEncryptionSetList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-03-02/DiskRP/diskEncryptionSet.json#L567 |
R4037 - MissingTypeObject |
The schema 'ResourceUriList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-03-02/DiskRP/diskEncryptionSet.json#L586 |
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: rotationToLatestKeyVersionEnabled Location: stable/2022-03-02/DiskRP/diskEncryptionSet.json#L403 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: rotationToLatestKeyVersionEnabled Location: stable/2022-03-02/DiskRP/diskEncryptionSet.json#L560 |
|
'EncryptionSetProperties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: stable/2022-03-02/DiskRP/diskEncryptionSet.json#L378 |
️⚠️
Avocado: 1 Warnings warning [Detail]
Rule | Message |
---|---|
The default tag contains multiple API versions swaggers. readme: specification/compute/resource-manager/readme.md tag: specification/compute/resource-manager/readme.md#tag-package-2022-03-02 |
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
Hi @parkhyukjun89, Your PR has some issues. Please fix the CI sequentially by following the order of
|
@ArcturusZhang is the sdk track2 CI failure relevant to this PR? |
* add cross-tenant feature * fix filename typo * prettier
* add cross-tenant feature * fix filename typo * prettier
* new version folder * new version folder * sync with diskRP 2021-12-01 changes * Update creationData description (#18050) * Update diskRPCommon.json * Update diskRPCommon.json * adding SecurityProfile in DiskRestorePointProperties (#18826) * add cross-tenant feature (#18718) * add cross-tenant feature * fix filename typo * prettier * Swagger changes for PremiumV2 in DiskRP (#18786) * Swagger changes for PremiumV2 in DiskRP * Added new property copyCompletionError * Updated description for new property copyCompletionError * Added the type as object for CopyCompletionError * Addressed comment to update the description for CopySourceNotFound Co-authored-by: akashpargat <akashpargat@microsoft.com> * Add new Azure Compute Gallery image ids to ImageDiskReference for PutDisk Support in 2022-03-02 Api Version (#18868) * new sig ids for put disk 2022-03-02 * fix errors and add example path * extra space * remove required id * prettify common Co-authored-by: Jerry Chan <jerch@microsoft.com> * Feature/cplat 2022 03 02 (#18945) * add cross-tenant feature * fix filename typo * prettier * add federatedClientId to diskEncryptionSetUpdateProperties * New ApI Version * Readme changes * adding SecurityProfile in DiskRestorePointProperties (#18826) * add cross-tenant feature (#18718) * add cross-tenant feature * fix filename typo * prettier * Swagger changes for PremiumV2 in DiskRP (#18786) * Swagger changes for PremiumV2 in DiskRP * Added new property copyCompletionError * Updated description for new property copyCompletionError * Added the type as object for CopyCompletionError * Addressed comment to update the description for CopySourceNotFound Co-authored-by: akashpargat <akashpargat@microsoft.com> * Add new Azure Compute Gallery image ids to ImageDiskReference for PutDisk Support in 2022-03-02 Api Version (#18868) * new sig ids for put disk 2022-03-02 * fix errors and add example path * extra space * remove required id * prettify common Co-authored-by: Jerry Chan <jerch@microsoft.com> * Feature/cplat 2022 03 02 (#18945) * add cross-tenant feature * fix filename typo * prettier * add federatedClientId to diskEncryptionSetUpdateProperties * GET snapshot-Changed CopyCompletionError enum name (#19160) Co-authored-by: Karan Manish Thakkar <kathakkar@microsoft.com> * move UserAssignedIdentities to common.json to fix duplicate definition * update readme with gallery 2022-01-03 * sync with past updates * update with description for object * fix readme * GET snapshot-Changed CopyCompletionError enum name (#19227) Co-authored-by: Karan Manish Thakkar <kathakkar@microsoft.com> * fixing readme.md * fix vmss userAssignedIdentities duplicate definition Co-authored-by: Theodore Chang <thchan@microsoft.com> Co-authored-by: anshulsolanki21 <73930854+anshulsolanki21@users.noreply.github.com> Co-authored-by: parkhyukjun89 <hyupar@microsoft.com> Co-authored-by: Akash Pargat <akashpargat@yahoo.com> Co-authored-by: akashpargat <akashpargat@microsoft.com> Co-authored-by: jerryc3 <48365571+jerryc3@users.noreply.github.com> Co-authored-by: Jerry Chan <jerch@microsoft.com> Co-authored-by: Karan Manish Thakkar <kkaran.thakkar@gmail.com> Co-authored-by: Karan Manish Thakkar <kathakkar@microsoft.com> Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com>
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.