Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.DigitalTwins to add version stable/2022-05-31 #18728

Conversation

sjiherzig
Copy link
Member

@sjiherzig sjiherzig commented Apr 19, 2022

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @sjiherzig Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 19, 2022

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:
    Rule Message
    R4037 - MissingTypeObject The schema 'DigitalTwinsResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L1251
    R4037 - MissingTypeObject The schema 'DigitalTwinsIdentity' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L1302
    R4037 - MissingTypeObject The schema 'ErrorResponse' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L1331
    R4037 - MissingTypeObject The schema 'ErrorDefinition' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L1340
    R4037 - MissingTypeObject The schema 'DigitalTwinsEndpointResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L1603
    R4037 - MissingTypeObject The schema 'DigitalTwinsEndpointResourceProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L1620
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L1353
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L1391
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L1244
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L1842
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L2002
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'PrivateLinkResources_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L642
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'PrivateEndpointConnections_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L729
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'endpoints' with immediate parent 'DigitalTwinsDescription', must have a list by immediate parent operation.
    Location: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L1603
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'privateLinkResources' with immediate parent 'DigitalTwinsDescription', must have a list by immediate parent operation.
    Location: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L1838
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'privateEndpointConnections' with immediate parent 'DigitalTwinsDescription', must have a list by immediate parent operation.
    Location: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L1981
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'timeSeriesDatabaseConnections' with immediate parent 'DigitalTwinsDescription', must have a list by immediate parent operation.
    Location: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L2061
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction
    Location: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L1420
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️⚠️Cross-Version Breaking Changes: 31 Warnings warning [Detail]
    The following breaking changes are detected by comparison with the latest stable version:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L55:9
    Old: Microsoft.DigitalTwins/stable/2020-12-01/digitaltwins.json#L55:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L102:9
    Old: Microsoft.DigitalTwins/stable/2020-12-01/digitaltwins.json#L102:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L164:9
    Old: Microsoft.DigitalTwins/stable/2020-12-01/digitaltwins.json#L164:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L223:9
    Old: Microsoft.DigitalTwins/stable/2020-12-01/digitaltwins.json#L223:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L280:9
    Old: Microsoft.DigitalTwins/stable/2020-12-01/digitaltwins.json#L280:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L325:9
    Old: Microsoft.DigitalTwins/stable/2020-12-01/digitaltwins.json#L325:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L372:9
    Old: Microsoft.DigitalTwins/stable/2020-12-01/digitaltwins.json#L372:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L434:9
    Old: Microsoft.DigitalTwins/stable/2020-12-01/digitaltwins.json#L434:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L491:9
    Old: Microsoft.DigitalTwins/stable/2020-12-01/digitaltwins.json#L491:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L530:9
    Old: Microsoft.DigitalTwins/stable/2020-12-01/digitaltwins.json#L530:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L572:9
    Old: Microsoft.DigitalTwins/stable/2020-12-01/digitaltwins.json#L572:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L605:9
    Old: Microsoft.DigitalTwins/stable/2020-12-01/digitaltwins.json#L605:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L653:9
    Old: Microsoft.DigitalTwins/stable/2020-12-01/digitaltwins.json#L653:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L695:9
    Old: Microsoft.DigitalTwins/stable/2020-12-01/digitaltwins.json#L695:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L740:9
    Old: Microsoft.DigitalTwins/stable/2020-12-01/digitaltwins.json#L740:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L782:9
    Old: Microsoft.DigitalTwins/stable/2020-12-01/digitaltwins.json#L782:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L826:9
    Old: Microsoft.DigitalTwins/stable/2020-12-01/digitaltwins.json#L826:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L873:9
    Old: Microsoft.DigitalTwins/stable/2020-12-01/digitaltwins.json#L873:9
    ⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
    New: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L2157:5
    Old: Microsoft.DigitalTwins/stable/2020-12-01/digitaltwins.json#L1750:5
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L2002:9
    Old: Microsoft.DigitalTwins/stable/2020-12-01/digitaltwins.json#L1729:9
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L1842:9
    Old: Microsoft.DigitalTwins/stable/2020-12-01/digitaltwins.json#L1564:9
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L1696:5
    Old: Microsoft.DigitalTwins/stable/2020-12-01/digitaltwins.json#L1412:5
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L1730:5
    Old: Microsoft.DigitalTwins/stable/2020-12-01/digitaltwins.json#L1448:5
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L1764:5
    Old: Microsoft.DigitalTwins/stable/2020-12-01/digitaltwins.json#L1484:5
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L1960:9
    Old: Microsoft.DigitalTwins/stable/2020-12-01/digitaltwins.json#L1685:9
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L2002:9
    Old: Microsoft.DigitalTwins/stable/2020-12-01/digitaltwins.json#L1729:9
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L1842:9
    Old: Microsoft.DigitalTwins/stable/2020-12-01/digitaltwins.json#L1564:9
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L1696:5
    Old: Microsoft.DigitalTwins/stable/2020-12-01/digitaltwins.json#L1412:5
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L1730:5
    Old: Microsoft.DigitalTwins/stable/2020-12-01/digitaltwins.json#L1448:5
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.DigitalTwins/stable/2022-05-31/digitaltwins.json#L1764:5
    Old: Microsoft.DigitalTwins/stable/2020-12-01/digitaltwins.json#L1484:5
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 19, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go-track2 - armdigitaltwins - 0.6.0
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-digitaltwins - 6.1.0
    ️✔️azure-sdk-for-go - digitaltwins/mgmt/2020-12-01/digitaltwins - v65.0.0
    ️✔️azure-sdk-for-go - digitaltwins/mgmt/2020-10-31/digitaltwins - v65.0.0
    ️✔️azure-sdk-for-go - preview/digitaltwins/mgmt/2021-06-30-preview/digitaltwins - v65.0.0
    ️✔️azure-sdk-for-go - preview/digitaltwins/mgmt/2020-03-01-preview/digitaltwins - v65.0.0
    ️✔️azure-sdk-for-go - digitaltwins/mgmt/2022-05-31/digitaltwins - v65.0.0
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 360b1d5. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
    • ️✔️track2_azure-mgmt-digitaltwins [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 360b1d5. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
      cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
      cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
      cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
      cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
      cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
    • ️✔️azure-resourcemanager-digitaltwins [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 360b1d5. SDK Automation 14.0.0
      command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️digitaltwins/mgmt/2022-05-31/digitaltwins [View full logs]  [Release SDK Changes]
      info	[Changelog] This is a new package
      info	[Changelog]
    • ️✔️digitaltwins/mgmt/2020-12-01/digitaltwins [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️digitaltwins/mgmt/2020-10-31/digitaltwins [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/digitaltwins/mgmt/2021-06-30-preview/digitaltwins [View full logs
      info	[Changelog] This is a new package
      info	[Changelog]
    • ️✔️preview/digitaltwins/mgmt/2020-03-01-preview/digitaltwins [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 360b1d5. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armdigitaltwins [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `EndpointProvisioningStateUpdating`
      info	[Changelog] - New const `TimeSeriesDatabaseConnectionStateUpdating`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 2 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 360b1d5. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      cmderr	[automation_init.sh]  WARN deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
      cmderr	[automation_init.sh]  deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
      cmderr	[automation_init.sh] npm WARN deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
      cmderr	[automation_init.sh]  deprecated @azure/storage-blob@10.5.0: This version has been deprecated, please upgrade to the version tagged as latest
      cmderr	[automation_init.sh]  @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-digitaltwins [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation group TimeSeriesDatabaseConnections
      info	[Changelog]   - Added Interface GroupIdInformationProperties
      info	[Changelog]   - Added Interface SystemData
      info	[Changelog]   - Added Interface TimeSeriesDatabaseConnectionListResult
      info	[Changelog]   - Added Interface TimeSeriesDatabaseConnectionProperties
      info	[Changelog]   - Added Interface TimeSeriesDatabaseConnectionsCreateOrUpdateOptionalParams
      info	[Changelog]   - Added Interface TimeSeriesDatabaseConnectionsDeleteOptionalParams
      info	[Changelog]   - Added Interface TimeSeriesDatabaseConnectionsGetOptionalParams
      info	[Changelog]   - Added Interface TimeSeriesDatabaseConnectionsListNextOptionalParams
      info	[Changelog]   - Added Interface TimeSeriesDatabaseConnectionsListOptionalParams
      info	[Changelog]   - Added Type Alias AzureDataExplorerConnectionProperties
      info	[Changelog]   - Added Type Alias ConnectionType_2
      info	[Changelog]   - Added Type Alias CreatedByType
      info	[Changelog]   - Added Type Alias TimeSeriesDatabaseConnection
      info	[Changelog]   - Added Type Alias TimeSeriesDatabaseConnectionPropertiesUnion
      info	[Changelog]   - Added Type Alias TimeSeriesDatabaseConnectionsCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias TimeSeriesDatabaseConnectionsDeleteResponse
      info	[Changelog]   - Added Type Alias TimeSeriesDatabaseConnectionsGetResponse
      info	[Changelog]   - Added Type Alias TimeSeriesDatabaseConnectionsListNextResponse
      info	[Changelog]   - Added Type Alias TimeSeriesDatabaseConnectionsListResponse
      info	[Changelog]   - Added Type Alias TimeSeriesDatabaseConnectionState
      info	[Changelog]   - Interface DigitalTwinsResource has a new optional parameter systemData
      info	[Changelog]   - Interface ExternalResource has a new optional parameter systemData
      info	[Changelog]   - Interface Operation has a new optional parameter properties
      info	[Changelog]   - Interface PrivateEndpointConnection has a new optional parameter systemData
      info	[Changelog]   - Class AzureDigitalTwinsManagementClient has a new parameter timeSeriesDatabaseConnections
      info	[Changelog]   - Added Enum KnownConnectionType
      info	[Changelog]   - Added Enum KnownCreatedByType
      info	[Changelog]   - Added Enum KnownTimeSeriesDatabaseConnectionState
      info	[Changelog]   - Enum KnownEndpointProvisioningState has a new value Updating
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 360b1d5. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️digitaltwins [View full logs]  [Release Schema Changes]
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 360b1d5. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.DigitalTwins [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @sjiherzig, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 22, 2022
    @openapi-workflow-bot
    Copy link

    Hi, @sjiherzig your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    @sjiherzig
    Copy link
    Member Author

    I don't know what went wrong, but the changes are not showing up properly since pushing updates to the PR. Here is a list of what has changed w.r.t. 2021-06-30-preview:

    digitaltwins.json:

    • API version reference
    • Endpoint resource provisioning states include "Updating"
    • Time Series Database Connection resource provisioning states include "Updating"

    Examples:

    • Updated API versions
    • Added LRO headers (Azure-Async and Location, as well as Retry-After value)

    W.r.t. the last stable version (2020-12-01), the primary changes are the addition of the Time Series Database Connection resource & APIs.

    @sjiherzig sjiherzig marked this pull request as ready for review April 22, 2022 07:17
    @sjiherzig
    Copy link
    Member Author

    Service has not yet been deployed. Waiting for reviews, and will only merge / request to be merged once service version is available.

    @sjiherzig sjiherzig added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Apr 22, 2022
    @mentat9 mentat9 added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 22, 2022
    @ghost
    Copy link

    ghost commented May 8, 2022

    Hi, @sjiherzig. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost ghost added the no-recent-activity label May 8, 2022
    @sjiherzig sjiherzig removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jun 7, 2022
    @sjiherzig
    Copy link
    Member Author

    sjiherzig commented Jun 7, 2022

    @chunyu3 This is ready to be merged - thanks!

    @chunyu3
    Copy link
    Member

    chunyu3 commented Jun 8, 2022

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants