Add support for Standby Geo #18783
Merged
Add support for Standby Geo #18783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @subhrob Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The response of operation:'Databases_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Sql/preview/2022-02-01-preview/Databases.json#L68 |
|
The response of operation:'Databases_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Sql/preview/2022-02-01-preview/Databases.json#L108 |
|
The response of operation:'Databases_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Sql/preview/2022-02-01-preview/Databases.json#L253 |
|
The response of operation:'ReplicationLinks_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Sql/preview/2022-02-01-preview/ReplicationLinks.json#L65 |
|
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Sql/preview/2022-02-01-preview/ReplicationLinks.json#L141 |
|
Missing identifier id in array item property Location: Microsoft.Sql/preview/2022-02-01-preview/Databases.json#L1797 |
| A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: Microsoft.Sql/preview/2022-02-01-preview/Databases.json#L313 |
|
| A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: Microsoft.Sql/preview/2022-02-01-preview/Databases.json#L433 |
|
| A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: Microsoft.Sql/preview/2022-02-01-preview/Databases.json#L543 |
|
| A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: Microsoft.Sql/preview/2022-02-01-preview/Databases.json#L593 |
|
| A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: Microsoft.Sql/preview/2022-02-01-preview/ReplicationLinks.json#L156 |
|
| A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: Microsoft.Sql/preview/2022-02-01-preview/ReplicationLinks.json#L209 |
|
| OperationId should contain the verb: 'move' in:'Databases_Rename'. Consider updating the operationId Location: Microsoft.Sql/preview/2022-02-01-preview/Databases.json#L497 |
|
| OperationId should contain the verb: 'forcefailoverallowdataloss' in:'ReplicationLinks_FailoverAllowDataLoss'. Consider updating the operationId Location: Microsoft.Sql/preview/2022-02-01-preview/ReplicationLinks.json#L215 |
|
| '$skipToken' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation. Location: Microsoft.Sql/preview/2022-02-01-preview/Databases.json#L33 |
|
| 'linkId' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation. Location: Microsoft.Sql/preview/2022-02-01-preview/ReplicationLinks.json#L128 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/sql/resource-manager/readme.md tag: specification/sql/resource-manager/readme.md#tag-package-composite-v5 |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️Cross-Version Breaking Changes: 3 Warnings warning [Detail]
- Compared Swaggers (Based on Oad v0.9.3)
- current:preview/2022-02-01-preview/Databases.json compared with base:preview/2021-11-01-preview/Databases.json
- current:preview/2022-02-01-preview/ReplicationLinks.json compared with base:preview/2021-11-01-preview/ReplicationLinks.json
| Rule | Message |
|---|---|
| The new version is missing a property found in the old version. Was 'delegatedResources' renamed or removed? New: Microsoft.Sql/preview/2022-02-01-preview/Databases.json#L827:7 Old: Microsoft.Sql/preview/2021-11-01-preview/Databases.json#L824:7 |
|
| The new version is missing a property found in the old version. Was 'primaryDelegatedIdentityClientId' renamed or removed? New: Microsoft.Sql/preview/2022-02-01-preview/Databases.json#L877:7 Old: Microsoft.Sql/preview/2021-11-01-preview/Databases.json#L881:7 |
|
| The new version is missing a property found in the old version. Was 'primaryDelegatedIdentityClientId' renamed or removed? New: Microsoft.Sql/preview/2022-02-01-preview/Databases.json#L1242:7 Old: Microsoft.Sql/preview/2021-11-01-preview/Databases.json#L1250:7 |
️️✔️SDK Track2 Validation succeeded [Detail]
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
|
"readme":"sql/resource-manager/readme.md", "tag":"package-preview-2022-02", "details":"Error: Plugin checker reported failure." |
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
ghost
added
the
This was referenced Apr 22, 2022
This was referenced Apr 22, 2022
Closed
This was referenced Apr 22, 2022
|
please fix the failed pipeline. |
|
we might ignore the failed .NET sdk pipeline |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @subhrob your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
|
please update/add other replication link json files which might be impacted. |
|
Hi @subhrob, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This reverts commit 1bc2b74.
|
Please fix the checkboxes This is an update to an existing API version and does not require ARM review |
raosuhas
removed
the
WaitForARMFeedback
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
@raosuhas , i have unchecked the checkbox. Can the PR be merged now? |
No the checkbox is still set for ARM review request. Please update the second chack bos to remove "WaitforARMFeedback" tag. You need to work with the pr assignee from the sdk team and breaking change team if applicable to get this checked in |
|
@raosuhas i have updated the checkbox. The "WaitforARMFeedback" does not go away though. Thanks |
|
@raych1 , could you please provide your feedback for this PR. Thanks |
|
Hi @raych1 , could you please help review this PR. Thanks a lot. |
@subhrob , please see the first comment of this PR to have ARM team review on your latest changes. |
raych1
removed
the
WaitForARMFeedback
ericshape
pushed a commit
to ericshape/azure-rest-api-specs
that referenced
this pull request
May 31, 2022
* Add support for Standby Geo * Add text to custom-words * Add ReplicationLinks for older versions * Revert "Add ReplicationLinks for older versions" This reverts commit 1bc2b74. Co-authored-by: subhrob <subhrob@microsoft.com>
ericshape
pushed a commit
to ericshape/azure-rest-api-specs
that referenced
this pull request
May 31, 2022
* Add support for Standby Geo * Add text to custom-words * Add ReplicationLinks for older versions * Revert "Add ReplicationLinks for older versions" This reverts commit 1bc2b74. Co-authored-by: subhrob <subhrob@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.