AMS v2 public preview #18820

suhanishri · 2022-04-26T05:48:56Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

Please follow the link to find more details on the swagger existing in azure-rest-api-specs-pr repo AMS private repo swagger

Adding monitors spec and examples

All Monitors spec and examples

openapi-workflow-bot · 2022-04-26T05:48:58Z

Hi, @suhanishri Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-workflow-bot · 2022-04-26T05:48:59Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2022-04-26T05:49:00Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️⚠️LintDiff: 2 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.12.3 , classic-openapi-validator v1.2.4 )
- workloads/resource-manager/readme.md tag:package-2021-12-01-preview
Linted configuring files (Based on target branch, openapi-validator v1.12.3 , classic-openapi-validator v1.2.4 )
- workloads/resource-manager/readme.md tag:default

The following errors/warnings are introduced by current PR:

Rule	Message
⚠️ R3010 - TrackedResourceListByImmediateParent	The child tracked resource, 'providerInstances' with immediate parent 'Monitor', must have a list by immediate parent operation. Location: Microsoft.Workloads/preview/2021-12-01-preview/monitors.json#L843
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.Workloads/preview/2021-12-01-preview/monitors.json#L585

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

workloads/resource-manager/readme.md#package-2021-12-01-preview

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-04-26T05:49:01Z

Swagger Generation Artifacts

️⌛ApiDocPreview pending [Detail]

️⌛SDK Breaking Change Tracking pending [Detail]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2022-04-26T05:51:38Z

Hi @suhanishri, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

gargankit-microsoft · 2022-04-26T08:24:38Z

commonTypes.json can be removed, was used in SVI swagger only which is not being merged right now

Added new providers

openapi-pipeline-app · 2022-04-26T11:48:47Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️✔️azure-sdk-for-go-track2 - armworkloads - 0.1.0
️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-workloads - first release
️✔️azure-sdk-for-go - preview/workloads/mgmt/2021-12-01-preview/workloads - v63.4.0

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from cd8f049. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-workloads [View full logs] [Release SDK Changes]
- azure_mgmt_workloads-1.0.0b1-py3-none-any.whl
- azure-mgmt-workloads-1.0.0b1.zip
```
info	[Changelog]   - Initial Release
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from cd8f049. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.

️✔️azure-resourcemanager-workloads [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from cd8f049. SDK Automation 14.0.0

command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️preview/workloads/mgmt/2021-12-01-preview/workloads [View full logs] [Release SDK Changes]
```
info	[Changelog] This is a new package
info	[Changelog]
```

️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from cd8f049. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️armworkloads [View full logs] [Release SDK Changes]
```
info	[Changelog] This is a new package
info	[Changelog]
```

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs]Release - Generate from cd8f049. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh] deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh] npm WARN deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh] deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh] deprecated @azure/storage-blob@10.5.0: This version has been deprecated, please upgrade to the version tagged as latest
cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-workloads [View full logs] [Release SDK Changes]
- azure-arm-workloads-1.0.0-beta.1.tgz
```
info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
```

️❌ azure-sdk-for-net failed [Detail]

❌Failed [Logs]Release - Generate from cd8f049. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/workloads/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] No usable version of the libssl was found
cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
warn	Skip package processing as generation is failed

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from cd8f049. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️workloads [View full logs] [Release Schema Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

Updating with recent monitors spec changes in private repo

Changes for Go sdk

openapi-workflow-bot · 2022-05-05T10:38:42Z

Hi, @suhanishri your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

...tion/workloads/resource-manager/Microsoft.Workloads/preview/2021-12-01-preview/monitors.json

honghr · 2022-05-10T10:28:24Z

Hi @suhanishri , You need waiting for ARM team review. Once ARM review completed, it will be labeled with ARMSignedOff. And then I can merge it.

rkmanda

🕐

suhanishri · 2022-05-12T12:19:57Z

Hi @suhanishri , You need waiting for ARM team review. Once ARM review completed, it will be labeled with ARMSignedOff. And then I can merge it.

Hi @honghr ,
We are already live in private preview and have onboarded multiple customers. our existing swagger is in private repo(https://github.com/Azure/azure-rest-api-specs-pr/tree/RPSaaSMaster/specification/workloads/resource-manager/Microsoft.Workloads/preview/2021-12-01-preview) and is already approved by ARM team earlier when we started our development.

Link to private repo PR with ARM sign off - https://github.com/Azure/azure-rest-api-specs-pr/pull/5262

I suppose that should be sufficient here.

rkmanda

Create to sync Azure/azure-rest-api-specs#18820 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...azure-sdk:sdkAuto/workloads?expand=1)

* Adding monitors spec and examples Adding monitors spec and examples * All Monitors spec and examples All Monitors spec and examples * Delete commonTypes.json * Added new providers Added new providers * Updating with recent monitors spec changes in private repo Updating with recent monitors spec changes in private repo * Changes for Go sdk Changes for Go sdk * Update readme.md

suhanishri added 2 commits April 25, 2022 18:49

Adding monitors spec and examples

c3cc3db

Adding monitors spec and examples

All Monitors spec and examples

2d9f36e

All Monitors spec and examples

suhanishri added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Apr 26, 2022

suhanishri requested review from msyyc, BigCat20196, ArcturusZhang, jsntcy and qiaozha as code owners April 26, 2022 05:48

openapi-assignment-bot bot assigned honghr Apr 26, 2022

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Apr 26, 2022

Delete commonTypes.json

4837ab9

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Apr 26, 2022

gargankit-microsoft approved these changes Apr 26, 2022

View reviewed changes

Added new providers

61aff7c

Added new providers

suhanishri requested a review from amitms2103 April 27, 2022 06:23

suhanishri added 2 commits April 27, 2022 12:54

Updating with recent monitors spec changes in private repo

c781ca4

Updating with recent monitors spec changes in private repo

Changes for Go sdk

c35c2df

Changes for Go sdk

suhanishri removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label May 4, 2022

amitms2103 approved these changes May 4, 2022

View reviewed changes

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 5, 2022

zizw123 reviewed May 6, 2022

View reviewed changes

...tion/workloads/resource-manager/Microsoft.Workloads/preview/2021-12-01-preview/monitors.json Show resolved Hide resolved

zizw123 reviewed May 6, 2022

View reviewed changes

...tion/workloads/resource-manager/Microsoft.Workloads/preview/2021-12-01-preview/monitors.json Show resolved Hide resolved

zizw123 reviewed May 6, 2022

View reviewed changes

...tion/workloads/resource-manager/Microsoft.Workloads/preview/2021-12-01-preview/monitors.json Show resolved Hide resolved

zizw123 reviewed May 6, 2022

View reviewed changes

...tion/workloads/resource-manager/Microsoft.Workloads/preview/2021-12-01-preview/monitors.json Show resolved Hide resolved

suhanishri requested a review from zizw123 May 9, 2022 07:37

rkmanda requested changes May 12, 2022

View reviewed changes

rkmanda added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label May 12, 2022

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 12, 2022

rkmanda approved these changes May 14, 2022

View reviewed changes

rkmanda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label May 14, 2022

openapi-workflow-bot bot removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label May 14, 2022

honghr merged commit cd8f049 into main May 15, 2022

azure-sdk mentioned this pull request May 15, 2022

[ReleasePR @azure/arm-workloads] [Microsoft.Workloads/monitors] Add a new API version 2023-10-01-preview Azure/azure-sdk-for-js#21876

Closed

gargankit-microsoft deleted the Workloads/AmsV2_PublicPreview_rev1 branch May 26, 2022 08:45

gargankit-microsoft restored the Workloads/AmsV2_PublicPreview_rev1 branch May 26, 2022 08:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AMS v2 public preview #18820

AMS v2 public preview #18820

suhanishri commented Apr 26, 2022 •

edited by honghr

Loading

openapi-workflow-bot bot commented Apr 26, 2022

openapi-workflow-bot bot commented Apr 26, 2022

openapi-pipeline-app bot commented Apr 26, 2022 •

edited

Loading

openapi-pipeline-app bot commented Apr 26, 2022 •

edited

Loading

openapi-workflow-bot bot commented Apr 26, 2022

gargankit-microsoft commented Apr 26, 2022 •

edited

Loading

openapi-pipeline-app bot commented Apr 26, 2022 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented May 5, 2022

honghr commented May 10, 2022

rkmanda left a comment

suhanishri commented May 12, 2022 •

edited

Loading

rkmanda left a comment

AMS v2 public preview #18820

AMS v2 public preview #18820

Conversation

suhanishri commented Apr 26, 2022 • edited by honghr Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Apr 26, 2022

openapi-workflow-bot bot commented Apr 26, 2022

openapi-pipeline-app bot commented Apr 26, 2022 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Apr 26, 2022 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Apr 26, 2022

gargankit-microsoft commented Apr 26, 2022 • edited Loading

openapi-pipeline-app bot commented Apr 26, 2022 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented May 5, 2022

honghr commented May 10, 2022

rkmanda left a comment

Choose a reason for hiding this comment

suhanishri commented May 12, 2022 • edited Loading

rkmanda left a comment

Choose a reason for hiding this comment

suhanishri commented Apr 26, 2022 •

edited by honghr

Loading

openapi-pipeline-app bot commented Apr 26, 2022 •

edited

Loading

openapi-pipeline-app bot commented Apr 26, 2022 •

edited

Loading

gargankit-microsoft commented Apr 26, 2022 •

edited

Loading

openapi-pipeline-app bot commented Apr 26, 2022 •

edited

Loading

suhanishri commented May 12, 2022 •

edited

Loading