Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.MixedReality to add version preview/2019-02-28-preview #18835

Conversation

RamonArguelles
Copy link
Contributor

@RamonArguelles RamonArguelles commented Apr 27, 2022

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Apr 27, 2022

Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]
Rule Message
1041 - AddedPropertyInResponse The new version has a new property 'origin' in response that was not found in the old version.
New: Microsoft.MixedReality/preview/2019-02-28-preview/mixedreality.json#L526:7
Old: Microsoft.MixedReality/preview/2019-02-28-preview/mixedreality.json#L526:7
️⚠️LintDiff: 0 Warnings warning [Detail]
The following errors/warnings exist before current PR submission:
Rule Message
R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
Location: Microsoft.MixedReality/preview/2019-02-28-preview/mixedreality.json#L61
R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
Location: Microsoft.MixedReality/preview/2019-02-28-preview/mixedreality.json#L106
R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
Location: Microsoft.MixedReality/preview/2019-02-28-preview/mixedreality.json#L143
R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
Location: Microsoft.MixedReality/preview/2019-02-28-preview/mixedreality.json#L185
R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
Location: Microsoft.MixedReality/preview/2019-02-28-preview/mixedreality.json#L230
R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
Location: Microsoft.MixedReality/preview/2019-02-28-preview/mixedreality.json#L270
R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
Location: Microsoft.MixedReality/preview/2019-02-28-preview/mixedreality.json#L313
R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
Location: Microsoft.MixedReality/preview/2019-02-28-preview/mixedreality.json#L362
R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
Location: Microsoft.MixedReality/preview/2019-02-28-preview/mixedreality.json#L404
R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
Location: Microsoft.MixedReality/preview/2019-02-28-preview/mixedreality.json#L447
R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.MixedReality/preview/2019-02-28-preview/mixedreality.json#L641
R4037 - MissingTypeObject The schema 'OperationList' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.MixedReality/preview/2019-02-28-preview/mixedreality.json#L585
R4041 - XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.MixedReality/preview/2019-02-28-preview/mixedreality.json#L588
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: nameAvailable
Location: Microsoft.MixedReality/preview/2019-02-28-preview/mixedreality.json#L483
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction
Location: Microsoft.MixedReality/preview/2019-02-28-preview/mixedreality.json#L535
⚠️ R4024 - PreviewVersionOverOneYear The API version:2019-02-28-preview having been in a preview state over one year , please move it to GA or retire.
Location: Microsoft.MixedReality/preview/2019-02-28-preview/mixedreality.json#L6
⚠️ R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: ResourceGet
Location: Microsoft.MixedReality/preview/2019-02-28-preview/mixedreality.json#L244
⚠️ R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: ResourceRegenerateKey
Location: Microsoft.MixedReality/preview/2019-02-28-preview/mixedreality.json#L418
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation

️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Apr 27, 2022

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

️✔️azure-sdk-for-go-track2 - armmixedreality - 0.4.1
️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-mixedreality - 1.0.0
️✔️azure-sdk-for-go - mixedreality/mgmt/2021-01-01/mixedreality - v63.4.0
️✔️azure-sdk-for-go - preview/mixedreality/mgmt/2021-03-01-preview/mixedreality - v63.4.0
azure-sdk-for-go - preview/mixedreality/mgmt/2020-05-01-preview/mixedreality - v63.4.0
+	Const `False` has been removed
+	Const `True` has been removed
+	Function `PossibleNameAvailabilityValues` has been removed
+	Function `RemoteRenderingAccountIdentity.MarshalJSON` has been removed
+	Struct `RemoteRenderingAccountIdentity` has been removed
+	Type of `CheckNameAvailabilityResponse.NameAvailable` has been changed from `NameAvailability` to `*bool`
+	Type of `RemoteRenderingAccount.Identity` has been changed from `*RemoteRenderingAccountIdentity` to `*Identity`
️✔️azure-sdk-for-go - preview/mixedreality/mgmt/2019-02-28/mixedreality - v63.4.0
️❌ azure-sdk-for-net failed [Detail]
  • Failed [Logs]Release - Generate from b9d9355. SDK Automation 14.0.0
    warn	Skip initScript due to not configured
    command	sudo apt-get install -y dotnet-sdk-6.0
    command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/mixedreality/resource-manager/readme.md
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] No usable version of the libssl was found
    cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
    cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
    cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
    error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
    warn	Skip package processing as generation is failed
️⚠️ azure-sdk-for-python-track2 warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from b9d9355. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmderr	[automation_generate.sh]
    cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.5.5 -> 8.10.0
    cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.10.0>
    cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.10.0` to update!
    cmderr	[automation_generate.sh] npm notice
  • ️✔️track2_azure-mgmt-mixedreality [View full logs]  [Release SDK Changes]
    info	[Changelog] **Features**
    info	[Changelog]
    info	[Changelog]   - Model MetricDimension has a new parameter to_be_exported_for_shoebox
    info	[Changelog]   - Model MetricSpecification has a new parameter category
    info	[Changelog]   - Model MetricSpecification has a new parameter enable_regional_mdm_account
    info	[Changelog]   - Model MetricSpecification has a new parameter fill_gap_with_zero
    info	[Changelog]   - Model MetricSpecification has a new parameter locked_aggregation_type
    info	[Changelog]   - Model MetricSpecification has a new parameter metric_filter_pattern
    info	[Changelog]   - Model MetricSpecification has a new parameter source_mdm_account
    info	[Changelog]   - Model MetricSpecification has a new parameter source_mdm_namespace
    info	[Changelog]   - Model MetricSpecification has a new parameter supported_aggregation_types
    info	[Changelog]   - Model MetricSpecification has a new parameter supported_time_grain_types
    info	[Changelog]   - Model ObjectAnchorsAccount has a new parameter kind
    info	[Changelog]   - Model ObjectAnchorsAccount has a new parameter plan
    info	[Changelog]   - Model ObjectAnchorsAccount has a new parameter sku
️⚠️ azure-sdk-for-js warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from b9d9355. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    cmderr	[automation_init.sh]  read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
    cmderr	[automation_init.sh] deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
    cmderr	[automation_init.sh] npm WARN deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
    cmderr	[automation_init.sh] WARN deprecated @azure/storage-blob@10.5.0: This version has been deprecated, please upgrade to the version tagged as latest
    cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-mixedreality [View full logs]  [Release SDK Changes]
    info	[Changelog] **Features**
    info	[Changelog]
    info	[Changelog]   - Added operation group ObjectAnchorsAccounts
    info	[Changelog]   - Added Interface ObjectAnchorsAccountPage
    info	[Changelog]   - Added Interface ObjectAnchorsAccountsCreateOptionalParams
    info	[Changelog]   - Added Interface ObjectAnchorsAccountsDeleteOptionalParams
    info	[Changelog]   - Added Interface ObjectAnchorsAccountsGetOptionalParams
    info	[Changelog]   - Added Interface ObjectAnchorsAccountsListByResourceGroupNextOptionalParams
    info	[Changelog]   - Added Interface ObjectAnchorsAccountsListByResourceGroupOptionalParams
    info	[Changelog]   - Added Interface ObjectAnchorsAccountsListBySubscriptionNextOptionalParams
    info	[Changelog]   - Added Interface ObjectAnchorsAccountsListBySubscriptionOptionalParams
    info	[Changelog]   - Added Interface ObjectAnchorsAccountsListKeysOptionalParams
    info	[Changelog]   - Added Interface ObjectAnchorsAccountsRegenerateKeysOptionalParams
    info	[Changelog]   - Added Interface ObjectAnchorsAccountsUpdateOptionalParams
    info	[Changelog]   - Added Type Alias ObjectAnchorsAccount
    info	[Changelog]   - Added Type Alias ObjectAnchorsAccountIdentity
    info	[Changelog]   - Added Type Alias ObjectAnchorsAccountsCreateResponse
    info	[Changelog]   - Added Type Alias ObjectAnchorsAccountsGetResponse
    info	[Changelog]   - Added Type Alias ObjectAnchorsAccountsListByResourceGroupNextResponse
    info	[Changelog]   - Added Type Alias ObjectAnchorsAccountsListByResourceGroupResponse
    info	[Changelog]   - Added Type Alias ObjectAnchorsAccountsListBySubscriptionNextResponse
    info	[Changelog]   - Added Type Alias ObjectAnchorsAccountsListBySubscriptionResponse
    info	[Changelog]   - Added Type Alias ObjectAnchorsAccountsListKeysResponse
    info	[Changelog]   - Added Type Alias ObjectAnchorsAccountsRegenerateKeysResponse
    info	[Changelog]   - Added Type Alias ObjectAnchorsAccountsUpdateResponse
    info	[Changelog]   - Interface MetricDimension has a new optional parameter toBeExportedForShoebox
    info	[Changelog]   - Class MixedRealityClient has a new parameter objectAnchorsAccounts
    error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from b9d9355. SDK Automation 14.0.0
    command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️mixedreality/mgmt/2021-01-01/mixedreality [View full logs]  [Release SDK Changes]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New field `EnableRegionalMdmAccount` in struct `MetricSpecification`
    info	[Changelog] - New field `SourceMdmNamespace` in struct `MetricSpecification`
    info	[Changelog] - New field `Category` in struct `MetricSpecification`
    info	[Changelog] - New field `SupportedAggregationTypes` in struct `MetricSpecification`
    info	[Changelog] - New field `FillGapWithZero` in struct `MetricSpecification`
    info	[Changelog] - New field `LockedAggregationType` in struct `MetricSpecification`
    info	[Changelog] - New field `MetricFilterPattern` in struct `MetricSpecification`
    info	[Changelog] - New field `SourceMdmAccount` in struct `MetricSpecification`
    info	[Changelog] - New field `SupportedTimeGrainTypes` in struct `MetricSpecification`
    info	[Changelog] - New field `ToBeExportedForShoebox` in struct `MetricDimension`
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 2 additive change(s).
  • ️✔️preview/mixedreality/mgmt/2021-03-01-preview/mixedreality [View full logs
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New field `SupportedAggregationTypes` in struct `MetricSpecification`
    info	[Changelog] - New field `SourceMdmAccount` in struct `MetricSpecification`
    info	[Changelog] - New field `FillGapWithZero` in struct `MetricSpecification`
    info	[Changelog] - New field `Category` in struct `MetricSpecification`
    info	[Changelog] - New field `LockedAggregationType` in struct `MetricSpecification`
    info	[Changelog] - New field `EnableRegionalMdmAccount` in struct `MetricSpecification`
    info	[Changelog] - New field `SourceMdmNamespace` in struct `MetricSpecification`
    info	[Changelog] - New field `MetricFilterPattern` in struct `MetricSpecification`
    info	[Changelog] - New field `SupportedTimeGrainTypes` in struct `MetricSpecification`
    info	[Changelog] - New field `ToBeExportedForShoebox` in struct `MetricDimension`
    info	[Changelog] - New field `Kind` in struct `ObjectAnchorsAccount`
    info	[Changelog] - New field `Plan` in struct `ObjectAnchorsAccount`
    info	[Changelog] - New field `Sku` in struct `ObjectAnchorsAccount`
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 3 additive change(s).
  • ️✔️preview/mixedreality/mgmt/2020-05-01-preview/mixedreality [View full logs
    Only show 30 items here, please refer to log for details.
    info	[Changelog] - Struct `RemoteRenderingAccountIdentity` has been removed
    info	[Changelog]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New const `ManagedIdentity`
    info	[Changelog] - New const `Application`
    info	[Changelog] - New const `Key`
    info	[Changelog] - New const `User`
    info	[Changelog] - New function `PossibleCreatedByTypeValues() []CreatedByType`
    info	[Changelog] - New struct `LogSpecification`
    info	[Changelog] - New struct `MetricDimension`
    info	[Changelog] - New struct `MetricSpecification`
    info	[Changelog] - New struct `OperationProperties`
    info	[Changelog] - New struct `ServiceSpecification`
    info	[Changelog] - New struct `SystemData`
    info	[Changelog] - New field `Origin` in struct `Operation`
    info	[Changelog] - New field `Properties` in struct `Operation`
    info	[Changelog] - New field `IsDataAction` in struct `Operation`
    info	[Changelog] - New field `Plan` in struct `SpatialAnchorsAccount`
    info	[Changelog] - New field `Sku` in struct `SpatialAnchorsAccount`
    info	[Changelog] - New field `Identity` in struct `SpatialAnchorsAccount`
    info	[Changelog] - New field `Kind` in struct `SpatialAnchorsAccount`
    info	[Changelog] - New field `SystemData` in struct `SpatialAnchorsAccount`
    info	[Changelog] - New field `StorageAccountName` in struct `AccountProperties`
    info	[Changelog] - New field `Sku` in struct `RemoteRenderingAccount`
    info	[Changelog] - New field `Plan` in struct `RemoteRenderingAccount`
    info	[Changelog] - New field `Kind` in struct `RemoteRenderingAccount`
    info	[Changelog] - New field `SystemData` in struct `RemoteRenderingAccount`
    info	[Changelog]
    info	[Changelog] Total 8 breaking change(s), 21 additive change(s).
  • ️✔️preview/mixedreality/mgmt/2019-02-28/mixedreality [View full logs
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New field `Origin` in struct `Operation`
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 1 additive change(s).
️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from b9d9355. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️armmixedreality [View full logs]  [Release SDK Changes]
    info	[Changelog] ### Other Changes
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
️⚠️ azure-sdk-for-java warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from b9d9355. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
    cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
    cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
    cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
    cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
  • ️✔️azure-resourcemanager-mixedreality [View full logs]  [Release SDK Changes]
️⚠️ azure-resource-manager-schemas warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from b9d9355. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] WARN old lockfile
    cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
    cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
    cmderr	[initScript.sh] npm WARN old lockfile
    cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
    cmderr	[initScript.sh] npm WARN old lockfile
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    warn	No file changes detected after generation
  • ️✔️mixedreality [View full logs
️❌ azure-powershell failed [Detail]
  • Failed [Logs]Release - Generate from b9d9355. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • Az.mixedreality [View full logs]  [Release SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

@RamonArguelles
Copy link
Contributor Author

Will be following up on the breaking change approval

@openapi-workflow-bot
Copy link

NewApiVersionRequired reason:

A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

@RamonArguelles
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@RamonArguelles
Copy link
Contributor Author

Hi @leni-msft. We followed up with a request to get a breaking change approval, which we thankfully got. Any else we might be missing to be able to complete this PR?

Thanks!

@ghost
Copy link

ghost commented May 22, 2022

Hi, @RamonArguelles. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

@ghost ghost added the no-recent-activity label May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 FixS360
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants