[Hub Generated] Review request for Microsoft.SqlVirtualMachine to add version preview/2021-11-01-preview #18838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The new version is adding enum value(s) 'Everyday' from the old version. New: Microsoft.SqlVirtualMachine/preview/2021-11-01-preview/sqlvm.json#L1691:9 Old: Microsoft.SqlVirtualMachine/preview/2021-11-01-preview/sqlvm.json#L1691:9 |
️⚠️LintDiff: 0 Warnings warning [Detail]
- Linted configuring files (Based on source branch, openapi-validator v1.13.0 , classic-openapi-validator v1.2.4 )
- Linted configuring files (Based on target branch, openapi-validator v1.13.0 , classic-openapi-validator v1.2.4 )
| Rule | Message |
|---|---|
|
The response schema of operations API '/providers/Microsoft.SqlVirtualMachine/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.SqlVirtualMachine/preview/2021-11-01-preview/sqlvm.json#L238 |
|
Missing identifier id in array item property Location: Microsoft.SqlVirtualMachine/preview/2021-11-01-preview/sqlvm.json#L984 |
|
Missing identifier id in array item property Location: Microsoft.SqlVirtualMachine/preview/2021-11-01-preview/sqlvm.json#L1201 |
| The child tracked resource, 'availabilityGroupListeners' with immediate parent 'SqlVirtualMachineGroup', must have a list by immediate parent operation. Location: Microsoft.SqlVirtualMachine/preview/2021-11-01-preview/sqlvm.json#L1158 |
|
| Guid used in model definition 'ResourceIdentity' for property 'principalId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.SqlVirtualMachine/preview/2021-11-01-preview/sqlvm.json#L1535 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: createDefaultAvailabilityGroupIfNotExist Location: Microsoft.SqlVirtualMachine/preview/2021-11-01-preview/sqlvm.json#L991 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enable Location: Microsoft.SqlVirtualMachine/preview/2021-11-01-preview/sqlvm.json#L1687 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enable Location: Microsoft.SqlVirtualMachine/preview/2021-11-01-preview/sqlvm.json#L1725 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableEncryption Location: Microsoft.SqlVirtualMachine/preview/2021-11-01-preview/sqlvm.json#L1729 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: backupSystemDbs Location: Microsoft.SqlVirtualMachine/preview/2021-11-01-preview/sqlvm.json#L1762 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enable Location: Microsoft.SqlVirtualMachine/preview/2021-11-01-preview/sqlvm.json#L1831 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: sqlSystemDbOnDataDisk Location: Microsoft.SqlVirtualMachine/preview/2021-11-01-preview/sqlvm.json#L1899 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enable Location: Microsoft.SqlVirtualMachine/preview/2021-11-01-preview/sqlvm.json#L1939 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: runImmediately Location: Microsoft.SqlVirtualMachine/preview/2021-11-01-preview/sqlvm.json#L1943 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isRServicesEnabled Location: Microsoft.SqlVirtualMachine/preview/2021-11-01-preview/sqlvm.json#L2047 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isOptimizeForAdHocWorkloadsEnabled Location: Microsoft.SqlVirtualMachine/preview/2021-11-01-preview/sqlvm.json#L2066 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enable Location: Microsoft.SqlVirtualMachine/preview/2021-11-01-preview/sqlvm.json#L2145 |
|
| 'SQLTempDbSettings' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.SqlVirtualMachine/preview/2021-11-01-preview/sqlvm.json#L2100 |
|
| 'Schedule' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.SqlVirtualMachine/preview/2021-11-01-preview/sqlvm.json#L2142 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
|
Hi @rchlkm, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Apr 27, 2022
rchlkm
commented
Apr 27, 2022
| @@ -1697,7 +1697,8 @@ | |||
| "Thursday", | |||
| "Friday", | |||
| "Saturday", | |||
| "Sunday" | |||
| "Sunday", | |||
| "Everyday" | |||
There was a problem hiding this comment.
Hi @raych1, This PR is adding "Everyday" enum value to autoPatchingSettings.dayOfWeek. This value was already an accepted value by SQL VM Resource Provider before we released 2021-11-01 version, however, the enum value as missed during the swagger generation process.
How can we avoid this breaking change flag?
There was a problem hiding this comment.
It has to get breaking change review board approval.
|
Hi @rchlkm, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
@rchlkm , can you fix the |
|
Hi, @rchlkm. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
ghost
added
the
JeffreyRichter
added
the
Approved-BreakingChange
Swagger Generation Artifacts
|
Swagger Generation Artifacts
|
raych1
approved these changes
May 25, 2022
This was referenced May 25, 2022
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
May 25, 2022
…osoft.SqlVirtualMachine to add version preview/2021-11-01-preview (#2387) Create to sync Azure/azure-rest-api-specs#18838 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...azure-sdk:sdkAuto/sqlvirtualmachine?expand=1)
gargankit-microsoft
pushed a commit
that referenced
this pull request
May 26, 2022
… version preview/2021-11-01-preview (#18838) * Add Everyday enum to autoPatching.dayOfWeek * rename duplicate x-ms-enum * rename PatchingDayOfWeek * rename days of week variants * rename AutoBackupDaysOfWeek
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.