Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage STG 83 features #18887

Merged
merged 5 commits into from
May 11, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -700,6 +700,27 @@
},
{
"$ref": "#/parameters/SourceIfUnmodifiedSince"
},
{
"$ref": "#/parameters/Owner"
},
{
"$ref": "#/parameters/Group"
},
{
"$ref": "#/parameters/Acl"
},
{
"$ref": "#/parameters/ProposedLeaseIdOptional"
},
{
"$ref": "#/parameters/LeaseDurationMethod"
},
{
"$ref": "#/parameters/PathExpiryOptionsOptional"
},
{
"$ref": "#/parameters/PathExpiryTime"
}
],
"responses": {
Expand Down Expand Up @@ -1018,12 +1039,7 @@
}
},
{
"name": "x-ms-lease-duration",
"in": "header",
"description": "The lease duration is required to acquire a lease, and specifies the duration of the lease in seconds. The lease duration must be between 15 and 60 seconds or -1 for infinite lease.",
"format": "int32",
"required": false,
"type": "integer"
"$ref": "#/parameters/LeaseDuration"
},
{
"name": "x-ms-lease-break-period",
Expand Down Expand Up @@ -2585,6 +2601,25 @@
"x-ms-parameter-location": "method",
"description": "Proposed lease ID, in a GUID string format. The Blob service returns 400 (Invalid request) if the proposed lease ID is not in the correct format. See Guid Constructor (String) for a list of valid GUID string formats."
},
"LeaseDuration": {
"name": "x-ms-lease-duration",
"in": "header",
"description": "The lease duration is required to acquire a lease, and specifies the duration of the lease in seconds. The lease duration must be between 15 and 60 seconds or -1 for infinite lease.",
"format": "int32",
"required": false,
"type": "integer",
"x-ms-parameter-location": "client"
},
"LeaseDurationMethod": {
"name": "x-ms-lease-duration",
"x-ms-client-name": "leaseDuration",
"in": "header",
"description": "The lease duration is required to acquire a lease, and specifies the duration of the lease in seconds. The lease duration must be between 15 and 60 seconds or -1 for infinite lease.",
"format": "int64",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is of an int32 type in the LeaseDuration specification. I am curious if there is a reason this is int64 here? Same for the rest of the files

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seanmcc-msft - is this a bug in your swagger spec?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using longs moving forward, this was originally int32 to historical reasons.

"required": false,
"type": "integer",
"x-ms-parameter-location": "method"
},
"Prefix": {
"name": "prefix",
"in": "query",
Expand Down Expand Up @@ -2914,6 +2949,25 @@
"x-ms-parameter-location": "method",
"description": "Required. Indicates mode of the expiry time"
},
"PathExpiryOptionsOptional": {
"name": "x-ms-expiry-option",
"x-ms-client-name": "ExpiryOptions",
"in": "header",
"required": false,
"type": "string",
"enum": [
"NeverExpire",
"RelativeToCreation",
"RelativeToNow",
"Absolute"
],
"x-ms-enum": {
"name": "PathExpiryOptions",
"modelAsString": true
},
"x-ms-parameter-location": "method",
"description": "Required. Indicates mode of the expiry time"
},
"PathExpiryTime": {
"name": "x-ms-expiry-time",
"x-ms-client-name": "ExpiresOn",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -709,6 +709,27 @@
},
{
"$ref": "#/parameters/EncryptionAlgorithm"
},
{
"$ref": "#/parameters/Owner"
},
{
"$ref": "#/parameters/Group"
},
{
"$ref": "#/parameters/Acl"
},
{
"$ref": "#/parameters/ProposedLeaseIdOptional"
},
{
"$ref": "#/parameters/LeaseDurationMethod"
},
{
"$ref": "#/parameters/PathExpiryOptionsOptional"
},
{
"$ref": "#/parameters/PathExpiryTime"
}
],
"responses": {
Expand Down Expand Up @@ -1037,12 +1058,7 @@
}
},
{
"name": "x-ms-lease-duration",
"in": "header",
"description": "The lease duration is required to acquire a lease, and specifies the duration of the lease in seconds. The lease duration must be between 15 and 60 seconds or -1 for infinite lease.",
"format": "int32",
"required": false,
"type": "integer"
"$ref": "#/parameters/LeaseDuration"
},
{
"name": "x-ms-lease-break-period",
Expand Down Expand Up @@ -2666,6 +2682,25 @@
"x-ms-parameter-location": "method",
"description": "Proposed lease ID, in a GUID string format. The Blob service returns 400 (Invalid request) if the proposed lease ID is not in the correct format. See Guid Constructor (String) for a list of valid GUID string formats."
},
"LeaseDuration": {
"name": "x-ms-lease-duration",
"in": "header",
"description": "The lease duration is required to acquire a lease, and specifies the duration of the lease in seconds. The lease duration must be between 15 and 60 seconds or -1 for infinite lease.",
"format": "int32",
"required": false,
"type": "integer",
"x-ms-parameter-location": "client"
},
"LeaseDurationMethod": {
"name": "x-ms-lease-duration",
"x-ms-client-name": "leaseDuration",
"in": "header",
"description": "The lease duration is required to acquire a lease, and specifies the duration of the lease in seconds. The lease duration must be between 15 and 60 seconds or -1 for infinite lease.",
"format": "int64",
"required": false,
"type": "integer",
"x-ms-parameter-location": "method"
},
"Prefix": {
"name": "prefix",
"in": "query",
Expand Down Expand Up @@ -2995,6 +3030,25 @@
"x-ms-parameter-location": "method",
"description": "Required. Indicates mode of the expiry time"
},
"PathExpiryOptionsOptional": {
"name": "x-ms-expiry-option",
"x-ms-client-name": "ExpiryOptions",
"in": "header",
"required": false,
"type": "string",
"enum": [
"NeverExpire",
"RelativeToCreation",
"RelativeToNow",
"Absolute"
],
"x-ms-enum": {
"name": "PathExpiryOptions",
"modelAsString": true
},
"x-ms-parameter-location": "method",
"description": "Required. Indicates mode of the expiry time"
},
"PathExpiryTime": {
"name": "x-ms-expiry-time",
"x-ms-client-name": "ExpiresOn",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -709,6 +709,27 @@
},
{
"$ref": "#/parameters/EncryptionAlgorithm"
},
{
"$ref": "#/parameters/Owner"
},
{
"$ref": "#/parameters/Group"
},
{
"$ref": "#/parameters/Acl"
},
{
"$ref": "#/parameters/ProposedLeaseIdOptional"
},
{
"$ref": "#/parameters/LeaseDurationMethod"
},
{
"$ref": "#/parameters/PathExpiryOptionsOptional"
},
{
"$ref": "#/parameters/PathExpiryTime"
}
],
"responses": {
Expand Down Expand Up @@ -1037,12 +1058,7 @@
}
},
{
"name": "x-ms-lease-duration",
"in": "header",
"description": "The lease duration is required to acquire a lease, and specifies the duration of the lease in seconds. The lease duration must be between 15 and 60 seconds or -1 for infinite lease.",
"format": "int32",
"required": false,
"type": "integer"
"$ref": "#/parameters/LeaseDuration"
},
{
"name": "x-ms-lease-break-period",
Expand Down Expand Up @@ -2666,6 +2682,25 @@
"x-ms-parameter-location": "method",
"description": "Proposed lease ID, in a GUID string format. The Blob service returns 400 (Invalid request) if the proposed lease ID is not in the correct format. See Guid Constructor (String) for a list of valid GUID string formats."
},
"LeaseDuration": {
"name": "x-ms-lease-duration",
"in": "header",
"description": "The lease duration is required to acquire a lease, and specifies the duration of the lease in seconds. The lease duration must be between 15 and 60 seconds or -1 for infinite lease.",
"format": "int32",
"required": false,
"type": "integer",
"x-ms-parameter-location": "client"
},
"LeaseDurationMethod": {
"name": "x-ms-lease-duration",
"x-ms-client-name": "leaseDuration",
"in": "header",
"description": "The lease duration is required to acquire a lease, and specifies the duration of the lease in seconds. The lease duration must be between 15 and 60 seconds or -1 for infinite lease.",
"format": "int64",
"required": false,
"type": "integer",
"x-ms-parameter-location": "method"
},
"Prefix": {
"name": "prefix",
"in": "query",
Expand Down Expand Up @@ -2995,6 +3030,25 @@
"x-ms-parameter-location": "method",
"description": "Required. Indicates mode of the expiry time"
},
"PathExpiryOptionsOptional": {
"name": "x-ms-expiry-option",
"x-ms-client-name": "ExpiryOptions",
"in": "header",
"required": false,
"type": "string",
"enum": [
"NeverExpire",
"RelativeToCreation",
"RelativeToNow",
"Absolute"
],
"x-ms-enum": {
"name": "PathExpiryOptions",
"modelAsString": true
},
"x-ms-parameter-location": "method",
"description": "Required. Indicates mode of the expiry time"
},
"PathExpiryTime": {
"name": "x-ms-expiry-time",
"x-ms-client-name": "ExpiresOn",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -709,6 +709,27 @@
},
{
"$ref": "#/parameters/EncryptionAlgorithm"
},
{
"$ref": "#/parameters/Owner"
},
{
"$ref": "#/parameters/Group"
},
{
"$ref": "#/parameters/Acl"
},
{
"$ref": "#/parameters/ProposedLeaseIdOptional"
},
{
"$ref": "#/parameters/LeaseDurationMethod"
},
{
"$ref": "#/parameters/PathExpiryOptionsOptional"
},
{
"$ref": "#/parameters/PathExpiryTime"
}
],
"responses": {
Expand Down Expand Up @@ -1037,12 +1058,7 @@
}
},
{
"name": "x-ms-lease-duration",
"in": "header",
"description": "The lease duration is required to acquire a lease, and specifies the duration of the lease in seconds. The lease duration must be between 15 and 60 seconds or -1 for infinite lease.",
"format": "int32",
"required": false,
"type": "integer"
"$ref": "#/parameters/LeaseDuration"
},
{
"name": "x-ms-lease-break-period",
Expand Down Expand Up @@ -2666,6 +2682,25 @@
"x-ms-parameter-location": "method",
"description": "Proposed lease ID, in a GUID string format. The Blob service returns 400 (Invalid request) if the proposed lease ID is not in the correct format. See Guid Constructor (String) for a list of valid GUID string formats."
},
"LeaseDuration": {
"name": "x-ms-lease-duration",
"in": "header",
"description": "The lease duration is required to acquire a lease, and specifies the duration of the lease in seconds. The lease duration must be between 15 and 60 seconds or -1 for infinite lease.",
"format": "int32",
"required": false,
"type": "integer",
"x-ms-parameter-location": "client"
},
"LeaseDurationMethod": {
"name": "x-ms-lease-duration",
"x-ms-client-name": "leaseDuration",
"in": "header",
"description": "The lease duration is required to acquire a lease, and specifies the duration of the lease in seconds. The lease duration must be between 15 and 60 seconds or -1 for infinite lease.",
"format": "int64",
"required": false,
"type": "integer",
"x-ms-parameter-location": "method"
},
"Prefix": {
"name": "prefix",
"in": "query",
Expand Down Expand Up @@ -2995,6 +3030,25 @@
"x-ms-parameter-location": "method",
"description": "Required. Indicates mode of the expiry time"
},
"PathExpiryOptionsOptional": {
"name": "x-ms-expiry-option",
"x-ms-client-name": "ExpiryOptions",
"in": "header",
"required": false,
"type": "string",
"enum": [
"NeverExpire",
"RelativeToCreation",
"RelativeToNow",
"Absolute"
],
"x-ms-enum": {
"name": "PathExpiryOptions",
"modelAsString": true
},
"x-ms-parameter-location": "method",
"description": "Required. Indicates mode of the expiry time"
},
"PathExpiryTime": {
"name": "x-ms-expiry-time",
"x-ms-client-name": "ExpiresOn",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9555,7 +9555,8 @@
"P80",
"Hot",
"Cool",
"Archive"
"Archive",
"Premium"
],
"x-ms-enum": {
"name": "AccessTier",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9563,7 +9563,8 @@
"P80",
"Hot",
"Cool",
"Archive"
"Archive",
"Premium"
],
"x-ms-enum": {
"name": "AccessTier",
Expand Down
Loading