Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daorozco microsoft.authorization 2021 04 01 preview #18909

Conversation

dagoroz
Copy link
Contributor

@dagoroz dagoroz commented May 4, 2022

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.

Feature is already public, exposing versions to fix swagger KPI

  1. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.

Feature is already public, exposing versions to fix swagger KPI

  1. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[x] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @dagoroz Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 4, 2022

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    compared swaggers (via Oad v0.9.7)] new version base version
    authorization-AccessReviewCalls.json 2021-03-01-preview(92ea9ee) 2021-03-01-preview(main)
    ️❌Breaking Change(Cross-Version): 15 Errors, 18 Warnings failed [Detail]
    compared swaggers (via Oad v0.9.7)] new version base version
    authorization-RoleAssignmentsCalls.json 2021-04-01-preview(92ea9ee) 2015-07-01(main)
    authorization-RoleAssignmentsCalls.json 2021-04-01-preview(92ea9ee) 2020-10-01-preview(main)
    common-types.json 2021-04-01-preview(92ea9ee) 2020-10-01(main)
    common-types.json 2021-04-01-preview(92ea9ee) 2020-10-01-preview(main)

    The following breaking changes are detected by comparison with the latest stable version:

    Only 29 items are listed, please refer to log for more details.

    Rule Message
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/{resourceProviderNamespace}/{parentResourcePath}/{resourceType}/{resourceName}/providers/Microsoft.Authorization/roleAssignments' removed or restructured?
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-RoleAssignmentsCalls.json#L37:5
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'RoleManagementPolicyApprovalRule' removed or renamed?
    New: Microsoft.Authorization/preview/2021-04-01-preview/common-types.json#L19:3
    Old: Microsoft.Authorization/stable/2020-10-01/common-types.json#L19:3
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ApprovalSettings' removed or renamed?
    New: Microsoft.Authorization/preview/2021-04-01-preview/common-types.json#L19:3
    Old: Microsoft.Authorization/stable/2020-10-01/common-types.json#L19:3
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'RoleManagementPolicyAuthenticationContextRule' removed or renamed?
    New: Microsoft.Authorization/preview/2021-04-01-preview/common-types.json#L19:3
    Old: Microsoft.Authorization/stable/2020-10-01/common-types.json#L19:3
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'RoleManagementPolicyEnablementRule' removed or renamed?
    New: Microsoft.Authorization/preview/2021-04-01-preview/common-types.json#L19:3
    Old: Microsoft.Authorization/stable/2020-10-01/common-types.json#L19:3
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'RoleManagementPolicyExpirationRule' removed or renamed?
    New: Microsoft.Authorization/preview/2021-04-01-preview/common-types.json#L19:3
    Old: Microsoft.Authorization/stable/2020-10-01/common-types.json#L19:3
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'RoleManagementPolicyNotificationRule' removed or renamed?
    New: Microsoft.Authorization/preview/2021-04-01-preview/common-types.json#L19:3
    Old: Microsoft.Authorization/stable/2020-10-01/common-types.json#L19:3
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'RoleManagementPolicyRuleTarget' removed or renamed?
    New: Microsoft.Authorization/preview/2021-04-01-preview/common-types.json#L19:3
    Old: Microsoft.Authorization/stable/2020-10-01/common-types.json#L19:3
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'RoleManagementPolicyRuleType' removed or renamed?
    New: Microsoft.Authorization/preview/2021-04-01-preview/common-types.json#L19:3
    Old: Microsoft.Authorization/stable/2020-10-01/common-types.json#L19:3
    1008 - ModifiedOperationId The operation id has been changed from 'RoleAssignments_List' to 'RoleAssignments_ListForSubscription'. This will impact generated code.
    New: Microsoft.Authorization/preview/2021-04-01-preview/authorization-RoleAssignmentsCalls.json#L38:7
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-RoleAssignmentsCalls.json#L451:7
    1011 - AddingResponseCode The new version adds a response code '200'.
    New: Microsoft.Authorization/preview/2021-04-01-preview/authorization-RoleAssignmentsCalls.json#L258:11
    1011 - AddingResponseCode The new version adds a response code '200'.
    New: Microsoft.Authorization/preview/2021-04-01-preview/authorization-RoleAssignmentsCalls.json#L483:11
    1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.Authorization/preview/2021-04-01-preview/authorization-RoleAssignmentsCalls.json#L648:9
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-RoleAssignmentsCalls.json#L562:9
    1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.Authorization/preview/2021-04-01-preview/authorization-RoleAssignmentsCalls.json#L637:9
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-RoleAssignmentsCalls.json#L610:9
    1034 - AddedRequiredProperty The new version has new required property 'roleDefinitionId, principalId' that was not found in the old version.
    New: Microsoft.Authorization/preview/2021-04-01-preview/authorization-RoleAssignmentsCalls.json#L741:9
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-RoleAssignmentsCalls.json#L594:9
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Authorization/preview/2021-04-01-preview/authorization-RoleAssignmentsCalls.json#L110:13
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-RoleAssignmentsCalls.json#L145:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Authorization/preview/2021-04-01-preview/authorization-RoleAssignmentsCalls.json#L632:11
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-RoleAssignmentsCalls.json#L605:11
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Authorization/preview/2021-04-01-preview/authorization-RoleAssignmentsCalls.json#L741:9
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-RoleAssignmentsCalls.json#L594:9
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Authorization/preview/2021-04-01-preview/authorization-RoleAssignmentsCalls.json#L214:13
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-RoleAssignmentsCalls.json#L301:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Authorization/preview/2021-04-01-preview/authorization-RoleAssignmentsCalls.json#L237:9
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-RoleAssignmentsCalls.json#L243:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Authorization/preview/2021-04-01-preview/authorization-RoleAssignmentsCalls.json#L237:9
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-RoleAssignmentsCalls.json#L636:9
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Authorization/preview/2021-04-01-preview/authorization-RoleAssignmentsCalls.json#L254:13
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-RoleAssignmentsCalls.json#L255:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Authorization/preview/2021-04-01-preview/authorization-RoleAssignmentsCalls.json#L306:13
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-RoleAssignmentsCalls.json#L197:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Authorization/preview/2021-04-01-preview/authorization-RoleAssignmentsCalls.json#L442:13
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-RoleAssignmentsCalls.json#L432:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Authorization/preview/2021-04-01-preview/authorization-RoleAssignmentsCalls.json#L479:13
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-RoleAssignmentsCalls.json#L393:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Authorization/preview/2021-04-01-preview/authorization-RoleAssignmentsCalls.json#L522:13
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-RoleAssignmentsCalls.json#L342:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Authorization/preview/2021-04-01-preview/authorization-RoleAssignmentsCalls.json#L61:13
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-RoleAssignmentsCalls.json#L475:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Authorization/preview/2021-04-01-preview/authorization-RoleAssignmentsCalls.json#L399:13
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-RoleAssignmentsCalls.json#L527:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Authorization/preview/2021-04-01-preview/authorization-RoleAssignmentsCalls.json#L618:5
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-RoleAssignmentsCalls.json#L551:5
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️❌LintDiff: 27 Errors, 9 Warnings failed [Detail] [must fix]The following errors/warnings are introduced by current PR:

    Only 29 items are listed, please refer to log for more details.

    Rule Message Related RPC [For API reviewers]
    R4037 - MissingTypeObject The schema 'AccessReviewScheduleDefinition' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1050
    R4037 - MissingTypeObject The schema 'AccessReviewScheduleDefinitionProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1076
    R4037 - MissingTypeObject The schema 'AccessReviewInstance' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1167
    R4037 - MissingTypeObject The schema 'AccessReviewInstanceProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1193
    R4037 - MissingTypeObject The schema 'AccessReviewScheduleSettings' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1232
    R4037 - MissingTypeObject The schema 'AccessReviewDefaultSettings' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1284
    R4037 - MissingTypeObject The schema 'AccessReviewRecurrenceSettings' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1310
    R4037 - MissingTypeObject The schema 'AccessReviewRecurrencePattern' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1325
    R4037 - MissingTypeObject The schema 'AccessReviewRecurrenceRange' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1347
    R4037 - MissingTypeObject The schema 'AccessReviewScope' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1382
    R4037 - MissingTypeObject The schema 'AccessReviewReviewer' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1429
    R4037 - MissingTypeObject The schema 'AccessReviewDecision' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1451
    R4037 - MissingTypeObject The schema 'AccessReviewDecisionProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1477
    R4037 - MissingTypeObject The schema 'AccessReviewDecisionResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1574
    R4037 - MissingTypeObject The schema 'AccessReviewDecisionIdentity' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1604
    R4037 - MissingTypeObject The schema 'AccessReviewDecisionUserIdentity' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1635
    R4037 - MissingTypeObject The schema 'AccessReviewDecisionServicePrincipalIdentity' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1655
    R4037 - MissingTypeObject The schema 'AccessReviewActorIdentity' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1675
    R4037 - MissingTypeObject The schema 'AccessReviewScheduleDefinitionListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1708
    R4037 - MissingTypeObject The schema 'AccessReviewInstanceListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1724
    R4037 - MissingTypeObject The schema 'AccessReviewDecisionListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1740
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1129
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1136
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1835
    AutoRest exception "location":"specification/authorization/resource-manager/readme.md",
    "tag":"package-preview-2021-04",
    "details":"swagger-document-override/md-override-loader - FAILED"
    AutoRest exception "location":"specification/authorization/resource-manager/readme.md",
    "tag":"package-preview-2021-04",
    "details":"Error: Could not read 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/authorization/resource-manager/Microsoft.Authorization/preview/2021-04-01-preview/EligibleChildResources.json'."
    AutoRest exception "location":"specification/authorization/resource-manager/readme.md",
    "tag":"package-preview-2021-04",
    "details":"swagger-document/loader - FAILED"
    ⚠️ R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: GetAccessReview
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L248
    ⚠️ R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: GetAccessReviews
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L288


    The following errors/warnings exist before current PR submission:

    Rule Message
    ⚠️ R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: GetAccessReviews
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L710
    ⚠️ R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: GetAccessReviews
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L749
    ⚠️ R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: GetAccessReviews
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L795
    ⚠️ R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: GetAccessReview
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L842
    ⚠️ R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: GetAccessReviews
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L886
    ⚠️ R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: GetAccessReviews
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L939
    ⚠️ R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: GetAccessReviews
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L991
    ️❌Avocado: 2 Errors, 1 Warnings failed [Detail]
    Rule Message
    NO_JSON_FILE_FOUND The JSON file is not found but it is referenced from the readme file.
    readme: specification/authorization/resource-manager/readme.md
    json: Microsoft.Authorization/preview/2021-04-01-preview/RoleManagementPolicyAssignment.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag does not contain all APIs in this RP. Please make sure the missing API swaggers are in the default tag.
    readme: specification/authorization/resource-manager/readme.md
    json: Microsoft.Authorization/stable/2015-07-01/authorization-RoleAssignmentsCalls.json
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/authorization/resource-manager/readme.md
    tag: specification/authorization/resource-manager/readme.md#tag-package-2022-04-01
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️❌~[Staging] ServiceAPIReadinessTest: 2 Errors, 0 Warnings failed [Detail]
    Rule Message
    RUNTIME_ERROR "errorCode: AssertionError,
    errorMessage: ResourceType 'accessReviewScheduleDefinitions' should be deployed in 'West Central US' on apiVersion '2021-03-01'.: expected [ Array(20) ] to satisfy [Function]"
    RUNTIME_ERROR "errorCode: AssertionError,
    errorMessage: ResourceType 'accessReviewScheduleDefinitions' should be deployed in 'West Central US' on apiVersion '2021-03-01'.: expected [ Array(20) ] to satisfy [Function]"
    ️❌ModelValidation: 4 Errors, 0 Warnings failed [Detail]
    Rule Message
    DISCRIMINATOR_VALUE_NOT_FOUND Discriminator value "azureRole" not found
    Url: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1574:37
    ExampleUrl: preview/2021-03-01-preview/examples/GetAccessReviewInstanceDecisions.json#L42:25
    DISCRIMINATOR_VALUE_NOT_FOUND Discriminator value "azureRole" not found
    Url: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1574:37
    ExampleUrl: preview/2021-03-01-preview/examples/GetAccessReviewInstanceMyDecisions.json#L41:25
    DISCRIMINATOR_VALUE_NOT_FOUND Discriminator value "azureRole" not found
    Url: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1574:37
    ExampleUrl: preview/2021-03-01-preview/examples/GetAccessReviewInstanceMyDecisionById.json#L40:21
    DISCRIMINATOR_VALUE_NOT_FOUND Discriminator value "azureRole" not found
    Url: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1574:37
    ExampleUrl: preview/2021-03-01-preview/examples/PatchAccessReviewInstanceMyDecisionById.json#L47:21
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️❌PoliCheck: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    Click detail for error messages. Exception contact vsswagger@microsoft.com or https://aka.ms/swaggersupport.
    ️⚠️SDK Track2 Validation: 4 Warnings warning [Detail]
    • The following tags are being changed in this PR
      • "https://github.com/Azure/azure-rest-api-specs/blob/92ea9ee9c18d775bfac46beeb00e89135bc056cc/specification/authorization/resource-manager/readme.md#tag-package-2021-03-01-preview-only">authorization/resource-manager/readme.md#package-2021-03-01-preview-only
      • "https://github.com/Azure/azure-rest-api-specs/blob/92ea9ee9c18d775bfac46beeb00e89135bc056cc/specification/authorization/resource-manager/readme.md#tag-package-preview-2021-04">authorization/resource-manager/readme.md#package-preview-2021-04
      • "https://github.com/Azure/azure-rest-api-specs/blob/92ea9ee9c18d775bfac46beeb00e89135bc056cc/specification/authorization/resource-manager/readme.md#tag-package-2021-04-01-preview-only">authorization/resource-manager/readme.md#package-2021-04-01-preview-only
      • "https://github.com/Azure/azure-rest-api-specs/blob/92ea9ee9c18d775bfac46beeb00e89135bc056cc/specification/authorization/resource-manager/readme.md#tag-package-2021-04-01-preview">authorization/resource-manager/readme.md#package-2021-04-01-preview
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ UnkownSecurityScheme "readme":"authorization/resource-manager/readme.md",
    "tag":"package-2021-04-01-preview-only",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ⚠️ PreCheck/EmptyParentSchemaWarning "readme":"authorization/resource-manager/readme.md",
    "tag":"package-2021-04-01-preview",
    "details":"Schema 'AccessReviewDecisionUserIdentity' has an allOf list with an empty object schema as a parent,
    removing it."
    ⚠️ PreCheck/EmptyParentSchemaWarning "readme":"authorization/resource-manager/readme.md",
    "tag":"package-2021-04-01-preview",
    "details":"Schema 'AccessReviewDecisionServicePrincipalIdentity' has an allOf list with an empty object schema as a parent,
    removing it."
    ⚠️ UnkownSecurityScheme "readme":"authorization/resource-manager/readme.md",
    "tag":"package-2021-04-01-preview",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"


    The following errors/warnings exist before current PR submission:

    Rule Message
    ⚠️ PreCheck/EmptyParentSchemaWarning "readme":"authorization/resource-manager/readme.md",
    "tag":"package-2021-03-01-preview-only",
    "details":"Schema 'AccessReviewDecisionUserIdentity' has an allOf list with an empty object schema as a parent,
    removing it."
    ⚠️ PreCheck/EmptyParentSchemaWarning "readme":"authorization/resource-manager/readme.md",
    "tag":"package-2021-03-01-preview-only",
    "details":"Schema 'AccessReviewDecisionServicePrincipalIdentity' has an allOf list with an empty object schema as a parent,
    removing it."
    ⚠️ UnkownSecurityScheme "readme":"authorization/resource-manager/readme.md",
    "tag":"package-2021-03-01-preview-only",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 4, 2022
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 4, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go-track2 - armauthorization - 0.6.0
    +	Const `AccessReviewHistoryDefinitionStatusDone` has been removed
    +	Const `AccessReviewHistoryDefinitionStatusError` has been removed
    +	Const `AccessReviewHistoryDefinitionStatusInProgress` has been removed
    +	Const `AccessReviewHistoryDefinitionStatusRequested` has been removed
    +	Const `AccessReviewInstanceReviewersTypeAssigned` has been removed
    +	Const `AccessReviewInstanceReviewersTypeManagers` has been removed
    +	Const `AccessReviewInstanceReviewersTypeSelf` has been removed
    +	Const `AccessReviewScopePrincipalTypeRedeemedGuestUser` has been removed
    +	Const `AccessReviewScopePrincipalTypeUserGroup` has been removed
    +	Field `BackupReviewers` of struct `AccessReviewInstanceProperties` has been removed
    +	Field `ExpandNestedMemberships` of struct `AccessReviewScope` has been removed
    +	Field `RecommendationLookBackDuration` of struct `AccessReviewScheduleSettings` has been removed
    +	Field `ReviewersType` of struct `AccessReviewInstanceProperties` has been removed
    +	Field `Reviewers` of struct `AccessReviewInstanceProperties` has been removed
    +	Function `*AccessReviewContactedReviewerProperties.UnmarshalJSON` has been removed
    +	Function `*AccessReviewDecisionResourceAzureRole.GetAccessReviewDecisionResource` has been removed
    +	Function `*AccessReviewDecisionResourceAzureRole.UnmarshalJSON` has been removed
    +	Function `*AccessReviewHistoryDefinitionClient.Create` has been removed
    +	Function `*AccessReviewHistoryDefinitionClient.DeleteByID` has been removed
    +	Function `*AccessReviewHistoryDefinitionInstanceClient.GenerateDownloadURI` has been removed
    +	Function `*AccessReviewHistoryDefinitionInstancesClient.NewListPager` has been removed
    +	Function `*AccessReviewHistoryDefinitionProperties.UnmarshalJSON` has been removed
    +	Function `*AccessReviewHistoryDefinitionsClient.GetByID` has been removed
    +	Function `*AccessReviewHistoryDefinitionsClient.NewListPager` has been removed
    +	Function `*AccessReviewHistoryInstanceProperties.UnmarshalJSON` has been removed
    +	Function `*AccessReviewInstanceContactedReviewersClient.NewListPager` has been removed
    +	Function `*AccessReviewInstancesClient.Create` has been removed
    +	Function `*TenantLevelAccessReviewInstanceContactedReviewersClient.NewListPager` has been removed
    +	Function `AccessReviewContactedReviewerListResult.MarshalJSON` has been removed
    +	Function `AccessReviewContactedReviewerProperties.MarshalJSON` has been removed
    +	Function `AccessReviewDecisionResourceAzureRole.MarshalJSON` has been removed
    +	Function `AccessReviewHistoryDefinitionInstanceListResult.MarshalJSON` has been removed
    +	Function `AccessReviewHistoryDefinitionListResult.MarshalJSON` has been removed
    +	Function `AccessReviewHistoryDefinitionProperties.MarshalJSON` has been removed
    +	Function `AccessReviewHistoryInstanceProperties.MarshalJSON` has been removed
    +	Function `NewAccessReviewHistoryDefinitionClient` has been removed
    +	Function `NewAccessReviewHistoryDefinitionInstanceClient` has been removed
    +	Function `NewAccessReviewHistoryDefinitionInstancesClient` has been removed
    +	Function `NewAccessReviewHistoryDefinitionsClient` has been removed
    +	Function `NewAccessReviewInstanceContactedReviewersClient` has been removed
    +	Function `NewTenantLevelAccessReviewInstanceContactedReviewersClient` has been removed
    +	Function `PossibleAccessReviewHistoryDefinitionStatusValues` has been removed
    +	Function `PossibleAccessReviewInstanceReviewersTypeValues` has been removed
    +	Struct `AccessReviewContactedReviewerListResult` has been removed
    +	Struct `AccessReviewContactedReviewerProperties` has been removed
    +	Struct `AccessReviewContactedReviewer` has been removed
    +	Struct `AccessReviewDecisionResourceAzureRole` has been removed
    +	Struct `AccessReviewHistoryDefinitionClientCreateOptions` has been removed
    +	Struct `AccessReviewHistoryDefinitionClientCreateResponse` has been removed
    +	Struct `AccessReviewHistoryDefinitionClientDeleteByIDOptions` has been removed
    +	Struct `AccessReviewHistoryDefinitionClientDeleteByIDResponse` has been removed
    +	Struct `AccessReviewHistoryDefinitionClient` has been removed
    +	Struct `AccessReviewHistoryDefinitionInstanceClientGenerateDownloadURIOptions` has been removed
    +	Struct `AccessReviewHistoryDefinitionInstanceClientGenerateDownloadURIResponse` has been removed
    +	Struct `AccessReviewHistoryDefinitionInstanceClient` has been removed
    +	Struct `AccessReviewHistoryDefinitionInstanceListResult` has been removed
    +	Struct `AccessReviewHistoryDefinitionInstancesClientListOptions` has been removed
    +	Struct `AccessReviewHistoryDefinitionInstancesClientListResponse` has been removed
    +	Struct `AccessReviewHistoryDefinitionInstancesClient` has been removed
    +	Struct `AccessReviewHistoryDefinitionListResult` has been removed
    +	Struct `AccessReviewHistoryDefinitionProperties` has been removed
    +	Struct `AccessReviewHistoryDefinition` has been removed
    +	Struct `AccessReviewHistoryDefinitionsClientGetByIDOptions` has been removed
    +	Struct `AccessReviewHistoryDefinitionsClientGetByIDResponse` has been removed
    +	Struct `AccessReviewHistoryDefinitionsClientListOptions` has been removed
    +	Struct `AccessReviewHistoryDefinitionsClientListResponse` has been removed
    +	Struct `AccessReviewHistoryDefinitionsClient` has been removed
    +	Struct `AccessReviewHistoryInstanceProperties` has been removed
    +	Struct `AccessReviewHistoryInstance` has been removed
    +	Struct `AccessReviewHistoryScheduleSettings` has been removed
    +	Struct `AccessReviewInstanceContactedReviewersClientListOptions` has been removed
    +	Struct `AccessReviewInstanceContactedReviewersClientListResponse` has been removed
    +	Struct `AccessReviewInstanceContactedReviewersClient` has been removed
    +	Struct `AccessReviewInstancesClientCreateOptions` has been removed
    +	Struct `AccessReviewInstancesClientCreateResponse` has been removed
    +	Struct `TenantLevelAccessReviewInstanceContactedReviewersClientListOptions` has been removed
    +	Struct `TenantLevelAccessReviewInstanceContactedReviewersClientListResponse` has been removed
    +	Struct `TenantLevelAccessReviewInstanceContactedReviewersClient` has been removed
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-authorization - 2.0.0
    ️✔️azure-sdk-for-go - authorization/mgmt/2020-10-01/authorization - v63.4.0
    azure-sdk-for-go - authorization/mgmt/2015-07-01/authorization - v63.4.0
    +	Function `ProviderOperationsMetadataClient.GetPreparer` parameter(s) have been changed from `(context.Context, string, string, string)` to `(context.Context, string, string)`
    +	Function `ProviderOperationsMetadataClient.Get` parameter(s) have been changed from `(context.Context, string, string, string)` to `(context.Context, string, string)`
    +	Function `ProviderOperationsMetadataClient.ListComplete` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
    +	Function `ProviderOperationsMetadataClient.ListPreparer` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
    +	Function `ProviderOperationsMetadataClient.List` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
    ️✔️azure-sdk-for-go - preview/authorization/mgmt/2020-10-01-preview/authorization - v63.4.0
    azure-sdk-for-go - preview/authorization/mgmt/2020-04-01-preview/authorization - v63.4.0
    +	Const `Application` has been removed
    +	Const `DirectoryObjectOrGroup` has been removed
    +	Const `DirectoryRoleTemplate` has been removed
    +	Const `Everyone` has been removed
    +	Const `MSI` has been removed
    +	Const `Unknown` has been removed
    +	Function `Principal.MarshalJSON` has been removed
    azure-sdk-for-go - preview/authorization/mgmt/2018-09-01-preview/authorization - v63.4.0
    +	Const `Application` has been removed
    +	Const `DirectoryObjectOrGroup` has been removed
    +	Const `DirectoryRoleTemplate` has been removed
    +	Const `Everyone` has been removed
    +	Const `MSI` has been removed
    +	Const `Unknown` has been removed
    +	Function `Principal.MarshalJSON` has been removed
    azure-sdk-for-go - preview/authorization/mgmt/2018-07-01-preview/authorization - v63.4.0
    +	Function `Principal.MarshalJSON` has been removed
    ️✔️azure-sdk-for-go - preview/authorization/mgmt/2018-01-01-preview/authorization - v63.4.0
    azure-sdk-for-go - preview/authorization/mgmt/2017-10-01-preview/authorization - v63.4.0
    +	Function `ProviderOperationsMetadataClient.GetPreparer` parameter(s) have been changed from `(context.Context, string, string, string)` to `(context.Context, string, string)`
    +	Function `ProviderOperationsMetadataClient.Get` parameter(s) have been changed from `(context.Context, string, string, string)` to `(context.Context, string, string)`
    +	Function `ProviderOperationsMetadataClient.ListComplete` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
    +	Function `ProviderOperationsMetadataClient.ListPreparer` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
    +	Function `ProviderOperationsMetadataClient.List` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
    azure-sdk-for-go - armauthorization - 2.0.0
    +	Function `*RoleAssignmentsClient.NewListForResourcePager` parameter(s) have been changed from `(string, string, string, string, string, *RoleAssignmentsClientListForResourceOptions)` to `(string, string, string, string, *RoleAssignmentsClientListForResourceOptions)`
    +	Function `*RoleAssignmentsClient.NewListPager` has been removed
    +	Struct `PermissionAutoGenerated` has been removed
    +	Struct `RoleAssignmentPropertiesWithScope` has been removed
    +	Struct `RoleAssignmentsClientListOptions` has been removed
    +	Struct `RoleAssignmentsClientListResponse` has been removed
    +	Type of `RoleAssignment.Properties` has been changed from `*RoleAssignmentPropertiesWithScope` to `*RoleAssignmentProperties`
    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 27cf7d4e1469ee7926a62920fd69e8561fcb75f7. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      warn	File azure-sdk-for-net_tmp/initOutput.json not found to read
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    • ️✔️Azure.ResourceManager.Authorization [View full logs]  [Preview SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from 27cf7d4e1469ee7926a62920fd69e8561fcb75f7. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]  global `--global`, `--local` are deprecated. Use `--location=global` instead.
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.11.0 -> 8.18.0
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.18.0>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.18.0` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-authorization [View full logs]  [Preview SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Added operation AccessReviewInstancesOperations.create
      info	[Changelog]   - Added operation group AccessReviewHistoryDefinitionInstanceOperations
      info	[Changelog]   - Added operation group AccessReviewHistoryDefinitionInstancesOperations
      info	[Changelog]   - Added operation group AccessReviewHistoryDefinitionOperations
      info	[Changelog]   - Added operation group AccessReviewHistoryDefinitionsOperations
      info	[Changelog]   - Added operation group AccessReviewInstanceContactedReviewersOperations
      info	[Changelog]   - Added operation group ScopeAccessReviewDefaultSettingsOperations
      info	[Changelog]   - Added operation group ScopeAccessReviewHistoryDefinitionInstanceOperations
      info	[Changelog]   - Added operation group ScopeAccessReviewHistoryDefinitionInstancesOperations
      info	[Changelog]   - Added operation group ScopeAccessReviewHistoryDefinitionOperations
      info	[Changelog]   - Added operation group ScopeAccessReviewHistoryDefinitionsOperations
      info	[Changelog]   - Added operation group ScopeAccessReviewInstanceContactedReviewersOperations
      info	[Changelog]   - Added operation group ScopeAccessReviewInstanceDecisionsOperations
      info	[Changelog]   - Added operation group ScopeAccessReviewInstanceOperations
      info	[Changelog]   - Added operation group ScopeAccessReviewInstancesOperations
      info	[Changelog]   - Added operation group ScopeAccessReviewScheduleDefinitionsOperations
      info	[Changelog]   - Added operation group TenantLevelAccessReviewInstanceContactedReviewersOperations
      info	[Changelog]   - Model AccessReviewDecision has a new parameter insights
      info	[Changelog]   - Model AccessReviewDecision has a new parameter membership_types
      info	[Changelog]   - Model AccessReviewDecisionProperties has a new parameter insights
      info	[Changelog]   - Model AccessReviewDecisionProperties has a new parameter membership_types
      info	[Changelog]   - Model AccessReviewDefaultSettings has a new parameter recommendation_look_back_duration
      info	[Changelog]   - Model AccessReviewInstance has a new parameter backup_reviewers
      info	[Changelog]   - Model AccessReviewInstance has a new parameter reviewers
      info	[Changelog]   - Model AccessReviewInstance has a new parameter reviewers_type
      info	[Changelog]   - Model AccessReviewScheduleDefinition has a new parameter exclude_resource_id
      info	[Changelog]   - Model AccessReviewScheduleDefinition has a new parameter exclude_role_definition_id
      info	[Changelog]   - Model AccessReviewScheduleDefinition has a new parameter expand_nested_memberships
      info	[Changelog]   - Model AccessReviewScheduleDefinition has a new parameter include_access_below_resource
      info	[Changelog]   - Model AccessReviewScheduleDefinition has a new parameter include_inherited_access
      info	[Changelog]   - Model AccessReviewScheduleDefinition has a new parameter recommendation_look_back_duration
      info	[Changelog]   - Model AccessReviewScheduleDefinitionProperties has a new parameter exclude_resource_id
      info	[Changelog]   - Model AccessReviewScheduleDefinitionProperties has a new parameter exclude_role_definition_id
      info	[Changelog]   - Model AccessReviewScheduleDefinitionProperties has a new parameter expand_nested_memberships
      info	[Changelog]   - Model AccessReviewScheduleDefinitionProperties has a new parameter include_access_below_resource
      info	[Changelog]   - Model AccessReviewScheduleDefinitionProperties has a new parameter include_inherited_access
      info	[Changelog]   - Model AccessReviewScheduleDefinitionProperties has a new parameter recommendation_look_back_duration
      info	[Changelog]   - Model AccessReviewScheduleSettings has a new parameter recommendation_look_back_duration
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 27cf7d4e1469ee7926a62920fd69e8561fcb75f7. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armauthorization [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Function `*RoleAssignmentsClient.NewListForResourcePager` parameter(s) have been changed from `(string, string, string, string, string, *RoleAssignmentsClientListForResourceOptions)` to `(string, string, string, string, *RoleAssignmentsClientListForResourceOptions)`
      info	[Changelog] - Type of `RoleAssignment.Properties` has been changed from `*RoleAssignmentPropertiesWithScope` to `*RoleAssignmentProperties`
      info	[Changelog] - Function `*RoleAssignmentsClient.NewListPager` has been removed
      info	[Changelog] - Struct `PermissionAutoGenerated` has been removed
      info	[Changelog] - Struct `RoleAssignmentPropertiesWithScope` has been removed
      info	[Changelog] - Struct `RoleAssignmentsClientListOptions` has been removed
      info	[Changelog] - Struct `RoleAssignmentsClientListResponse` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New function `*DenyAssignmentsClient.GetByID(context.Context, string, *DenyAssignmentsClientGetByIDOptions) (DenyAssignmentsClientGetByIDResponse, error)`
      info	[Changelog] - New function `*DenyAssignmentsClient.Get(context.Context, string, string, *DenyAssignmentsClientGetOptions) (DenyAssignmentsClientGetResponse, error)`
      info	[Changelog] - New function `*DenyAssignmentsClient.NewListPager(*DenyAssignmentsClientListOptions) *runtime.Pager[DenyAssignmentsClientListResponse]`
      info	[Changelog] - New function `NewDenyAssignmentsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*DenyAssignmentsClient, error)`
      info	[Changelog] - New function `*DenyAssignmentsClient.NewListForScopePager(string, *DenyAssignmentsClientListForScopeOptions) *runtime.Pager[DenyAssignmentsClientListForScopeResponse]`
      info	[Changelog] - New function `*RoleAssignmentsClient.NewListForSubscriptionPager(*RoleAssignmentsClientListForSubscriptionOptions) *runtime.Pager[RoleAssignmentsClientListForSubscriptionResponse]`
      info	[Changelog] - New function `*DenyAssignmentsClient.NewListForResourcePager(string, string, string, string, string, *DenyAssignmentsClientListForResourceOptions) *runtime.Pager[DenyAssignmentsClientListForResourceResponse]`
      info	[Changelog] - New function `*DenyAssignmentsClient.NewListForResourceGroupPager(string, *DenyAssignmentsClientListForResourceGroupOptions) *runtime.Pager[DenyAssignmentsClientListForResourceGroupResponse]`
      info	[Changelog] - New struct `DenyAssignment`
      info	[Changelog] - New struct `DenyAssignmentFilter`
      info	[Changelog] - New struct `DenyAssignmentListResult`
      info	[Changelog] - New struct `DenyAssignmentPermission`
      info	[Changelog] - New struct `DenyAssignmentProperties`
      info	[Changelog] - New struct `DenyAssignmentsClient`
      info	[Changelog] - New struct `DenyAssignmentsClientGetByIDOptions`
      info	[Changelog] - New struct `DenyAssignmentsClientGetByIDResponse`
      info	[Changelog] - New struct `DenyAssignmentsClientGetOptions`
      info	[Changelog] - New struct `DenyAssignmentsClientGetResponse`
      info	[Changelog] - New struct `DenyAssignmentsClientListForResourceGroupOptions`
      info	[Changelog] - New struct `DenyAssignmentsClientListForResourceGroupResponse`
      info	[Changelog] - New struct `DenyAssignmentsClientListForResourceOptions`
      info	[Changelog] - New struct `DenyAssignmentsClientListForResourceResponse`
      info	[Changelog] - New struct `DenyAssignmentsClientListForScopeOptions`
      info	[Changelog] - New struct `DenyAssignmentsClientListForScopeResponse`
      info	[Changelog] - New struct `DenyAssignmentsClientListOptions`
      info	[Changelog] - New struct `DenyAssignmentsClientListResponse`
      info	[Changelog] - New struct `RoleAssignmentsClientListForSubscriptionOptions`
      info	[Changelog] - New struct `RoleAssignmentsClientListForSubscriptionResponse`
      info	[Changelog] - New struct `ValidationResponse`
      info	[Changelog] - New struct `ValidationResponseErrorInfo`
      info	[Changelog] - New field `TenantID` in struct `RoleAssignmentsClientDeleteByIDOptions`
      info	[Changelog] - New field `DataActions` in struct `Permission`
      info	[Changelog] - New field `NotDataActions` in struct `Permission`
      info	[Changelog] - New field `IsDataAction` in struct `ProviderOperation`
      info	[Changelog] - New field `TenantID` in struct `RoleAssignmentsClientGetByIDOptions`
      info	[Changelog] - New field `Description` in struct `RoleAssignmentProperties`
      info	[Changelog] - New field `CreatedBy` in struct `RoleAssignmentProperties`
      info	[Changelog] - New field `CreatedOn` in struct `RoleAssignmentProperties`
      info	[Changelog] - New field `UpdatedOn` in struct `RoleAssignmentProperties`
      info	[Changelog] - New field `Scope` in struct `RoleAssignmentProperties`
      info	[Changelog] - New field `DelegatedManagedIdentityResourceID` in struct `RoleAssignmentProperties`
      info	[Changelog] - New field `UpdatedBy` in struct `RoleAssignmentProperties`
      info	[Changelog] - New field `ConditionVersion` in struct `RoleAssignmentProperties`
      info	[Changelog] - New field `Condition` in struct `RoleAssignmentProperties`
      info	[Changelog] - New field `PrincipalType` in struct `RoleAssignmentProperties`
      info	[Changelog] - New field `TenantID` in struct `RoleAssignmentsClientGetOptions`
      info	[Changelog] - New field `Type` in struct `RoleDefinitionFilter`
      info	[Changelog] - New field `SkipToken` in struct `RoleAssignmentsClientListForScopeOptions`
      info	[Changelog] - New field `TenantID` in struct `RoleAssignmentsClientListForScopeOptions`
      info	[Changelog] - New field `TenantID` in struct `RoleAssignmentsClientDeleteOptions`
      info	[Changelog] - New field `TenantID` in struct `RoleAssignmentsClientListForResourceGroupOptions`
      info	[Changelog] - New field `TenantID` in struct `RoleAssignmentsClientListForResourceOptions`
      info	[Changelog]
      info	[Changelog] Total 11 breaking change(s), 63 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 27cf7d4e1469ee7926a62920fd69e8561fcb75f7. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-authorization [View full logs]  [Preview SDK Changes]
      info	[Changelog]
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️❌ azure-resource-manager-schemas failed [Detail]
    • Failed [Logs] Generate from 27cf7d4e1469ee7926a62920fd69e8561fcb75f7. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • authorization/resource-manager [View full logs]  [Preview Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs] Generate from 27cf7d4e1469ee7926a62920fd69e8561fcb75f7. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.authorization [View full logs]  [Preview SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi, @dagoroz your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    @openapi-workflow-bot
    Copy link

    Hi @dagoroz, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @dagoroz
    Copy link
    Contributor Author

    dagoroz commented May 4, 2022

    Justification for AVOCADO "NOT_LATEST_API_VERSION_IN_DEFAULT_TAG":
    This PR is not publishing a version beyond latest tag, this is backfill to fix S360 items

    Justification for Errors in AccessReviewCalls:
    They fall beyond the scope of this PR. They require intervention of their respective PG.

    Justification for cross version breaking change:
    This backfill is aligned more to the new GA version planed to release by end of May, these changes have been reviewed and approved in this PR to the private repo

    https://github.com/Azure/azure-rest-api-specs-pr/pull/6248

    @dagoroz dagoroz marked this pull request as ready for review May 4, 2022 23:24
    @dagoroz dagoroz requested a review from stankovski as a code owner May 4, 2022 23:24
    @dagoroz dagoroz marked this pull request as draft May 4, 2022 23:24
    @dagoroz dagoroz marked this pull request as ready for review May 4, 2022 23:26
    @dagoroz
    Copy link
    Contributor Author

    dagoroz commented May 10, 2022

    @ruowan gentle ping
    This is to fix some swagger KPIs and I would like to at least start the conversation on it since I have another PR after this 😅

    @dagoroz
    Copy link
    Contributor Author

    dagoroz commented Jun 13, 2022

    @raosuhas thanks for approving.
    is there anything else I need to do for it to get merged?

    @dagoroz
    Copy link
    Contributor Author

    dagoroz commented Jun 23, 2022

    @raosuhas ping

    @ghost
    Copy link

    ghost commented Aug 7, 2022

    Hi, @dagoroz. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost ghost added the no-recent-activity label Aug 7, 2022
    @dagoroz dagoroz force-pushed the daorozco-Microsoft.Authorization-2021-04-01-preview branch from b9596ea to f89a70e Compare August 17, 2022 23:07
    @ghost ghost removed the no-recent-activity label Aug 17, 2022
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 17, 2022

    Generated ApiView

    Language Package Name ApiView Link
    Python track2_azure-mgmt-authorization Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Java azure-resourcemanager-authorization-generated Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    JavaScript @azure/arm-authorization Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    .Net Azure.ResourceManager.Authorization Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

    @openapi-workflow-bot
    Copy link

    Hi @dagoroz, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @dagoroz dagoroz closed this Aug 22, 2022
    gerrytan pushed a commit to gerrytan/azure-rest-api-specs that referenced this pull request Sep 6, 2024
    gerrytan added a commit that referenced this pull request Sep 20, 2024
    …o Terraform HCL (#30455)
    
    * New RP: Microsoft.AzureTerraform (ver=2023-07-01-preview)
    
    * prettier
    
    * remove x-ms-discriminator-value
    
    * readme.md: add `openapi-subtype`
    
    * Fix LintDiff failure
    
    * Result configuration type change from object to string
    
    * Remove properties: `subscriptionId` and `environment`
    
    * Change `errors` from list of string to list of `ErrorResponse`
    
    * Add operations endpoint
    
    * Update
    
    * Update
    
    * AzureTerraform RP: Sync the MS version with the private version
    
    * Terraform: Change `exportEerraform` endpoint to LRO (#18782)
    
    * terraform: Modify the `exportTerraform` RT to be LRO
    
    * Update
    
    * prettier
    
    * spell
    
    * CI validation
    
    * More CI issue fixes
    
    * typo
    
    * Add readme.go.md
    
    * typo
    
    * prettier
    
    * suppression
    
    * Update suppression
    
    * AzureTerrform: Remove the parallelism property (#18909)
    
    * exportTerraform: Change resourceId -> resourceIds; Add `maskSensitive`; Change `fullConfig` defaults (#19178)
    
    * exportTerraform: Change resourceId -> resourceIds; Add `maskSensitive`; Change `fullConfig` defaults
    
    * rename
    
    * rename
    
    * rename
    
    * Specify LRO model (#19401)
    
    * Add up the `resourceId` in `OperationStatus` model (#19450)
    
    * Add `uri` format (#19455)
    
    * Add format url
    
    * update
    
    * TypeSpec for Microsoft.AzureTerraform (#19390)
    
    * TypeSpec for Microsoft.AzureTerraform
    
    * Sorted swagger file, and added typespec generated with tsp-client
    
    * revert export.json in prep of merging
    
    * Sorted export.json for easy diff on future typespec -> swagger
    
    * Rerun swagger -> typespec conversion after merging latest RPSaaSMaster,
    updated namespace
    
    * tsp compile for TypeSpec -> swagger
    
    * Refactored typescript to minimise swagger diff
    
    * Spread ErrorResponse into OperationStatus model
    
    * Fixed enums, use doc decorator
    
    * Update exportTerraform path desc
    
    * Update doc for ExportResource model
    
    * LintDiff fix: remove unnecessary auth
    
    * Add resourceId prop to OperationStatus model, fixed char casing so they're consistent throughout
    
    * Made resourceId read only
    
    * Check `Swagger BreakingChange`: minimise diff on x-ms-enum
    
    * TypeSpec Validation fix: rename dir and add missing @doc
    
    * Upgrade/rp tsp 0.60 (#19551) -- applying only for specification/terraform
    
    * Revert accidental changes to cSpell.json while merging
    
    * Added tf files used for armstrong testing
    
    ---------
    
    Co-authored-by: magodo <wztdyl@sina.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go CI-BreakingChange-Go-V2 CI-FixRequiredOnFailure resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants