Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Network Preview Version 2022-04-01-preview #18911

Merged
merged 8 commits into from
May 23, 2022
Merged

Conversation

yanfa317
Copy link
Contributor

@yanfa317 yanfa317 commented May 4, 2022

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@yanfa317 yanfa317 requested a review from MikhailTryakhov as a code owner May 4, 2022 21:20
@openapi-workflow-bot
Copy link

Hi, @yanfa317 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 4, 2022

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️LintDiff: 12 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ R1003 - ListInOperationName Since operation 'ListActiveConnectivityConfigurations' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Network/preview/2022-04-01-preview/networkManagerActiveConfiguration.json#L67
    ⚠️ R1003 - ListInOperationName Since operation 'ListActiveSecurityAdminRules' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Network/preview/2022-04-01-preview/networkManagerActiveConfiguration.json#L120
    ⚠️ R1003 - ListInOperationName Since operation 'ListActiveSecurityUserRules' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Network/preview/2022-04-01-preview/networkManagerActiveConfiguration.json#L173
    ⚠️ R1003 - ListInOperationName Since operation 'ListNetworkManagerEffectiveConnectivityConfigurations' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Network/preview/2022-04-01-preview/networkManagerEffectiveConfiguration.json#L67
    ⚠️ R1003 - ListInOperationName Since operation 'ListNetworkManagerEffectiveSecurityAdminRules' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Network/preview/2022-04-01-preview/networkManagerEffectiveConfiguration.json#L120
    ⚠️ R1003 - ListInOperationName Since operation 'ListEffectiveVirtualNetworks_ByNetworkGroup' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Network/preview/2022-04-01-preview/networkManagerGroup.json#L245
    ⚠️ R1007 - PatchInOperationName 'PATCH' operation 'NetworkManagers_Patch' should use method name 'Update'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Network/preview/2022-04-01-preview/networkManager.json#L169
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'NetworkManagerDeploymentStatusModel'. Consider using the plural form of 'NetworkManagerDeploymentStatus' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Network/preview/2022-04-01-preview/networkManager.json#L291
    ⚠️ R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'commit' in:'NetworkManagerCommits_Post'. Consider updating the operationId
    Location: Microsoft.Network/preview/2022-04-01-preview/networkManager.json#L222
    ⚠️ R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'listdeploymentstatus' in:'NetworkManagerDeploymentStatus_List'. Consider updating the operationId
    Location: Microsoft.Network/preview/2022-04-01-preview/networkManager.json#L291
    ⚠️ R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'listeffectivevirtualnetworks' in:'EffectiveVirtualNetworks_ListByNetworkManager'. Consider updating the operationId
    Location: Microsoft.Network/preview/2022-04-01-preview/networkManager.json#L423
    ⚠️ R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'listeffectivevirtualnetworks' in:'ListEffectiveVirtualNetworks_ByNetworkGroup'. Consider updating the operationId
    Location: Microsoft.Network/preview/2022-04-01-preview/networkManagerGroup.json#L245


    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    R2026 - AvoidAnonymousTypes Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models.
    Location: Microsoft.Network/preview/2022-04-01-preview/network.json#L301
    R4037 - MissingTypeObject The schema 'ErrorDetails' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-04-01-preview/network.json#L38
    R4037 - MissingTypeObject The schema 'Error' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-04-01-preview/network.json#L55
    R4037 - MissingTypeObject The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-04-01-preview/network.json#L83
    R4037 - MissingTypeObject The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-04-01-preview/network.json#L83
    R4037 - MissingTypeObject The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-04-01-preview/network.json#L83
    R4037 - MissingTypeObject The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-04-01-preview/network.json#L83
    R4037 - MissingTypeObject The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-04-01-preview/network.json#L83
    R4037 - MissingTypeObject The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-04-01-preview/network.json#L83
    R4037 - MissingTypeObject The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-04-01-preview/network.json#L83
    R4037 - MissingTypeObject The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-04-01-preview/network.json#L83
    R4037 - MissingTypeObject The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-04-01-preview/network.json#L83
    R4037 - MissingTypeObject The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-04-01-preview/network.json#L83
    R4037 - MissingTypeObject The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-04-01-preview/network.json#L93
    R4037 - MissingTypeObject The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-04-01-preview/network.json#L93
    R4037 - MissingTypeObject The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-04-01-preview/network.json#L93
    R4037 - MissingTypeObject The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-04-01-preview/network.json#L93
    R4037 - MissingTypeObject The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-04-01-preview/network.json#L93
    R4037 - MissingTypeObject The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-04-01-preview/network.json#L93
    R4037 - MissingTypeObject The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-04-01-preview/network.json#L93
    R4037 - MissingTypeObject The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-04-01-preview/network.json#L93
    R4037 - MissingTypeObject The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-04-01-preview/network.json#L93
    R4037 - MissingTypeObject The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-04-01-preview/network.json#L93
    R4037 - MissingTypeObject The schema 'AzureAsyncOperationResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-04-01-preview/network.json#L118
    R4037 - MissingTypeObject The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-04-01-preview/network.json#L140
    R4037 - MissingTypeObject The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-04-01-preview/network.json#L140
    R4037 - MissingTypeObject The schema 'SubResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-04-01-preview/network.json#L198
    R4037 - MissingTypeObject The schema 'TagsObject' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-04-01-preview/network.json#L208
    R4037 - MissingTypeObject The schema 'ManagedServiceIdentity' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-04-01-preview/network.json#L273
    R4037 - MissingTypeObject The schema 'ExtendedLocation' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/preview/2022-04-01-preview/network.json#L395
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️⚠️Cross-Version Breaking Changes: 22 Warnings warning [Detail]
    The following breaking changes are detected by comparison with latest preview version:
    Rule Message
    ⚠️ 1011 - AddingResponseCode The new version adds a response code '202'.
    New: Microsoft.Network/preview/2022-04-01-preview/networkManager.json#L136:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code '200'.
    New: Microsoft.Network/preview/2022-04-01-preview/networkManager.json#L236:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code '202'.
    New: Microsoft.Network/preview/2022-04-01-preview/networkManagerConnectivityConfiguration.json#L139:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code '202'.
    New: Microsoft.Network/preview/2022-04-01-preview/networkManagerGroup.json#L159:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code '202'.
    New: Microsoft.Network/preview/2022-04-01-preview/networkManagerGroup.json#L394:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code '202'.
    New: Microsoft.Network/preview/2022-04-01-preview/networkManagerSecurityAdminConfiguration.json#L189:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code '202'.
    New: Microsoft.Network/preview/2022-04-01-preview/networkManagerSecurityAdminConfiguration.json#L378:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code '202'.
    New: Microsoft.Network/preview/2022-04-01-preview/networkManagerSecurityAdminConfiguration.json#L579:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code '202'.
    New: Microsoft.Network/preview/2022-04-01-preview/networkManagerSecurityUserConfiguration.json#L189:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code '202'.
    New: Microsoft.Network/preview/2022-04-01-preview/networkManagerSecurityUserConfiguration.json#L378:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code '202'.
    New: Microsoft.Network/preview/2022-04-01-preview/networkManagerSecurityUserConfiguration.json#L579:11
    ⚠️ 1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.Network/preview/2022-04-01-preview/networkManager.json#L121:7
    Old: Microsoft.Network/preview/2022-02-01-preview/networkManager.json#L121:7
    ⚠️ 1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.Network/preview/2022-04-01-preview/networkManager.json#L218:7
    Old: Microsoft.Network/preview/2022-02-01-preview/networkManager.json#L205:7
    ⚠️ 1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.Network/preview/2022-04-01-preview/networkManagerConnectivityConfiguration.json#L124:7
    Old: Microsoft.Network/preview/2022-02-01-preview/networkManagerConnectivityConfiguration.json#L124:7
    ⚠️ 1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.Network/preview/2022-04-01-preview/networkManagerGroup.json#L144:7
    Old: Microsoft.Network/preview/2022-02-01-preview/networkManagerGroup.json#L144:7
    ⚠️ 1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.Network/preview/2022-04-01-preview/networkManagerGroup.json#L384:7
    Old: Microsoft.Network/preview/2022-02-01-preview/networkManagerGroup.json#L371:7
    ⚠️ 1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.Network/preview/2022-04-01-preview/networkManagerSecurityAdminConfiguration.json#L174:7
    Old: Microsoft.Network/preview/2022-02-01-preview/networkManagerSecurityAdminConfiguration.json#L174:7
    ⚠️ 1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.Network/preview/2022-04-01-preview/networkManagerSecurityAdminConfiguration.json#L363:7
    Old: Microsoft.Network/preview/2022-02-01-preview/networkManagerSecurityAdminConfiguration.json#L350:7
    ⚠️ 1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.Network/preview/2022-04-01-preview/networkManagerSecurityAdminConfiguration.json#L564:7
    Old: Microsoft.Network/preview/2022-02-01-preview/networkManagerSecurityAdminConfiguration.json#L538:7
    ⚠️ 1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.Network/preview/2022-04-01-preview/networkManagerSecurityUserConfiguration.json#L174:7
    Old: Microsoft.Network/preview/2022-02-01-preview/networkManagerSecurityUserConfiguration.json#L174:7
    ⚠️ 1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.Network/preview/2022-04-01-preview/networkManagerSecurityUserConfiguration.json#L363:7
    Old: Microsoft.Network/preview/2022-02-01-preview/networkManagerSecurityUserConfiguration.json#L350:7
    ⚠️ 1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.Network/preview/2022-04-01-preview/networkManagerSecurityUserConfiguration.json#L564:7
    Old: Microsoft.Network/preview/2022-02-01-preview/networkManagerSecurityUserConfiguration.json#L538:7
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 4, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go-track2 - armnetwork - 1.0.1
    azure-sdk-for-js - @azure/arm-network - 28.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2021-08-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2021-05-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2021-03-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2021-02-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2020-11-01/network - v64.1.0
    azure-sdk-for-go - network/mgmt/2020-08-01/network - v64.1.0
    +	Field `ExtendedLocation` of struct `VirtualNetworkGatewayPropertiesFormat` has been removed
    +	Field `VirtualNetworkExtendedLocationResourceID` of struct `VirtualNetworkGatewayPropertiesFormat` has been removed
    +	Type of `SubnetPropertiesFormat.PrivateEndpointNetworkPolicies` has been changed from `*string` to `VirtualNetworkPrivateEndpointNetworkPolicies`
    +	Type of `SubnetPropertiesFormat.PrivateLinkServiceNetworkPolicies` has been changed from `*string` to `VirtualNetworkPrivateLinkServiceNetworkPolicies`
    azure-sdk-for-go - network/mgmt/2020-07-01/network - v64.1.0
    +	Field `ExtendedLocation` of struct `VirtualNetworkGatewayPropertiesFormat` has been removed
    +	Field `VirtualNetworkExtendedLocationResourceID` of struct `VirtualNetworkGatewayPropertiesFormat` has been removed
    +	Type of `SubnetPropertiesFormat.PrivateEndpointNetworkPolicies` has been changed from `*string` to `VirtualNetworkPrivateEndpointNetworkPolicies`
    +	Type of `SubnetPropertiesFormat.PrivateLinkServiceNetworkPolicies` has been changed from `*string` to `VirtualNetworkPrivateLinkServiceNetworkPolicies`
    ️✔️azure-sdk-for-go - network/mgmt/2020-06-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2020-05-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2020-04-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2020-03-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-12-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-11-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-09-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-08-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-07-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-06-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-04-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-02-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-12-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-11-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-10-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-08-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-07-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-06-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-04-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-02-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-01-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2017-11-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2017-10-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2015-06-15/network - v64.1.0
    ️✔️azure-sdk-for-go - preview/network/mgmt/2021-03-01-preview/network - v64.1.0
    ️✔️azure-sdk-for-go - preview/network/mgmt/2021-02-01-preview/network - v64.1.0
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-network - 20.0.0
    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from d916ae1. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.5.5 -> 8.10.0
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.10.0>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.10.0` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-network [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model ApplicationGatewayRoutingRule has a new parameter priority
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from d916ae1. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
      cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
      cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
      cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
      cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
      cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
    • ️✔️azure-resourcemanager-network-generated [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from d916ae1. SDK Automation 14.0.0
      command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️network/mgmt/2021-08-01/network [View full logs]  [Release SDK Changes]
      Only show 4 items here, please refer to log for details.
      info	[Changelog]
      info	[Changelog] - New field `Priority` in struct `ApplicationGatewayRoutingRulePropertiesFormat`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 1 additive change(s).
    • ️✔️network/mgmt/2021-05-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2021-03-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2021-02-01/network [View full logs
      Only show 4 items here, please refer to log for details.
      info	[Changelog] - New field `ResolvedPrivateLinkServiceLocation` in struct `PrivateLinkServiceConnectionProperties`
      info	[Changelog] - New field `ResourceGUID` in struct `PrivateEndpointProperties`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 6 additive change(s).
    • ️✔️network/mgmt/2020-11-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2020-08-01/network [View full logs
      Only show 4 items here, please refer to log for details.
      info	[Changelog] - New field `ResourceGUID` in struct `VirtualNetworkPeeringPropertiesFormat`
      info	[Changelog] - New field `ApplicationGatewayIPConfigurations` in struct `SubnetPropertiesFormat`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 35 additive change(s).
    • ️✔️network/mgmt/2020-07-01/network [View full logs
      Only show 4 items here, please refer to log for details.
      info	[Changelog] - New field `PrivateLinkService` in struct `InterfacePropertiesFormat`
      info	[Changelog] - New field `Type` in struct `InterfaceIPConfiguration`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 27 additive change(s).
    • ️✔️network/mgmt/2020-06-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2020-05-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2020-04-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2020-03-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-12-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-11-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-09-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-08-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-07-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-06-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-04-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-02-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-12-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-11-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-10-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-08-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-07-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-06-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-04-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-02-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-01-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2017-11-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2017-10-01/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2015-06-15/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/network/mgmt/2021-03-01-preview/network [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/network/mgmt/2021-02-01-preview/network [View full logs
      info	[Changelog] This is a new package
      info	[Changelog]
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from d916ae1. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armnetwork [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New field `Priority` in struct `ApplicationGatewayRoutingRulePropertiesFormat`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 1 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from d916ae1. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      cmderr	[automation_init.sh]  deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
      cmderr	[automation_init.sh]  uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
      cmderr	[automation_init.sh] npm WARN deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
      cmderr	[automation_init.sh] WARN deprecated @azure/storage-blob@10.5.0: This version has been deprecated, please upgrade to the version tagged as latest
      cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-network [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Type Alias ApplicationGatewayRoutingRule has a new parameter priority
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from d916ae1. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
      warn	Skip detect changed packages
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from d916ae1. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.network [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @yanfa317, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @jago2136
    Copy link
    Contributor

    jago2136 commented May 4, 2022

    LGTM

    @zizw123
    Copy link

    zizw123 commented May 4, 2022

    Please make sure you check the right check boxes for the review to take place. thanks.

    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 4, 2022
    @openapi-workflow-bot
    Copy link

    Hi, @yanfa317 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    @yanfa317
    Copy link
    Contributor Author

    yanfa317 commented May 4, 2022

    Please make sure you check the right check boxes for the review to take place. thanks.

    Thanks for quick reply, I have updated all checked boxes. THanks!

    @zizw123
    Copy link

    zizw123 commented May 5, 2022

    Please make sure you check the right check boxes for the review to take place. thanks.

    Thanks for quick reply, I have updated all checked boxes. THanks!

    Please also check all the errors and let us know when it's ready to be reviewed. Thanks.

    Copy link
    Member

    @rkmanda rkmanda left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    🕐

    @rkmanda rkmanda added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label May 14, 2022
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 14, 2022
    @rkmanda rkmanda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label May 17, 2022
    @openapi-workflow-bot openapi-workflow-bot bot removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label May 17, 2022
    Copy link
    Member

    @rkmanda rkmanda left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    :shipit:

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review Network
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    7 participants