-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2022-04-01 #19082
Conversation
Hi, @asmaskar Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
Rule | Message |
---|---|
R3021 - PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/certificates/{certificateName}' Location: Microsoft.RecoveryServices/stable/2022-04-01/registeredidentities.json#L21 |
R3021 - PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/registeredIdentities/{identityName}' Location: Microsoft.RecoveryServices/stable/2022-04-01/registeredidentities.json#L80 |
R3021 - PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/replicationUsages' Location: Microsoft.RecoveryServices/stable/2022-04-01/replicationusages.json#L21 |
R3021 - PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/usages' Location: Microsoft.RecoveryServices/stable/2022-04-01/vaultusages.json#L21 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/stable/2022-04-01/registeredidentities.json#L64 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/stable/2022-04-01/registeredidentities.json#L108 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/stable/2022-04-01/replicationusages.json#L45 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/stable/2022-04-01/vaultusages.json#L45 |
R4011 - DeleteOperationResponses |
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.RecoveryServices/stable/2022-03-01/vaults.json#L459 |
R4011 - DeleteOperationResponses |
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.RecoveryServices/stable/2022-04-01/registeredidentities.json#L108 |
R4011 - DeleteOperationResponses |
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.RecoveryServices/stable/2022-04-01/vaults.json#L459 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Microsoft.RecoveryServices/stable/2022-04-01/replicationusages.json#L70 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Microsoft.RecoveryServices/stable/2022-04-01/replicationusages.json#L74 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Microsoft.RecoveryServices/stable/2022-04-01/replicationusages.json#L78 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Microsoft.RecoveryServices/stable/2022-04-01/replicationusages.json#L88 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Microsoft.RecoveryServices/stable/2022-04-01/replicationusages.json#L92 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Microsoft.RecoveryServices/stable/2022-04-01/replicationusages.json#L96 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Microsoft.RecoveryServices/stable/2022-04-01/replicationusages.json#L100 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Microsoft.RecoveryServices/stable/2022-04-01/replicationusages.json#L104 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Microsoft.RecoveryServices/stable/2022-04-01/replicationusages.json#L108 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Microsoft.RecoveryServices/stable/2022-04-01/replicationusages.json#L126 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Microsoft.RecoveryServices/stable/2022-04-01/replicationusages.json#L130 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Microsoft.RecoveryServices/stable/2022-04-01/replicationusages.json#L134 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Microsoft.RecoveryServices/stable/2022-04-01/replicationusages.json#L138 |
R4018 - OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.RecoveryServices/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.RecoveryServices/stable/2022-03-01/vaults.json#L231 |
R4018 - OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.RecoveryServices/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.RecoveryServices/stable/2022-04-01/vaults.json#L231 |
R4036 - ImplementPrivateEndpointAPIs |
The private endpoint API: /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/privateEndpointConnections/{privateEndpointConnectionName} is missing. Location: Microsoft.RecoveryServices/stable/2022-04-01/vaultusages.json#L20 |
R4036 - ImplementPrivateEndpointAPIs |
The private endpoint API: /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/privateEndpointConnections is missing. Location: Microsoft.RecoveryServices/stable/2022-04-01/vaultusages.json#L20 |
R4037 - MissingTypeObject |
The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.RecoveryServices/stable/2022-03-01/vaults.json#L1758 |
R4037 - MissingTypeObject |
The schema 'Error' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.RecoveryServices/stable/2022-03-01/vaults.json#L1768 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️
Cross-Version Breaking Changes: 3 Warnings warning [Detail]
- Compared Swaggers (Based on Oad v0.9.5)
- current:stable/2022-04-01/registeredidentities.json compared with base:stable/2022-03-01/registeredidentities.json
- current:stable/2022-04-01/registeredidentities.json compared with base:preview/2022-01-31-preview/registeredidentities.json
- current:stable/2022-04-01/replicationusages.json compared with base:stable/2022-03-01/replicationusages.json
- current:stable/2022-04-01/replicationusages.json compared with base:preview/2022-01-31-preview/replicationusages.json
- current:stable/2022-04-01/vaults.json compared with base:stable/2022-03-01/vaults.json
- current:stable/2022-04-01/vaults.json compared with base:preview/2022-01-31-preview/vaults.json
- current:stable/2022-04-01/vaultusages.json compared with base:stable/2022-03-01/vaultusages.json
- current:stable/2022-04-01/vaultusages.json compared with base:preview/2022-01-31-preview/vaultusages.json
Rule | Message |
---|---|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{location}/capabilities' removed or restructured? Old: Microsoft.RecoveryServices/preview/2022-01-31-preview/vaults.json#L187:5 |
|
The new version is missing a definition that was found in the old version. Was 'ResourceCapabilities' removed or renamed? New: Microsoft.RecoveryServices/stable/2022-04-01/vaults.json#L817:3 Old: Microsoft.RecoveryServices/preview/2022-01-31-preview/vaults.json#L869:3 |
|
The new version is missing a definition that was found in the old version. Was 'CapabilitiesProperties' removed or renamed? New: Microsoft.RecoveryServices/stable/2022-04-01/vaults.json#L817:3 Old: Microsoft.RecoveryServices/preview/2022-01-31-preview/vaults.json#L869:3 |
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
Hi @asmaskar, Your PR has some issues. Please fix the CI sequentially by following the order of
|
@asmaskar, please fix all the require tool check errors. Thanks. |
@lirenhe i have fixed the errors |
Please work with ARM team to get this PR reviewed. Thanks |
@asmaskar - Please fully fill out the submission form: this is required for proper automation and routing of your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
…soft.RecoveryServices to add version stable/2022-04-01 (#2414) Create to sync Azure/azure-rest-api-specs#19082 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...azure-sdk:sdkAuto/recoveryservices?expand=1)
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.