[ApplicationInsights] Fix namespace and output folder for .NET #19119

HarveyLink · 2022-05-18T06:55:56Z

Correct the namespace and output folder for .NET.
NOTE: This could be a breaking change.

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

Correct the namespace and output folder for .NET. NOTE: This could be a breaking change.

openapi-workflow-bot · 2022-05-18T06:55:59Z

Hi, @HarveyLink Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2022-05-18T06:56:00Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

Linted configuring files (Based on source branch, openapi-validator v1.13.0 , classic-openapi-validator v1.2.4 )
- applicationinsights/resource-manager/readme.md tag:default
Linted configuring files (Based on target branch, openapi-validator v1.13.0 , classic-openapi-validator v1.2.4 )
- applicationinsights/resource-manager/readme.md tag:default

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/applicationinsights/resource-manager/readme.md tag: specification/applicationinsights/resource-manager/readme.md#tag-package-2022-02-01

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-05-18T06:56:01Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

️✔️azure-sdk-for-go-track2 - armapplicationinsights - 0.5.1
️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-applicationinsights - 3.0.0
❌azure-sdk-for-go - appinsights/mgmt/2020-02-02/insights - v64.1.0

+	Const `ItemTypeFolder` has been removed

❌azure-sdk-for-go - appinsights/mgmt/2015-05-01/insights - v64.1.0

+	Const `Folder` has been removed

️✔️azure-sdk-for-go - preview/appinsights/mgmt/2022-02-01-preview/insights - v64.1.0
❌azure-sdk-for-go - preview/appinsights/mgmt/2022-01-11-preview/insights - v64.1.0

+	Function `WorkbooksClient.GetPreparer` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string, string, *bool)`
+	Function `WorkbooksClient.Get` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string, string, *bool)`

❌azure-sdk-for-go - preview/appinsights/mgmt/2021-11-01-preview/insights - v64.1.0

+	Const `ItemTypeFolder` has been removed
+	Function `WorkbooksClient.GetPreparer` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string, string, *bool)`
+	Function `WorkbooksClient.Get` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string, string, *bool)`

️❌ azure-sdk-for-net failed [Detail]

❌Failed [Logs]Release - Generate from 3552ecb. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/applicationinsights/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] No usable version of the libssl was found
cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
warn	Skip package processing as generation is failed

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 3552ecb. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]  config global `--global`, `--local` are deprecated. Use `--location=global` instead.

️✔️track2_azure-mgmt-applicationinsights [View full logs] [Release SDK Changes]
- azure_mgmt_applicationinsights-3.1.0-py3-none-any.whl
- azure-mgmt-applicationinsights-3.1.0.zip
```
info	[Changelog]
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 3552ecb. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.

️✔️azure-resourcemanager-applicationinsights [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 3552ecb. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️armapplicationinsights [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `*WorkbookTemplatesClient.Update` parameter(s) have been changed from `(context.Context, string, string, *WorkbookTemplatesClientUpdateOptions)` to `(context.Context, string, string, WorkbookTemplateUpdateParameters, *WorkbookTemplatesClientUpdateOptions)`
info	[Changelog] - Function `*WorkbooksClient.Update` parameter(s) have been changed from `(context.Context, string, string, *WorkbooksClientUpdateOptions)` to `(context.Context, string, string, WorkbookUpdateParameters, *WorkbooksClientUpdateOptions)`
info	[Changelog] - Field `WorkbookTemplateUpdateParameters` of struct `WorkbookTemplatesClientUpdateOptions` has been removed
info	[Changelog] - Field `WorkbookUpdateParameters` of struct `WorkbooksClientUpdateOptions` has been removed
info	[Changelog]
info	[Changelog] Total 4 breaking change(s), 0 additive change(s).

️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 14f1c4b56bf83b02286de2a395d4c700c8ff0e74. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️armapplicationinsights [View full logs] [Preview SDK Changes]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs]Release - Generate from 3552ecb. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh] WARN deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh]  uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh] npm WARN deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh]  deprecated @azure/storage-blob@10.5.0: This version has been deprecated, please upgrade to the version tagged as latest
cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-appinsights [View full logs] [Release SDK Changes]
- azure-arm-appinsights-5.0.0-beta.5.tgz
```
info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
```

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 3552ecb. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation

️✔️applicationinsights [View full logs]

️️✔️ azure-powershell succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 3552ecb. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

️✔️Az.ApplicationInsights [View full logs] [Release SDK Changes]
- Az.ApplicationInsights.0.1.0.nupkg

_{Posted by Swagger Pipeline | How to fix these errors?}

HarveyLink · 2022-05-18T06:57:51Z

In order to fix Azure/azure-sdk-for-net#28733, we have to release a new version of Microsoft.Azure.Management.ApplicationInsights , need to fix the readme first.

[ApplicationInsights] Fix namespace and output folder for .NET

4e77811

Correct the namespace and output folder for .NET. NOTE: This could be a breaking change.

openapi-assignment-bot bot assigned akning-ms May 18, 2022

HarveyLink requested review from ArthurMa1978, m-nash, fengzhou-msft and ArcturusZhang May 18, 2022 07:03

HarveyLink requested review from Yao725 and archerzz May 18, 2022 07:13

akning-ms assigned ArcturusZhang and unassigned akning-ms May 25, 2022

ArcturusZhang approved these changes May 26, 2022

View reviewed changes

HarveyLink mentioned this pull request May 26, 2022

[BUG] [Fix mentioned] [Easy fix] "ApplicationInsightsManagementClient.Workbooks" methods throw "InvalidApiVersionParameter" Azure/azure-sdk-for-net#28733

Closed

ArcturusZhang merged commit 3552ecb into main Jun 22, 2022

ArcturusZhang deleted the HarveyLink-patch-1 branch June 22, 2022 02:32

azure-sdk mentioned this pull request Jun 22, 2022

[ReleasePR armapplicationinsights] Workbooks correctness Azure/azure-sdk-for-go#18253

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Jun 22, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ApplicationInsights] Fix namespace and output folder for .NET #19119

[ApplicationInsights] Fix namespace and output folder for .NET #19119

HarveyLink commented May 18, 2022

openapi-workflow-bot bot commented May 18, 2022

openapi-pipeline-app bot commented May 18, 2022 •

edited

Loading

openapi-pipeline-app bot commented May 18, 2022 •

edited

Loading

Breaking Changes Tracking

HarveyLink commented May 18, 2022

[ApplicationInsights] Fix namespace and output folder for .NET #19119

[ApplicationInsights] Fix namespace and output folder for .NET #19119

Conversation

HarveyLink commented May 18, 2022

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented May 18, 2022

openapi-pipeline-app bot commented May 18, 2022 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented May 18, 2022 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

HarveyLink commented May 18, 2022

openapi-pipeline-app bot commented May 18, 2022 •

edited

Loading

openapi-pipeline-app bot commented May 18, 2022 •

edited

Loading