Add PRLabels to CODEOWNERS #19123

liurunliang · 2022-05-18T12:09:39Z

Init - Add PRLabel to CODEOWNERS

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

Init - Add PRLabel to CODEOWNERS

mikekistler

Looks good! 👍

I added a few entries. If this is what we need to get labels onto PRs, let's not wait for a complete list. Let's get started with what we have and then fill in later where needed.

CODEOWNERS

mikekistler · 2022-05-19T12:51:49Z

I also have a question on this: is it possible to add an entry to CODEOWNERS that associates a label with a particular directory but NOT a code owner? I think that would be useful.

liurunliang · 2022-05-20T02:37:54Z

Hi @mikekistler , I have tried it with CreateRuleFabricBot. The bot ignores the entry without code owner.

weidongxu-microsoft

Nice work!

Does our bot supports it (or it is a Github Action)?

liurunliang · 2022-05-20T03:00:58Z

Hi @weidongxu-microsoft, Yes, Fabric Bot supports it.

weshaggard · 2022-05-20T20:49:57Z

@liurunliang this is step one of configuring the data then someone has to run the tool to generate the fabricbot config from this information. Is that something you plan to do separately? Perhaps we can do it in the same PR?

jsquire

The general format looks good. Wes' comment above is an important one. This forms the basis that the rules can be generated from, but tooling will need to be run to extract the rules and merge them into the bot configuration in the repository.

tomkerkhove

Thanks a ton!

tomkerkhove · 2022-05-23T08:38:29Z

Relates to Azure/azure-sdk-tools#2743

Co-authored-by: Mike Kistler <mikekistler@microsoft.com>

openapi-pipeline-app · 2022-05-24T08:43:36Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-05-24T08:43:37Z

Swagger pipeline restarted successfully, please wait for status update in this comment.

ruowan · 2022-05-24T08:44:36Z

/azp run

azure-pipelines · 2022-05-24T08:44:44Z

Azure Pipelines successfully started running 1 pipeline(s).

Co-authored-by: Mike Kistler <mikekistler@microsoft.com>

openapi-workflow-bot · 2022-05-24T08:51:17Z

Hi @liurunliang, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

weshaggard · 2022-05-24T20:25:19Z

CODEOWNERS

 /specification/alertsmanagement/ @ofirmanor @olalavi @erangon @orieldar @ilaizi @shakednai1 @khaboasb @orenhor
+
+# PRLabel: %API Management
 /specification/apimanagement/ @promoisha @solankisamir


@ruowan @akning-ms unrelated to this PR but there are a lot of invalid users in this code owners file that we should figure out how to get fixed. Can you guys please file a clean-up item for tracking this issue.

We create a issue to track cleanup code owner files. Azure/azure-sdk-tools#3374

* Add PRLabels to CODEOWNERS Init - Add PRLabel to CODEOWNERS * Update CODEOWNERS Co-authored-by: Mike Kistler <mikekistler@microsoft.com> * Update CODEOWNERS Co-authored-by: Mike Kistler <mikekistler@microsoft.com> * Add fabricbot.json Co-authored-by: Ruoxuan Wang <52271048+ruowan@users.noreply.github.com> Co-authored-by: Mike Kistler <mikekistler@microsoft.com>

Add PRLabels to CODEOWNERS

ea6e321

Init - Add PRLabel to CODEOWNERS

mikekistler approved these changes May 19, 2022

View reviewed changes

CODEOWNERS Show resolved Hide resolved

CODEOWNERS Show resolved Hide resolved

mikekistler reviewed May 19, 2022

View reviewed changes

CODEOWNERS Show resolved Hide resolved

mikekistler requested a review from weshaggard May 19, 2022 12:49

mikekistler requested a review from weidongxu-microsoft May 19, 2022 12:53

weidongxu-microsoft approved these changes May 20, 2022

View reviewed changes

weshaggard requested a review from jsquire May 20, 2022 20:50

jsquire approved these changes May 21, 2022

View reviewed changes

tomkerkhove approved these changes May 23, 2022

View reviewed changes

Update CODEOWNERS

e3bc953

Co-authored-by: Mike Kistler <mikekistler@microsoft.com>

Update CODEOWNERS

86b4d51

Co-authored-by: Mike Kistler <mikekistler@microsoft.com>

openapi-pipeline-app bot added the BreakingChangeReviewRequired label May 24, 2022

Add fabricbot.json

f1dfc8b

ruowan added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label May 24, 2022

ruowan marked this pull request as ready for review May 24, 2022 09:28

openapi-assignment-bot bot assigned akning-ms May 24, 2022

openapi-pipeline-app bot removed the BreakingChangeReviewRequired label May 24, 2022

ruowan approved these changes May 24, 2022

View reviewed changes

weshaggard reviewed May 24, 2022

View reviewed changes

ruowan merged commit 236c7ce into Azure:main May 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add PRLabels to CODEOWNERS #19123

Add PRLabels to CODEOWNERS #19123

liurunliang commented May 18, 2022 •

edited

Loading

mikekistler left a comment

mikekistler commented May 19, 2022

liurunliang commented May 20, 2022 •

edited

Loading

weidongxu-microsoft left a comment •

edited

Loading

liurunliang commented May 20, 2022

weshaggard commented May 20, 2022 •

edited

Loading

jsquire left a comment •

edited

Loading

tomkerkhove left a comment

tomkerkhove commented May 23, 2022

openapi-pipeline-app bot commented May 24, 2022 •

edited

Loading

openapi-pipeline-app bot commented May 24, 2022 •

edited

Loading

ruowan commented May 24, 2022

azure-pipelines bot commented May 24, 2022

openapi-workflow-bot bot commented May 24, 2022

weshaggard May 24, 2022

ruowan May 25, 2022

Add PRLabels to CODEOWNERS #19123

Add PRLabels to CODEOWNERS #19123

Conversation

liurunliang commented May 18, 2022 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

mikekistler left a comment

Choose a reason for hiding this comment

mikekistler commented May 19, 2022

liurunliang commented May 20, 2022 • edited Loading

weidongxu-microsoft left a comment • edited Loading

Choose a reason for hiding this comment

liurunliang commented May 20, 2022

weshaggard commented May 20, 2022 • edited Loading

jsquire left a comment • edited Loading

Choose a reason for hiding this comment

tomkerkhove left a comment

Choose a reason for hiding this comment

tomkerkhove commented May 23, 2022

openapi-pipeline-app bot commented May 24, 2022 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented May 24, 2022 • edited Loading

ruowan commented May 24, 2022

azure-pipelines bot commented May 24, 2022

openapi-workflow-bot bot commented May 24, 2022

weshaggard May 24, 2022

Choose a reason for hiding this comment

ruowan May 25, 2022

Choose a reason for hiding this comment

liurunliang commented May 18, 2022 •

edited

Loading

liurunliang commented May 20, 2022 •

edited

Loading

weidongxu-microsoft left a comment •

edited

Loading

weshaggard commented May 20, 2022 •

edited

Loading

jsquire left a comment •

edited

Loading

openapi-pipeline-app bot commented May 24, 2022 •

edited

Loading

openapi-pipeline-app bot commented May 24, 2022 •

edited

Loading