-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.CostManagement to add version stable/2022-05-01 #19143
[Hub Generated] Review request for Microsoft.CostManagement to add version stable/2022-05-01 #19143
Conversation
Hi, @absyed Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
compared swaggers (via Oad v0.9.6)] | new version | base version |
---|---|---|
common-types.json | 2022-05-01(9c3ff8c) | 2021-10-01(main) |
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 2 Warnings warning [Detail]
compared tags (via openapi-validator v1.13.0) | new version | base version |
---|---|---|
package-2022-05 | package-2022-05(9c3ff8c) | default(main) |
The following errors/warnings are introduced by current PR:
Rule | Message |
---|---|
OperationId should contain the verb: 'generatecostdetailsreport' in:'GenerateCostDetailsReport_CreateOperation'. Consider updating the operationId Location: Microsoft.CostManagement/stable/2022-05-01/costmanagement.generatecostdetailsreport.json#L41 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: compressData Location: Microsoft.CostManagement/stable/2022-05-01/costmanagement.generatecostdetailsreport.json#L341 |
️⚠️
Avocado: 1 Warnings warning [Detail]
Rule | Message |
---|---|
The default tag contains multiple API versions swaggers. readme: specification/cost-management/resource-manager/readme.md tag: specification/cost-management/resource-manager/readme.md#tag-package-2022-05 |
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️⚠️
SDK Track2 Validation: 5 Warnings warning [Detail]
- The following tags are being changed in this PR
- "https://github.com/Azure/azure-rest-api-specs/blob/9c3ff8c573bcf12edcc18854a7aaff6246ad802f/specification/cost-management/resource-manager/readme.md#tag-package-2022-05">cost-management/resource-manager/readme.md#package-2022-05
Rule | Message |
---|---|
"readme":"cost-management/resource-manager/readme.md", "tag":"package-2022-05", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous" |
|
"readme":"cost-management/resource-manager/readme.md", "tag":"package-2022-05", "details":"The schema 'AlertProperties-details-resourceGroupFilterItem' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#/components/schemas/AlertProperties-details-resourceGroupFilterItem" |
|
"readme":"cost-management/resource-manager/readme.md", "tag":"package-2022-05", "details":"The schema 'AlertProperties-details-resourceFilterItem' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#/components/schemas/AlertProperties-details-resourceFilterItem" |
|
"readme":"cost-management/resource-manager/readme.md", "tag":"package-2022-05", "details":"The schema 'AlertProperties-details-meterFilterItem' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#/components/schemas/AlertProperties-details-meterFilterItem" |
|
"readme":"cost-management/resource-manager/readme.md", "tag":"package-2022-05", "details":"The schema 'QueryProperties-rows-itemsItem' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#/components/schemas/QueryProperties-rows-itemsItem" |
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
Swagger Generation Artifacts
|
Hi @absyed, Your PR has some issues. Please fix the CI sequentially by following the order of
|
Hi, @absyed your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
@absyed please fix the azure-resource-manager-schemas error, referring to this log: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1638250&view=logs&j=2b4a2910-f027-53b2-4397-cc9d62dced0f&t=8239b243-d1b9-5f8b-bfeb-b8cea9964242&l=326 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix the azure-resource-manager-schemas error, referring to this log: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1638250&view=logs&j=2b4a2910-f027-53b2-4397-cc9d62dced0f&t=8239b243-d1b9-5f8b-bfeb-b8cea9964242&l=326
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Pull request contains merge conflicts. |
/azp run |
Pull request contains merge conflicts. |
…agement-2022-05-01
Swagger Generation Artifacts
|
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.