[Hub Generated] Review request for Microsoft.Insights to add version stable/2022-06-15 #19148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @grlima Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| compared swaggers (via Oad v0.9.6)] | new version | base version |
|---|---|---|
| webTests_API.json | 2022-06-15(4761198) | 2015-05-01(main) |
| webTests_API.json | 2022-06-15(4761198) | 2020-10-05(main) |
The following breaking changes are detected by comparison with the latest preview version:
| Rule | Message |
|---|---|
| The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.Insights/operations' removed or restructured? Old: Microsoft.Insights/preview/2020-10-05-preview/webTests_API.json#L37:5 |
|
| The new version is removing enum value(s) 'basic' from the old version. New: Microsoft.Insights/stable/2022-06-15/webTests_API.json#L423:9 Old: Microsoft.Insights/preview/2020-10-05-preview/webTests_API.json#L463:9 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
| compared tags (via openapi-validator v1.13.0) | new version | base version |
|---|---|---|
| package-2022-06-15 | package-2022-06-15(4761198) | default(main) |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/applicationinsights/resource-manager/readme.md tag: specification/applicationinsights/resource-manager/readme.md#tag-package-2022-06-15 |
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️⚠️SDK Track2 Validation: 67 Warnings warning [Detail]
- The following tags are being changed in this PR
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
| "readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2022-06-15", "details":"Using directive.0.suppress which is deprecated and will be removed in the future." |
|
| "readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2022-06-15", "details":"Using directive.1.suppress which is deprecated and will be removed in the future." |
|
| "readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2022-06-15", "details":"Using directive.2.suppress which is deprecated and will be removed in the future." |
|
| "readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2022-06-15", "details":"Using directive.3.suppress which is deprecated and will be removed in the future." |
|
| "readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2022-06-15", "details":"Using directive.4.suppress which is deprecated and will be removed in the future." |
|
| "readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2022-06-15", "details":"Using directive.5.suppress which is deprecated and will be removed in the future." |
|
| "readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2022-06-15", "details":"Using directive.6.suppress which is deprecated and will be removed in the future." |
|
| "readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2022-06-15", "details":"Using directive.7.suppress which is deprecated and will be removed in the future." |
|
| "readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2022-06-15", "details":"Using directive.8.suppress which is deprecated and will be removed in the future." |
|
| "readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2022-06-15", "details":"Using directive.9.suppress which is deprecated and will be removed in the future." |
|
| "readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2022-06-15", "details":"Using directive.10.suppress which is deprecated and will be removed in the future." |
|
| "readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2022-06-15", "details":"Using directive.11.suppress which is deprecated and will be removed in the future." |
|
| "readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2022-06-15", "details":"Using directive.12.suppress which is deprecated and will be removed in the future." |
|
| "readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2022-06-15", "details":"Using directive.13.suppress which is deprecated and will be removed in the future." |
|
| "readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2022-06-15", "details":"Using directive.14.suppress which is deprecated and will be removed in the future." |
|
| "readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2022-06-15", "details":"Using directive.15.suppress which is deprecated and will be removed in the future." |
|
| "readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2022-06-15", "details":"Using directive.16.suppress which is deprecated and will be removed in the future." |
|
| "readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2022-06-15", "details":"Using directive.17.suppress which is deprecated and will be removed in the future." |
|
| "readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2022-06-15", "details":"Using directive.18.suppress which is deprecated and will be removed in the future." |
|
| "readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2022-06-15", "details":"Using directive.19.suppress which is deprecated and will be removed in the future." |
|
| "readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2022-06-15", "details":"Using directive.20.suppress which is deprecated and will be removed in the future." |
|
| "readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2022-06-15", "details":"Using directive.21.suppress which is deprecated and will be removed in the future." |
|
| "readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2022-06-15", "details":"Using directive.22.suppress which is deprecated and will be removed in the future." |
|
| "readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2022-06-15", "details":"Using directive.23.suppress which is deprecated and will be removed in the future." |
|
| "readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2022-06-15", "details":"Using directive.24.suppress which is deprecated and will be removed in the future." |
|
| "readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2022-06-15", "details":"Using directive.25.suppress which is deprecated and will be removed in the future." |
|
| "readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2022-06-15", "details":"Using directive.26.suppress which is deprecated and will be removed in the future." |
|
| "readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2022-06-15", "details":"Using directive.27.suppress which is deprecated and will be removed in the future." |
|
| "readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2022-06-15", "details":"Using directive.28.suppress which is deprecated and will be removed in the future." |
|
| "readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2022-06-15", "details":"Using directive.29.suppress which is deprecated and will be removed in the future." |
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
Swagger Generation Artifacts
|
|
Hi @grlima, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced May 19, 2022
openapi-workflow-bot
bot
added
ARMReview
WaitForARMFeedback
|
Hi, @grlima your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
|
Please remove the "ARMChangesRequested" label if you want the API reviewer to look at this review again |
grlima
removed
DoNotMerge
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
Removed. Necessary ARM manifest changes have been deployed. |
|
@grlima do you need this PR to be reviewed again? don't see many updates other than the original removal of operations API |
Hi @jorgecotillo - I pretty much just need the PR to be merged at this point. It has been reviewed but it was on hold until corresponding ARM manifest changes were deployed. It's good to go now from my perspective. Thank you! |
jorgecotillo
added
ARMSignedOff
Work the PR assignee then to get this PR merged |
|
@tadelesh to review GO SDK breaking change |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Approved for Go breaking which come from code generator. |
tadelesh
added
the
Approved-SdkBreakingChange-Go
This was referenced Jul 4, 2022
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
Jul 4, 2022
…crosoft.Insights to add version stable/2022-06-15 (#2460) Create to sync Azure/azure-rest-api-specs#19148 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...azure-sdk:sdkAuto/applicationinsights?expand=1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.