Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.Automanage to add version preview/2021-04-30-preview and stable/2022-05-04 #19170

Merged
merged 9 commits into from
May 30, 2022
Merged

[Hub Generated] Review request for Microsoft.Automanage to add version preview/2021-04-30-preview and stable/2022-05-04 #19170

merged 9 commits into from
May 30, 2022

Conversation

mc3784
Copy link
Contributor

@mc3784 mc3784 commented May 20, 2022 •
edited
Loading

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @mc3784 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 20, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.Automanage/preview/2021-04-30-preview/automanage.json#L2294:9
    Old: Microsoft.Automanage/preview/2021-04-30-preview/automanage.json#L2294:9
    ️⚠️LintDiff: 4 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'versions' with immediate parent 'ConfigurationProfile', must have a list by immediate parent operation.
    Location: Microsoft.Automanage/stable/2022-05-04/automanage.json#L2117
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'reports' with immediate parent 'ConfigurationProfileAssignment', must have a list by immediate parent operation.
    Location: Microsoft.Automanage/stable/2022-05-04/automanage.json#L2276
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'reports' with immediate parent 'ConfigurationProfileAssignment', must have a list by immediate parent operation.
    Location: Microsoft.Automanage/stable/2022-05-04/automanage.json#L2276
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'reports' with immediate parent 'ConfigurationProfileAssignment', must have a list by immediate parent operation.
    Location: Microsoft.Automanage/stable/2022-05-04/automanage.json#L2276


    The following errors/warnings exist before current PR submission:

    Rule Message
    ❌ R4039 - ParametersOrder The parameters:configurationProfileName,resourceGroupName should be kept in the same order as they present in the path.
    Location: Microsoft.Automanage/preview/2021-04-30-preview/automanage.json#L221
    ❌ R4039 - ParametersOrder The parameters:configurationProfileName,resourceGroupName should be kept in the same order as they present in the path.
    Location: Microsoft.Automanage/preview/2021-04-30-preview/automanage.json#L287
    ❌ R4039 - ParametersOrder The parameters:configurationProfileName,resourceGroupName should be kept in the same order as they present in the path.
    Location: Microsoft.Automanage/preview/2021-04-30-preview/automanage.json#L388
    ❌ R4039 - ParametersOrder The parameters:configurationProfileName,versionName,resourceGroupName should be kept in the same order as they present in the path.
    Location: Microsoft.Automanage/preview/2021-04-30-preview/automanage.json#L543
    ❌ R4039 - ParametersOrder The parameters:configurationProfileName,versionName,resourceGroupName should be kept in the same order as they present in the path.
    Location: Microsoft.Automanage/preview/2021-04-30-preview/automanage.json#L616
    ❌ R4039 - ParametersOrder The parameters:configurationProfileName,versionName,resourceGroupName should be kept in the same order as they present in the path.
    Location: Microsoft.Automanage/preview/2021-04-30-preview/automanage.json#L731
    ❌ R4039 - ParametersOrder The parameters:configurationProfileName,resourceGroupName should be kept in the same order as they present in the path.
    Location: Microsoft.Automanage/preview/2021-04-30-preview/automanage.json#L800
    ❌ R4039 - ParametersOrder The parameters:configurationProfileAssignmentName,resourceGroupName,vmName should be kept in the same order as they present in the path.
    Location: Microsoft.Automanage/preview/2021-04-30-preview/automanage.json#L855
    ❌ R4039 - ParametersOrder The parameters:resourceGroupName,configurationProfileAssignmentName,vmName should be kept in the same order as they present in the path.
    Location: Microsoft.Automanage/preview/2021-04-30-preview/automanage.json#L924
    ❌ R4039 - ParametersOrder The parameters:resourceGroupName,configurationProfileAssignmentName,vmName should be kept in the same order as they present in the path.
    Location: Microsoft.Automanage/preview/2021-04-30-preview/automanage.json#L977
    ❌ R4039 - ParametersOrder The parameters:resourceGroupName,configurationProfileAssignmentName,reportName,vmName should be kept in the same order as they present in the path.
    Location: Microsoft.Automanage/preview/2021-04-30-preview/automanage.json#L1219
    ❌ R4039 - ParametersOrder The parameters:resourceGroupName,configurationProfileAssignmentName,vmName should be kept in the same order as they present in the path.
    Location: Microsoft.Automanage/preview/2021-04-30-preview/automanage.json#L1281
    ❌ R4039 - ParametersOrder The parameters:configurationProfileName,resourceGroupName should be kept in the same order as they present in the path.
    Location: Microsoft.Automanage/stable/2022-05-04/automanage.json#L221
    ❌ R4039 - ParametersOrder The parameters:configurationProfileName,resourceGroupName should be kept in the same order as they present in the path.
    Location: Microsoft.Automanage/stable/2022-05-04/automanage.json#L287
    ❌ R4039 - ParametersOrder The parameters:configurationProfileName,resourceGroupName should be kept in the same order as they present in the path.
    Location: Microsoft.Automanage/stable/2022-05-04/automanage.json#L388
    ❌ R4039 - ParametersOrder The parameters:configurationProfileName,versionName,resourceGroupName should be kept in the same order as they present in the path.
    Location: Microsoft.Automanage/stable/2022-05-04/automanage.json#L543
    ❌ R4039 - ParametersOrder The parameters:configurationProfileName,versionName,resourceGroupName should be kept in the same order as they present in the path.
    Location: Microsoft.Automanage/stable/2022-05-04/automanage.json#L616
    ❌ R4039 - ParametersOrder The parameters:configurationProfileName,resourceGroupName should be kept in the same order as they present in the path.
    Location: Microsoft.Automanage/stable/2022-05-04/automanage.json#L733
    ❌ R4039 - ParametersOrder The parameters:configurationProfileAssignmentName,resourceGroupName,vmName should be kept in the same order as they present in the path.
    Location: Microsoft.Automanage/stable/2022-05-04/automanage.json#L788
    ❌ R4039 - ParametersOrder The parameters:resourceGroupName,configurationProfileAssignmentName,vmName should be kept in the same order as they present in the path.
    Location: Microsoft.Automanage/stable/2022-05-04/automanage.json#L857
    ❌ R4039 - ParametersOrder The parameters:resourceGroupName,configurationProfileAssignmentName,vmName should be kept in the same order as they present in the path.
    Location: Microsoft.Automanage/stable/2022-05-04/automanage.json#L910
    ❌ R4039 - ParametersOrder The parameters:resourceGroupName,configurationProfileAssignmentName,reportName,vmName should be kept in the same order as they present in the path.
    Location: Microsoft.Automanage/stable/2022-05-04/automanage.json#L1152
    ❌ R4039 - ParametersOrder The parameters:resourceGroupName,configurationProfileAssignmentName,vmName should be kept in the same order as they present in the path.
    Location: Microsoft.Automanage/stable/2022-05-04/automanage.json#L1214
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: authorizationSet
    Location: Microsoft.Automanage/preview/2021-04-30-preview/automanage.json#L2497
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: authorizationSet
    Location: Microsoft.Automanage/stable/2022-05-04/automanage.json#L2430
    ⚠️ R4024 - PreviewVersionOverOneYear The API version:2021-04-30-preview having been in a preview state over one year , please move it to GA or retire.
    Location: Microsoft.Automanage/preview/2021-04-30-preview/automanage.json#L4
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️⚠️Cross-Version Breaking Changes: 2 Warnings warning [Detail]
    The following breaking changes are detected by comparison with latest preview version:
    Rule Message
    ⚠️ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.Automanage/stable/2022-05-04/automanage.json#L2227:9
    Old: Microsoft.Automanage/preview/2021-04-30-preview/automanage.json#L2294:9
    ⚠️ 1035 - RemovedOperation The new version is missing an operation that was found in the old version. Was operationId 'ConfigurationProfilesVersions_Update' removed or restructured?
    New: Microsoft.Automanage/stable/2022-05-04/automanage.json#L542:5
    Old: Microsoft.Automanage/preview/2021-04-30-preview/automanage.json#L542:5
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 20, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ❌azure-sdk-for-go-track2 - armautomanage - 0.6.0
    +	Function `*ConfigurationProfilesVersionsClient.Update` has been removed
+	Struct `ConfigurationProfilesVersionsClientUpdateOptions` has been removed
+	Struct `ConfigurationProfilesVersionsClientUpdateResponse` has been removed
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-automanage - 1.0.0b2
    ️✔️azure-sdk-for-go - preview/automanage/mgmt/2021-04-30-preview/automanage - v65.0.0
    ️✔️azure-sdk-for-go - preview/automanage/mgmt/2020-06-30-preview/automanage - v65.0.0
    ️❌ azure-sdk-for-net failed [Detail]   
  
    • ❌Failed [Logs]Release - Generate from c57d5de. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/automanage/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] No usable version of the libssl was found
cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
warn	Skip package processing as generation is failed
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]   
  
    • ⚠️Warning [Logs]Release - Generate from c57d5de. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.5.5 -> 8.11.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.11.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.11.0` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-automanage        [View full logs]         [Release SDK Changes]        Breaking Change Detected
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation ConfigurationProfileAssignmentsOperations.create_or_update
info	[Changelog]   - Added operation ConfigurationProfileAssignmentsOperations.list_by_cluster_name
info	[Changelog]   - Added operation ConfigurationProfileAssignmentsOperations.list_by_machine_name
info	[Changelog]   - Added operation ConfigurationProfileAssignmentsOperations.list_by_virtual_machines
info	[Changelog]   - Added operation group BestPracticesOperations
info	[Changelog]   - Added operation group BestPracticesVersionsOperations
info	[Changelog]   - Added operation group ConfigurationProfileHCIAssignmentsOperations
info	[Changelog]   - Added operation group ConfigurationProfileHCRPAssignmentsOperations
info	[Changelog]   - Added operation group ConfigurationProfilesOperations
info	[Changelog]   - Added operation group ConfigurationProfilesVersionsOperations
info	[Changelog]   - Added operation group HCIReportsOperations
info	[Changelog]   - Added operation group HCRPReportsOperations
info	[Changelog]   - Added operation group ReportsOperations
info	[Changelog]   - Added operation group ServicePrincipalsOperations
info	[Changelog]   - Model ConfigurationProfileAssignment has a new parameter system_data
info	[Changelog]   - Model ConfigurationProfileAssignmentProperties has a new parameter profile_overrides
info	[Changelog]   - Model ConfigurationProfileAssignmentProperties has a new parameter status
info	[Changelog]   - Model Operation has a new parameter action_type
info	[Changelog]   - Model Operation has a new parameter origin
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Model ConfigurationProfileAssignmentProperties no longer has parameter account_id
info	[Changelog]   - Model ConfigurationProfileAssignmentProperties no longer has parameter compliance
info	[Changelog]   - Model ConfigurationProfileAssignmentProperties no longer has parameter configuration_profile_preference_id
info	[Changelog]   - Model ConfigurationProfileAssignmentProperties no longer has parameter provisioning_status
info	[Changelog]   - Model Operation no longer has parameter status_code
info	[Changelog]   - Removed operation ConfigurationProfileAssignmentsOperations.begin_create_or_update
info	[Changelog]   - Removed operation group AccountsOperations
info	[Changelog]   - Removed operation group ConfigurationProfilePreferencesOperations
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]  
  
    • ️✔️Succeeded [Logs]Release - Generate from c57d5de. SDK Automation 14.0.0 
      command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️preview/automanage/mgmt/2021-04-30-preview/automanage        [View full logs]         [Release SDK Changes]      
            Only show 60 items here, please refer to log for details.
      info	[Changelog] - New function `ConfigurationProfileHCIAssignmentsClient.DeleteSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `NewHCIReportsClientWithBaseURI(string, string) HCIReportsClient`
info	[Changelog] - New function `HCIReportsClient.Get(context.Context, string, string, string, string) (Report, error)`
info	[Changelog] - New function `ConfigurationProfileHCRPAssignmentsClient.CreateOrUpdateSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `NewHCIReportsClient(string) HCIReportsClient`
info	[Changelog] - New function `ConfigurationProfileAssignmentsClient.ListByVirtualMachinesPreparer(context.Context, string, string) (*http.Request, error)`
info	[Changelog] - New function `NewConfigurationProfileHCIAssignmentsClient(string) ConfigurationProfileHCIAssignmentsClient`
info	[Changelog] - New function `ConfigurationProfileHCRPAssignmentsClient.CreateOrUpdateResponder(*http.Response) (ConfigurationProfileAssignment, error)`
info	[Changelog] - New function `ServicePrincipalsClient.ListBySubscriptionPreparer(context.Context) (*http.Request, error)`
info	[Changelog] - New function `ConfigurationProfileHCRPAssignmentsClient.Delete(context.Context, string, string, string) (autorest.Response, error)`
info	[Changelog] - New function `NewConfigurationProfileHCRPAssignmentsClientWithBaseURI(string, string) ConfigurationProfileHCRPAssignmentsClient`
info	[Changelog] - New function `ServicePrincipal.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `HCIReportsClient.GetResponder(*http.Response) (Report, error)`
info	[Changelog] - New function `ConfigurationProfileAssignmentsClient.ListByVirtualMachinesSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `ServicePrincipalsClient.GetResponder(*http.Response) (ServicePrincipal, error)`
info	[Changelog] - New function `ConfigurationProfileHCIAssignmentsClient.DeleteResponder(*http.Response) (autorest.Response, error)`
info	[Changelog] - New function `ServicePrincipalsClient.GetPreparer(context.Context) (*http.Request, error)`
info	[Changelog] - New function `HCRPReportsClient.ListByConfigurationProfileAssignmentsSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `ConfigurationProfileHCIAssignmentsClient.DeletePreparer(context.Context, string, string, string) (*http.Request, error)`
info	[Changelog] - New function `ConfigurationProfileHCRPAssignmentsClient.DeleteResponder(*http.Response) (autorest.Response, error)`
info	[Changelog] - New function `HCIReportsClient.ListByConfigurationProfileAssignmentsPreparer(context.Context, string, string, string) (*http.Request, error)`
info	[Changelog] - New function `HCRPReportsClient.ListByConfigurationProfileAssignmentsPreparer(context.Context, string, string, string) (*http.Request, error)`
info	[Changelog] - New function `HCRPReportsClient.GetPreparer(context.Context, string, string, string, string) (*http.Request, error)`
info	[Changelog] - New function `ConfigurationProfileAssignmentsClient.ListByMachineNameSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `ConfigurationProfileHCRPAssignmentsClient.GetPreparer(context.Context, string, string, string) (*http.Request, error)`
info	[Changelog] - New function `ConfigurationProfileHCIAssignmentsClient.GetResponder(*http.Response) (ConfigurationProfileAssignment, error)`
info	[Changelog] - New function `ConfigurationProfileAssignmentsClient.ListByClusterNameResponder(*http.Response) (ConfigurationProfileAssignmentList, error)`
info	[Changelog] - New function `ConfigurationProfileHCRPAssignmentsClient.CreateOrUpdatePreparer(context.Context, ConfigurationProfileAssignment, string, string, string) (*http.Request, error)`
info	[Changelog] - New function `ConfigurationProfileHCIAssignmentsClient.CreateOrUpdate(context.Context, ConfigurationProfileAssignment, string, string, string) (ConfigurationProfileAssignment, error)`
info	[Changelog] - New function `ConfigurationProfileAssignmentsClient.ListByMachineNamePreparer(context.Context, string, string) (*http.Request, error)`
info	[Changelog] - New function `NewConfigurationProfileHCRPAssignmentsClient(string) ConfigurationProfileHCRPAssignmentsClient`
info	[Changelog] - New function `HCIReportsClient.GetSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `ConfigurationProfileHCRPAssignmentsClient.DeletePreparer(context.Context, string, string, string) (*http.Request, error)`
info	[Changelog] - New function `HCRPReportsClient.ListByConfigurationProfileAssignmentsResponder(*http.Response) (ReportList, error)`
info	[Changelog] - New function `ConfigurationProfileHCIAssignmentsClient.Get(context.Context, string, string, string) (ConfigurationProfileAssignment, error)`
info	[Changelog] - New function `HCRPReportsClient.GetSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `ConfigurationProfileHCRPAssignmentsClient.Get(context.Context, string, string, string) (ConfigurationProfileAssignment, error)`
info	[Changelog] - New function `ServicePrincipalProperties.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `ServicePrincipalsClient.ListBySubscriptionSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `ServicePrincipalsClient.ListBySubscription(context.Context) (ServicePrincipalListResult, error)`
info	[Changelog] - New function `ConfigurationProfileAssignmentsClient.ListByClusterNameSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `ConfigurationProfileHCIAssignmentsClient.CreateOrUpdatePreparer(context.Context, ConfigurationProfileAssignment, string, string, string) (*http.Request, error)`
info	[Changelog] - New function `ConfigurationProfileAssignmentsClient.ListByClusterNamePreparer(context.Context, string, string) (*http.Request, error)`
info	[Changelog] - New function `ServicePrincipalsClient.GetSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `HCRPReportsClient.ListByConfigurationProfileAssignments(context.Context, string, string, string) (ReportList, error)`
info	[Changelog] - New function `HCIReportsClient.ListByConfigurationProfileAssignmentsSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `ConfigurationProfileHCRPAssignmentsClient.GetSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `ConfigurationProfileAssignmentsClient.ListByClusterName(context.Context, string, string) (ConfigurationProfileAssignmentList, error)`
info	[Changelog] - New function `NewConfigurationProfileHCIAssignmentsClientWithBaseURI(string, string) ConfigurationProfileHCIAssignmentsClient`
info	[Changelog] - New function `NewHCRPReportsClientWithBaseURI(string, string) HCRPReportsClient`
info	[Changelog] - New struct `ConfigurationProfileHCIAssignmentsClient`
info	[Changelog] - New struct `ConfigurationProfileHCRPAssignmentsClient`
info	[Changelog] - New struct `HCIReportsClient`
info	[Changelog] - New struct `HCRPReportsClient`
info	[Changelog] - New struct `ServicePrincipal`
info	[Changelog] - New struct `ServicePrincipalListResult`
info	[Changelog] - New struct `ServicePrincipalProperties`
info	[Changelog] - New struct `ServicePrincipalsClient`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 89 additive change(s).
    • ️✔️preview/automanage/mgmt/2020-06-30-preview/automanage        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]  
  
    • ️✔️Succeeded [Logs]Release - Generate from c57d5de. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armautomanage        [View full logs]         [Release SDK Changes]        Breaking Change Detected
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `*ConfigurationProfilesVersionsClient.Update` has been removed
info	[Changelog] - Struct `ConfigurationProfilesVersionsClientUpdateOptions` has been removed
info	[Changelog] - Struct `ConfigurationProfilesVersionsClientUpdateResponse` has been removed
info	[Changelog]
info	[Changelog] Total 5 breaking change(s), 0 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]   
  
    • ⚠️Warning [Logs]Release - Generate from c57d5de. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh]  deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh]  uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh] npm WARN deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh] WARN deprecated @azure/storage-blob@10.5.0: This version has been deprecated, please upgrade to the version tagged as latest
cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-automanage        [View full logs]         [Release SDK Changes]      
      info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️️✔️ azure-powershell succeeded [Detail] [Expand]  
  
    • ️✔️Succeeded [Logs]Release - Generate from c57d5de. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.Automanage        [View full logs]         [Release SDK Changes]      
    Posted by Swagger Pipeline | How to fix these errors?
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
            





    

      
    
  
      

    

  
    
  @openapi-workflow-bot


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      



      

  
    

  
    
    

  
    

    


      
    

        

    
  
    
    
      
          
    Hi @mc3784, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.  
    TaskHow to fixPriority
     
    AvocadoFix-AvocadoHigh
     
    Semantic validationFix-SemanticValidation-ErrorHigh
     
    Model validationFix-ModelValidation-ErrorHigh
     
    LintDiffFix-LintDiffhigh
      If you need further help, please feedback via swagger feedback.
    
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
            





    

      
    
  
      

    

  
    
  @openapi-workflow-bot


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      



      

  
    

  
    
    

  
    

    


      
    

        

    
  
    
    
      
          
    Hi @mc3784, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. 
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
     If you want to know the production traffic statistic, please see ARM Traffic statistic. 
     If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. 
     Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.
    
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
          
    
  
    
    
  
    

  
    
      
    
  This was referenced May 20, 2022

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



  
    

    

    


  
    
  
    
    
  
    

  
    
      
    
  This was referenced May 20, 2022

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



  
    

    




    

      
    
  
        



    

      
    
  
            





    

      
    
  
        



    

      
    
  
            


    


  
    
  
  
    
  
          @mc3784
  mc3784


        marked this pull request as ready for review

    May 27, 2022 18:40    
    

    

    
    


    
    
    
    
      
    
    
    
    

      

          @openapi-workflow-bot
openapi-workflow-bot
bot



            added
      

  ARMReview


      

  WaitForARMFeedback

  <valid label in PR review process> add this label when ARM review is required

  labels


      May 27, 2022

    
    
  
    





    

      
    
  
      

    

  
    
  @openapi-workflow-bot


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      



      

  
    

  
    
    

  
    

    


      
    

        

    
  
    
    
      
          
    Hi, @mc3784 your PR are labelled with  WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).
    
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    




        
    
  
            
    
    
    
      
    
    
    
    

      

          @JeffreyRichter
JeffreyRichter




          added
  the 

  Approved-BreakingChange

  DO NOT USE! OBSOLETE label. See  https://github.com/Azure/azure-sdk-tools/issues/6374
 label


      May 27, 2022

    
    
  
    





    

        
    
  
        



    

        
    
  
            
    
    
    
      
    
    
    
    

      

          @NetRock
NetRock




          added
  the 

  ARMSignedOff

  <valid label in PR review process>add this label when ARM approve updates after review
 label


      May 28, 2022

    
    
  
    


    
    
    
    
      
    
    
    
    

      

          @openapi-workflow-bot
openapi-workflow-bot
bot



          removed
  the 

  WaitForARMFeedback

  <valid label in PR review process> add this label when ARM review is required
 label


      May 28, 2022

    
    
  
    


  
    
  
    
    
  
    
  
    


        @leni-msft
  leni-msft



        merged commit c57d5de
      into

      
  
    Azure:main
  


    May 30, 2022

  
    

    


    

  
    
  
    
    
  
    

  
    
      
    
  This was referenced May 30, 2022

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



  
    

    

  
  



    



  
  
    
    
    
      

      
    



    
    

    
    
      
    
              
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  

    

      
    
    
    
  
    


    
  
              

    


      
    
  
    
    
    
    
    
  
    
    Reviewers
  
    

    


        
    
          

  
      @NetRock
  
    NetRock



          
            
              
            
          
          NetRock approved these changes

        
    

      
    


    


    
    
  
    

      
  
    
    Assignees
  
    


        

      
    
        

  
      @leni-msft
  
    leni-msft
    

      
    
    



    


      

    
  


  
    
    Labels
  
    


    
    
      

    Approved-BreakingChange

  DO NOT USE! OBSOLETE label. See  https://github.com/Azure/azure-sdk-tools/issues/6374
  

    ARMReview

  

    ARMSignedOff

  <valid label in PR review process>add this label when ARM approve updates after review
  

    CI-BreakingChange-Go-V2

  

    FixS360



    


    


      

  
    
    
    
        
    
    Projects
  
    

        
    

    

    None yet




      
    


      

    
  
    
    
  
    
    Milestone
  
    

      No milestone


    


    
      
          

    
  
    
    
      
    
        
    
    
    Development
  
    


          


    Successfully merging this pull request may close these issues.
    


  


            
  
    

    

          

    

  
      
    
  
    
    
    
      4 participants
    
    
    
    
        
          @mc3784 
        
          @NetRock 
        
          @JeffreyRichter 
        
          @leni-msft