Cherry pick GA May APIs #19188
Merged
Cherry pick GA May APIs #19188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adding Swagger for GA API * remove extractive summerization changes * run .\Copy-AzSpecifications.ps1 -SourceBranch dev-cognitiveservices-Language-2022-03-01-preview * removing extractive summerization from results * removing analyze conversation APIs auto generated from March APIs * single classification with array of class as multi classification * update readme * update the read me * update read.me * code review # Conflicts: # specification/cognitiveservices/data-plane/Language/readme.md
* Add Language authoring 2022-05-01 APIs * Some build fixes * Add polymerphism for CLU exported project * Rename the api-version property in the import body * Retrigger CI * Update the hostTemplate and the operation Ids * Use the common error objects * Remove redundant definitions * Update the stringIndexType * Revert "Update the stringIndexType" This reverts commit 455762d. * Fix import/export object in CT * Rename actual to predicted * Add the APIs examples * Fix the examples validations * Fix prettier * Fix autorest issues * Fix nextLink examples regression * Retrigger CI * Renaming the swagger files * Apply PR feedback - part 1 * Add the documentation for the schemas * Fix spelling errors * Update the descriptions for the analyzetext-authoring * Rename project-file-version to projectFileVersion
* Add CLU 2022-05-01 GA version * Remove role * Update modality to inputModality * Do not update property name to inputModality, only the enum name. * Resolve comments * Rename CustomConversation Co-authored-by: Chong Tang <chot@microsoft.com>
…ion (2022-05-01) (Azure#18836) * Update authoring and runtime APIs to follow the same convention * Update the examples * Remove other references to "named" in "named entity recognition" * Remove more 'named' from the swagger
…ot in the GA version (Azure#18946) * Adding the missing 'required' attribute present in preview APIs and not in the GA version * Updates
* rename LUIS to Luis * use camel case for enum values * Revert "use camel case for enum values" This reverts commit 8db93fb. Co-authored-by: Chong Tang <chot@microsoft.com>
…nalyzeconversations.json (Azure#19030) Co-authored-by: Chong Tang <chot@microsoft.com>
nourhaanfarid
requested review from
tg-msft and
rysweet
and removed request for
a team
|
Hi, @nourhaanfarid Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Guid used in model definition 'ConversationalAnalysisAuthoringExportedLuisOrchestration' for property 'appId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Language/stable/2022-05-01/analyzeconversations-authoring.json#L1831 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌Cross-Version Breaking Changes: 1 Errors, 82 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.9.5)
- current:stable/2022-05-01/analyzeconversations.json compared with base:preview/2022-03-01-preview/analyzeconversations.json
- current:stable/2022-05-01/common.json compared with base:stable/2021-10-01/common.json
- current:stable/2022-05-01/common.json compared with base:preview/2022-03-01-preview/common.json
- current:stable/2022-05-01/textanalytics.json compared with base:preview/2022-03-01-preview/textanalytics.json
| Rule | Message |
|---|---|
|
The new version has new required property 'error' that was not found in the old version. New: Language/stable/2022-05-01/common.json#L10:5 Old: Language/stable/2021-10-01/common.json#L10:5 |
The following breaking changes are detected by comparison with latest preview version:
Only 30 items are listed, please refer to log for more details.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=294690&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 128 " |
️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]
Breaking Changes Tracking
️⚠️ azure-sdk-for-net-track2 warning [Detail]
⚠️Warning [Logs] Generate from 78deaf9b666f26a5909b1a713ed32b962b378ee6. SDK Automation 14.0.0command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json warn File azure-sdk-for-net_tmp/initOutput.json not found to read command pwsh ./eng/scripts/Automation-Sdk-Generate.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json warn No file changes detected after generation warn Skip detect changed packages
️⚠️ azure-sdk-for-python warning [Detail]
⚠️Warning [Logs] Generate from 78deaf9b666f26a5909b1a713ed32b962b378ee6. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] cmderr [automation_generate.sh] npm notice New minor version of npm available! 8.5.5 -> 8.10.0 cmderr [automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.10.0> cmderr [automation_generate.sh] npm notice Run `npm install -g npm@8.10.0` to update! cmderr [automation_generate.sh] npm notice warn No file changes detected after generation warn No package detected after generation
lmazuel
merged commit c433561
into
Azure:release-cognitiveservices-Language-2022-05-01-GA-V2
heaths
added a commit
that referenced
this pull request
May 24, 2022
* Cognitive Services Language GA API 2022-05-01 Swagger (#18402) * adding Swagger for GA API * remove extractive summerization changes * run .\Copy-AzSpecifications.ps1 -SourceBranch dev-cognitiveservices-Language-2022-03-01-preview * removing extractive summerization from results * removing analyze conversation APIs auto generated from March APIs * single classification with array of class as multi classification * update readme * update the read me * update read.me * code review * Use azure-sdk-for-net-track2 for validation (#18756) * Add Language authoring 2022-05-01 APIs (#18694) * Add Language authoring 2022-05-01 APIs * Some build fixes * Add polymerphism for CLU exported project * Rename the api-version property in the import body * Retrigger CI * Update the hostTemplate and the operation Ids * Use the common error objects * Remove redundant definitions * Update the stringIndexType * Revert "Update the stringIndexType" This reverts commit 455762d. * Fix import/export object in CT * Rename actual to predicted * Add the APIs examples * Fix the examples validations * Fix prettier * Fix autorest issues * Fix nextLink examples regression * Retrigger CI * Renaming the swagger files * Apply PR feedback - part 1 * Add the documentation for the schemas * Fix spelling errors * Update the descriptions for the analyzetext-authoring * Rename project-file-version to projectFileVersion * Add CLU 2022-05-01 GA version (#18759) * Add CLU 2022-05-01 GA version * Remove role * Update modality to inputModality * Do not update property name to inputModality, only the enum name. * Resolve comments * Rename CustomConversation Co-authored-by: Chong Tang <chot@microsoft.com> * Update Language authoring and runtime APIs to follow the same convention (2022-05-01) (#18836) * Update authoring and runtime APIs to follow the same convention * Update the examples * Remove other references to "named" in "named entity recognition" * Remove more 'named' from the swagger * Adding the missing 'required' attribute present in preview APIs and not in the GA version (#18946) * Adding the missing 'required' attribute present in preview APIs and not in the GA version * Updates * Add api-version parameter to cancel job endpoint (#18985) * Use PascalCase for enum values (#18840) * rename LUIS to Luis * use camel case for enum values * Revert "use camel case for enum values" This reverts commit 8db93fb. Co-authored-by: Chong Tang <chot@microsoft.com> * Copy QuestionAnswering definitions to common.json and refer them in analyzeconversations.json (#19030) Co-authored-by: Chong Tang <chot@microsoft.com> Co-authored-by: Heath Stewart <heaths@microsoft.com> Co-authored-by: Mohamed Abbas <moaba@microsoft.com> Co-authored-by: Chong Tang <ct4ew@virginia.edu> Co-authored-by: Chong Tang <chot@microsoft.com> Co-authored-by: Bidisha Chakraborty <29803402+bidisha-c@users.noreply.github.com>
lmazuel
pushed a commit
that referenced
this pull request
May 24, 2022
* Cognitive Services Language GA API 2022-05-01 Swagger (#18402) * adding Swagger for GA API * remove extractive summerization changes * run .\Copy-AzSpecifications.ps1 -SourceBranch dev-cognitiveservices-Language-2022-03-01-preview * removing extractive summerization from results * removing analyze conversation APIs auto generated from March APIs * single classification with array of class as multi classification * update readme * update the read me * update read.me * code review * Use azure-sdk-for-net-track2 for validation (#18756) * Add Language authoring 2022-05-01 APIs (#18694) * Add Language authoring 2022-05-01 APIs * Some build fixes * Add polymerphism for CLU exported project * Rename the api-version property in the import body * Retrigger CI * Update the hostTemplate and the operation Ids * Use the common error objects * Remove redundant definitions * Update the stringIndexType * Revert "Update the stringIndexType" This reverts commit 455762d. * Fix import/export object in CT * Rename actual to predicted * Add the APIs examples * Fix the examples validations * Fix prettier * Fix autorest issues * Fix nextLink examples regression * Retrigger CI * Renaming the swagger files * Apply PR feedback - part 1 * Add the documentation for the schemas * Fix spelling errors * Update the descriptions for the analyzetext-authoring * Rename project-file-version to projectFileVersion * Add CLU 2022-05-01 GA version (#18759) * Add CLU 2022-05-01 GA version * Remove role * Update modality to inputModality * Do not update property name to inputModality, only the enum name. * Resolve comments * Rename CustomConversation Co-authored-by: Chong Tang <chot@microsoft.com> * Update Language authoring and runtime APIs to follow the same convention (2022-05-01) (#18836) * Update authoring and runtime APIs to follow the same convention * Update the examples * Remove other references to "named" in "named entity recognition" * Remove more 'named' from the swagger * Adding the missing 'required' attribute present in preview APIs and not in the GA version (#18946) * Adding the missing 'required' attribute present in preview APIs and not in the GA version * Updates * Add api-version parameter to cancel job endpoint (#18985) * Use PascalCase for enum values (#18840) * rename LUIS to Luis * use camel case for enum values * Revert "use camel case for enum values" This reverts commit 8db93fb. Co-authored-by: Chong Tang <chot@microsoft.com> * Copy QuestionAnswering definitions to common.json and refer them in analyzeconversations.json (#19030) Co-authored-by: Chong Tang <chot@microsoft.com> Co-authored-by: Heath Stewart <heaths@microsoft.com> Co-authored-by: Mohamed Abbas <moaba@microsoft.com> Co-authored-by: Chong Tang <ct4ew@virginia.edu> Co-authored-by: Chong Tang <chot@microsoft.com> Co-authored-by: Bidisha Chakraborty <29803402+bidisha-c@users.noreply.github.com> Co-authored-by: Nourhan <92883092+nourhaanfarid@users.noreply.github.com> Co-authored-by: Mohamed Abbas <moaba@microsoft.com> Co-authored-by: Chong Tang <ct4ew@virginia.edu> Co-authored-by: Chong Tang <chot@microsoft.com> Co-authored-by: Bidisha Chakraborty <29803402+bidisha-c@users.noreply.github.com>
gargankit-microsoft
pushed a commit
that referenced
this pull request
May 26, 2022
* Cognitive Services Language GA API 2022-05-01 Swagger (#18402) * adding Swagger for GA API * remove extractive summerization changes * run .\Copy-AzSpecifications.ps1 -SourceBranch dev-cognitiveservices-Language-2022-03-01-preview * removing extractive summerization from results * removing analyze conversation APIs auto generated from March APIs * single classification with array of class as multi classification * update readme * update the read me * update read.me * code review * Use azure-sdk-for-net-track2 for validation (#18756) * Add Language authoring 2022-05-01 APIs (#18694) * Add Language authoring 2022-05-01 APIs * Some build fixes * Add polymerphism for CLU exported project * Rename the api-version property in the import body * Retrigger CI * Update the hostTemplate and the operation Ids * Use the common error objects * Remove redundant definitions * Update the stringIndexType * Revert "Update the stringIndexType" This reverts commit 455762d. * Fix import/export object in CT * Rename actual to predicted * Add the APIs examples * Fix the examples validations * Fix prettier * Fix autorest issues * Fix nextLink examples regression * Retrigger CI * Renaming the swagger files * Apply PR feedback - part 1 * Add the documentation for the schemas * Fix spelling errors * Update the descriptions for the analyzetext-authoring * Rename project-file-version to projectFileVersion * Add CLU 2022-05-01 GA version (#18759) * Add CLU 2022-05-01 GA version * Remove role * Update modality to inputModality * Do not update property name to inputModality, only the enum name. * Resolve comments * Rename CustomConversation Co-authored-by: Chong Tang <chot@microsoft.com> * Update Language authoring and runtime APIs to follow the same convention (2022-05-01) (#18836) * Update authoring and runtime APIs to follow the same convention * Update the examples * Remove other references to "named" in "named entity recognition" * Remove more 'named' from the swagger * Adding the missing 'required' attribute present in preview APIs and not in the GA version (#18946) * Adding the missing 'required' attribute present in preview APIs and not in the GA version * Updates * Add api-version parameter to cancel job endpoint (#18985) * Use PascalCase for enum values (#18840) * rename LUIS to Luis * use camel case for enum values * Revert "use camel case for enum values" This reverts commit 8db93fb. Co-authored-by: Chong Tang <chot@microsoft.com> * Copy QuestionAnswering definitions to common.json and refer them in analyzeconversations.json (#19030) Co-authored-by: Chong Tang <chot@microsoft.com> Co-authored-by: Heath Stewart <heaths@microsoft.com> Co-authored-by: Mohamed Abbas <moaba@microsoft.com> Co-authored-by: Chong Tang <ct4ew@virginia.edu> Co-authored-by: Chong Tang <chot@microsoft.com> Co-authored-by: Bidisha Chakraborty <29803402+bidisha-c@users.noreply.github.com> Co-authored-by: Nourhan <92883092+nourhaanfarid@users.noreply.github.com> Co-authored-by: Mohamed Abbas <moaba@microsoft.com> Co-authored-by: Chong Tang <ct4ew@virginia.edu> Co-authored-by: Chong Tang <chot@microsoft.com> Co-authored-by: Bidisha Chakraborty <29803402+bidisha-c@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.