Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mgmt][Network] Remove global configuration "multiapi" #19276

Merged
merged 1 commit into from
Jun 2, 2022
Merged

[Mgmt][Network] Remove global configuration "multiapi" #19276

merged 1 commit into from
Jun 2, 2022

Conversation

BigCat20196
Copy link
Contributor

@BigCat20196 BigCat20196 requested a review from msyyc as a code owner May 31, 2022 07:15
@openapi-workflow-bot
Copy link

Hi, @BigCat20196 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 31, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️LintDiff succeeded [Detail] [Expand] 
    Validation passes for LintDiff.

    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 31, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go-track2 - armnetwork - 1.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2021-08-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2021-05-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2021-03-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2021-02-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2020-11-01/network - v65.0.0
    ❌azure-sdk-for-go - network/mgmt/2020-08-01/network - v65.0.0
    +	Field `ExtendedLocation` of struct `VirtualNetworkGatewayPropertiesFormat` has been removed
+	Field `VirtualNetworkExtendedLocationResourceID` of struct `VirtualNetworkGatewayPropertiesFormat` has been removed
+	Type of `SubnetPropertiesFormat.PrivateEndpointNetworkPolicies` has been changed from `*string` to `VirtualNetworkPrivateEndpointNetworkPolicies`
+	Type of `SubnetPropertiesFormat.PrivateLinkServiceNetworkPolicies` has been changed from `*string` to `VirtualNetworkPrivateLinkServiceNetworkPolicies`
    ❌azure-sdk-for-go - network/mgmt/2020-07-01/network - v65.0.0
    +	Field `ExtendedLocation` of struct `VirtualNetworkGatewayPropertiesFormat` has been removed
+	Field `VirtualNetworkExtendedLocationResourceID` of struct `VirtualNetworkGatewayPropertiesFormat` has been removed
+	Type of `SubnetPropertiesFormat.PrivateEndpointNetworkPolicies` has been changed from `*string` to `VirtualNetworkPrivateEndpointNetworkPolicies`
+	Type of `SubnetPropertiesFormat.PrivateLinkServiceNetworkPolicies` has been changed from `*string` to `VirtualNetworkPrivateLinkServiceNetworkPolicies`
    ️✔️azure-sdk-for-go - network/mgmt/2020-06-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2020-05-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2020-04-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2020-03-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-12-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-11-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-09-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-08-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-07-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-06-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-04-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-02-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-12-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-11-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-10-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-08-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-07-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-06-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-04-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-02-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-01-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2017-11-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2017-10-01/network - v65.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2015-06-15/network - v65.0.0
    ️✔️azure-sdk-for-go - preview/network/mgmt/2021-03-01-preview/network - v65.0.0
    ️✔️azure-sdk-for-go - preview/network/mgmt/2021-02-01-preview/network - v65.0.0
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-network - 20.0.0
    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from b513729. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-network [View full logs]  [Release SDK Changes] 
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model ApplicationGatewayRoutingRule has a new parameter priority
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from b513729. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
    • ️✔️azure-resourcemanager-network-generated [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from b513729. SDK Automation 14.0.0 
      command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️network/mgmt/2021-08-01/network [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2021-05-01/network [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2021-03-01/network [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2021-02-01/network [View full logs] 
      Only show 4 items here, please refer to log for details.
      info	[Changelog] - New field `Type` in struct `PrivateDNSZoneConfig`
info	[Changelog] - New field `ResolvedPrivateLinkServiceLocation` in struct `PrivateLinkServiceConnectionProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 6 additive change(s).
    • ️✔️network/mgmt/2020-11-01/network [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2020-08-01/network [View full logs] 
      Only show 4 items here, please refer to log for details.
      info	[Changelog] - New field `MigrationPhase` in struct `InterfacePropertiesFormat`
info	[Changelog] - New field `PrivateLinkService` in struct `InterfacePropertiesFormat`
info	[Changelog]
info	[Changelog] Total 2 breaking change(s), 35 additive change(s).
    • ️✔️network/mgmt/2020-07-01/network [View full logs] 
      Only show 4 items here, please refer to log for details.
      info	[Changelog] - New field `Type` in struct `InterfaceIPConfiguration`
info	[Changelog] - New field `State` in struct `ServiceTagInformationPropertiesFormat`
info	[Changelog]
info	[Changelog] Total 2 breaking change(s), 27 additive change(s).
    • ️✔️network/mgmt/2020-06-01/network [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2020-05-01/network [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2020-04-01/network [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2020-03-01/network [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-12-01/network [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-11-01/network [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-09-01/network [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-08-01/network [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-07-01/network [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-06-01/network [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-04-01/network [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-02-01/network [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-12-01/network [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-11-01/network [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-10-01/network [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-08-01/network [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-07-01/network [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-06-01/network [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-04-01/network [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-02-01/network [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-01-01/network [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2017-11-01/network [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2017-10-01/network [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2015-06-15/network [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/network/mgmt/2021-03-01-preview/network [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/network/mgmt/2021-02-01-preview/network [View full logs]  
      info	[Changelog] This is a new package
info	[Changelog]
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from b513729. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armnetwork [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New field `Priority` in struct `ApplicationGatewayRoutingRulePropertiesFormat`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 1 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from b513729. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh]  WARN deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh] deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh] deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh] deprecated @azure/storage-blob@10.5.0: This version has been deprecated, please upgrade to the version tagged as latest
cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-network [View full logs]  [Release SDK Changes] 
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Type Alias ApplicationGatewayRoutingRule has a new parameter priority
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from b513729. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation
warn	Skip detect changed packages
    ️❌ azure-powershell failed [Detail]
    • ❌Failed [Logs]Release - Generate from b513729. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ❌Az.network [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    This was referenced May 31, 2022
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    @raych1
    Copy link
    Member

    raych1 commented Jun 1, 2022

    @msyyc , can you review this PR?

    @msyyc msyyc assigned msyyc and unassigned raych1 Jun 2, 2022
    @msyyc msyyc merged commit b513729 into Azure:main Jun 2, 2022
    This was referenced Jun 2, 2022
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @msyyc msyyc msyyc approved these changes

    Assignees

    @msyyc msyyc

    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @BigCat20196 @raych1 @msyyc