[Hub Generated] Review request for Microsoft.DocumentDB to add version preview/2022-05-15-preview (includes 2022-05-15 stable) #19290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-02-15-preview to version 2022-05-15-preview
|
Hi, @ekuhlmann23 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| compared swaggers (via Oad v0.9.6)] | new version | base version |
|---|---|---|
| cosmos-db.json | 2022-05-15(6cc136a) | 2021-10-15(main) |
| cosmos-db.json | 2022-05-15(6cc136a) | 2022-02-15(main) |
| dataTransferService.json | 2022-05-15(6cc136a) | 2022-02-15(main) |
| managedCassandra.json | 2022-05-15(6cc136a) | 2021-10-15(main) |
| managedCassandra.json | 2022-05-15(6cc136a) | 2022-02-15(main) |
| mongorbac.json | 2022-05-15(6cc136a) | 2022-02-15(main) |
| notebook.json | 2022-05-15(6cc136a) | 2021-10-15(main) |
| notebook.json | 2022-05-15(6cc136a) | 2022-02-15(main) |
| privateEndpointConnection.json | 2022-05-15(6cc136a) | 2021-10-15(main) |
| privateEndpointConnection.json | 2022-05-15(6cc136a) | 2022-02-15(main) |
| privateLinkResources.json | 2022-05-15(6cc136a) | 2021-10-15(main) |
| privateLinkResources.json | 2022-05-15(6cc136a) | 2022-02-15(main) |
| rbac.json | 2022-05-15(6cc136a) | 2021-10-15(main) |
| rbac.json | 2022-05-15(6cc136a) | 2022-02-15(main) |
| restorable.json | 2022-05-15(6cc136a) | 2021-10-15(main) |
| restorable.json | 2022-05-15(6cc136a) | 2022-02-15(main) |
| services.json | 2022-05-15(6cc136a) | 2022-02-15(main) |
| cosmos-db.json | 2022-05-15(6cc136a) | 2021-10-15(main) |
| cosmos-db.json | 2022-05-15(6cc136a) | 2022-02-15(main) |
| managedCassandra.json | 2022-05-15(6cc136a) | 2021-10-15(main) |
| managedCassandra.json | 2022-05-15(6cc136a) | 2022-02-15(main) |
| notebook.json | 2022-05-15(6cc136a) | 2021-10-15(main) |
| notebook.json | 2022-05-15(6cc136a) | 2022-02-15(main) |
| privateEndpointConnection.json | 2022-05-15(6cc136a) | 2021-10-15(main) |
| privateEndpointConnection.json | 2022-05-15(6cc136a) | 2022-02-15(main) |
| privateLinkResources.json | 2022-05-15(6cc136a) | 2021-10-15(main) |
| privateLinkResources.json | 2022-05-15(6cc136a) | 2022-02-15(main) |
| rbac.json | 2022-05-15(6cc136a) | 2021-10-15(main) |
| rbac.json | 2022-05-15(6cc136a) | 2022-02-15(main) |
| restorable.json | 2022-05-15(6cc136a) | 2021-10-15(main) |
| restorable.json | 2022-05-15(6cc136a) | 2022-02-15(main) |
| services.json | 2022-05-15(6cc136a) | 2022-02-15(main) |
The following breaking changes are detected by comparison with the latest preview version:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/graphs' removed or restructured? Old: Microsoft.DocumentDB/preview/2022-02-15-preview/cosmos-db.json#L1449:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/graphs/{graphName}' removed or restructured? Old: Microsoft.DocumentDB/preview/2022-02-15-preview/cosmos-db.json#L1485:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/sqlDatabases/{databaseName}/clientEncryptionKeys' removed or restructured? Old: Microsoft.DocumentDB/preview/2022-02-15-preview/cosmos-db.json#L1935:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/sqlDatabases/{databaseName}/clientEncryptionKeys/{clientEncryptionKeyName}' removed or restructured? Old: Microsoft.DocumentDB/preview/2022-02-15-preview/cosmos-db.json#L1974:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/sqlDatabases/{databaseName}/containers/{containerName}/partitionMerge' removed or restructured? Old: Microsoft.DocumentDB/preview/2022-02-15-preview/cosmos-db.json#L2229:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/sqlDatabases/{databaseName}/containers/{containerName}/throughputSettings/default/retrieveThroughputDistribution' removed or restructured? Old: Microsoft.DocumentDB/preview/2022-02-15-preview/cosmos-db.json#L2477:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/sqlDatabases/{databaseName}/containers/{containerName}/throughputSettings/default/redistributeThroughput' removed or restructured? Old: Microsoft.DocumentDB/preview/2022-02-15-preview/cosmos-db.json#L2538:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/mongodbDatabases/{databaseName}/collections/{collectionName}/throughputSettings/default/retrieveThroughputDistribution' removed or restructured? Old: Microsoft.DocumentDB/preview/2022-02-15-preview/cosmos-db.json#L3474:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/mongodbDatabases/{databaseName}/collections/{collectionName}/throughputSettings/default/redistributeThroughput' removed or restructured? Old: Microsoft.DocumentDB/preview/2022-02-15-preview/cosmos-db.json#L3535:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/mongodbDatabases/{databaseName}/collections/{collectionName}/partitionMerge' removed or restructured? Old: Microsoft.DocumentDB/preview/2022-02-15-preview/cosmos-db.json#L3762:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/cassandraKeyspaces/{keyspaceName}/views' removed or restructured? Old: Microsoft.DocumentDB/preview/2022-02-15-preview/cosmos-db.json#L5775:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/cassandraKeyspaces/{keyspaceName}/views/{viewName}' removed or restructured? Old: Microsoft.DocumentDB/preview/2022-02-15-preview/cosmos-db.json#L5814:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/cassandraKeyspaces/{keyspaceName}/views/{viewName}/throughputSettings/default' removed or restructured? Old: Microsoft.DocumentDB/preview/2022-02-15-preview/cosmos-db.json#L5944:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/cassandraKeyspaces/{keyspaceName}/views/{viewName}/throughputSettings/default/migrateToAutoscale' removed or restructured? Old: Microsoft.DocumentDB/preview/2022-02-15-preview/cosmos-db.json#L6033:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/cassandraKeyspaces/{keyspaceName}/views/{viewName}/throughputSettings/default/migrateToManualThroughput' removed or restructured? Old: Microsoft.DocumentDB/preview/2022-02-15-preview/cosmos-db.json#L6082:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/cassandraClusters/{clusterName}/backups' removed or restructured? Old: Microsoft.DocumentDB/preview/2022-02-15-preview/managedCassandra.json#L344:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/cassandraClusters/{clusterName}/backups/{backupId}' removed or restructured? Old: Microsoft.DocumentDB/preview/2022-02-15-preview/managedCassandra.json#L386:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/gremlinDatabases/{databaseName}/graphs/{graphName}/retrieveContinuousBackupInformation' removed or restructured? Old: Microsoft.DocumentDB/preview/2022-02-15-preview/restorable.json#L555:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.DocumentDB/locations/{location}/restorableDatabaseAccounts/{instanceId}/restorableGremlinDatabases' removed or restructured? Old: Microsoft.DocumentDB/preview/2022-02-15-preview/restorable.json#L616:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.DocumentDB/locations/{location}/restorableDatabaseAccounts/{instanceId}/restorableGraphs' removed or restructured? Old: Microsoft.DocumentDB/preview/2022-02-15-preview/restorable.json#L658:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.DocumentDB/locations/{location}/restorableDatabaseAccounts/{instanceId}/restorableGremlinResources' removed or restructured? Old: Microsoft.DocumentDB/preview/2022-02-15-preview/restorable.json#L709:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/tables/{tableName}/retrieveContinuousBackupInformation' removed or restructured? Old: Microsoft.DocumentDB/preview/2022-02-15-preview/restorable.json#L757:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.DocumentDB/locations/{location}/restorableDatabaseAccounts/{instanceId}/restorableTables' removed or restructured? Old: Microsoft.DocumentDB/preview/2022-02-15-preview/restorable.json#L815:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.DocumentDB/locations/{location}/restorableDatabaseAccounts/{instanceId}/restorableTableResources' removed or restructured? Old: Microsoft.DocumentDB/preview/2022-02-15-preview/restorable.json#L863:5 |
|
| The new version is missing a definition that was found in the old version. Was 'ClientEncryptionKeyCreateUpdateParameters' removed or renamed? New: Microsoft.DocumentDB/stable/2022-05-15/cosmos-db.json#L5125:3 Old: Microsoft.DocumentDB/preview/2022-02-15-preview/cosmos-db.json#L6132:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ClientEncryptionKeyCreateUpdateProperties' removed or renamed? New: Microsoft.DocumentDB/stable/2022-05-15/cosmos-db.json#L5125:3 Old: Microsoft.DocumentDB/preview/2022-02-15-preview/cosmos-db.json#L6132:3 |
|
| The new version is missing a definition that was found in the old version. Was 'GraphResourceCreateUpdateParameters' removed or renamed? New: Microsoft.DocumentDB/stable/2022-05-15/cosmos-db.json#L5125:3 Old: Microsoft.DocumentDB/preview/2022-02-15-preview/cosmos-db.json#L6132:3 |
|
| The new version is missing a definition that was found in the old version. Was 'GraphResourceCreateUpdateProperties' removed or renamed? New: Microsoft.DocumentDB/stable/2022-05-15/cosmos-db.json#L5125:3 Old: Microsoft.DocumentDB/preview/2022-02-15-preview/cosmos-db.json#L6132:3 |
|
| The new version is missing a definition that was found in the old version. Was 'GraphResource' removed or renamed? New: Microsoft.DocumentDB/stable/2022-05-15/cosmos-db.json#L5125:3 Old: Microsoft.DocumentDB/preview/2022-02-15-preview/cosmos-db.json#L6132:3 |
|
| The new version is missing a definition that was found in the old version. Was 'CassandraViewCreateUpdateParameters' removed or renamed? New: Microsoft.DocumentDB/stable/2022-05-15/cosmos-db.json#L5125:3 Old: Microsoft.DocumentDB/preview/2022-02-15-preview/cosmos-db.json#L6132:3 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️🔄LintDiff inProgress [Detail]
️⚠️Avocado: 2 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The JSON file has a circular reference. readme: specification/cosmos-db/resource-manager/readme.md json: Microsoft.DocumentDB/preview/2022-05-15-preview/privateEndpointConnection.json |
|
| The JSON file has a circular reference. readme: specification/cosmos-db/resource-manager/readme.md json: Microsoft.DocumentDB/stable/2022-05-15/privateEndpointConnection.json |
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️⚠️SDK Track2 Validation: 138 Warnings warning [Detail]
- The following tags are being changed in this PR
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
| "readme":"cosmos-db/resource-manager/readme.md", "tag":"package-preview-2022-05", "details":"Using directive.0.suppress which is deprecated and will be removed in the future." |
|
| "readme":"cosmos-db/resource-manager/readme.md", "tag":"package-preview-2022-05", "details":"Using directive.1.suppress which is deprecated and will be removed in the future." |
|
| "readme":"cosmos-db/resource-manager/readme.md", "tag":"package-preview-2022-05", "details":"Using directive.2.suppress which is deprecated and will be removed in the future." |
|
| "readme":"cosmos-db/resource-manager/readme.md", "tag":"package-preview-2022-05", "details":"Using directive.3.suppress which is deprecated and will be removed in the future." |
|
| "readme":"cosmos-db/resource-manager/readme.md", "tag":"package-preview-2022-05", "details":"Using directive.4.suppress which is deprecated and will be removed in the future." |
|
| "readme":"cosmos-db/resource-manager/readme.md", "tag":"package-preview-2022-05", "details":"Using directive.5.suppress which is deprecated and will be removed in the future." |
|
| "readme":"cosmos-db/resource-manager/readme.md", "tag":"package-preview-2022-05", "details":"Using directive.6.suppress which is deprecated and will be removed in the future." |
|
| "readme":"cosmos-db/resource-manager/readme.md", "tag":"package-preview-2022-05", "details":"Using directive.7.suppress which is deprecated and will be removed in the future." |
|
| "readme":"cosmos-db/resource-manager/readme.md", "tag":"package-preview-2022-05", "details":"Using directive.8.suppress which is deprecated and will be removed in the future." |
|
| "readme":"cosmos-db/resource-manager/readme.md", "tag":"package-preview-2022-05", "details":"Using directive.9.suppress which is deprecated and will be removed in the future." |
|
| "readme":"cosmos-db/resource-manager/readme.md", "tag":"package-preview-2022-05", "details":"Using directive.10.suppress which is deprecated and will be removed in the future." |
|
| "readme":"cosmos-db/resource-manager/readme.md", "tag":"package-preview-2022-05", "details":"Using directive.11.suppress which is deprecated and will be removed in the future." |
|
| "readme":"cosmos-db/resource-manager/readme.md", "tag":"package-preview-2022-05", "details":"Using directive.12.suppress which is deprecated and will be removed in the future." |
|
| "readme":"cosmos-db/resource-manager/readme.md", "tag":"package-preview-2022-05", "details":"Using directive.13.suppress which is deprecated and will be removed in the future." |
|
| "readme":"cosmos-db/resource-manager/readme.md", "tag":"package-preview-2022-05", "details":"Using directive.14.suppress which is deprecated and will be removed in the future." |
|
| "readme":"cosmos-db/resource-manager/readme.md", "tag":"package-preview-2022-05", "details":"Using directive.15.suppress which is deprecated and will be removed in the future." |
|
| "readme":"cosmos-db/resource-manager/readme.md", "tag":"package-preview-2022-05", "details":"Using directive.16.suppress which is deprecated and will be removed in the future." |
|
| "readme":"cosmos-db/resource-manager/readme.md", "tag":"package-preview-2022-05", "details":"Using directive.17.suppress which is deprecated and will be removed in the future." |
|
| "readme":"cosmos-db/resource-manager/readme.md", "tag":"package-preview-2022-05", "details":"Using directive.18.suppress which is deprecated and will be removed in the future." |
|
| "readme":"cosmos-db/resource-manager/readme.md", "tag":"package-preview-2022-05", "details":"Using directive.19.suppress which is deprecated and will be removed in the future." |
|
| "readme":"cosmos-db/resource-manager/readme.md", "tag":"package-preview-2022-05", "details":"Using directive.20.suppress which is deprecated and will be removed in the future." |
|
| "readme":"cosmos-db/resource-manager/readme.md", "tag":"package-preview-2022-05", "details":"Using directive.21.suppress which is deprecated and will be removed in the future." |
|
| "readme":"cosmos-db/resource-manager/readme.md", "tag":"package-preview-2022-05", "details":"Using directive.22.suppress which is deprecated and will be removed in the future." |
|
| "readme":"cosmos-db/resource-manager/readme.md", "tag":"package-preview-2022-05", "details":"Using directive.23.suppress which is deprecated and will be removed in the future." |
|
| "readme":"cosmos-db/resource-manager/readme.md", "tag":"package-preview-2022-05", "details":"Using directive.24.suppress which is deprecated and will be removed in the future." |
|
| "readme":"cosmos-db/resource-manager/readme.md", "tag":"package-preview-2022-05", "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > DatabaseAccountGetProperties > properties > apiProperties)\n keys: [ \u001b[32m'type'\u001b[39m ]" |
|
| "readme":"cosmos-db/resource-manager/readme.md", "tag":"package-preview-2022-05", "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > DatabaseAccountGetProperties > properties > analyticalStorageConfiguration)\n keys: [ \u001b[32m'type'\u001b[39m ]" |
|
| "readme":"cosmos-db/resource-manager/readme.md", "tag":"package-preview-2022-05", "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > DatabaseAccountGetProperties > properties > createMode)\n keys: [ \u001b[32m'type'\u001b[39m, \u001b[32m'default'\u001b[39m ]" |
|
| "readme":"cosmos-db/resource-manager/readme.md", "tag":"package-preview-2022-05", "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > DatabaseAccountGetProperties > properties > restoreParameters)\n keys: [ \u001b[32m'type'\u001b[39m ]" |
|
| "readme":"cosmos-db/resource-manager/readme.md", "tag":"package-preview-2022-05", "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > DatabaseAccountGetProperties > properties > backupPolicy)\n keys: [ \u001b[32m'type'\u001b[39m ]" |
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
Swagger Generation Artifacts
|
openapi-workflow-bot
bot
added
ARMReview
WaitForARMFeedback
|
Hi, @ekuhlmann23 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
|
Hi @ekuhlmann23, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced May 31, 2022
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
added 2 commits
June 1, 2022 15:32
ekuhlmann23
changed the title
|
@msyyc Could you pls take a look at python sdk generation failure? |
|
Hi @ekuhlmann23 There are two many duplication in new tag, please check the swagger definition: |
|
Looking into this. However, I don't seem to find where this is coming from, as there are a lot of duplication errors. Could it related to the fact I have included the 2022-05-15 stable version as well as the 2022-05-15-preview version in the same PR? |
added 2 commits
June 23, 2022 11:24
|
Fixed the python errors, was related to an incorrect line in the README. Should be good to go! |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@leni-msft could you please merge the PR? Thanks! |
leni-msft
approved these changes
Jun 27, 2022
This was referenced Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.