-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{OperationalInsight} Ingestion value was removed from the DataSourceT… #19365
Conversation
…ype enum The API version 2020-03-01-preview supported DataSourceType enum with 'Ingestion' as one of the valid values for log analytics linked storage account. However, this value was removed in 2020-08-01 leading to 'Invalid value' error when storage accounts are linked to a workspace where the data source type is specified as Ingestion.
Hi, @navba-MSFT Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
1 similar comment
Hi, @navba-MSFT Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
Rule | Message |
---|---|
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L75 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L75 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L75 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L75 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L112 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L112 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L112 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L112 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L146 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L146 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L146 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L146 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L177 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L177 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L177 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L177 |
R4011 - DeleteOperationResponses |
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L112 |
R4011 - DeleteOperationResponses |
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L112 |
R4011 - DeleteOperationResponses |
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L112 |
R4011 - DeleteOperationResponses |
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L112 |
R4037 - MissingTypeObject |
The schema 'LinkedStorageAccountsResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L226 |
R4037 - MissingTypeObject |
The schema 'LinkedStorageAccountsResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L226 |
R4037 - MissingTypeObject |
The schema 'LinkedStorageAccountsResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L226 |
R4037 - MissingTypeObject |
The schema 'LinkedStorageAccountsResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L226 |
R4037 - MissingTypeObject |
The schema 'LinkedStorageAccountsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L244 |
R4037 - MissingTypeObject |
The schema 'LinkedStorageAccountsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L244 |
R4037 - MissingTypeObject |
The schema 'LinkedStorageAccountsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L244 |
R4037 - MissingTypeObject |
The schema 'LinkedStorageAccountsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L244 |
The response of operation:'LinkedStorageAccounts_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L38 |
|
The response of operation:'LinkedStorageAccounts_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L118 |
️⚠️
Avocado: 1 Warnings warning [Detail]
Rule | Message |
---|---|
The default tag contains multiple API versions swaggers. readme: specification/operationalinsights/resource-manager/readme.md tag: specification/operationalinsights/resource-manager/readme.md#tag-package-2022-02 |
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
- operationalinsights/resource-manager/readme.md#package-2021-12-01-preview
- operationalinsights/resource-manager/readme.md#package-2020-08
- operationalinsights/resource-manager/readme.md#package-2020-10
- operationalinsights/resource-manager/readme.md#package-2021-06
- operationalinsights/resource-manager/readme.md#package-2022-02
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
@yoramsinger Could you please review this PR once you get a chance ? |
Looks fine. |
@yoramsinger @yossi-y @OlegAnaniev-MSFT Thanks for approving this. Could you please merge this once you get a chance ? Thanks in advance. |
@akning-ms can you help us merge this fix, the actual API supports this additional enum, but for some reason it was not added in this version. |
…ype enum
The API version 2020-03-01-preview supported DataSourceType enum with 'Ingestion' as one of the valid values for log analytics linked storage account.
However, this value was removed in 2020-08-01 leading to 'Invalid value' error when storage accounts are linked to a workspace where the data source type is specified as Ingestion.
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.
fixes Azure/azure-sdk-for-go#18322