Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Microsoft.Security\Pricing API Documentation #19439

Merged

Conversation

rejoron
Copy link
Contributor

@rejoron rejoron commented Jun 14, 2022

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @rejoron Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 14, 2022

    Swagger Validation Report

    ️❌BreakingChange: 4 Errors, 0 Warnings failed [Detail]
    Rule Message
    1040 - AddedReadOnlyPropertyInResponse The new version has a new read-only property 'deprecated' in response that was not found in the old version.
    New: Microsoft.Security/stable/2022-03-01/pricings.json#L188:7
    Old: Microsoft.Security/stable/2022-03-01/pricings.json#L188:7
    1040 - AddedReadOnlyPropertyInResponse The new version has a new read-only property 'replacedBy' in response that was not found in the old version.
    New: Microsoft.Security/stable/2022-03-01/pricings.json#L188:7
    Old: Microsoft.Security/stable/2022-03-01/pricings.json#L188:7
    1045 - AddedOptionalProperty The new version has a new optional property 'deprecated' that was not found in the old version.
    New: Microsoft.Security/stable/2022-03-01/pricings.json#L188:7
    Old: Microsoft.Security/stable/2022-03-01/pricings.json#L188:7
    1045 - AddedOptionalProperty The new version has a new optional property 'replacedBy' that was not found in the old version.
    New: Microsoft.Security/stable/2022-03-01/pricings.json#L188:7
    Old: Microsoft.Security/stable/2022-03-01/pricings.json#L188:7
    ️⚠️LintDiff: 1 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: deprecated
    Location: Microsoft.Security/stable/2022-03-01/pricings.json#L221


    The following errors/warnings exist before current PR submission:

    Rule Message
    R4037 - MissingTypeObject The schema 'PricingList' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Security/stable/2022-03-01/pricings.json#L154
    ⚠️ R1006 - PutInOperationName 'PUT' operation 'Pricings_Update' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Security/stable/2022-03-01/pricings.json#L121
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'Pricings_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.Security/stable/2022-03-01/pricings.json#L38
    ⚠️ R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get pricings on subscription
    Location: Microsoft.Security/stable/2022-03-01/pricings.json#L75
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/security/resource-manager/readme.md
    tag: specification/security/resource-manager/readme.md#tag-package-composite-v3
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 14, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 63312d0. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armsecurity [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog] - New struct `ConnectorApplicationClientCreateOrUpdateOptions`
      info	[Changelog] - New struct `ConnectorApplicationClientCreateOrUpdateResponse`
      info	[Changelog] - New struct `ConnectorApplicationClientDeleteOptions`
      info	[Changelog] - New struct `ConnectorApplicationClientDeleteResponse`
      info	[Changelog] - New struct `ConnectorApplicationClientGetOptions`
      info	[Changelog] - New struct `ConnectorApplicationClientGetResponse`
      info	[Changelog] - New struct `ConnectorApplicationsClient`
      info	[Changelog] - New struct `ConnectorApplicationsClientListOptions`
      info	[Changelog] - New struct `ConnectorApplicationsClientListResponse`
      info	[Changelog] - New struct `ConnectorGovernanceRuleClient`
      info	[Changelog] - New struct `ConnectorGovernanceRuleClientListOptions`
      info	[Changelog] - New struct `ConnectorGovernanceRuleClientListResponse`
      info	[Changelog] - New struct `ConnectorGovernanceRulesClient`
      info	[Changelog] - New struct `ConnectorGovernanceRulesClientCreateOrUpdateOptions`
      info	[Changelog] - New struct `ConnectorGovernanceRulesClientCreateOrUpdateResponse`
      info	[Changelog] - New struct `ConnectorGovernanceRulesClientDeleteOptions`
      info	[Changelog] - New struct `ConnectorGovernanceRulesClientDeleteResponse`
      info	[Changelog] - New struct `ConnectorGovernanceRulesClientGetOptions`
      info	[Changelog] - New struct `ConnectorGovernanceRulesClientGetResponse`
      info	[Changelog] - New struct `ConnectorGovernanceRulesExecuteStatusClient`
      info	[Changelog] - New struct `ConnectorGovernanceRulesExecuteStatusClientBeginGetOptions`
      info	[Changelog] - New struct `ConnectorGovernanceRulesExecuteStatusClientGetResponse`
      info	[Changelog] - New struct `CspmMonitorAzureDevOpsOffering`
      info	[Changelog] - New struct `CspmMonitorGcpOffering`
      info	[Changelog] - New struct `CspmMonitorGcpOfferingNativeCloudConnection`
      info	[Changelog] - New struct `CspmMonitorGithubOffering`
      info	[Changelog] - New struct `DefenderFoDatabasesAwsOffering`
      info	[Changelog] - New struct `DefenderFoDatabasesAwsOfferingArcAutoProvisioning`
      info	[Changelog] - New struct `DefenderFoDatabasesAwsOfferingArcAutoProvisioningServicePrincipalSecretMetadata`
      info	[Changelog] - New struct `DefenderForContainersAwsOfferingContainerVulnerabilityAssessment`
      info	[Changelog] - New struct `DefenderForContainersAwsOfferingContainerVulnerabilityAssessmentTask`
      info	[Changelog] - New struct `DefenderForContainersGcpOffering`
      info	[Changelog] - New struct `DefenderForContainersGcpOfferingDataPipelineNativeCloudConnection`
      info	[Changelog] - New struct `DefenderForContainersGcpOfferingNativeCloudConnection`
      info	[Changelog] - New struct `DefenderForDatabasesGcpOffering`
      info	[Changelog] - New struct `DefenderForDatabasesGcpOfferingArcAutoProvisioning`
      info	[Changelog] - New struct `DefenderForDatabasesGcpOfferingArcAutoProvisioningConfiguration`
      info	[Changelog] - New struct `DefenderForDatabasesGcpOfferingDefenderForDatabasesArcAutoProvisioning`
      info	[Changelog] - New struct `DefenderForServersAwsOfferingMdeAutoProvisioning`
      info	[Changelog] - New struct `DefenderForServersAwsOfferingSubPlan`
      info	[Changelog] - New struct `DefenderForServersAwsOfferingVMScanners`
      info	[Changelog] - New struct `DefenderForServersAwsOfferingVMScannersConfiguration`
      info	[Changelog] - New struct `DefenderForServersAwsOfferingVaAutoProvisioning`
      info	[Changelog] - New struct `DefenderForServersAwsOfferingVaAutoProvisioningConfiguration`
      info	[Changelog] - New struct `DefenderForServersGcpOffering`
      info	[Changelog] - New struct `DefenderForServersGcpOfferingArcAutoProvisioning`
      info	[Changelog] - New struct `DefenderForServersGcpOfferingArcAutoProvisioningConfiguration`
      info	[Changelog] - New struct `DefenderForServersGcpOfferingDefenderForServers`
      info	[Changelog] - New struct `DefenderForServersGcpOfferingMdeAutoProvisioning`
      info	[Changelog] - New struct `DefenderForServersGcpOfferingSubPlan`
      info	[Changelog] - New struct `DefenderForServersGcpOfferingVaAutoProvisioning`
      info	[Changelog] - New struct `DefenderForServersGcpOfferingVaAutoProvisioningConfiguration`
      info	[Changelog] - New struct `EnvironmentData`
      info	[Changelog] - New struct `ExecuteGovernanceRuleParams`
      info	[Changelog] - New struct `ExecuteRuleStatus`
      info	[Changelog] - New struct `GcpOrganizationalData`
      info	[Changelog] - New struct `GcpOrganizationalDataMember`
      info	[Changelog] - New struct `GcpOrganizationalDataOrganization`
      info	[Changelog] - New struct `GcpProjectDetails`
      info	[Changelog] - New struct `GcpProjectEnvironmentData`
      info	[Changelog] - New struct `GithubScopeEnvironmentData`
      info	[Changelog] - New struct `GovernanceAssignment`
      info	[Changelog] - New struct `GovernanceAssignmentAdditionalData`
      info	[Changelog] - New struct `GovernanceAssignmentProperties`
      info	[Changelog] - New struct `GovernanceAssignmentsClient`
      info	[Changelog] - New struct `GovernanceAssignmentsClientCreateOrUpdateOptions`
      info	[Changelog] - New struct `GovernanceAssignmentsClientCreateOrUpdateResponse`
      info	[Changelog] - New struct `GovernanceAssignmentsClientDeleteOptions`
      info	[Changelog] - New struct `GovernanceAssignmentsClientDeleteResponse`
      info	[Changelog] - New struct `GovernanceAssignmentsClientGetOptions`
      info	[Changelog] - New struct `GovernanceAssignmentsClientGetResponse`
      info	[Changelog] - New struct `GovernanceAssignmentsClientListOptions`
      info	[Changelog] - New struct `GovernanceAssignmentsClientListResponse`
      info	[Changelog] - New struct `GovernanceAssignmentsList`
      info	[Changelog] - New struct `GovernanceEmailNotification`
      info	[Changelog] - New struct `GovernanceRule`
      info	[Changelog] - New struct `GovernanceRuleClient`
      info	[Changelog] - New struct `GovernanceRuleClientListOptions`
      info	[Changelog] - New struct `GovernanceRuleClientListResponse`
      info	[Changelog] - New struct `GovernanceRuleEmailNotification`
      info	[Changelog] - New struct `GovernanceRuleList`
      info	[Changelog] - New struct `GovernanceRuleOwnerSource`
      info	[Changelog] - New struct `GovernanceRuleProperties`
      info	[Changelog] - New struct `GovernanceRulesClient`
      info	[Changelog] - New struct `GovernanceRulesClientBeginRuleIDExecuteSingleSecurityConnectorOptions`
      info	[Changelog] - New struct `GovernanceRulesClientBeginRuleIDExecuteSingleSubscriptionOptions`
      info	[Changelog] - New struct `GovernanceRulesClientCreateOrUpdateOptions`
      info	[Changelog] - New struct `GovernanceRulesClientCreateOrUpdateResponse`
      info	[Changelog] - New struct `GovernanceRulesClientDeleteOptions`
      info	[Changelog] - New struct `GovernanceRulesClientDeleteResponse`
      info	[Changelog] - New struct `GovernanceRulesClientGetOptions`
      info	[Changelog] - New struct `GovernanceRulesClientGetResponse`
      info	[Changelog] - New struct `GovernanceRulesClientRuleIDExecuteSingleSecurityConnectorResponse`
      info	[Changelog] - New struct `GovernanceRulesClientRuleIDExecuteSingleSubscriptionResponse`
      info	[Changelog] - New struct `RemediationEta`
      info	[Changelog] - New struct `SubscriptionGovernanceRulesExecuteStatusClient`
      info	[Changelog] - New struct `SubscriptionGovernanceRulesExecuteStatusClientBeginGetOptions`
      info	[Changelog] - New struct `SubscriptionGovernanceRulesExecuteStatusClientGetResponse`
      info	[Changelog] - New field `HierarchyIdentifierTrialEndDate` in struct `ConnectorProperties`
      info	[Changelog] - New field `EnvironmentData` in struct `ConnectorProperties`
      info	[Changelog] - New field `EnvironmentName` in struct `ConnectorProperties`
      info	[Changelog] - New field `ScubaExternalID` in struct `DefenderForContainersAwsOffering`
      info	[Changelog] - New field `AutoProvisioning` in struct `DefenderForContainersAwsOffering`
      info	[Changelog] - New field `ContainerVulnerabilityAssessment` in struct `DefenderForContainersAwsOffering`
      info	[Changelog] - New field `KubeAuditRetentionTime` in struct `DefenderForContainersAwsOffering`
      info	[Changelog] - New field `ContainerVulnerabilityAssessmentTask` in struct `DefenderForContainersAwsOffering`
      info	[Changelog] - New field `EnableContainerVulnerabilityAssessment` in struct `DefenderForContainersAwsOffering`
      info	[Changelog] - New field `CloudRoleArn` in struct `DefenderForServersAwsOfferingArcAutoProvisioning`
      info	[Changelog] - New field `SubTechniques` in struct `AlertProperties`
      info	[Changelog] - New field `Version` in struct `AlertProperties`
      info	[Changelog] - New field `Techniques` in struct `AlertProperties`
      info	[Changelog] - New field `SupportingEvidence` in struct `AlertProperties`
      info	[Changelog] - New field `SubPlan` in struct `DefenderForServersAwsOffering`
      info	[Changelog] - New field `VMScanners` in struct `DefenderForServersAwsOffering`
      info	[Changelog] - New field `VaAutoProvisioning` in struct `DefenderForServersAwsOffering`
      info	[Changelog] - New field `MdeAutoProvisioning` in struct `DefenderForServersAwsOffering`
      info	[Changelog] - New field `Deprecated` in struct `PricingProperties`
      info	[Changelog] - New field `ReplacedBy` in struct `PricingProperties`
      info	[Changelog]
      info	[Changelog] Total 8 breaking change(s), 356 additive change(s).
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 63312d0. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-security [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog]   - Added Interface SecureScoreControlDefinitionItem
      info	[Changelog]   - Added Interface SecureScoreControlDetails
      info	[Changelog]   - Added Interface SecureScoreItem
      info	[Changelog]   - Added Interface SecurityAssessment
      info	[Changelog]   - Added Interface SecurityAssessmentMetadata
      info	[Changelog]   - Added Interface SecurityAssessmentMetadataPropertiesResponse
      info	[Changelog]   - Added Interface SecurityAssessmentMetadataResponse
      info	[Changelog]   - Added Interface SecurityAssessmentProperties
      info	[Changelog]   - Added Interface SecurityAssessmentPropertiesResponse
      info	[Changelog]   - Added Interface SecurityAssessmentResponse
      info	[Changelog]   - Added Interface SecurityConnector
      info	[Changelog]   - Added Interface SecurityConnectorApplicationCreateOrUpdateOptionalParams
      info	[Changelog]   - Added Interface SecurityConnectorApplicationDeleteOptionalParams
      info	[Changelog]   - Added Interface SecurityConnectorApplicationGetOptionalParams
      info	[Changelog]   - Added Interface SecurityConnectorApplicationsListNextOptionalParams
      info	[Changelog]   - Added Interface SecurityConnectorApplicationsListOptionalParams
      info	[Changelog]   - Added Interface SecurityConnectorGovernanceRuleListNextOptionalParams
      info	[Changelog]   - Added Interface SecurityConnectorGovernanceRuleListOptionalParams
      info	[Changelog]   - Added Interface SecurityConnectorGovernanceRulesCreateOrUpdateOptionalParams
      info	[Changelog]   - Added Interface SecurityConnectorGovernanceRulesDeleteOptionalParams
      info	[Changelog]   - Added Interface SecurityConnectorGovernanceRulesExecuteStatusGetHeaders
      info	[Changelog]   - Added Interface SecurityConnectorGovernanceRulesExecuteStatusGetOptionalParams
      info	[Changelog]   - Added Interface SecurityConnectorGovernanceRulesGetOptionalParams
      info	[Changelog]   - Added Interface SecurityContact
      info	[Changelog]   - Added Interface SecuritySolution
      info	[Changelog]   - Added Interface SecuritySolutionsReferenceData
      info	[Changelog]   - Added Interface SecuritySubAssessment
      info	[Changelog]   - Added Interface SecurityTask
      info	[Changelog]   - Added Interface ServerVulnerabilityAssessment
      info	[Changelog]   - Added Interface ServerVulnerabilityProperties
      info	[Changelog]   - Added Interface Setting
      info	[Changelog]   - Added Interface Software
      info	[Changelog]   - Added Interface SqlServerVulnerabilityProperties
      info	[Changelog]   - Added Interface SubscriptionGovernanceRulesExecuteStatusGetHeaders
      info	[Changelog]   - Added Interface SubscriptionGovernanceRulesExecuteStatusGetOptionalParams
      info	[Changelog]   - Added Interface ThresholdCustomAlertRule
      info	[Changelog]   - Added Interface TimeWindowCustomAlertRule
      info	[Changelog]   - Added Interface TopologyResource
      info	[Changelog]   - Added Interface TrackedResource
      info	[Changelog]   - Added Interface TwinUpdatesNotInAllowedRange
      info	[Changelog]   - Added Interface UnauthorizedOperationsNotInAllowedRange
      info	[Changelog]   - Added Interface UpdateIotSecuritySolutionData
      info	[Changelog]   - Added Interface WorkspaceSetting
      info	[Changelog]   - Added Type Alias ApplicationConditionOperator
      info	[Changelog]   - Added Type Alias ApplicationCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias ApplicationGetResponse
      info	[Changelog]   - Added Type Alias ApplicationsListNextResponse
      info	[Changelog]   - Added Type Alias ApplicationsListResponse
      info	[Changelog]   - Added Type Alias ApplicationSourceResourceType
      info	[Changelog]   - Added Type Alias AwsOrganizationalDataUnion
      info	[Changelog]   - Added Type Alias EnvironmentDataUnion
      info	[Changelog]   - Added Type Alias EnvironmentType
      info	[Changelog]   - Added Type Alias GcpOrganizationalDataUnion
      info	[Changelog]   - Added Type Alias GovernanceAssignmentsCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias GovernanceAssignmentsGetResponse
      info	[Changelog]   - Added Type Alias GovernanceAssignmentsListNextResponse
      info	[Changelog]   - Added Type Alias GovernanceAssignmentsListResponse
      info	[Changelog]   - Added Type Alias GovernanceRuleConditionOperator
      info	[Changelog]   - Added Type Alias GovernanceRuleListNextResponse
      info	[Changelog]   - Added Type Alias GovernanceRuleListResponse
      info	[Changelog]   - Added Type Alias GovernanceRuleOwnerSourceType
      info	[Changelog]   - Added Type Alias GovernanceRulesCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias GovernanceRulesGetResponse
      info	[Changelog]   - Added Type Alias GovernanceRuleSourceResourceType
      info	[Changelog]   - Added Type Alias GovernanceRulesRuleIdExecuteSingleSecurityConnectorResponse
      info	[Changelog]   - Added Type Alias GovernanceRulesRuleIdExecuteSingleSubscriptionResponse
      info	[Changelog]   - Added Type Alias GovernanceRuleType
      info	[Changelog]   - Added Type Alias ScanningMode
      info	[Changelog]   - Added Type Alias SecurityConnectorApplicationCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias SecurityConnectorApplicationGetResponse
      info	[Changelog]   - Added Type Alias SecurityConnectorApplicationsListNextResponse
      info	[Changelog]   - Added Type Alias SecurityConnectorApplicationsListResponse
      info	[Changelog]   - Added Type Alias SecurityConnectorGovernanceRuleListNextResponse
      info	[Changelog]   - Added Type Alias SecurityConnectorGovernanceRuleListResponse
      info	[Changelog]   - Added Type Alias SecurityConnectorGovernanceRulesCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias SecurityConnectorGovernanceRulesExecuteStatusGetResponse
      info	[Changelog]   - Added Type Alias SecurityConnectorGovernanceRulesGetResponse
      info	[Changelog]   - Added Type Alias SubPlan
      info	[Changelog]   - Added Type Alias SubscriptionGovernanceRulesExecuteStatusGetResponse
      info	[Changelog]   - Added Type Alias Type
      info	[Changelog]   - Interface AlertsSimulateOptionalParams has a new optional parameter resumeFrom
      info	[Changelog]   - Interface AlertsSimulateOptionalParams has a new optional parameter updateIntervalInMs
      info	[Changelog]   - Interface DefenderForServersAwsOfferingArcAutoProvisioning has a new optional parameter cloudRoleArn
      info	[Changelog]   - Class SecurityCenter has a new parameter applicationOperations
      info	[Changelog]   - Class SecurityCenter has a new parameter applications
      info	[Changelog]   - Class SecurityCenter has a new parameter governanceAssignments
      info	[Changelog]   - Class SecurityCenter has a new parameter governanceRuleOperations
      info	[Changelog]   - Class SecurityCenter has a new parameter governanceRules
      info	[Changelog]   - Class SecurityCenter has a new parameter securityConnectorApplication
      info	[Changelog]   - Class SecurityCenter has a new parameter securityConnectorApplications
      info	[Changelog]   - Class SecurityCenter has a new parameter securityConnectorGovernanceRule
      info	[Changelog]   - Class SecurityCenter has a new parameter securityConnectorGovernanceRules
      info	[Changelog]   - Class SecurityCenter has a new parameter securityConnectorGovernanceRulesExecuteStatus
      info	[Changelog]   - Class SecurityCenter has a new parameter subscriptionGovernanceRulesExecuteStatus
      info	[Changelog]   - Added Enum KnownApplicationConditionOperator
      info	[Changelog]   - Added Enum KnownApplicationSourceResourceType
      info	[Changelog]   - Added Enum KnownEnvironmentType
      info	[Changelog]   - Added Enum KnownGovernanceRuleConditionOperator
      info	[Changelog]   - Added Enum KnownGovernanceRuleOwnerSourceType
      info	[Changelog]   - Added Enum KnownGovernanceRuleSourceResourceType
      info	[Changelog]   - Added Enum KnownGovernanceRuleType
      info	[Changelog]   - Added Enum KnownScanningMode
      info	[Changelog]   - Added Enum KnownSubPlan
      info	[Changelog]   - Added Enum KnownType
      info	[Changelog]   - Enum KnownAlertStatus has a new value InProgress
      info	[Changelog]   - Enum KnownBundleType has a new value CosmosDbs
      info	[Changelog]   - Enum KnownCloudName has a new value AzureDevOps
      info	[Changelog]   - Enum KnownCloudName has a new value Github
      info	[Changelog]   - Enum KnownOfferingType has a new value CspmMonitorAzureDevOps
      info	[Changelog]   - Enum KnownOfferingType has a new value CspmMonitorGcp
      info	[Changelog]   - Enum KnownOfferingType has a new value CspmMonitorGithub
      info	[Changelog]   - Enum KnownOfferingType has a new value DefenderForContainersGcp
      info	[Changelog]   - Enum KnownOfferingType has a new value DefenderForDatabasesAws
      info	[Changelog]   - Enum KnownOfferingType has a new value DefenderForDatabasesGcp
      info	[Changelog]   - Enum KnownOfferingType has a new value DefenderForServersGcp
      info	[Changelog]   - Enum KnownSettingName has a new value WdatpUnifiedSolution
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Removed operation Alerts.simulate
    ️❌ azure-sdk-for-net failed [Detail]
    • Failed [Logs]Release - Generate from 63312d0. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-6.0
      command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/security/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] FATAL: System.InvalidOperationException: Values specified by 'enum' mismatch those specified by 'x-ms-enum' (name: 'ApplicationConditionOperator'): 'Equals', 'In' vs 'Contains', 'In'
      cmderr	[Autorest]    at AutoRest.Modeler.ObjectBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/ObjectBuilder.cs:line 132
      cmderr	[Autorest]    at AutoRest.Modeler.SchemaBuilder.ParentBuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 217
      cmderr	[Autorest]    at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 48
      cmderr	[Autorest]    at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 133
      cmderr	[Autorest]    at AutoRest.Modeler.ObjectBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/ObjectBuilder.cs:line 182
      cmderr	[Autorest]    at AutoRest.Modeler.SchemaBuilder.ParentBuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 217
      cmderr	[Autorest]    at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 48
      cmderr	[Autorest]    at AutoRest.Modeler.SwaggerModeler.BuildCompositeTypes() in /opt/vsts/work/1/s/src/SwaggerModeler.cs:line 348
      cmderr	[Autorest]    at AutoRest.Modeler.SwaggerModeler.Build(ServiceDefinition serviceDefinition) in /opt/vsts/work/1/s/src/SwaggerModeler.cs:line 66
      cmderr	[Autorest]    at AutoRest.Modeler.Program.<ProcessInternal>d2.MoveNext() in /opt/vsts/work/1/s/src/Program.cs:line 60
      cmderr	[Autorest] --- End of stack trace from previous location where exception was thrown ---
      cmderr	[Autorest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
      cmderr	[Autorest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
      cmderr	[Autorest]    at NewPlugin.<Process>d15.MoveNext()
      cmderr	[Autorest] FATAL: csharp/imodeler1 - FAILED
      cmderr	[Autorest] FATAL: Error: Plugin imodeler1 reported failure.
      cmderr	[Autorest]   Error: Plugin imodeler1 reported failure.
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
      warn	Skip package processing as generation is failed
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 63312d0. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
      cmderr	[automation_generate.sh] notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.11.0 -> 8.16.0
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.16.0>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.16.0` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-security [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation AlertsOperations.begin_simulate
      info	[Changelog]   - Added operation AlertsOperations.get_resource_group_level
      info	[Changelog]   - Added operation AlertsOperations.get_subscription_level
      info	[Changelog]   - Added operation AlertsOperations.list_resource_group_level_by_region
      info	[Changelog]   - Added operation AlertsOperations.list_subscription_level_by_region
      info	[Changelog]   - Added operation AlertsOperations.update_resource_group_level_state_to_activate
      info	[Changelog]   - Added operation AlertsOperations.update_resource_group_level_state_to_dismiss
      info	[Changelog]   - Added operation AlertsOperations.update_subscription_level_state_to_activate
      info	[Changelog]   - Added operation AlertsOperations.update_subscription_level_state_to_dismiss
      info	[Changelog]   - Added operation ServerVulnerabilityAssessmentOperations.begin_delete
      info	[Changelog]   - Added operation group IngestionSettingsOperations
      info	[Changelog]   - Added operation group SoftwareInventoriesOperations
      info	[Changelog]   - Model IoTSecuritySolutionModel has a new parameter additional_workspaces
      info	[Changelog]   - Model IoTSecuritySolutionModel has a new parameter system_data
      info	[Changelog]   - Model SecurityAssessmentMetadata has a new parameter categories
      info	[Changelog]   - Model SecurityAssessmentMetadataProperties has a new parameter categories
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Client name is changed
      info	[Changelog]   - Model SecurityAssessmentMetadata no longer has parameter category
      info	[Changelog]   - Model SecurityAssessmentMetadataProperties no longer has parameter category
      info	[Changelog]   - Operation AdaptiveApplicationControlsOperations.delete has a new parameter asc_location
      info	[Changelog]   - Operation AdaptiveApplicationControlsOperations.get has a new parameter asc_location
      info	[Changelog]   - Operation AdaptiveApplicationControlsOperations.put has a new parameter asc_location
      info	[Changelog]   - Operation AlertsOperations.update_resource_group_level_state_to_resolve has a new parameter asc_location
      info	[Changelog]   - Operation AlertsOperations.update_subscription_level_state_to_resolve has a new parameter asc_location
      info	[Changelog]   - Operation AllowedConnectionsOperations.get has a new parameter asc_location
      info	[Changelog]   - Operation AllowedConnectionsOperations.list_by_home_region has a new parameter asc_location
      info	[Changelog]   - Operation DiscoveredSecuritySolutionsOperations.get has a new parameter asc_location
      info	[Changelog]   - Operation DiscoveredSecuritySolutionsOperations.list_by_home_region has a new parameter asc_location
      info	[Changelog]   - Operation ExternalSecuritySolutionsOperations.get has a new parameter asc_location
      info	[Changelog]   - Operation ExternalSecuritySolutionsOperations.list_by_home_region has a new parameter asc_location
      info	[Changelog]   - Operation JitNetworkAccessPoliciesOperations.create_or_update has a new parameter asc_location
      info	[Changelog]   - Operation JitNetworkAccessPoliciesOperations.delete has a new parameter asc_location
      info	[Changelog]   - Operation JitNetworkAccessPoliciesOperations.get has a new parameter asc_location
      info	[Changelog]   - Operation JitNetworkAccessPoliciesOperations.initiate has a new parameter asc_location
      info	[Changelog]   - Operation JitNetworkAccessPoliciesOperations.list_by_region has a new parameter asc_location
      info	[Changelog]   - Operation JitNetworkAccessPoliciesOperations.list_by_resource_group_and_region has a new parameter asc_location
      info	[Changelog]   - Operation LocationsOperations.get has a new parameter asc_location
      info	[Changelog]   - Operation SecuritySolutionsOperations.get has a new parameter asc_location
      info	[Changelog]   - Operation SecuritySolutionsReferenceDataOperations.list_by_home_region has a new parameter asc_location
      info	[Changelog]   - Operation TasksOperations.get_resource_group_level_task has a new parameter asc_location
      info	[Changelog]   - Operation TasksOperations.get_subscription_level_task has a new parameter asc_location
      info	[Changelog]   - Operation TasksOperations.list_by_home_region has a new parameter asc_location
      info	[Changelog]   - Operation TasksOperations.list_by_resource_group has a new parameter asc_location
      info	[Changelog]   - Operation TasksOperations.update_resource_group_level_task_state has a new parameter asc_location
      info	[Changelog]   - Operation TasksOperations.update_subscription_level_task_state has a new parameter asc_location
      info	[Changelog]   - Operation TopologyOperations.get has a new parameter asc_location
      info	[Changelog]   - Operation TopologyOperations.list_by_home_region has a new parameter asc_location
      info	[Changelog]   - Removed operation AlertsOperations.get_resource_group_level_alerts
      info	[Changelog]   - Removed operation AlertsOperations.get_subscription_level_alert
      info	[Changelog]   - Removed operation AlertsOperations.list_resource_group_level_alerts_by_region
      info	[Changelog]   - Removed operation AlertsOperations.list_subscription_level_alerts_by_region
      info	[Changelog]   - Removed operation AlertsOperations.update_resource_group_level_alert_state_to_dismiss
      info	[Changelog]   - Removed operation AlertsOperations.update_resource_group_level_alert_state_to_reactivate
      info	[Changelog]   - Removed operation AlertsOperations.update_subscription_level_alert_state_to_dismiss
      info	[Changelog]   - Removed operation AlertsOperations.update_subscription_level_alert_state_to_reactivate
      info	[Changelog]   - Removed operation ServerVulnerabilityAssessmentOperations.delete
      info	[Changelog]   - Removed operation group DeviceOperations
      info	[Changelog]   - Removed operation group DevicesForHubOperations
      info	[Changelog]   - Removed operation group DevicesForSubscriptionOperations
      info	[Changelog]   - Removed operation group IotAlertTypesOperations
      info	[Changelog]   - Removed operation group IotAlertsOperations
      info	[Changelog]   - Removed operation group IotDefenderSettingsOperations
      info	[Changelog]   - Removed operation group IotRecommendationTypesOperations
      info	[Changelog]   - Removed operation group IotRecommendationsOperations
      info	[Changelog]   - Removed operation group IotSensorsOperations
      info	[Changelog]   - Removed operation group IotSitesOperations
      info	[Changelog]   - Removed operation group OnPremiseIotSensorsOperations
    ️❌ azure-resource-manager-schemas failed [Detail]
    • Failed [Logs]Release - Generate from 63312d0. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • security/resource-manager [View full logs]  [Release Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from 63312d0. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.security [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @rejoron, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @openapi-workflow-bot
    Copy link

    NewApiVersionRequired reason:

    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

    EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    @openapi-workflow-bot
    Copy link

    Hi @rejoron, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @mikekistler mikekistler added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jul 18, 2022
    @ghost
    Copy link

    ghost commented Aug 7, 2022

    Hi, @rejoron. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost ghost added the no-recent-activity label Aug 7, 2022
    @ruowan ruowan merged commit 63312d0 into Azure:main Aug 8, 2022
    @ghost ghost removed the no-recent-activity label Aug 8, 2022
    ghost pushed a commit to Azure/azure-resource-manager-schemas that referenced this pull request Aug 8, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 CI-BreakingChange-Go CI-BreakingChange-JavaScript
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants