-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix s360 errors in Reservation APIs #19575
Fix s360 errors in Reservation APIs #19575
Conversation
Hi, @pednekarpraj Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
compared swaggers (via Oad v0.9.6)] | new version | base version |
---|---|---|
consumption.json | 2019-10-01(c59fb35) | 2019-10-01(main) |
Only 30 items are listed, please refer to log for more details.
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v1.13.0) | new version | base version |
---|---|---|
package-2019-10 | package-2019-10(c59fb35) | package-2019-10(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
R3021 - PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/providers/Microsoft.Management/managementGroups/{managementGroupId}/providers/Microsoft.Billing/billingPeriods/{billingPeriodName}/Microsoft.Consumption/aggregatedCost' Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L1557 |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'Microsoft.Management, Microsoft.Billing' doesn't match the namespace. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L1557 |
R4011 - DeleteOperationResponses |
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L424 |
R4018 - OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.Consumption/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L1477 |
R4037 - MissingTypeObject |
The schema 'MeterDetails' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L1739 |
R4037 - MissingTypeObject |
The schema 'UsageDetailsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L1818 |
R4037 - MissingTypeObject |
The schema 'LegacyUsageDetailProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L1856 |
R4037 - MissingTypeObject |
The schema 'ModernUsageDetailProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L2099 |
R4037 - MissingTypeObject |
The schema 'TagProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L3852 |
R4037 - MissingTypeObject |
The schema 'Tag' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L3874 |
R4037 - MissingTypeObject |
The schema 'BudgetsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L3890 |
R4037 - MissingTypeObject |
The schema 'BudgetProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L3924 |
R4037 - MissingTypeObject |
The schema 'BudgetTimePeriod' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L3995 |
R4037 - MissingTypeObject |
The schema 'BudgetFilter' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4013 |
R4037 - MissingTypeObject |
The schema 'BudgetFilterProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4038 |
R4037 - MissingTypeObject |
The schema 'BudgetComparisonExpression' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4051 |
R4037 - MissingTypeObject |
The schema 'CurrentSpend' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4084 |
R4037 - MissingTypeObject |
The schema 'ForecastSpend' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4100 |
R4037 - MissingTypeObject |
The schema 'Notification' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4116 |
R4037 - MissingTypeObject |
The schema 'PriceSheetModel' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4233 |
R4037 - MissingTypeObject |
The schema 'DownloadProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4256 |
R4037 - MissingTypeObject |
The schema 'PriceSheetProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4271 |
R4037 - MissingTypeObject |
The schema 'ChargesListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4518 |
R4037 - MissingTypeObject |
The schema 'MeterDetailsResponse' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4703 |
R4037 - MissingTypeObject |
The schema 'ErrorDetails' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4733 |
R4037 - MissingTypeObject |
The schema 'HighCasedErrorDetails' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4748 |
R4037 - MissingTypeObject |
The schema 'display' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4797 |
R4037 - MissingTypeObject |
The schema 'OperationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4824 |
R4037 - MissingTypeObject |
The schema 'Events' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4842 |
R4037 - MissingTypeObject |
The schema 'EventProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4876 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️❌
ModelValidation: 1 Errors, 0 Warnings failed [Detail]
Rule | Message |
---|---|
XMS_EXAMPLE_NOTFOUND_ERROR |
x-ms-example not found in Operations_List. Url: Microsoft.Consumption/stable/2019-10-01/consumption.json#L1478:14 |
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️⚠️
SDK Track2 Validation: 2 Warnings warning [Detail]
- The following tags are being changed in this PR
Rule | Message |
---|---|
"readme":"consumption/resource-manager/readme.md", "tag":"package-2019-10", "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > BudgetProperties > properties > filter)\n keys: [ \u001b[32m'type'\u001b[39m ]" |
|
"readme":"consumption/resource-manager/readme.md", "tag":"package-2019-10", "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > BudgetProperties > properties > notifications > additionalProperties)\n keys: [ \u001b[32m'type'\u001b[39m ]" |
|
💬 | "readme":"consumption/resource-manager/readme.md", "tag":"package-2019-10", "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.11.0 -> 1.11.0)" |
💬 | "readme":"consumption/resource-manager/readme.md", "tag":"package-2019-10", "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.11.0->1.11.0)" |
💬 | "readme":"consumption/resource-manager/readme.md", "tag":"package-2019-10", "details":"> Installing AutoRest extension '@autorest/modelerfour' (4.21.4 -> 4.21.4)" |
💬 | "readme":"consumption/resource-manager/readme.md", "tag":"package-2019-10", "details":"> Installed AutoRest extension '@autorest/modelerfour' (4.21.4->4.21.4)" |
💬 | "readme":"consumption/resource-manager/readme.md", "tag":"package-2019-10", "details":"Autorest completed in 11.63s. 0 files generated." |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
"readme":"consumption/resource-manager/readme.md", "tag":"package-2019-10", "details":"Using directive.0.suppress which is deprecated and will be removed in the future." |
|
💬 | "readme":"consumption/resource-manager/readme.md", "tag":"package-2019-10", "details":"AutoRest core version selected from configuration: ^3.2.0." |
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
Swagger Generation Artifacts
|
Hi @pednekarpraj, Your PR has some issues. Please fix the CI sequentially by following the order of
|
Hi @pednekarpraj, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
NewApiVersionRequired reason: |
@changlong-liu Can you merge the PR ? I got a sign off on breaking change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@changlong-liu Can you please merge the PR ? |
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.