[Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2022-05-01 #19659

singhabh27 · 2022-07-04T06:06:23Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

…/2022-03-01 to version 2022-05-01

openapi-workflow-bot · 2022-07-04T06:06:26Z

Hi, @singhabh27 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2022-07-04T06:06:26Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️⌛Breaking Change(Cross-Version) pending [Detail]

️⌛CredScan pending [Detail]

️⌛LintDiff pending [Detail]

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️⌛ApiReadinessCheck pending [Detail]

️⌛ModelValidation pending [Detail]

️⌛SemanticValidation pending [Detail]

️⌛PoliCheck pending [Detail]

️🔄SDK Track2 Validation inProgress [Detail]

️🔄PrettierCheck inProgress [Detail]

️⌛SpellCheck pending [Detail]

️🔄Lint(RPaaS) inProgress [Detail]

️🔄CadlValidation inProgress [Detail]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-07-04T06:06:27Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️✔️azure-sdk-for-go - armrecoveryservicessiterecovery - 1.1.0
️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-recoveryservicessiterecovery - 1.0.0b1

️❌ azure-sdk-for-net failed [Detail]

❌Failed [Logs]Release - Generate from 3c3cd8e. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/recoveryservicessiterecovery/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] No usable version of the libssl was found
cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
warn	Skip package processing as generation is failed

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 3c3cd8e. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.

️✔️track2_azure-mgmt-recoveryservicessiterecovery [View full logs] [Release SDK Changes]

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation ReplicationMigrationItemsOperations.begin_pause_replication
info	[Changelog]   - Added operation ReplicationMigrationItemsOperations.begin_resume_replication
info	[Changelog]   - Added operation ReplicationProtectedItemsOperations.begin_switch_provider
info	[Changelog]   - Added operation group ReplicationAppliancesOperations
info	[Changelog]   - Model A2AContainerMappingInput has a new parameter automation_account_authentication_type
info	[Changelog]   - Model A2ACreateProtectionIntentInput has a new parameter agent_auto_update_status
info	[Changelog]   - Model A2ACreateProtectionIntentInput has a new parameter automation_account_arm_id
info	[Changelog]   - Model A2ACreateProtectionIntentInput has a new parameter automation_account_authentication_type
info	[Changelog]   - Model A2AEnableProtectionInput has a new parameter recovery_capacity_reservation_group_id
info	[Changelog]   - Model A2AEnableProtectionInput has a new parameter recovery_extended_location
info	[Changelog]   - Model A2AProtectionContainerMappingDetails has a new parameter automation_account_authentication_type
info	[Changelog]   - Model A2AReplicationDetails has a new parameter initial_primary_extended_location
info	[Changelog]   - Model A2AReplicationDetails has a new parameter initial_recovery_extended_location
info	[Changelog]   - Model A2AReplicationDetails has a new parameter primary_extended_location
info	[Changelog]   - Model A2AReplicationDetails has a new parameter recovery_capacity_reservation_group_id
info	[Changelog]   - Model A2AReplicationDetails has a new parameter recovery_extended_location
info	[Changelog]   - Model A2AReplicationIntentDetails has a new parameter agent_auto_update_status
info	[Changelog]   - Model A2AReplicationIntentDetails has a new parameter automation_account_arm_id
info	[Changelog]   - Model A2AReplicationIntentDetails has a new parameter automation_account_authentication_type
info	[Changelog]   - Model A2ASwitchProtectionInput has a new parameter recovery_capacity_reservation_group_id
info	[Changelog]   - Model A2AUpdateContainerMappingInput has a new parameter automation_account_authentication_type
info	[Changelog]   - Model A2AUpdateReplicationProtectedItemInput has a new parameter recovery_capacity_reservation_group_id
info	[Changelog]   - Model HyperVVirtualMachineDetails has a new parameter hyper_v_host_id
info	[Changelog]   - Model InMageAzureV2ProtectedDiskDetails has a new parameter seconds_to_take_switch_provider
info	[Changelog]   - Model InMageAzureV2ReplicationDetails has a new parameter switch_provider_blocking_error_details
info	[Changelog]   - Model InMageAzureV2ReplicationDetails has a new parameter switch_provider_details
info	[Changelog]   - Model InMageRcmProtectedDiskDetails has a new parameter seed_blob_uri
info	[Changelog]   - Model InMageRcmReplicationDetails has a new parameter storage_account_id
info	[Changelog]   - Model MigrationItemProperties has a new parameter critical_job_history
info	[Changelog]   - Model MigrationItemProperties has a new parameter last_migration_status
info	[Changelog]   - Model MigrationItemProperties has a new parameter last_migration_time
info	[Changelog]   - Model MigrationItemProperties has a new parameter recovery_services_provider_id
info	[Changelog]   - Model MigrationItemProperties has a new parameter replication_status
info	[Changelog]   - Model RecoveryPlanA2AInput has a new parameter primary_extended_location
info	[Changelog]   - Model RecoveryPlanA2AInput has a new parameter recovery_extended_location
info	[Changelog]   - Model ReplicationProtectedItemProperties has a new parameter switch_provider_state
info	[Changelog]   - Model ReplicationProtectedItemProperties has a new parameter switch_provider_state_description
info	[Changelog]   - Model VMwareCbtEnableMigrationInput has a new parameter test_network_id
info	[Changelog]   - Model VMwareCbtEnableMigrationInput has a new parameter test_subnet_name
info	[Changelog]   - Model VMwareCbtMigrationDetails has a new parameter resume_progress_percentage
info	[Changelog]   - Model VMwareCbtMigrationDetails has a new parameter resume_retry_count
info	[Changelog]   - Model VMwareCbtMigrationDetails has a new parameter storage_account_id
info	[Changelog]   - Model VMwareCbtMigrationDetails has a new parameter test_network_id
info	[Changelog]   - Model VMwareCbtNicDetails has a new parameter test_ip_address
info	[Changelog]   - Model VMwareCbtNicDetails has a new parameter test_ip_address_type
info	[Changelog]   - Model VMwareCbtNicDetails has a new parameter test_network_id
info	[Changelog]   - Model VMwareCbtNicDetails has a new parameter test_subnet_name
info	[Changelog]   - Model VMwareCbtNicInput has a new parameter test_static_ip_address
info	[Changelog]   - Model VMwareCbtNicInput has a new parameter test_subnet_name
info	[Changelog]   - Model VMwareCbtProtectedDiskDetails has a new parameter seed_blob_uri
info	[Changelog]   - Model VMwareCbtProtectedDiskDetails has a new parameter target_blob_uri
info	[Changelog]   - Model VMwareCbtProtectionContainerMappingDetails has a new parameter role_size_to_nic_count_map
info	[Changelog]   - Model VMwareCbtTestMigrateInput has a new parameter vm_nics
info	[Changelog]   - Model VMwareCbtUpdateDiskInput has a new parameter is_os_disk
info	[Changelog]   - Model VMwareCbtUpdateMigrationItemInput has a new parameter test_network_id
info	[Changelog]   - Model VMwareDetails has a new parameter switch_provider_blocking_error_details
info	[Changelog]   - Model VmmVirtualMachineDetails has a new parameter hyper_v_host_id

️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 3c3cd8e. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-recoveryservicessiterecovery [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 3c3cd8e. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️armrecoveryservicessiterecovery [View full logs] [Release SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `MigrationItemOperationPauseReplication`
info	[Changelog] - New const `TestMigrationStateTestMigrationPartiallySucceeded`
info	[Changelog] - New const `TestMigrationStateTestMigrationCompletedWithInformation`
info	[Changelog] - New const `MigrationStateProtectionSuspended`
info	[Changelog] - New const `MigrationStateMigrationCompletedWithInformation`
info	[Changelog] - New const `MigrationStateResumeInProgress`
info	[Changelog] - New const `MigrationStateSuspendingProtection`
info	[Changelog] - New const `MigrationStateMigrationPartiallySucceeded`
info	[Changelog] - New const `MigrationStateResumeInitiated`
info	[Changelog] - New const `MigrationItemOperationResumeReplication`
info	[Changelog] - New function `*ReplicationMigrationItemsClient.BeginResumeReplication(context.Context, string, string, string, ResumeReplicationInput, *ReplicationMigrationItemsClientBeginResumeReplicationOptions) (*runtime.Poller[ReplicationMigrationItemsClientResumeReplicationResponse], error)`
info	[Changelog] - New function `*ResumeReplicationProviderSpecificInput.GetResumeReplicationProviderSpecificInput() *ResumeReplicationProviderSpecificInput`
info	[Changelog] - New function `*VMwareCbtResumeReplicationInput.GetResumeReplicationProviderSpecificInput() *ResumeReplicationProviderSpecificInput`
info	[Changelog] - New function `*ReplicationMigrationItemsClient.BeginPauseReplication(context.Context, string, string, string, PauseReplicationInput, *ReplicationMigrationItemsClientBeginPauseReplicationOptions) (*runtime.Poller[ReplicationMigrationItemsClientPauseReplicationResponse], error)`
info	[Changelog] - New struct `CriticalJobHistoryDetails`
info	[Changelog] - New struct `PauseReplicationInput`
info	[Changelog] - New struct `PauseReplicationInputProperties`
info	[Changelog] - New struct `ReplicationMigrationItemsClientBeginPauseReplicationOptions`
info	[Changelog] - New struct `ReplicationMigrationItemsClientBeginResumeReplicationOptions`
info	[Changelog] - New struct `ReplicationMigrationItemsClientPauseReplicationResponse`
info	[Changelog] - New struct `ReplicationMigrationItemsClientResumeReplicationResponse`
info	[Changelog] - New struct `ResumeReplicationInput`
info	[Changelog] - New struct `ResumeReplicationInputProperties`
info	[Changelog] - New struct `ResumeReplicationProviderSpecificInput`
info	[Changelog] - New struct `VMwareCbtResumeReplicationInput`
info	[Changelog] - New field `SeedBlobURI` in struct `InMageRcmProtectedDiskDetails`
info	[Changelog] - New field `ResumeProgressPercentage` in struct `VMwareCbtMigrationDetails`
info	[Changelog] - New field `ResumeRetryCount` in struct `VMwareCbtMigrationDetails`
info	[Changelog] - New field `TestNetworkID` in struct `VMwareCbtMigrationDetails`
info	[Changelog] - New field `StorageAccountID` in struct `VMwareCbtMigrationDetails`
info	[Changelog] - New field `StorageAccountID` in struct `InMageRcmReplicationDetails`
info	[Changelog] - New field `LastMigrationTime` in struct `MigrationItemProperties`
info	[Changelog] - New field `ReplicationStatus` in struct `MigrationItemProperties`
info	[Changelog] - New field `CriticalJobHistory` in struct `MigrationItemProperties`
info	[Changelog] - New field `RecoveryServicesProviderID` in struct `MigrationItemProperties`
info	[Changelog] - New field `LastMigrationStatus` in struct `MigrationItemProperties`
info	[Changelog] - New field `RoleSizeToNicCountMap` in struct `VMwareCbtProtectionContainerMappingDetails`
info	[Changelog] - New field `TargetBlobURI` in struct `VMwareCbtProtectedDiskDetails`
info	[Changelog] - New field `SeedBlobURI` in struct `VMwareCbtProtectedDiskDetails`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 43 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 3c3cd8e. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-recoveryservices-siterecovery [View full logs] [Release SDK Changes]

azure-arm-recoveryservices-siterecovery-4.1.0.tgz

Only show 120 items here, please refer to log for details.

info	[Changelog]   - Added Interface InMageRcmProtectionContainerMappingDetails
info	[Changelog]   - Added Interface InMageRcmRecoveryPointDetails
info	[Changelog]   - Added Interface InMageRcmReplicationDetails
info	[Changelog]   - Added Interface InMageRcmReprotectInput
info	[Changelog]   - Added Interface InMageRcmTestFailoverInput
info	[Changelog]   - Added Interface InMageRcmUnplannedFailoverInput
info	[Changelog]   - Added Interface InMageRcmUpdateApplianceForReplicationProtectedItemInput
info	[Changelog]   - Added Interface InMageRcmUpdateContainerMappingInput
info	[Changelog]   - Added Interface InMageRcmUpdateReplicationProtectedItemInput
info	[Changelog]   - Added Interface InMageReplicationDetails
info	[Changelog]   - Added Interface InMageReprotectInput
info	[Changelog]   - Added Interface InMageTestFailoverInput
info	[Changelog]   - Added Interface InMageUnplannedFailoverInput
info	[Changelog]   - Added Interface Job
info	[Changelog]   - Added Interface JobStatusEventDetails
info	[Changelog]   - Added Interface JobTaskDetails
info	[Changelog]   - Added Interface LogicalNetwork
info	[Changelog]   - Added Interface ManualActionTaskDetails
info	[Changelog]   - Added Interface MigrationItem
info	[Changelog]   - Added Interface MigrationRecoveryPoint
info	[Changelog]   - Added Interface Network
info	[Changelog]   - Added Interface NetworkMapping
info	[Changelog]   - Added Interface NewProtectionProfile
info	[Changelog]   - Added Interface NewRecoveryVirtualNetwork
info	[Changelog]   - Added Interface PauseReplicationInput
info	[Changelog]   - Added Interface PauseReplicationInputProperties
info	[Changelog]   - Added Interface Policy
info	[Changelog]   - Added Interface ProtectableItem
info	[Changelog]   - Added Interface ProtectionContainer
info	[Changelog]   - Added Interface ProtectionContainerMapping
info	[Changelog]   - Added Interface RecoveryPlan
info	[Changelog]   - Added Interface RecoveryPlanA2ADetails
info	[Changelog]   - Added Interface RecoveryPlanA2AFailoverInput
info	[Changelog]   - Added Interface RecoveryPlanA2AInput
info	[Changelog]   - Added Interface RecoveryPlanAutomationRunbookActionDetails
info	[Changelog]   - Added Interface RecoveryPlanGroupTaskDetails
info	[Changelog]   - Added Interface RecoveryPlanHyperVReplicaAzureFailbackInput
info	[Changelog]   - Added Interface RecoveryPlanHyperVReplicaAzureFailoverInput
info	[Changelog]   - Added Interface RecoveryPlanInMageAzureV2FailoverInput
info	[Changelog]   - Added Interface RecoveryPlanInMageFailoverInput
info	[Changelog]   - Added Interface RecoveryPlanInMageRcmFailbackFailoverInput
info	[Changelog]   - Added Interface RecoveryPlanInMageRcmFailoverInput
info	[Changelog]   - Added Interface RecoveryPlanManualActionDetails
info	[Changelog]   - Added Interface RecoveryPlanScriptActionDetails
info	[Changelog]   - Added Interface RecoveryPlanShutdownGroupTaskDetails
info	[Changelog]   - Added Interface RecoveryPoint
info	[Changelog]   - Added Interface RecoveryServicesProvider
info	[Changelog]   - Added Interface ReplicationGroupDetails
info	[Changelog]   - Added Interface ReplicationMigrationItemsPauseReplicationOptionalParams
info	[Changelog]   - Added Interface ReplicationMigrationItemsResumeReplicationOptionalParams
info	[Changelog]   - Added Interface ReplicationProtectedItem
info	[Changelog]   - Added Interface ReplicationProtectionIntent
info	[Changelog]   - Added Interface ResumeReplicationInput
info	[Changelog]   - Added Interface ResumeReplicationInputProperties
info	[Changelog]   - Added Interface ResumeReplicationProviderSpecificInput
info	[Changelog]   - Added Interface ScriptActionTaskDetails
info	[Changelog]   - Added Interface StorageClassification
info	[Changelog]   - Added Interface StorageClassificationMapping
info	[Changelog]   - Added Interface SupportedOperatingSystems
info	[Changelog]   - Added Interface SwitchProtectionJobDetails
info	[Changelog]   - Added Interface TestFailoverJobDetails
info	[Changelog]   - Added Interface VaultHealthDetails
info	[Changelog]   - Added Interface VaultSetting
info	[Changelog]   - Added Interface VCenter
info	[Changelog]   - Added Interface VirtualMachineTaskDetails
info	[Changelog]   - Added Interface VmmDetails
info	[Changelog]   - Added Interface VmmToAzureCreateNetworkMappingInput
info	[Changelog]   - Added Interface VmmToAzureNetworkMappingSettings
info	[Changelog]   - Added Interface VmmToAzureUpdateNetworkMappingInput
info	[Changelog]   - Added Interface VmmToVmmCreateNetworkMappingInput
info	[Changelog]   - Added Interface VmmToVmmNetworkMappingSettings
info	[Changelog]   - Added Interface VmmToVmmUpdateNetworkMappingInput
info	[Changelog]   - Added Interface VmmVirtualMachineDetails
info	[Changelog]   - Added Interface VmNicUpdatesTaskDetails
info	[Changelog]   - Added Interface VMwareCbtContainerCreationInput
info	[Changelog]   - Added Interface VMwareCbtContainerMappingInput
info	[Changelog]   - Added Interface VMwareCbtEnableMigrationInput
info	[Changelog]   - Added Interface VMwareCbtEventDetails
info	[Changelog]   - Added Interface VMwareCbtMigrateInput
info	[Changelog]   - Added Interface VMwareCbtMigrationDetails
info	[Changelog]   - Added Interface VMwareCbtPolicyCreationInput
info	[Changelog]   - Added Interface VmwareCbtPolicyDetails
info	[Changelog]   - Added Interface VMwareCbtProtectionContainerMappingDetails
info	[Changelog]   - Added Interface VMwareCbtResumeReplicationInput
info	[Changelog]   - Added Interface VMwareCbtResyncInput
info	[Changelog]   - Added Interface VMwareCbtTestMigrateInput
info	[Changelog]   - Added Interface VMwareCbtUpdateMigrationItemInput
info	[Changelog]   - Added Interface VMwareDetails
info	[Changelog]   - Added Interface VMwareV2FabricCreationInput
info	[Changelog]   - Added Interface VMwareV2FabricSpecificDetails
info	[Changelog]   - Added Interface VMwareVirtualMachineDetails
info	[Changelog]   - Added Type Alias ReplicationMigrationItemsPauseReplicationResponse
info	[Changelog]   - Added Type Alias ReplicationMigrationItemsResumeReplicationResponse
info	[Changelog]   - Added Type Alias ResumeReplicationProviderSpecificInputUnion
info	[Changelog]   - Interface InMageRcmProtectedDiskDetails has a new optional parameter seedBlobUri
info	[Changelog]   - Interface MigrationItemProperties has a new optional parameter criticalJobHistory
info	[Changelog]   - Interface MigrationItemProperties has a new optional parameter lastMigrationStatus
info	[Changelog]   - Interface MigrationItemProperties has a new optional parameter lastMigrationTime
info	[Changelog]   - Interface MigrationItemProperties has a new optional parameter recoveryServicesProviderId
info	[Changelog]   - Interface MigrationItemProperties has a new optional parameter replicationStatus
info	[Changelog]   - Interface VMwareCbtNicDetails has a new optional parameter testIPAddress
info	[Changelog]   - Interface VMwareCbtNicDetails has a new optional parameter testIPAddressType
info	[Changelog]   - Interface VMwareCbtNicDetails has a new optional parameter testNetworkId
info	[Changelog]   - Interface VMwareCbtNicDetails has a new optional parameter testSubnetName
info	[Changelog]   - Interface VMwareCbtNicInput has a new optional parameter testStaticIPAddress
info	[Changelog]   - Interface VMwareCbtNicInput has a new optional parameter testSubnetName
info	[Changelog]   - Interface VMwareCbtProtectedDiskDetails has a new optional parameter seedBlobUri
info	[Changelog]   - Interface VMwareCbtProtectedDiskDetails has a new optional parameter targetBlobUri
info	[Changelog]   - Interface VMwareCbtUpdateDiskInput has a new optional parameter isOSDisk
info	[Changelog]   - Enum KnownMigrationItemOperation has a new value PauseReplication
info	[Changelog]   - Enum KnownMigrationItemOperation has a new value ResumeReplication
info	[Changelog]   - Enum KnownMigrationState has a new value MigrationCompletedWithInformation
info	[Changelog]   - Enum KnownMigrationState has a new value MigrationPartiallySucceeded
info	[Changelog]   - Enum KnownMigrationState has a new value ProtectionSuspended
info	[Changelog]   - Enum KnownMigrationState has a new value ResumeInitiated
info	[Changelog]   - Enum KnownMigrationState has a new value ResumeInProgress
info	[Changelog]   - Enum KnownMigrationState has a new value SuspendingProtection
info	[Changelog]   - Enum KnownTestMigrationState has a new value TestMigrationCompletedWithInformation
info	[Changelog]   - Enum KnownTestMigrationState has a new value TestMigrationPartiallySucceeded
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 3c3cd8e. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️recoveryservicessiterecovery [View full logs] [Release Schema Changes]

️️✔️ azure-powershell succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 3c3cd8e. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

️✔️Az.SiteRecovery [View full logs] [Release SDK Changes]
- Az.SiteRecovery.0.1.0.nupkg

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-07-08T12:32:35Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

compared swaggers (via Oad v0.9.6)]	new version	base version
service.json	2022-05-01(1a85d68)	2022-04-01(main)

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 4 Warnings warning [Detail]

compared tags (via openapi-validator v1.13.0)	new version	base version
package-2022-05	package-2022-05(1a85d68)	default(main)

The following errors/warnings are introduced by current PR:

Rule	Message
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.RecoveryServices/stable/2022-05-01/service.json#L18745
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.RecoveryServices/stable/2022-05-01/service.json#L21682
⚠️ R2010 - LongRunningOperationsOptionsValidator	A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: Microsoft.RecoveryServices/stable/2022-05-01/service.json#L2301
⚠️ R2010 - LongRunningOperationsOptionsValidator	A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: Microsoft.RecoveryServices/stable/2022-05-01/service.json#L2378

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.RecoveryServices/stable/2022-05-01/service.json#L8131
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.RecoveryServices/stable/2022-05-01/service.json#L8138
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.RecoveryServices/stable/2022-05-01/service.json#L8296
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.RecoveryServices/stable/2022-05-01/service.json#L8303
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.RecoveryServices/stable/2022-05-01/service.json#L8490
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.RecoveryServices/stable/2022-05-01/service.json#L8497
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.RecoveryServices/stable/2022-05-01/service.json#L9120
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.RecoveryServices/stable/2022-05-01/service.json#L9127
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.RecoveryServices/stable/2022-05-01/service.json#L9134
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.RecoveryServices/stable/2022-05-01/service.json#L9185
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.RecoveryServices/stable/2022-05-01/service.json#L9357
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.RecoveryServices/stable/2022-05-01/service.json#L9364
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.RecoveryServices/stable/2022-05-01/service.json#L9476
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.RecoveryServices/stable/2022-05-01/service.json#L9515
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.RecoveryServices/stable/2022-05-01/service.json#L9522
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.RecoveryServices/stable/2022-05-01/service.json#L9693
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.RecoveryServices/stable/2022-05-01/service.json#L9978
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.RecoveryServices/stable/2022-05-01/service.json#L10078
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.RecoveryServices/stable/2022-05-01/service.json#L10223
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.RecoveryServices/stable/2022-05-01/service.json#L10316
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.RecoveryServices/stable/2022-05-01/service.json#L10392
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.RecoveryServices/stable/2022-05-01/service.json#L10515
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.RecoveryServices/stable/2022-05-01/service.json#L10593
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.RecoveryServices/stable/2022-05-01/service.json#L10707
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.RecoveryServices/stable/2022-05-01/service.json#L10714
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.RecoveryServices/stable/2022-05-01/service.json#L11026
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.RecoveryServices/stable/2022-05-01/service.json#L11231
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.RecoveryServices/stable/2022-05-01/service.json#L11542
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.RecoveryServices/stable/2022-05-01/service.json#L11670
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.RecoveryServices/stable/2022-05-01/service.json#L11773

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️⚠️SDK Track2 Validation: 1 Warnings warning [Detail]

The following tags are being changed in this PR

"https://github.com/Azure/azure-rest-api-specs/blob/1a85d6809840149edad4f25ded5935961291f91c/specification/recoveryservicessiterecovery/resource-manager/readme.md#tag-package-2022-05">recoveryservicessiterecovery/resource-manager/readme.md#package-2022-05

The following errors/warnings are introduced by current PR:

Rule	Message
⚠️ UnkownSecurityScheme	"readme":"recoveryservicessiterecovery/resource-manager/readme.md", "tag":"package-2022-05", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous"

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2022-07-08T12:32:58Z

Hi @singhabh27, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

mentat9 · 2022-07-15T21:21:38Z

    "replicationStatus": {

Does this have a fixed set of values? If so, it should be a string enum.

In reply to: 1185953798

Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2022-05-01/service.json:18118 in bbd756d. [](commit_id = bbd756d, deletion_comment = False)

mentat9 · 2022-07-15T21:21:45Z

  "properties": {}

ARM recommends against the use of the additionalProperties/empty/unschematized object pattern. ARM favors stronger typing wherever possible because it allows all consumers of your API to reason about it. This has benefits for everyone that interacts with your API including basic infrastructure, other Azure features, SDK owners, and customers. Unschematized objects are essentially API contracts that bypass Azure versioning infrastructure.

Generally, this pattern should only be used when needed and the object properties are dynamic, unknown, or user defined. Ref: https://armwiki.azurewebsites.net/api_contracts/guidelines/openapi.html#oapi032-only-use-additionalproperties-when-the-object-properties-are-dynamic-unknown-or-user-defined.

In reply to: 1185953859

Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2022-05-01/service.json:18690 in bbd756d. [](commit_id = bbd756d, deletion_comment = False)

mentat9 · 2022-07-15T21:21:51Z

    "deleteMigrationResources": {

If this has a fixed set of values, it should be modeled as string enum.

In reply to: 1185953908

Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2022-05-01/service.json:24219 in bbd756d. [](commit_id = bbd756d, deletion_comment = False)

mentat9 · 2022-07-15T21:21:57Z

    "instanceType": {

This should be a string enum so the known types are discoverable.

Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2022-05-01/service.json:21636 in bbd756d. [](commit_id = bbd756d, deletion_comment = False)

openapi-workflow-bot · 2022-07-15T21:22:56Z

Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested

msyyc · 2022-08-04T05:57:19Z

Hi @singhabh27 please remove DoNotMerge if you want to merge the PR:

msyyc · 2022-08-04T05:57:51Z

Hi @JeffreyRichter Please help review the swagger breaking change. Thanks!

singhabh27 · 2022-08-04T07:50:21Z

/azp run

azure-pipelines · 2022-08-04T07:50:31Z

Azure Pipelines successfully started running 1 pipeline(s).

msyyc · 2022-08-04T08:45:59Z

Hi @JeffreyRichter Please help review the swagger breaking change. Thanks!

It is fake warning.

…st for Microsoft.RecoveryServices to add version stable/2022-05-01 (#2512) Create to sync Azure/azure-rest-api-specs#19659 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...azure-sdk:sdkAuto/recoveryservicessiterecovery?expand=1)

singhabh27 added 3 commits July 4, 2022 11:36

Adds base for updating Microsoft.RecoveryServices from version stable…

7c8a23e

…/2022-03-01 to version 2022-05-01

Updates readme

0f5b71e

Updates API version in new specs and examples

df48ba4

openapi-assignment-bot bot assigned changlong-liu Jul 4, 2022

singhabh27 added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jul 4, 2022

singhabh27 assigned msyyc and unassigned changlong-liu Jul 4, 2022

Including pause resume changes

9b8170a

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Jul 8, 2022

LintDiff Fixed

bbd756d

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label Jul 8, 2022

singhabh27 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 12, 2022

mentat9 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jul 15, 2022

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 15, 2022

openapi-pipeline-app bot added the CI-BreakingChange-Go label Aug 4, 2022

vCenterFqdn change revert

c28b435

openapi-pipeline-app bot removed BreakingChangeReviewRequired CI-BreakingChange-Go labels Aug 4, 2022

Swagger Correctness issue resolved

8558100

openapi-pipeline-app bot added the BreakingChangeReviewRequired label Aug 4, 2022

Breaking Change Resolved

a0acd27

msyyc approved these changes Aug 4, 2022

View reviewed changes

msyyc self-requested a review August 4, 2022 08:48

singhabh27 added 3 commits August 5, 2022 11:48

Included 2022-04-01 in readme.md file

a5aba25

Added critical job property

883b7d5

Added missed property

1a85d68

singhabh27 removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Aug 5, 2022

msyyc approved these changes Aug 5, 2022

View reviewed changes

msyyc merged commit 3c3cd8e into Azure:main Aug 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2022-05-01 #19659

[Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2022-05-01 #19659

singhabh27 commented Jul 4, 2022 •

edited

Loading

openapi-workflow-bot bot commented Jul 4, 2022

openapi-pipeline-app bot commented Jul 4, 2022 •

edited

Loading

openapi-pipeline-app bot commented Jul 4, 2022 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Jul 8, 2022 •

edited

Loading

openapi-workflow-bot bot commented Jul 8, 2022

mentat9 commented Jul 15, 2022 •

edited by rkmanda

Loading

mentat9 commented Jul 15, 2022 •

edited by rkmanda

Loading

mentat9 commented Jul 15, 2022 •

edited by rkmanda

Loading

mentat9 commented Jul 15, 2022

openapi-workflow-bot bot commented Jul 15, 2022

msyyc commented Aug 4, 2022

msyyc commented Aug 4, 2022

singhabh27 commented Aug 4, 2022

azure-pipelines bot commented Aug 4, 2022

msyyc commented Aug 4, 2022

[Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2022-05-01 #19659

[Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2022-05-01 #19659

Conversation

singhabh27 commented Jul 4, 2022 • edited Loading

ARM API Information (Control Plane)

Changelog

Contribution checklist (MS Employees Only):

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Jul 4, 2022

openapi-pipeline-app bot commented Jul 4, 2022 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jul 4, 2022 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Jul 8, 2022 • edited Loading

Swagger Validation Report

openapi-workflow-bot bot commented Jul 8, 2022

mentat9 commented Jul 15, 2022 • edited by rkmanda Loading

mentat9 commented Jul 15, 2022 • edited by rkmanda Loading

mentat9 commented Jul 15, 2022 • edited by rkmanda Loading

mentat9 commented Jul 15, 2022

openapi-workflow-bot bot commented Jul 15, 2022

msyyc commented Aug 4, 2022

msyyc commented Aug 4, 2022

singhabh27 commented Aug 4, 2022

azure-pipelines bot commented Aug 4, 2022

msyyc commented Aug 4, 2022

singhabh27 commented Jul 4, 2022 •

edited

Loading

openapi-pipeline-app bot commented Jul 4, 2022 •

edited

Loading

openapi-pipeline-app bot commented Jul 4, 2022 •

edited

Loading

openapi-pipeline-app bot commented Jul 8, 2022 •

edited

Loading

mentat9 commented Jul 15, 2022 •

edited by rkmanda

Loading

mentat9 commented Jul 15, 2022 •

edited by rkmanda

Loading

mentat9 commented Jul 15, 2022 •

edited by rkmanda

Loading