-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(PostgreSQL) fixes Azure/azure-sdk-for-go#18506 #19661
Conversation
Azure is offering postgres 14 flexible server but the sdk is currently limited to Versions 11 12 and 13. https://github.com/Azure/azure-sdk-for-go/blob/sdk/resourcemanager/postgresql/armpostgresqlflexibleservers/v1.0.0/sdk/resourcemanager/postgresql/armpostgresqlflexibleservers/zz_generated_constants.go#L263 fixes Azure/azure-sdk-for-go#18506
Hi, @navba-MSFT Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
compared swaggers (via Oad v0.9.6)] | new version | base version |
---|---|---|
postgresql.json | 2021-06-01(fd0f4a2) | 2021-06-01(main) |
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v1.13.0) | new version | base version |
---|---|---|
package-flexibleserver-2021-06 | package-flexibleserver-2021-06(fd0f4a2) | package-flexibleserver-2021-06(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
R4037 - MissingTypeObject |
The schema 'StorageEditionCapability' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1177 |
R4037 - MissingTypeObject |
The schema 'CapabilityProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1310 |
R4037 - MissingTypeObject |
The schema 'ServerProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1404 |
R4037 - MissingTypeObject |
The schema 'Server' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1534 |
R4037 - MissingTypeObject |
The schema 'ServerPropertiesForUpdate' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1558 |
R4037 - MissingTypeObject |
The schema 'ServerForUpdate' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1610 |
R4037 - MissingTypeObject |
The schema 'Sku' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1652 |
R4037 - MissingTypeObject |
The schema 'Storage' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1678 |
R4037 - MissingTypeObject |
The schema 'Backup' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1688 |
R4037 - MissingTypeObject |
The schema 'Network' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1722 |
R4037 - MissingTypeObject |
The schema 'HighAvailability' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1758 |
R4037 - MissingTypeObject |
The schema 'FirewallRuleProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1827 |
R4037 - MissingTypeObject |
The schema 'FirewallRule' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1846 |
R4037 - MissingTypeObject |
The schema 'ConfigurationProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1886 |
R4037 - MissingTypeObject |
The schema 'Configuration' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1954 |
R4037 - MissingTypeObject |
The schema 'OperationDisplay' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1991 |
R4037 - MissingTypeObject |
The schema 'Operation' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L2016 |
R4037 - MissingTypeObject |
The schema 'NameAvailabilityRequest' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L2079 |
R4037 - MissingTypeObject |
The schema 'NameAvailability' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L2095 |
R4037 - MissingTypeObject |
The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L2157 |
Since operation 'LocationBasedCapabilitiesExecute' response has model definition 'x-ms-pageable', it should be of the form 'list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L916 |
|
'GET' operation 'LocationBasedCapabilities_Execute' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L916 |
|
'PUT' operation 'Configurations_Put' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L813 |
|
Based on the response model schema, operation 'Operations_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1002 |
|
OperationId should contain the verb: 'checknameavailability' in:'CheckNameAvailability_Execute'. Consider updating the operationId Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L871 |
|
OperationId should contain the verb: 'checkvirtualnetworksubnetusage' in:'VirtualNetworkSubnetUsage_Execute'. Consider updating the operationId Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L958 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: geoBackupSupported Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1317 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: zoneRedundantHaSupported Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1322 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: zoneRedundantHaAndGeoBackupSupported Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1327 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDynamicConfig Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1926 |
️⚠️
Avocado: 1 Warnings warning [Detail]
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️⚠️
SDK Track2 Validation: 9 Warnings warning [Detail]
- The following tags are being changed in this PR
Rule | Message |
---|---|
"readme":"postgresql/resource-manager/readme.md", "tag":"package-flexibleserver-2021-06", "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > ServerProperties > properties > storage)\n keys: [ \u001b[32m'default'\u001b[39m ]" |
|
"readme":"postgresql/resource-manager/readme.md", "tag":"package-flexibleserver-2021-06", "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > ServerProperties > properties > backup)\n keys: [ \u001b[32m'default'\u001b[39m ]" |
|
"readme":"postgresql/resource-manager/readme.md", "tag":"package-flexibleserver-2021-06", "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > ServerProperties > properties > network)\n keys: [ \u001b[32m'default'\u001b[39m ]" |
|
"readme":"postgresql/resource-manager/readme.md", "tag":"package-flexibleserver-2021-06", "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > ServerProperties > properties > highAvailability)\n keys: [ \u001b[32m'default'\u001b[39m ]" |
|
"readme":"postgresql/resource-manager/readme.md", "tag":"package-flexibleserver-2021-06", "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > ServerProperties > properties > maintenanceWindow)\n keys: [ \u001b[32m'default'\u001b[39m ]" |
|
"readme":"postgresql/resource-manager/readme.md", "tag":"package-flexibleserver-2021-06", "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > ServerPropertiesForUpdate > properties > storage)\n keys: [ \u001b[32m'default'\u001b[39m ]" |
|
"readme":"postgresql/resource-manager/readme.md", "tag":"package-flexibleserver-2021-06", "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > ServerPropertiesForUpdate > properties > backup)\n keys: [ \u001b[32m'default'\u001b[39m ]" |
|
"readme":"postgresql/resource-manager/readme.md", "tag":"package-flexibleserver-2021-06", "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > ServerPropertiesForUpdate > properties > highAvailability)\n keys: [ \u001b[32m'default'\u001b[39m ]" |
|
"readme":"postgresql/resource-manager/readme.md", "tag":"package-flexibleserver-2021-06", "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > ServerPropertiesForUpdate > properties > maintenanceWindow)\n keys: [ \u001b[32m'default'\u001b[39m ]" |
|
💬 | "readme":"postgresql/resource-manager/readme.md", "tag":"package-flexibleserver-2021-06", "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.11.0 -> 1.11.0)" |
💬 | "readme":"postgresql/resource-manager/readme.md", "tag":"package-flexibleserver-2021-06", "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.11.0->1.11.0)" |
💬 | "readme":"postgresql/resource-manager/readme.md", "tag":"package-flexibleserver-2021-06", "details":"> Installing AutoRest extension '@autorest/modelerfour' (4.21.4 -> 4.21.4)" |
💬 | "readme":"postgresql/resource-manager/readme.md", "tag":"package-flexibleserver-2021-06", "details":"> Installed AutoRest extension '@autorest/modelerfour' (4.21.4->4.21.4)" |
💬 | "readme":"postgresql/resource-manager/readme.md", "tag":"package-flexibleserver-2021-06", "details":"Autorest completed in 11.07s. 0 files generated." |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
"readme":"postgresql/resource-manager/readme.md", "tag":"package-flexibleserver-2021-06", "details":"Using directive.0.suppress which is deprecated and will be removed in the future." |
|
💬 | "readme":"postgresql/resource-manager/readme.md", "tag":"package-flexibleserver-2021-06", "details":"AutoRest core version selected from configuration: ^3.2.0." |
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
Swagger Generation Artifacts
|
@xunsun-commits, please help to confirm whether this behaviour is supported in the service side. Thanks |
@sunilagarwal, @lfittl-msft, @sr-msft, @niklarin, @DaeunYim Could you please review this PR once you get a chance ? Thanks in advance. |
@xunsun-commits @sunilagarwal, @lfittl-msft, @sr-msft, @niklarin, @DaeunYim Could you please look into this PR once you get a chance ? Thanks in advance. |
Azure is offering postgres 14 flexible server but the sdk is currently limited to Versions 11 12 and 13.
https://github.com/Azure/azure-sdk-for-go/blob/sdk/resourcemanager/postgresql/armpostgresqlflexibleservers/v1.0.0/sdk/resourcemanager/postgresql/armpostgresqlflexibleservers/zz_generated_constants.go#L263
fixes Azure/azure-sdk-for-go#18506
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.