Sync latest swagger files to 2022 02 01 preview #19680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * Initial Check-In to introduce ElasticSan RP * Applied coding styles and fixed the spelling mistake. * Updated with IOPS & MBps properties * Updated swagger file with NetWork Acls * Added "None" to protocol type and updated with other validations. * Removed ElasticSan from VolumeGroup operations * Addressed review comments by adding elasticSanName in each of its operation * Added volumeGroupName Parameters to the operations * Upated array item with "x-ms-identifiers": [] as per Swagger Lint recommendations * Removed unused parameters * Updated with Snapshot endpoints * Updated with missing "type" declarations * Added Snapshot changes and addressed the PR review comments * Fixed Lint differences * Fixed Lint difference * Added Export feature for Snapshot * Updated with Sku level settings * Updated with AdditionalInfo with "x-ms-identifiers": [] * Fixed Lint compilation issue with "x-ms-identifiers": [], * Fixed Prettier issues * Updated the readme* files with the right package and namespaces. * Pointed GO to track2 * Updated readme.go.md with the yaml format * Addressed review comments, updated with ecommon types and added naming restrictions. * Updated with common SystemData * Corrected the missing json structure * Updated 'CreateOrUpdate" with "Create" * Updated the spec with Network ACLs * Removed unnecessary error codes * Regenerated the examples * Removed Snapshot API and addressed PR comments (Azure#18638) * Removed Snapshot API and addressed PR comments * Removed Ruby SDK information (Azure#18662) * Reverted tsconfig.json and removed Ruby related SDK information. * Corrected the indentation for swagger-to-sdk Co-authored-by: Rajesh Kumar Aggani <raaggani@microsoft.com>
…ApiVersionBump' (Azure#18629) * Copy previous version to 2022-02-01 directory * Adding changed spec files from PR 4200. Without api-version bump * Changing version string 2021-06-01 to 2022-02-01 in specs * Updating SDK generation tags/settings to use 2022-02 * Fixing some LintDiff issues (new rules) * Fixing "prettier" issue * Fixing bad conflict resolution
* update access mode values * update examples * Add 202 in delete spec * Add provisioning issues changes * update schema * review changs * update * typo in model fix * make provisioning issues readonly * Add one example in list association, provisioning state enum update * Add logggin categories in profile * examples update * update * update examples * reformat code * Add x-msidentifier for logger * update * provisioning state fix * Fix provisioning state * Add location header in delete nsp association * update location header * update location header * location header update Co-authored-by: Kaushal Kumar <kumarkaushal@microsoft.com>
…sion stable/2022-03-10 (Azure#18458) * Adds base for updating Microsoft.HybridCompute from version preview/2021-12-10-preview to version 2022-03-10 * Updates readme * Updates API version in new specs and examples * updated the swagger * fixed typo * fixed examples * fixed swagger issues * removed columns * fixed the x-ms-identifier format * fixed the identifier again * fixed the readme tag * ran prettier * removed extra tag in the readme.md * Update HybridCompute.json updated serviceStatuses and agentConfiguration descriptions * removed resources * removed resources in the examples * addressed issues * ran prettier * A small fix to the newly added field's name * updated the az cli related files Co-authored-by: Justin Chen <justin99chen@gmail.com>
… preview/2021-12-01-preview (Azure#18297) * New Swagger Spec File * New Swagger Example Spec File * New Readme Config File * New Azure AZ Readme Config File * New Azure CLI Readme Config File * New Go Language Readme Config File * New Python Language Readme Config File * New Typescript Language Readme Config File * New C# Language Readme Config File * merging educationrp spec to public branch * Delete OperationGroupGet.json fix avocado error
…Azure#17382) * adds new version for credentials api * adding new version to ReadMe * tagging /credentials * tagging /credential * rearranging ReadMe so that default tag could be detected * rearranging ReadMe so that default tag could be detected * testing avacado * adding 2022-02-01 back to ReadMe * testing avacado readme checker * testing avacado readme checker * testing a new readme file * Revert "testing a new readme file" This reverts commit e5536c9. * testing AzureStorage discriminator * pr feedback * pr feedback * adds description for credential models * fixes typo
…es PUT (v1.0 only). (Azure#18104) Co-authored-by: Chang Liu <changliu3@microsoft.com>
…on.md files (Azure#18731) * Corrected the Tag: name * Update readme.python.md Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
* Promote 2022-05-01-preview api from RPSaaSMaster to main * Fixing lint errors
* Add action start/end time. * Update examples with action start/end times. * fix typo in description. Co-authored-by: kipartha <kipartha@microsoft.com>
* Add new apis for test button feature * Fix bug * Revert to old package version * Fix errors * Fix errors * Fix error * Remove " * Only include the actiongroups changes in this new tag as per Dapeng. * Revert "Only include the actiongroups changes in this new tag as per Dapeng." This reverts commit 529a149. * Add "x-ms-identifiers": [], * Update the default tag * Add location headers * No need to return response * build * build * format json * Prettier check Co-authored-by: Thomas Pham <thompham@microsoft.com>
* Adds base for updating Microsoft.Network from version stable/2021-05-01 to version 2021-08-01 * Updates readme * Updates API version in new specs and examples * Add AppGw swagger changes for L4 proxy (Azure#17561) * Add AppGw swagger changes for L4 proxy * Fix Lint Errors * fix prettier checks * HubRoutingPreference in VirtualHub (Azure#17609) * commit1 * commit2 Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> * MultipleApipa feature VpnSiteLinkConnection and VirtualNetworkGatewayConnection (Azure#17672) * VngConnection * VpnSiteLinkConnection * fixes * fixes * fix2 * fixes Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> * Virtual Wan P2S MultiPool feature swagger changes (Azure#17620) * Virtual Wan P2S MultiPool feature swagger changes * Fix Swagger LintDiff errors * Fix LintDiff errors * Fix errors * Fix spec * Fix spec * Fix spec * Fix LintDiff errors * Fix LintDiff errors * Fix SDK azure-sdk-for-net generation error * Remove suppression * Fix errors * Fix Lintdiff error * Fix PrettierCheck * changes (Azure#18002) * Revert "changes (Azure#18002)" (Azure#18014) This reverts commit 320ed6a. * Add nic auxiliary mode (Azure#17577) * Add nic auxiliary mode * fix spacing * Fixing prettier check * Restoring package-lock file * Restoring package json Co-authored-by: Prachi Bhavsar <prbhavsar@microsoft.com> * Connection Draining add new properties (Azure#18052) * merge * fix * fix * Adding express route port authorization apis (Azure#17582) * adding apis and updating resource to support ports auth * moving change to 2021-08-01 * minor: removing change from 2020-07-01 * lintdiff : adding type object * minor: fixing prettier * adding authorizations to ports property * fixing circuitResourceUri property name * fixing model validation * changing circuit resource uri type to string * removing authorizations child reosurce from parent property * Fix Azure Firewall Policy regressions. Back fix validation issues (Azure#18233) * Fix regressions in Firewall Policy Swagger / give firewallPolicy.json some love * Additional lint violations * remove breaking changes for next time. TO DO * Revert "remove breaking changes for next time. TO DO" This reverts commit 8f44a17. * Reintroduce api-version for idps signature based routes. Create better names for enums to be generated in SDKs * standardize enum names with FirewallPolicy prefix * Azure Firewall Support of Private IP Ranges in IDPS (Azure#18320) * Azure Firewall Support of Private IP Ranges in IDPS * make sure all arrays have x-ms-identifiers * FirewallPolicy not Firewall policy fix spellcheck validation * Ability to update tags on firewall policies (Azure#18322) * Support updating of Azure Firewall Policy Tags. Includes HTTP Patch example * Use common-types ErrorDetail * Ability to update tags for Firewall Policies * spell check fix for firewallpolicy * Use future release api-version for example * Added flush conn to nsg (Azure#18393) * Added flush conn to nsg * Updated flushConn to correct location * Updated description * Modified T/F to Enabled/Disabled * Refactoring so that null value appears first * Reverted FlushConnection to boolean value instead of string * Revert "Added flush conn to nsg (Azure#18393)" (Azure#18576) This reverts commit 6541d30. * Fixing typo in response of idps private ip range feature (Azure#18574) * Use common-type api version (Azure#18729) Co-authored-by: Ben Eshed <bewaters@microsoft.com> * fix (Azure#18417) Co-authored-by: Tianen <347142915@qq.com> Co-authored-by: gk-ms <97893166+gk-ms@users.noreply.github.com> Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com> Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> Co-authored-by: Nilambari <nilamd@microsoft.com> Co-authored-by: nimaller <71352534+nimaller@users.noreply.github.com> Co-authored-by: pracsb <78512712+pr-work@users.noreply.github.com> Co-authored-by: Prachi Bhavsar <prbhavsar@microsoft.com> Co-authored-by: Matthew Yang <79727592+matyang22@users.noreply.github.com> Co-authored-by: utbarn-ms <66377251+utbarn-ms@users.noreply.github.com> Co-authored-by: Ben Eshed <thebenwaters@users.noreply.github.com> Co-authored-by: Satya-anshu <70507845+Satya-anshu@users.noreply.github.com> Co-authored-by: bewaterspassover <103988461+bewaterspassover@users.noreply.github.com> Co-authored-by: Ben Eshed <bewaters@microsoft.com>
* add openapi spec for scvmm * lint fixes, spell fixes * typo fix * prettier * force delete query param * removing some deprecated properties * remove additional props
* update doc * Update configure-python-sdk.md * Update configure-python-sdk.md * Update configure-python-sdk.md
…zure#18713) * add groupids in response * fix prettier issues * fix consistency problem with two swagger file Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>
Co-authored-by: Alex Wilcox <alex.wilcox@cloudsecure.ltd>
* Create 2022-05-01 * Delete 2022-05-01 * Create changes.json * Create GetChange.json * Create ListChanges.json * Update readme.md * Update changes.json * Update readme.md * Update readme.md * Update readme.md * Update readme.md * Update readme.md * Update readme.md
* Update readme.python.md * update * fix
* Copy existing FabricLocation * AzureStack Admin API - Fabric RP - FabricLocation - 2022-03-01 * Revert to original Fabric.json for common type
* swagger review initial commit * Swagger Changes for new API * Swagger Changes for new API * Swagger Changes for new API * Swagger Changes for new API * Swagger Changes for new API * fix validation issue * Swagger Changes for new API * Update readme.md changes to readme * manifest changes for new API
… preview/2019-10-11-preview (Azure#18482) * add x-ms-enum * Fix validation issues * Delete Notebooks spec Co-authored-by: Geoffrey Troyer <geoffreymtroyer@gmail.com> Co-authored-by: Kyle Cutler <kycutler@microsoft.com>
* Enable azure-powershell for all manage RPs * Change integrationRepository to Azure/azure-powershell-pr * Change azure-powershell in api-spec repo * Change azure-powershell in api-spec repo * Remove azure-powershell from some deprecated RPs Co-authored-by: v-yuzhichen@microsoft.com <v-yuzhichen@microsoft.com>
* Add new Sql VA API * Update server level API * Update API attributes * Update controlers * Add missing examples * Fix examples * Format JSON file * Update examples * Updae scan record API * Add ref to README file * Update version * Update enums * Add SystemData * add systemData * sort readme files * Update examples * Update remove baseline API * Add 204 respond to delete API * Add 204 error * Fixed error * Update description * Update swagger * fix PR comments, seperated baseline operations to /baselines/default/rules/ruleid * fix validations errors Co-authored-by: Ahmad Abas <ahabas@microsoft.com>
…er requirements. (Azure#19240) Co-authored-by: Ahmad Abas <ahabas@microsoft.com>
|
Hi, @ericshape Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| compared swaggers (via Oad v0.9.6)] | new version | base version |
|---|---|---|
| DatabaseExtensions.json | 2022-02-01(319ceae) | 2021-11-01(main) |
| DatabaseOperations.json | 2022-02-01(319ceae) | 2021-11-01(main) |
| DatabaseUsages.json | 2022-02-01(319ceae) | 2021-11-01(main) |
| Databases.json | 2022-02-01(319ceae) | 2021-11-01(main) |
| DistributedAvailabilityGroups.json | 2022-02-01(319ceae) | 2021-11-01(main) |
| ElasticPools.json | 2022-02-01(319ceae) | 2021-11-01(main) |
| EncryptionProtectors.json | 2022-02-01(319ceae) | 2021-11-01(main) |
| InstanceFailoverGroups.json | 2022-02-01(319ceae) | 2021-11-01(main) |
| LongTermRetentionPolicies.json | 2022-02-01(319ceae) | 2021-11-01(main) |
| ManagedDatabaseRestoreDetails.json | 2022-02-01(319ceae) | 2021-11-01(main) |
| ManagedDatabaseTransparentDataEncryption.json | 2022-02-01(319ceae) | 2021-11-01(main) |
| ManagedDatabases.json | 2022-02-01(319ceae) | 2021-11-01(main) |
| ManagedInstanceEncryptionProtectors.json | 2022-02-01(319ceae) | 2021-11-01(main) |
| ManagedInstanceKeys.json | 2022-02-01(319ceae) | 2021-11-01(main) |
| ManagedInstanceLongTermRetentionPolicies.json | 2022-02-01(319ceae) | 2021-11-01(main) |
| ManagedInstances.json | 2022-02-01(319ceae) | 2021-11-01(main) |
| ManagedServerDnsAliases.json | 2022-02-01(319ceae) | 2021-11-01(main) |
| ReplicationLinks.json | 2022-02-01(319ceae) | 2021-11-01(main) |
| ServerDevOpsAudit.json | 2022-02-01(319ceae) | 2021-11-01(main) |
| ServerKeys.json | 2022-02-01(319ceae) | 2021-11-01(main) |
| ServerTrustCertificates.json | 2022-02-01(319ceae) | 2021-11-01(main) |
| Servers.json | 2022-02-01(319ceae) | 2021-11-01(main) |
| SyncAgents.json | 2022-02-01(319ceae) | 2021-11-01(main) |
| SyncGroups.json | 2022-02-01(319ceae) | 2021-11-01(main) |
| SyncMembers.json | 2022-02-01(319ceae) | 2021-11-01(main) |
| TimeZones.json | 2022-02-01(319ceae) | 2021-11-01(main) |
| TransparentDataEncryptions.json | 2022-02-01(319ceae) | 2021-11-01(main) |
| VirtualClusters.json | 2022-02-01(319ceae) | 2021-11-01(main) |
The following breaking changes are detected by comparison with the latest preview version:
️❌LintDiff: 8 Errors, 0 Warnings failed [Detail]
| compared tags (via openapi-validator v1.13.0) | new version | base version |
|---|---|---|
| package-preview-2022-02 | package-preview-2022-02(319ceae) | package-preview-2022-02(dev-sql-Microsoft.Sql-2022-02-01-preview) |
The following errors/warnings are introduced by current PR:
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
️❌Avocado: 1 Errors, 1 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
The default tag does not contain all APIs in this RP. Please make sure the missing API swaggers are in the default tag. readme: specification/sql/resource-manager/readme.md json: Microsoft.Sql/preview/2022-02-01-preview/ManagedDatabases.json |
| The default tag contains multiple API versions swaggers. readme: specification/sql/resource-manager/readme.md tag: specification/sql/resource-manager/readme.md#tag-package-composite-v5 |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️SDK Track2 Validation succeeded [Detail]
- The following tags are being changed in this PR
- "https://github.com/Azure/azure-rest-api-specs/blob/319ceaede72ea9b065c6fee4e6a8df6de228d005/specification/sql/resource-manager/readme.md#tag-package-preview-2022-02">sql/resource-manager/readme.md#package-preview-2022-02
| Rule | Message |
|---|---|
|
"readme":"sql/resource-manager/readme.md", "tag":"package-preview-2022-02", "details":"Duplicate Operation 'DatabaseSqlVulnerabilityAssessmentRuleBaselines' > 'Delete' detected(This is most likely due to 2 operation using the same 'operationId' or 'tags'). Duplicates have those paths:\n - delete /subscriptions/subscriptionId/resourceGroups/resourceGroupName/providers/Microsoft.Sql/servers/serverName/databases/databaseName/sqlVulnerabilityAssessments/vulnerabilityAssessmentName/baselines/baselineName/rules/ruleId\n - delete /subscriptions/subscriptionId/resourceGroups/resourceGroupName/providers/Microsoft.Sql/servers/serverName/sqlVulnerabilityAssessments/vulnerabilityAssessmentName/baselines/baselineName/rules/ruleId" |
|
"readme":"sql/resource-manager/readme.md", "tag":"package-preview-2022-02", "details":"Duplicate object schemas with 'SecurityAlertPolicyName' name detected." |
|
"readme":"sql/resource-manager/readme.md", "tag":"package-preview-2022-02", "details":"Error: 2 errors occured -- cannot continue." |
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
Swagger Generation Artifacts
|
|
Hi @ericshape, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Jul 6, 2022
Closed
ericshape
changed the title
raych1
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
sync with the latest 2022-02-01-preview.
request ignore the validation error.
we have not fixed it in the DSMainDev repo. It needs some weeks to schedule and fix it as committer work.
R4041 - XmsIdentifierValidation
request ignore this Avacado error:
we will update the V5 SDK tag later:
❌ MISSING_APIS_IN_DEFAULT_TAG | The default tag does not contain all APIs in this RP. Please make sure the missing API swaggers are in the default tag.readme: specification/sql/resource-manager/readme.mdjson: Microsoft.Sql/preview/2022-02-01-preview/ManagedDatabases.json
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.