Add Init Containers to common definitions #19855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @p-bouchon Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| compared swaggers (via Oad v0.9.6)] | new version | base version |
|---|---|---|
| CommonDefinitions.json | 2022-06-01-preview(6f810fd) | 2022-03-01(main) |
| CommonDefinitions.json | 2022-06-01-preview(6f810fd) | 2022-01-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
| Rule | Message |
|---|---|
| The new version has a different 'allOf' property than the previous one. New: Microsoft.App/preview/2022-06-01-preview/CommonDefinitions.json#L98:5 Old: Microsoft.App/stable/2022-03-01/CommonDefinitions.json#L37:5 |
|
| The new version has a different 'allOf' property than the previous one. New: Microsoft.App/preview/2022-06-01-preview/CommonDefinitions.json#L504:11 Old: Microsoft.App/stable/2022-03-01/CommonDefinitions.json#L474:11 |
The following breaking changes are detected by comparison with the latest preview version:
| Rule | Message |
|---|---|
| The new version has a different 'allOf' property than the previous one. New: Microsoft.App/preview/2022-06-01-preview/CommonDefinitions.json#L98:5 Old: Microsoft.App/preview/2022-01-01-preview/CommonDefinitions.json#L37:5 |
|
| The new version has a different 'allOf' property than the previous one. New: Microsoft.App/preview/2022-06-01-preview/CommonDefinitions.json#L504:11 Old: Microsoft.App/preview/2022-01-01-preview/CommonDefinitions.json#L474:11 |
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v1.13.0) | new version | base version |
|---|---|---|
| package-preview-2022-06 | package-preview-2022-06(6f810fd) | package-preview-2022-06(Microsoft.App-2022-06-01-preview) |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2022-06-01-preview/CommonDefinitions.json#L755 |
|
| Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.App/preview/2022-06-01-preview/CommonDefinitions.json#L1 |
|
| The child tracked resource, 'daprComponents' with immediate parent 'ManagedEnvironment', must have a list by immediate parent operation. Location: Microsoft.App/preview/2022-06-01-preview/CommonDefinitions.json#L588 |
|
| The child tracked resource, 'daprComponents' with immediate parent 'ConnectedEnvironment', must have a list by immediate parent operation. Location: Microsoft.App/preview/2022-06-01-preview/CommonDefinitions.json#L588 |
|
| The child tracked resource, 'certificates' with immediate parent 'ManagedEnvironment', must have a list by immediate parent operation. Location: Microsoft.App/preview/2022-06-01-preview/CommonDefinitions.json#L746 |
|
| The child tracked resource, 'certificates' with immediate parent 'ConnectedEnvironment', must have a list by immediate parent operation. Location: Microsoft.App/preview/2022-06-01-preview/CommonDefinitions.json#L746 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️SDK Track2 Validation: 0 Warnings warning [Detail]
- The following tags are being changed in this PR
- "https://github.com/Azure/azure-rest-api-specs/blob/6f810fd6a7f215a539d7f4d292c23662652acc29/specification/app/resource-manager/readme.md#tag-package-preview-2022-06">app/resource-manager/readme.md#package-preview-2022-06
| Rule | Message |
|---|---|
| "readme":"app/resource-manager/readme.md", "tag":"package-preview-2022-06", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous" |
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
Swagger Generation Artifacts
|
vinisoto
suggested changes
Jul 20, 2022
jijohn14
reviewed
Jul 20, 2022
.../resource-manager/Microsoft.App/stable/2022-05-01/examples/ContainerApps_CreateOrUpdate.json
Outdated
Show resolved
Hide resolved
.../resource-manager/Microsoft.App/stable/2022-05-01/examples/ContainerApps_CreateOrUpdate.json
Outdated
Show resolved
Hide resolved
|
Hi, @p-bouchon. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
ghost
added
Generated ApiView
|
|
Hi @p-bouchon, Your PR has some issues. Please fix the CI sequentially by following the order of
|
|
Hi @p-bouchon, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
jijohn14
reviewed
Aug 10, 2022
...ication/app/resource-manager/Microsoft.App/preview/2022-06-01-preview/CommonDefinitions.json
Show resolved
Hide resolved
ruslany
reviewed
Aug 12, 2022
...ication/app/resource-manager/Microsoft.App/preview/2022-06-01-preview/CommonDefinitions.json
Outdated
Show resolved
Hide resolved
jijohn14
reviewed
Aug 12, 2022
...ication/app/resource-manager/Microsoft.App/preview/2022-06-01-preview/CommonDefinitions.json
Outdated
Show resolved
Hide resolved
jijohn14
approved these changes
Aug 12, 2022
openapi-workflow-bot
bot
added
ARMReview
WaitForARMFeedback
|
Hi, @p-bouchon your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
changlong-liu
removed
WaitForARMFeedback
|
Hi @p-bouchon , I removed "WaitForARMFeedback" since there is no new api defined in this PR. Please let me know if you want to get this PR merged, or do you want to have a review from ARM for some special reason? |
Yes, we are good to merge. Pinged you |
changlong-liu
approved these changes
Aug 19, 2022
leni-msft
pushed a commit
that referenced
this pull request
Sep 22, 2022
* Adds base for updating Microsoft.App from version stable/2022-03-01 to version 2022-05-01 * Updates readme * Updates API version in new specs and examples * Add app diag to 2022-05-01 (#18678) * Add container apps diagnostics * Fix validation errors * Move Microsoft.App diag APIs to 2022-05-01 * Fix validation errors * Fix validation errors * Fix validation errors 3 * Change operationIds Co-authored-by: Michimune Kohno <mikono@microsoft.com> * Fix definition for customhostnameesult (#19014) * fix * update * more fix * Cherry pick for the parameter name fixes for the 2022-03-01 and making the same fixes in 2022-05-01 (#19048) * Correct Probe enums (#18839) * fix probe enums * Fix revision mode enum * Fix patch example * Fix the casing of enums in the latest api version * Change the parameter names to unblock Terraform release (#19005) * contianerapps: fixing swagger inconsistencies in 2022-01-01-preview * containerapps: fixing inconsistencies in the 2022-03-01 swagger * containerapps: updating the examples for 2022-01-01-preview * containerapps: updating the examples to account for the updated parameter names * containerapps: fixing linting * fix probe enums * Fix revision mode enum * Fix the policheck error * Revert "containerapps: fixing linting" This reverts commit 3c4872f. * Revert "containerapps: updating the examples for 2022-01-01-preview" This reverts commit 9b81fbd. * Revert "contianerapps: fixing swagger inconsistencies in 2022-01-01-preview" This reverts commit 553fc55. * Undo changes to 2022-01-01-preview * Fix one issue * fix remaining inconsistency * fix authConfig and sourceControl names Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu> Co-authored-by: Mike Vu <mikevu@microsoft.com> * Change param names * Fix examples * Fix CI errors Co-authored-by: Mike Vu <mikevu@microsoft.com> Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu> * Fix description in all API versions (#19313) * Fix description for ManagedEnvironment.Internal property (#19307) * Fix descriptions in all api versions * Add traffic info to revisions api (#19054) * Add traffic info to a revision api * Add deprecated prop * Prettier fixes * 1pdate based on new proposal * Rename * Change names * minor fix * Add httpReadBufferSize to dapr config in Microsoft.App-2022-05-01 (#19360) * Add httpReadBufferSize to dapr config * remove nullable * Adds base for updating Microsoft.App from version stable/2022-05-01 to version 2022-06-01-preview * Updates readme * Updates API version in new specs and examples * Add new resources for 2022-06-01-preview (#19494) * update * update * update * fix * update * update * update * update * fix * update * update * Enable Dapr AI Connection string for Microsoft.App connected environment (#19974) * Enable Dapr AI Connection string for Microsoft.App connected environment * Fix dapr ai connection string * remove read * remove read permission of dapr ai connection string and instrument key for managed environment * fixes for comments * update (#20013) * Fixdescriptions on microsoft.app 2022 06 01 preview (#20133) * Fix casing for detector properties * Fix descriptions * Fix descriptions and detectorProperties in 2022-06-01-preview * Added `secretsStoreComponent` in 2022-06-01 spec (#20044) * Added `secretsStoreComponent` in 2022-06-01 spec Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com> * Fixed typos and added example of name/key Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com> * Add custom domain configuration for managed environment (#20149) Co-authored-by: Mengjun Qin <menqin@microsoft.com> * Add additional Dapr options (2022-06-01-preview) (#19886) * Add additional Dapr options * Update examples for 2022-06-01-preview * force ci * force ci * force ci * adding ip-restriction feat (#19841) * adding ip-restriction feat * remove from stable, add to preview * fix lintDiff error * fix modelvalidation error * fix formatting changes * rename names, add note to all allow or all deny * fix spell check error * update name and examples * rename `ipAddress` to `ipAddressRange` * making small change to re-run build pipeline * trigger GitHub actions * resolve comments Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com> * Remove Traffic Labels from revisions because they haven't been impelemented (#20261) * Revert "Add traffic info to revisions api (#19054)" This reverts commit 056cc51. * Remove traffic labels from revisions * Add property for tcp apps (#20193) * Add property for tcp apps * Add scale * Fix * Fix * Add Init Containers to common definitions (#19855) * add init containers to common definitions * move changes to 06-01 preview * remove repeated container definition * fix allof syntax * fix anonymous container definition * fix lintdiff errors * fix container allof syntax * add more init examples * split baseContainer definition * remove description Co-authored-by: p-bouchon <pbouchon@microsoft.com> * Update container app provisioningstate (#20411) * update * update * add property: maxInactiveRevisions (#20334) * add property: maxInactiveRevisions * update * update * Add premium sku related properties for managed environment (#19770) * Add premium sku related properties for managed environment * Move sku to base property * Add workloadProfileType * Examples for managed environment * Add container app example * Fix workloadProfiles * Add custom word * Fix WorkloadProfileType references * prettier fixes * Fix workload profile * Fix typo * remove readonly property for workload profile * Add object type * nit: Fix description location * Fix XmsIdentifierValidation * Remove spaces from enum values * Remove unwanted change * Add aka ms url * Update examples for workload profile type * Fix rebase issue * Fix json * Update description and move location * Remove provisioning state for node pool * sku capacity explanation * Remove capacity attribute * Remove capacity attribute from required * Mark sku property as required * Add x-ms-identifiers * Rename mimum and maximum * Rename skutype to skuName * Make sku property as optional * Make workload profile type as string * fix go SDK automation config Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn> * Fix source control status code in 2022-06-01-preview. (#20429) * Remove 20220501 because we will not support it in server side (#20427) * remove * update * Added support for user defined routing (#20464) * Added support for user defined routing * Added examples * fixed JSON syntax * syntax fix * fixed vnetenvironment syntax * fixed camel case * case fix * enum syntax * fixed comma cases ManagedEnvironmentOutBoundType * fixing casing * Some more APIs (#20448) * new APIs to 06-01 * test fix * more fixes * add last active time for revision (#20658) * Add custom domain for connected env (#20731) * add custom domain * fhcekout * billingMeters - GET endpoint (#20485) * Swagger documentation for /locations/{location}/billingMeters - GET endpoint * Add example, fix validation errors * Fix ARM validation errors, code review comments * Fix response validation * add proxy resource properties * Response formatting * add default error response * ARM Review feedback + small naming change for a property * Change GB to GiB * Fix 2022-06-01-preview branch merge conflicts (#20773) * Reset * more fixes * More fixes * another conflict fix * Fix old preview version * fix 2022-03-01 * supress lint Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com> Co-authored-by: Ruslan Yakushev <1664475+ruslany@users.noreply.github.com> Co-authored-by: michimune <michimune@outlook.com> Co-authored-by: Michimune Kohno <mikono@microsoft.com> Co-authored-by: Mike Vu <mikevu@microsoft.com> Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu> Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com> Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com> Co-authored-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com> Co-authored-by: Mengjun Qin <767524684@qq.com> Co-authored-by: Mengjun Qin <menqin@microsoft.com> Co-authored-by: Taher Daroly <41846928+tdaroly@users.noreply.github.com> Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com> Co-authored-by: zhenqxuMSFT <zhenqxu@microsoft.com> Co-authored-by: p-bouchon <107427816+p-bouchon@users.noreply.github.com> Co-authored-by: p-bouchon <pbouchon@microsoft.com> Co-authored-by: njucz <740360112@qq.com> Co-authored-by: JJ <jijohn@microsoft.com> Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn> Co-authored-by: yalixiang <88011184+yalixiang@users.noreply.github.com> Co-authored-by: Mahmoud Desokey <desokey@yahoo.com> Co-authored-by: Xingjian Wang <79332479+xwang971@users.noreply.github.com> Co-authored-by: trajkobal <108365738+trajkobal@users.noreply.github.com>
leni-msft
pushed a commit
that referenced
this pull request
Sep 27, 2022
* Adds base for updating Microsoft.App from version stable/2022-03-01 to version 2022-05-01 * Updates readme * Updates API version in new specs and examples * Add app diag to 2022-05-01 (#18678) * Add container apps diagnostics * Fix validation errors * Move Microsoft.App diag APIs to 2022-05-01 * Fix validation errors * Fix validation errors * Fix validation errors 3 * Change operationIds Co-authored-by: Michimune Kohno <mikono@microsoft.com> * Fix definition for customhostnameesult (#19014) * fix * update * more fix * Cherry pick for the parameter name fixes for the 2022-03-01 and making the same fixes in 2022-05-01 (#19048) * Correct Probe enums (#18839) * fix probe enums * Fix revision mode enum * Fix patch example * Fix the casing of enums in the latest api version * Change the parameter names to unblock Terraform release (#19005) * contianerapps: fixing swagger inconsistencies in 2022-01-01-preview * containerapps: fixing inconsistencies in the 2022-03-01 swagger * containerapps: updating the examples for 2022-01-01-preview * containerapps: updating the examples to account for the updated parameter names * containerapps: fixing linting * fix probe enums * Fix revision mode enum * Fix the policheck error * Revert "containerapps: fixing linting" This reverts commit 3c4872f. * Revert "containerapps: updating the examples for 2022-01-01-preview" This reverts commit 9b81fbd. * Revert "contianerapps: fixing swagger inconsistencies in 2022-01-01-preview" This reverts commit 553fc55. * Undo changes to 2022-01-01-preview * Fix one issue * fix remaining inconsistency * fix authConfig and sourceControl names Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu> Co-authored-by: Mike Vu <mikevu@microsoft.com> * Change param names * Fix examples * Fix CI errors Co-authored-by: Mike Vu <mikevu@microsoft.com> Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu> * Fix description in all API versions (#19313) * Fix description for ManagedEnvironment.Internal property (#19307) * Fix descriptions in all api versions * Add traffic info to revisions api (#19054) * Add traffic info to a revision api * Add deprecated prop * Prettier fixes * 1pdate based on new proposal * Rename * Change names * minor fix * Add httpReadBufferSize to dapr config in Microsoft.App-2022-05-01 (#19360) * Add httpReadBufferSize to dapr config * remove nullable * Adds base for updating Microsoft.App from version stable/2022-05-01 to version 2022-06-01-preview * Updates readme * Updates API version in new specs and examples * Add new resources for 2022-06-01-preview (#19494) * update * update * update * fix * update * update * update * update * fix * update * update * Enable Dapr AI Connection string for Microsoft.App connected environment (#19974) * Enable Dapr AI Connection string for Microsoft.App connected environment * Fix dapr ai connection string * remove read * remove read permission of dapr ai connection string and instrument key for managed environment * fixes for comments * update (#20013) * Fixdescriptions on microsoft.app 2022 06 01 preview (#20133) * Fix casing for detector properties * Fix descriptions * Fix descriptions and detectorProperties in 2022-06-01-preview * Added `secretsStoreComponent` in 2022-06-01 spec (#20044) * Added `secretsStoreComponent` in 2022-06-01 spec Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com> * Fixed typos and added example of name/key Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com> * Add custom domain configuration for managed environment (#20149) Co-authored-by: Mengjun Qin <menqin@microsoft.com> * Add additional Dapr options (2022-06-01-preview) (#19886) * Add additional Dapr options * Update examples for 2022-06-01-preview * force ci * force ci * force ci * adding ip-restriction feat (#19841) * adding ip-restriction feat * remove from stable, add to preview * fix lintDiff error * fix modelvalidation error * fix formatting changes * rename names, add note to all allow or all deny * fix spell check error * update name and examples * rename `ipAddress` to `ipAddressRange` * making small change to re-run build pipeline * trigger GitHub actions * resolve comments Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com> * Remove Traffic Labels from revisions because they haven't been impelemented (#20261) * Revert "Add traffic info to revisions api (#19054)" This reverts commit 056cc51. * Remove traffic labels from revisions * Add property for tcp apps (#20193) * Add property for tcp apps * Add scale * Fix * Fix * Add Init Containers to common definitions (#19855) * add init containers to common definitions * move changes to 06-01 preview * remove repeated container definition * fix allof syntax * fix anonymous container definition * fix lintdiff errors * fix container allof syntax * add more init examples * split baseContainer definition * remove description Co-authored-by: p-bouchon <pbouchon@microsoft.com> * Update container app provisioningstate (#20411) * update * update * add property: maxInactiveRevisions (#20334) * add property: maxInactiveRevisions * update * update * Add premium sku related properties for managed environment (#19770) * Add premium sku related properties for managed environment * Move sku to base property * Add workloadProfileType * Examples for managed environment * Add container app example * Fix workloadProfiles * Add custom word * Fix WorkloadProfileType references * prettier fixes * Fix workload profile * Fix typo * remove readonly property for workload profile * Add object type * nit: Fix description location * Fix XmsIdentifierValidation * Remove spaces from enum values * Remove unwanted change * Add aka ms url * Update examples for workload profile type * Fix rebase issue * Fix json * Update description and move location * Remove provisioning state for node pool * sku capacity explanation * Remove capacity attribute * Remove capacity attribute from required * Mark sku property as required * Add x-ms-identifiers * Rename mimum and maximum * Rename skutype to skuName * Make sku property as optional * Make workload profile type as string * fix go SDK automation config Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn> * Fix source control status code in 2022-06-01-preview. (#20429) * Remove 20220501 because we will not support it in server side (#20427) * remove * update * Added support for user defined routing (#20464) * Added support for user defined routing * Added examples * fixed JSON syntax * syntax fix * fixed vnetenvironment syntax * fixed camel case * case fix * enum syntax * fixed comma cases ManagedEnvironmentOutBoundType * fixing casing * Some more APIs (#20448) * new APIs to 06-01 * test fix * more fixes * add last active time for revision (#20658) * Add custom domain for connected env (#20731) * add custom domain * fhcekout * billingMeters - GET endpoint (#20485) * Swagger documentation for /locations/{location}/billingMeters - GET endpoint * Add example, fix validation errors * Fix ARM validation errors, code review comments * Fix response validation * add proxy resource properties * Response formatting * add default error response * ARM Review feedback + small naming change for a property * Change GB to GiB * Rename Action * secrets tag * missed fix Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com> Co-authored-by: Ruslan Yakushev <1664475+ruslany@users.noreply.github.com> Co-authored-by: michimune <michimune@outlook.com> Co-authored-by: Michimune Kohno <mikono@microsoft.com> Co-authored-by: Zunli Hu <zuh@microsoft.com> Co-authored-by: Mike Vu <mikevu@microsoft.com> Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu> Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com> Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com> Co-authored-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com> Co-authored-by: Mengjun Qin <767524684@qq.com> Co-authored-by: Mengjun Qin <menqin@microsoft.com> Co-authored-by: Taher Daroly <41846928+tdaroly@users.noreply.github.com> Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com> Co-authored-by: zhenqxuMSFT <zhenqxu@microsoft.com> Co-authored-by: p-bouchon <107427816+p-bouchon@users.noreply.github.com> Co-authored-by: p-bouchon <pbouchon@microsoft.com> Co-authored-by: njucz <740360112@qq.com> Co-authored-by: JJ <jijohn@microsoft.com> Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn> Co-authored-by: yalixiang <88011184+yalixiang@users.noreply.github.com> Co-authored-by: Mahmoud Desokey <desokey@yahoo.com> Co-authored-by: trajkobal <108365738+trajkobal@users.noreply.github.com>
leni-msft
pushed a commit
that referenced
this pull request
Sep 28, 2022
* Adds base for updating Microsoft.App from version stable/2022-03-01 to version 2022-05-01 * Updates readme * Updates API version in new specs and examples * Add app diag to 2022-05-01 (#18678) * Add container apps diagnostics * Fix validation errors * Move Microsoft.App diag APIs to 2022-05-01 * Fix validation errors * Fix validation errors * Fix validation errors 3 * Change operationIds Co-authored-by: Michimune Kohno <mikono@microsoft.com> * Fix definition for customhostnameesult (#19014) * fix * update * more fix * Cherry pick for the parameter name fixes for the 2022-03-01 and making the same fixes in 2022-05-01 (#19048) * Correct Probe enums (#18839) * fix probe enums * Fix revision mode enum * Fix patch example * Fix the casing of enums in the latest api version * Change the parameter names to unblock Terraform release (#19005) * contianerapps: fixing swagger inconsistencies in 2022-01-01-preview * containerapps: fixing inconsistencies in the 2022-03-01 swagger * containerapps: updating the examples for 2022-01-01-preview * containerapps: updating the examples to account for the updated parameter names * containerapps: fixing linting * fix probe enums * Fix revision mode enum * Fix the policheck error * Revert "containerapps: fixing linting" This reverts commit 3c4872f. * Revert "containerapps: updating the examples for 2022-01-01-preview" This reverts commit 9b81fbd. * Revert "contianerapps: fixing swagger inconsistencies in 2022-01-01-preview" This reverts commit 553fc55. * Undo changes to 2022-01-01-preview * Fix one issue * fix remaining inconsistency * fix authConfig and sourceControl names Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu> Co-authored-by: Mike Vu <mikevu@microsoft.com> * Change param names * Fix examples * Fix CI errors Co-authored-by: Mike Vu <mikevu@microsoft.com> Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu> * Fix description in all API versions (#19313) * Fix description for ManagedEnvironment.Internal property (#19307) * Fix descriptions in all api versions * Add traffic info to revisions api (#19054) * Add traffic info to a revision api * Add deprecated prop * Prettier fixes * 1pdate based on new proposal * Rename * Change names * minor fix * Add httpReadBufferSize to dapr config in Microsoft.App-2022-05-01 (#19360) * Add httpReadBufferSize to dapr config * remove nullable * Adds base for updating Microsoft.App from version stable/2022-05-01 to version 2022-06-01-preview * Updates readme * Updates API version in new specs and examples * Add new resources for 2022-06-01-preview (#19494) * update * update * update * fix * update * update * update * update * fix * update * update * Enable Dapr AI Connection string for Microsoft.App connected environment (#19974) * Enable Dapr AI Connection string for Microsoft.App connected environment * Fix dapr ai connection string * remove read * remove read permission of dapr ai connection string and instrument key for managed environment * fixes for comments * update (#20013) * Fixdescriptions on microsoft.app 2022 06 01 preview (#20133) * Fix casing for detector properties * Fix descriptions * Fix descriptions and detectorProperties in 2022-06-01-preview * Added `secretsStoreComponent` in 2022-06-01 spec (#20044) * Added `secretsStoreComponent` in 2022-06-01 spec Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com> * Fixed typos and added example of name/key Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com> * Add custom domain configuration for managed environment (#20149) Co-authored-by: Mengjun Qin <menqin@microsoft.com> * Add additional Dapr options (2022-06-01-preview) (#19886) * Add additional Dapr options * Update examples for 2022-06-01-preview * force ci * force ci * force ci * adding ip-restriction feat (#19841) * adding ip-restriction feat * remove from stable, add to preview * fix lintDiff error * fix modelvalidation error * fix formatting changes * rename names, add note to all allow or all deny * fix spell check error * update name and examples * rename `ipAddress` to `ipAddressRange` * making small change to re-run build pipeline * trigger GitHub actions * resolve comments Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com> * Remove Traffic Labels from revisions because they haven't been impelemented (#20261) * Revert "Add traffic info to revisions api (#19054)" This reverts commit 056cc51. * Remove traffic labels from revisions * Add property for tcp apps (#20193) * Add property for tcp apps * Add scale * Fix * Fix * Add Init Containers to common definitions (#19855) * add init containers to common definitions * move changes to 06-01 preview * remove repeated container definition * fix allof syntax * fix anonymous container definition * fix lintdiff errors * fix container allof syntax * add more init examples * split baseContainer definition * remove description Co-authored-by: p-bouchon <pbouchon@microsoft.com> * Update container app provisioningstate (#20411) * update * update * add property: maxInactiveRevisions (#20334) * add property: maxInactiveRevisions * update * update * Add premium sku related properties for managed environment (#19770) * Add premium sku related properties for managed environment * Move sku to base property * Add workloadProfileType * Examples for managed environment * Add container app example * Fix workloadProfiles * Add custom word * Fix WorkloadProfileType references * prettier fixes * Fix workload profile * Fix typo * remove readonly property for workload profile * Add object type * nit: Fix description location * Fix XmsIdentifierValidation * Remove spaces from enum values * Remove unwanted change * Add aka ms url * Update examples for workload profile type * Fix rebase issue * Fix json * Update description and move location * Remove provisioning state for node pool * sku capacity explanation * Remove capacity attribute * Remove capacity attribute from required * Mark sku property as required * Add x-ms-identifiers * Rename mimum and maximum * Rename skutype to skuName * Make sku property as optional * Make workload profile type as string * fix go SDK automation config Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn> * Fix source control status code in 2022-06-01-preview. (#20429) * Swagger documentation for /locations/{location}/billingMeters - GET endpoint * Add example, fix validation errors * Fix ARM validation errors, code review comments * Fix response validation * Remove 20220501 because we will not support it in server side (#20427) * remove * update * add proxy resource properties * Response formatting * Added support for user defined routing (#20464) * Added support for user defined routing * Added examples * fixed JSON syntax * syntax fix * fixed vnetenvironment syntax * fixed camel case * case fix * enum syntax * fixed comma cases ManagedEnvironmentOutBoundType * fixing casing * add default error response * Add available workprofiles -GET endpoint * Remove duplicate schema name WorkloadProfile * Change memoryGiB to memoryGB as suggested in code review * Add x-ms-pageable - nextLink support to not introduce breaking changes in the future * rename to memory in GiB because our case is Gibibytes base 1024 * change friendlyName to displayName * Some more APIs (#20448) * new APIs to 06-01 * test fix * more fixes * Add new property to the response object * add last active time for revision (#20658) * Add custom domain for connected env (#20731) * add custom domain * fhcekout * billingMeters - GET endpoint (#20485) * Swagger documentation for /locations/{location}/billingMeters - GET endpoint * Add example, fix validation errors * Fix ARM validation errors, code review comments * Fix response validation * add proxy resource properties * Response formatting * add default error response * ARM Review feedback + small naming change for a property * Change GB to GiB * Change the boolean value for default to enum * change error response to v3/ErrorResponse * Fix 2022-06-01-preview branch merge conflicts (#20773) * Reset * more fixes * More fixes * another conflict fix * Fix old preview version * fix 2022-03-01 Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com> Co-authored-by: Ruslan Yakushev <1664475+ruslany@users.noreply.github.com> Co-authored-by: michimune <michimune@outlook.com> Co-authored-by: Michimune Kohno <mikono@microsoft.com> Co-authored-by: Zunli Hu <zuh@microsoft.com> Co-authored-by: Mike Vu <mikevu@microsoft.com> Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu> Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com> Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com> Co-authored-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com> Co-authored-by: Mengjun Qin <767524684@qq.com> Co-authored-by: Mengjun Qin <menqin@microsoft.com> Co-authored-by: Taher Daroly <41846928+tdaroly@users.noreply.github.com> Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com> Co-authored-by: zhenqxuMSFT <zhenqxu@microsoft.com> Co-authored-by: p-bouchon <107427816+p-bouchon@users.noreply.github.com> Co-authored-by: p-bouchon <pbouchon@microsoft.com> Co-authored-by: njucz <740360112@qq.com> Co-authored-by: JJ <jijohn@microsoft.com> Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn> Co-authored-by: yalixiang <88011184+yalixiang@users.noreply.github.com> Co-authored-by: Mahmoud Desokey <desokey@yahoo.com> Co-authored-by: Xingjian Wang <79332479+xwang971@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.