KustoPool: Add aadObjectId property #19856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @amitelran Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| compared swaggers (via Oad v0.9.6)] | new version | base version |
|---|---|---|
| kustoPool.json | 2021-06-01(ae523a2) | 2021-06-01(main) |
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v1.13.0) | new version | base version |
|---|---|---|
| package-composite-v2 | package-composite-v2(ae523a2) | package-composite-v2(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The parameters:workspaceName,kustoPoolName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L182 |
|
The parameters:workspaceName,resourceGroupName,kustoPoolName should be kept in the same order as they present in the path. Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L225 |
|
The parameters:workspaceName,resourceGroupName,kustoPoolName should be kept in the same order as they present in the path. Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L300 |
|
The parameters:workspaceName,resourceGroupName,kustoPoolName should be kept in the same order as they present in the path. Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L367 |
|
The parameters:workspaceName,kustoPoolName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L416 |
|
The parameters:workspaceName,kustoPoolName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L462 |
|
The parameters:workspaceName,kustoPoolName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L508 |
|
The parameters:workspaceName,kustoPoolName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L556 |
|
The parameters:workspaceName,kustoPoolName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L614 |
|
The parameters:workspaceName,kustoPoolName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L662 |
|
The parameters:workspaceName,kustoPoolName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L717 |
|
The parameters:workspaceName,kustoPoolName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L772 |
|
The parameters:workspaceName,kustoPoolName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L820 |
|
The parameters:workspaceName,kustoPoolName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L875 |
|
The parameters:workspaceName,kustoPoolName,attachedDatabaseConfigurationName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L923 |
|
The parameters:workspaceName,kustoPoolName,attachedDatabaseConfigurationName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L969 |
|
The parameters:workspaceName,kustoPoolName,attachedDatabaseConfigurationName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1037 |
|
The parameters:workspaceName,kustoPoolName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1765 |
|
The parameters:workspaceName,kustoPoolName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1819 |
|
The parameters:workspaceName,kustoPoolName,principalAssignmentName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1867 |
|
The parameters:workspaceName,kustoPoolName,principalAssignmentName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1913 |
|
The parameters:workspaceName,kustoPoolName,principalAssignmentName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L1975 |
|
The parameters:workspaceName,kustoPoolName,databaseName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L2027 |
|
The parameters:workspaceName,kustoPoolName,databaseName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L2084 |
|
The parameters:workspaceName,kustoPoolName,databaseName,principalAssignmentName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L2135 |
|
The parameters:workspaceName,kustoPoolName,databaseName,principalAssignmentName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L2184 |
|
The parameters:workspaceName,kustoPoolName,databaseName,principalAssignmentName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L2249 |
|
Missing identifier id in array item property Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L2309 |
|
Missing identifier id in array item property Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L2383 |
|
Missing identifier id in array item property Location: Microsoft.Synapse/preview/2021-06-01-preview/kustoPool.json#L2420 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/synapse/resource-manager/readme.md tag: specification/synapse/resource-manager/readme.md#tag-package-composite-v2 |
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️❌ModelValidation: 6 Errors, 0 Warnings failed [Detail]
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️⚠️SDK Track2 Validation: 2 Warnings warning [Detail]
- The following tags are being changed in this PR
- "https://github.com/Azure/azure-rest-api-specs/blob/ae523a269ec6b3665790fc1fa1085dc95002d2ac/specification/synapse/resource-manager/readme.md#tag-package-composite-v2">synapse/resource-manager/readme.md#package-composite-v2
| Rule | Message |
|---|---|
| "readme":"synapse/resource-manager/readme.md", "tag":"package-composite-v2", "details":"Duplicate Schema named 'PrivateEndpointConnectionForPrivateLinkHubBasic' (5 differences):\n - properties.id.$ref: "#/components/schemas/schemas:93" => "#/components/schemas/schemas:1467"\n - properties.id.description: "identifier" =>\n - properties.id.readOnly: true =>\n - properties.properties.description: "Properties of private endpoint connection for private link hub" =>\n - properties.properties.x-ms-client-flatten: true =>" |
|
| "readme":"synapse/resource-manager/readme.md", "tag":"package-composite-v2", "details":"The schema 'KekIdentityProperties-useSystemAssignedIdentity' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/workspace.json#/components/schemas/KekIdentityProperties-useSystemAssignedIdentity" |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
| "readme":"synapse/resource-manager/readme.md", "tag":"package-composite-v2", "details":"Schema 'ReplicationLink' has a property 'type' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from ReplicationLink" |
|
| "readme":"synapse/resource-manager/readme.md", "tag":"package-composite-v2", "details":"Deduplicating schema name: 'SecurityAlertPolicyName' -> 'SecurityAlertPolicyNameAutoGenerated'" |
|
| "readme":"synapse/resource-manager/readme.md", "tag":"package-composite-v2", "details":"Deduplicating schema name: 'PrivateEndpointConnectionForPrivateLinkHubBasic' -> 'PrivateEndpointConnectionForPrivateLinkHubBasicAutoGenerated'" |
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
Swagger Generation Artifacts
|
|
Hi @amitelran, Your PR has some issues. Please fix the CI sequentially by following the order of
|
|
NewApiVersionRequired reason: |
This was referenced Jul 20, 2022
wonner
approved these changes
Jul 21, 2022
JeffreyRichter
added
the
Approved-BreakingChange
ruowan
approved these changes
Jul 25, 2022
This was referenced Jul 25, 2022
akning-ms
pushed a commit
that referenced
this pull request
Aug 1, 2022
* update folder structure * small errors and CI check * [Language Text] Update swagger titles (#19835) * [Language Text] Update swagger titles * edits * address feedback * Review request for Microsoft.ContainerService to add version 2022-06-01 (#19848) * Adds base for updating Microsoft.ContainerService from version stable/2022-04-01 to version 2022-06-01 * Updates readme * Updates API version in new specs and examples * update readmes (#19421) * Add key management service profile of a managed cluster for version 2022-06-01 (#19529) * Add NetworkPlugin none option to 2022-06-01 (#19510) * Add NetworkPlugin none option to 2022-06-01 * improve description for none value * Fix violated rule R4041 for 2022-06-01 managedCluster swagger (#19581) * remove useless directive * fix R4041 * GA AKS support for Dedicated Host Group (#19547) * GA AKS support for Dedicated Host Group * fit some format minor issue * add newline in end of files * Defender updates (#19665) * Defender updates * sample * remove old description Co-authored-by: Bin Xia <binxi@microsoft.com> Co-authored-by: Matt Stam <mattstam@live.com> Co-authored-by: Jianping Zeng <zjpjack@users.noreply.github.com> Co-authored-by: Or Parnes <orparnes@microsoft.com> * Update resources.json (#19861) * Pattts/predictive autoscale 20221001 (#19765) * Rev Autoscale API from 2021-05-01-preview to 2022-10-01. * Fix minor swagger issue. Default should be 'false' * Fix swagger validation error * Defining a new package 2022-10 * AutoscaleSettingResource now reference allOf 'resource' which is the actual autoscaleSetting resource definition * Fix require property issue * Run prettier against autoscale_API.json * [Maps - Render & Spatial Services] add v2022-08-01 (#19520) * copy old swagger to new folders * set api version to 2022-08-01 * apply api changes Co-authored-by: Gigi Grajo <gigigrajo@microsoft.com> * update appconfiguration (#19330) * update appconfiguration * Update readme.python.md * Update readme.python.md * Update readme.python.md * Update readme.python.md * Update readme.python.md * Update readme.python.md * Update readme.python.md * [Hub Generated] Publish private branch 'main' (#19852) * Add StorageMover specification for PubliC Preview * SpellCheck fix * Update custom-words * Update specification/storagemover/resource-manager/readme.md Co-authored-by: Abhishek Krishna <abkrish@microsoft.com> Co-authored-by: Dapeng Zhang <dapzhang@microsoft.com> * Merging Dynatrace swagger in stable folder (#19862) * Committing base swagger version * Removing preview tag from stable folder api version * Changing version name in all the files * Updating readme.go and readme.md files * [CDN] Fix customDomains property type in Endpoint (#19788) * [CDN] Fix customDomains property type in Endpoint * Fix linter error Co-authored-by: Bo Zhang <bzhan@microsoft.com> * Adding Microsoft.Sql AdvancedThreatProtectionSettings APIs for MI on v5 tag for 2022-02-01-preview (#19866) * update folders * [Hub Generated] Review request for Microsoft.KeyVault to add version stable/7.3 (#19844) * Update description of exportable attribute and release_policy.data * Remove submodule azure-reset-api-specs * Fix description for exportable Co-authored-by: Sunny Solanki <Sunny.Solanki@microsoft.com> * Add latest StorageMover updates (#19876) * Add StorageMover specification for PubliC Preview * SpellCheck fix * Update custom-words * Update specification/storagemover/resource-manager/readme.md * Add latest StorageMover updates Co-authored-by: Abhishek Krishna <abkrish@microsoft.com> Co-authored-by: Dapeng Zhang <dapzhang@microsoft.com> * Update readme.python.md (#19899) * Update readme.python.md * Update readme.md * Moving files from azure-rest-spec-pr to azure-rest-spec repo after api review (#19878) * Moving files from azure-rest-spec-pr to azure-rest-spec repo after api review * Add known words * Removed static IP allocation only from examples (#19858) * Removed static IP allocation * Removed static only from examples Co-authored-by: Arpit Gagneja <argagnej@microsoft.com> * Update securityinsights readme.python (#19903) * update securityinsights readme.python * Update readme.python.md Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <v-zhenbwei@microsoft.com> * fix lint errors in Synapse trigger.json (#19660) * put json files into RP folders * update readme * Add CONTRIBUTING.md (#19257) * Add CONTRIBUTING.md * Apply suggestions from PR review Co-authored-by: Heath Stewart <heaths@outlook.com> * Apply suggestions from PR review Co-authored-by: Weidong Xu <weidxu@microsoft.com> * Regen toc for CONTRIBUTING.md * Address PR review comments * Address PR review comments Co-authored-by: Heath Stewart <heaths@outlook.com> Co-authored-by: Weidong Xu <weidxu@microsoft.com> * fix devcenter readme.go.md config (#19906) * fix readme.go.md config * rename to SkuInfo * add annotation for labservices (#19884) * add to description of OS state (#19764) * [Hub Generated] Review request for Microsoft.KeyVault to add version preview/2021-06-01-preview (#19767) * Updated the managed hsm resource manager spec to include two additional properties for private endpoint connection item * Update managed hsm private endpoint connection item in mhsm spec for latest api version * Address LRO_RESPONSE_HEADER violation for managed hsm Long running operations that are annotated with x-ms-long-running-operation:true must return location header or azure-AsyncOperation in response. Added the missing location header for managed hsm update command as well as to the corresponding examples. * [Microsoft.DeviceUpdate] Adding first stable API version (#19846) * Copied the most recent preview version into the first stable version * Updated api version in new stable version, added the tag to readme.md * Fixed typo * Fixed the wrong path in readme.md * Reverted VS Code automatic breaking change * Fix broken link (#19688) * add aadObjectId property to kustoPool (#19856) Co-authored-by: Amit Elran <amelran@microsoft.com> * Updata securityinsights readme.python (#19917) * update securityinsights readme.python * update readme.python Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <v-zhenbwei@microsoft.com> * modify readme.typescripy.md for compute package (#19607) Co-authored-by: ZiWei Chen (WICRESOFT NORTH AMERICA LTD) <v-ziweichen@microsoft.com> * Dev gubalasu frontdoor microsoft.network 2021 06 01 (#19578) * Adds base for updating Microsoft.Network from version stable/2020-05-01 to version 2021-06-01 * Updates readme * Updates API version in new specs and examples * update waf configs and examples from 2020-11-01 * Update api version in new specs and examples * Migration api update * Update readme * Fix readme * update readme * Fix readme again * Fix readme * Fix readme * update waf policy provisioning state * Update securityinsights readme.python (#19923) * update securityinsights readme.python * update readme.python * last modify * Update readme.python.md Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <v-zhenbwei@microsoft.com> * sync with changes made to master * update folder structure * small errors and CI check * update folders * put json files into RP folders * update readme * resolve capitalization and number misplacement accident Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com> Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com> Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com> Co-authored-by: Bin Xia <binxi@microsoft.com> Co-authored-by: Matt Stam <mattstam@live.com> Co-authored-by: Jianping Zeng <zjpjack@users.noreply.github.com> Co-authored-by: Or Parnes <orparnes@microsoft.com> Co-authored-by: Alexander Batishchev <abatishchev@gmail.com> Co-authored-by: PatrickTseng <pattts@microsoft.com> Co-authored-by: gigi <52640944+gigigoo0@users.noreply.github.com> Co-authored-by: Gigi Grajo <gigigrajo@microsoft.com> Co-authored-by: zhenbiao wei <424401670@qq.com> Co-authored-by: Abhishek Krishna <AbhishekKrishna123@users.noreply.github.com> Co-authored-by: Abhishek Krishna <abkrish@microsoft.com> Co-authored-by: Dapeng Zhang <dapzhang@microsoft.com> Co-authored-by: Divyansh Agarwal <83802474+divyansh3131@users.noreply.github.com> Co-authored-by: t-bzhan <61817681+t-bzhan@users.noreply.github.com> Co-authored-by: Bo Zhang <bzhan@microsoft.com> Co-authored-by: Uriel Cohen <urielc@microsoft.com> Co-authored-by: susolank <73919400+susolank@users.noreply.github.com> Co-authored-by: Sunny Solanki <Sunny.Solanki@microsoft.com> Co-authored-by: Ralf Beckers <bexxx@users.noreply.github.com> Co-authored-by: arpit-gagneja <gagneja.arpit@gmail.com> Co-authored-by: Arpit Gagneja <argagnej@microsoft.com> Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <v-zhenbwei@microsoft.com> Co-authored-by: YanjunGao <85206987+yanjungao718@users.noreply.github.com> Co-authored-by: Mike Kistler <mikekistler@microsoft.com> Co-authored-by: Heath Stewart <heaths@outlook.com> Co-authored-by: Weidong Xu <weidxu@microsoft.com> Co-authored-by: Jiahui Peng <46921893+Alancere@users.noreply.github.com> Co-authored-by: j-zhong-ms <107880703+j-zhong-ms@users.noreply.github.com> Co-authored-by: Tom FitzMacken <tomfitz@microsoft.com> Co-authored-by: neeerajaakula <81248992+neeerajaakula@users.noreply.github.com> Co-authored-by: darkoa-msft <61987922+darkoa-msft@users.noreply.github.com> Co-authored-by: Roy Wellington <53838718+roy-work@users.noreply.github.com> Co-authored-by: Amit Elran <amitelran2110@gmail.com> Co-authored-by: Amit Elran <amelran@microsoft.com> Co-authored-by: kazrael2119 <98569699+kazrael2119@users.noreply.github.com> Co-authored-by: ZiWei Chen (WICRESOFT NORTH AMERICA LTD) <v-ziweichen@microsoft.com> Co-authored-by: gubalasu <59630928+gubalasu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.