Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Databases, ReplicationLinks APIs for SQL DB on v5 tag for 2022-02-01 #19895

Merged
merged 3 commits into from
Jul 27, 2022
Merged

Adding Databases, ReplicationLinks APIs for SQL DB on v5 tag for 2022-02-01 #19895

merged 3 commits into from
Jul 27, 2022

Conversation

subhrob
Copy link
Contributor

@subhrob subhrob commented Jul 22, 2022

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
      Adding a Microsoft.Sql new API to tag v5 to develop .NET SDK client.
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @subhrob Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 22, 2022

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    compared tags (via openapi-validator v1.13.0) new version base version
    default default(9080014) default(main)
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/sql/resource-manager/readme.md
    tag: specification/sql/resource-manager/readme.md#tag-package-composite-v5
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 22, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - armsql - 2.0.0-beta.1
    +	Function `*ReplicationLinksClient.Delete` has been removed
    +	Struct `ReplicationLinksClientDeleteOptions` has been removed
    azure-sdk-for-python-track2 - track2_azure-mgmt-sql - 4.0.0b3
    +	Removed operation ReplicationLinksOperations.delete
    azure-sdk-for-js - @azure/arm-sql - 10.0.0-beta.1
    +	Removed operation ReplicationLinks.delete
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from b55607c. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
    • ️✔️track2_azure-mgmt-sql [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation ReplicationLinksOperations.begin_delete
      info	[Changelog]   - Added operation group ManagedDatabaseAdvancedThreatProtectionSettingsOperations
      info	[Changelog]   - Added operation group ManagedInstanceAdvancedThreatProtectionSettingsOperations
      info	[Changelog]   - Added operation group ManagedInstanceDtcsOperations
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Removed operation ReplicationLinksOperations.delete
    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from b55607c. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armsql [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Function `*ReplicationLinksClient.Delete` has been removed
      info	[Changelog] - Struct `ReplicationLinksClientDeleteOptions` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `DtcNameCurrent`
      info	[Changelog] - New const `ReplicationLinkTypeSTANDBY`
      info	[Changelog] - New const `SecondaryTypeStandby`
      info	[Changelog] - New function `*ManagedInstanceAdvancedThreatProtectionSettingsClient.Get(context.Context, string, string, AdvancedThreatProtectionName, *ManagedInstanceAdvancedThreatProtectionSettingsClientGetOptions) (ManagedInstanceAdvancedThreatProtectionSettingsClientGetResponse, error)`
      info	[Changelog] - New function `*ReplicationLinksClient.BeginDelete(context.Context, string, string, string, string, *ReplicationLinksClientBeginDeleteOptions) (*runtime.Poller[ReplicationLinksClientDeleteResponse], error)`
      info	[Changelog] - New function `*ManagedInstanceDtcsClient.Get(context.Context, string, string, DtcName, *ManagedInstanceDtcsClientGetOptions) (ManagedInstanceDtcsClientGetResponse, error)`
      info	[Changelog] - New function `*ManagedServerDNSAliasesClient.Get(context.Context, string, string, string, *ManagedServerDNSAliasesClientGetOptions) (ManagedServerDNSAliasesClientGetResponse, error)`
      info	[Changelog] - New function `PossibleDtcNameValues() []DtcName`
      info	[Changelog] - New function `NewManagedDatabaseAdvancedThreatProtectionSettingsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ManagedDatabaseAdvancedThreatProtectionSettingsClient, error)`
      info	[Changelog] - New function `NewManagedServerDNSAliasesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ManagedServerDNSAliasesClient, error)`
      info	[Changelog] - New function `*ManagedServerDNSAliasesClient.BeginDelete(context.Context, string, string, string, *ManagedServerDNSAliasesClientBeginDeleteOptions) (*runtime.Poller[ManagedServerDNSAliasesClientDeleteResponse], error)`
      info	[Changelog] - New function `*ManagedInstanceDtcsClient.NewListByManagedInstancePager(string, string, *ManagedInstanceDtcsClientListByManagedInstanceOptions) *runtime.Pager[ManagedInstanceDtcsClientListByManagedInstanceResponse]`
      info	[Changelog] - New function `NewManagedInstanceDtcsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ManagedInstanceDtcsClient, error)`
      info	[Changelog] - New function `*ManagedServerDNSAliasesClient.BeginCreateOrUpdate(context.Context, string, string, string, ManagedServerDNSAliasCreation, *ManagedServerDNSAliasesClientBeginCreateOrUpdateOptions) (*runtime.Poller[ManagedServerDNSAliasesClientCreateOrUpdateResponse], error)`
      info	[Changelog] - New function `*ManagedServerDNSAliasesClient.NewListByManagedInstancePager(string, string, *ManagedServerDNSAliasesClientListByManagedInstanceOptions) *runtime.Pager[ManagedServerDNSAliasesClientListByManagedInstanceResponse]`
      info	[Changelog] - New function `*ManagedInstanceAdvancedThreatProtectionSettingsClient.NewListByInstancePager(string, string, *ManagedInstanceAdvancedThreatProtectionSettingsClientListByInstanceOptions) *runtime.Pager[ManagedInstanceAdvancedThreatProtectionSettingsClientListByInstanceResponse]`
      info	[Changelog] - New function `*ManagedDatabaseAdvancedThreatProtectionSettingsClient.CreateOrUpdate(context.Context, string, string, string, AdvancedThreatProtectionName, ManagedDatabaseAdvancedThreatProtection, *ManagedDatabaseAdvancedThreatProtectionSettingsClientCreateOrUpdateOptions) (ManagedDatabaseAdvancedThreatProtectionSettingsClientCreateOrUpdateResponse, error)`
      info	[Changelog] - New function `*ManagedDatabaseAdvancedThreatProtectionSettingsClient.Get(context.Context, string, string, string, AdvancedThreatProtectionName, *ManagedDatabaseAdvancedThreatProtectionSettingsClientGetOptions) (ManagedDatabaseAdvancedThreatProtectionSettingsClientGetResponse, error)`
      info	[Changelog] - New function `NewManagedInstanceAdvancedThreatProtectionSettingsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ManagedInstanceAdvancedThreatProtectionSettingsClient, error)`
      info	[Changelog] - New function `*ManagedServerDNSAliasesClient.BeginAcquire(context.Context, string, string, string, ManagedServerDNSAliasAcquisition, *ManagedServerDNSAliasesClientBeginAcquireOptions) (*runtime.Poller[ManagedServerDNSAliasesClientAcquireResponse], error)`
      info	[Changelog] - New function `*ManagedInstanceAdvancedThreatProtectionSettingsClient.BeginCreateOrUpdate(context.Context, string, string, AdvancedThreatProtectionName, ManagedInstanceAdvancedThreatProtection, *ManagedInstanceAdvancedThreatProtectionSettingsClientBeginCreateOrUpdateOptions) (*runtime.Poller[ManagedInstanceAdvancedThreatProtectionSettingsClientCreateOrUpdateResponse], error)`
      info	[Changelog] - New function `*ManagedInstanceDtcsClient.BeginCreateOrUpdate(context.Context, string, string, DtcName, ManagedInstanceDtc, *ManagedInstanceDtcsClientBeginCreateOrUpdateOptions) (*runtime.Poller[ManagedInstanceDtcsClientCreateOrUpdateResponse], error)`
      info	[Changelog] - New function `*ManagedDatabaseAdvancedThreatProtectionSettingsClient.NewListByDatabasePager(string, string, string, *ManagedDatabaseAdvancedThreatProtectionSettingsClientListByDatabaseOptions) *runtime.Pager[ManagedDatabaseAdvancedThreatProtectionSettingsClientListByDatabaseResponse]`
      info	[Changelog] - New struct `ManagedDatabaseAdvancedThreatProtection`
      info	[Changelog] - New struct `ManagedDatabaseAdvancedThreatProtectionListResult`
      info	[Changelog] - New struct `ManagedDatabaseAdvancedThreatProtectionSettingsClient`
      info	[Changelog] - New struct `ManagedDatabaseAdvancedThreatProtectionSettingsClientCreateOrUpdateOptions`
      info	[Changelog] - New struct `ManagedDatabaseAdvancedThreatProtectionSettingsClientCreateOrUpdateResponse`
      info	[Changelog] - New struct `ManagedDatabaseAdvancedThreatProtectionSettingsClientGetOptions`
      info	[Changelog] - New struct `ManagedDatabaseAdvancedThreatProtectionSettingsClientGetResponse`
      info	[Changelog] - New struct `ManagedDatabaseAdvancedThreatProtectionSettingsClientListByDatabaseOptions`
      info	[Changelog] - New struct `ManagedDatabaseAdvancedThreatProtectionSettingsClientListByDatabaseResponse`
      info	[Changelog] - New struct `ManagedInstanceAdvancedThreatProtection`
      info	[Changelog] - New struct `ManagedInstanceAdvancedThreatProtectionListResult`
      info	[Changelog] - New struct `ManagedInstanceAdvancedThreatProtectionSettingsClient`
      info	[Changelog] - New struct `ManagedInstanceAdvancedThreatProtectionSettingsClientBeginCreateOrUpdateOptions`
      info	[Changelog] - New struct `ManagedInstanceAdvancedThreatProtectionSettingsClientCreateOrUpdateResponse`
      info	[Changelog] - New struct `ManagedInstanceAdvancedThreatProtectionSettingsClientGetOptions`
      info	[Changelog] - New struct `ManagedInstanceAdvancedThreatProtectionSettingsClientGetResponse`
      info	[Changelog] - New struct `ManagedInstanceAdvancedThreatProtectionSettingsClientListByInstanceOptions`
      info	[Changelog] - New struct `ManagedInstanceAdvancedThreatProtectionSettingsClientListByInstanceResponse`
      info	[Changelog] - New struct `ManagedInstanceDtc`
      info	[Changelog] - New struct `ManagedInstanceDtcListResult`
      info	[Changelog] - New struct `ManagedInstanceDtcProperties`
      info	[Changelog] - New struct `ManagedInstanceDtcSecuritySettings`
      info	[Changelog] - New struct `ManagedInstanceDtcTransactionManagerCommunicationSettings`
      info	[Changelog] - New struct `ManagedInstanceDtcsClient`
      info	[Changelog] - New struct `ManagedInstanceDtcsClientBeginCreateOrUpdateOptions`
      info	[Changelog] - New struct `ManagedInstanceDtcsClientCreateOrUpdateResponse`
      info	[Changelog] - New struct `ManagedInstanceDtcsClientGetOptions`
      info	[Changelog] - New struct `ManagedInstanceDtcsClientGetResponse`
      info	[Changelog] - New struct `ManagedInstanceDtcsClientListByManagedInstanceOptions`
      info	[Changelog] - New struct `ManagedInstanceDtcsClientListByManagedInstanceResponse`
      info	[Changelog] - New struct `ManagedServerDNSAlias`
      info	[Changelog] - New struct `ManagedServerDNSAliasAcquisition`
      info	[Changelog] - New struct `ManagedServerDNSAliasCreation`
      info	[Changelog] - New struct `ManagedServerDNSAliasListResult`
      info	[Changelog] - New struct `ManagedServerDNSAliasProperties`
      info	[Changelog] - New struct `ManagedServerDNSAliasesClient`
      info	[Changelog] - New struct `ManagedServerDNSAliasesClientAcquireResponse`
      info	[Changelog] - New struct `ManagedServerDNSAliasesClientBeginAcquireOptions`
      info	[Changelog] - New struct `ManagedServerDNSAliasesClientBeginCreateOrUpdateOptions`
      info	[Changelog] - New struct `ManagedServerDNSAliasesClientBeginDeleteOptions`
      info	[Changelog] - New struct `ManagedServerDNSAliasesClientCreateOrUpdateResponse`
      info	[Changelog] - New struct `ManagedServerDNSAliasesClientDeleteResponse`
      info	[Changelog] - New struct `ManagedServerDNSAliasesClientGetOptions`
      info	[Changelog] - New struct `ManagedServerDNSAliasesClientGetResponse`
      info	[Changelog] - New struct `ManagedServerDNSAliasesClientListByManagedInstanceOptions`
      info	[Changelog] - New struct `ManagedServerDNSAliasesClientListByManagedInstanceResponse`
      info	[Changelog] - New struct `ReplicationLinksClientBeginDeleteOptions`
      info	[Changelog]
      info	[Changelog] Total 3 breaking change(s), 117 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from b55607c. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-sql [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog]   - Added Interface ManagedInstanceDtcSecuritySettings
      info	[Changelog]   - Added Interface ManagedInstanceDtcsGetOptionalParams
      info	[Changelog]   - Added Interface ManagedInstanceDtcsListByManagedInstanceNextOptionalParams
      info	[Changelog]   - Added Interface ManagedInstanceDtcsListByManagedInstanceOptionalParams
      info	[Changelog]   - Added Interface ManagedInstanceDtcTransactionManagerCommunicationSettings
      info	[Changelog]   - Added Interface ManagedServerDnsAliasAcquisition
      info	[Changelog]   - Added Interface ManagedServerDnsAliasCreation
      info	[Changelog]   - Added Interface ManagedServerDnsAliasesAcquireOptionalParams
      info	[Changelog]   - Added Interface ManagedServerDnsAliasesCreateOrUpdateOptionalParams
      info	[Changelog]   - Added Interface ManagedServerDnsAliasesDeleteOptionalParams
      info	[Changelog]   - Added Interface ManagedServerDnsAliasesGetOptionalParams
      info	[Changelog]   - Added Interface ManagedServerDnsAliasesListByManagedInstanceNextOptionalParams
      info	[Changelog]   - Added Interface ManagedServerDnsAliasesListByManagedInstanceOptionalParams
      info	[Changelog]   - Added Interface ManagedServerDnsAliasListResult
      info	[Changelog]   - Added Interface ServerAdvancedThreatProtectionSettingsCreateOrUpdateOptionalParams
      info	[Changelog]   - Added Interface ServerAdvancedThreatProtectionSettingsGetOptionalParams
      info	[Changelog]   - Added Interface ServerAdvancedThreatProtectionSettingsListByServerNextOptionalParams
      info	[Changelog]   - Added Interface ServerAdvancedThreatProtectionSettingsListByServerOptionalParams
      info	[Changelog]   - Added Interface ServerTrustCertificatesCreateOrUpdateOptionalParams
      info	[Changelog]   - Added Interface ServerTrustCertificatesDeleteOptionalParams
      info	[Changelog]   - Added Interface ServerTrustCertificatesGetOptionalParams
      info	[Changelog]   - Added Interface ServerTrustCertificatesListByInstanceNextOptionalParams
      info	[Changelog]   - Added Interface ServerTrustCertificatesListByInstanceOptionalParams
      info	[Changelog]   - Added Interface ServerTrustCertificatesListResult
      info	[Changelog]   - Added Type Alias AdvancedThreatProtectionName
      info	[Changelog]   - Added Type Alias AdvancedThreatProtectionState
      info	[Changelog]   - Added Type Alias DatabaseAdvancedThreatProtection
      info	[Changelog]   - Added Type Alias DatabaseAdvancedThreatProtectionSettingsCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias DatabaseAdvancedThreatProtectionSettingsGetResponse
      info	[Changelog]   - Added Type Alias DatabaseAdvancedThreatProtectionSettingsListByDatabaseNextResponse
      info	[Changelog]   - Added Type Alias DatabaseAdvancedThreatProtectionSettingsListByDatabaseResponse
      info	[Changelog]   - Added Type Alias DistributedAvailabilityGroup
      info	[Changelog]   - Added Type Alias DistributedAvailabilityGroupsCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias DistributedAvailabilityGroupsGetResponse
      info	[Changelog]   - Added Type Alias DistributedAvailabilityGroupsListByInstanceNextResponse
      info	[Changelog]   - Added Type Alias DistributedAvailabilityGroupsListByInstanceResponse
      info	[Changelog]   - Added Type Alias DistributedAvailabilityGroupsUpdateResponse
      info	[Changelog]   - Added Type Alias DtcName
      info	[Changelog]   - Added Type Alias EndpointCertificate
      info	[Changelog]   - Added Type Alias EndpointCertificatesGetResponse
      info	[Changelog]   - Added Type Alias EndpointCertificatesListByInstanceNextResponse
      info	[Changelog]   - Added Type Alias EndpointCertificatesListByInstanceResponse
      info	[Changelog]   - Added Type Alias IPv6FirewallRule
      info	[Changelog]   - Added Type Alias IPv6FirewallRulesCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias IPv6FirewallRulesGetResponse
      info	[Changelog]   - Added Type Alias IPv6FirewallRulesListByServerNextResponse
      info	[Changelog]   - Added Type Alias IPv6FirewallRulesListByServerResponse
      info	[Changelog]   - Added Type Alias ManagedDatabaseAdvancedThreatProtection
      info	[Changelog]   - Added Type Alias ManagedDatabaseAdvancedThreatProtectionSettingsCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias ManagedDatabaseAdvancedThreatProtectionSettingsGetResponse
      info	[Changelog]   - Added Type Alias ManagedDatabaseAdvancedThreatProtectionSettingsListByDatabaseNextResponse
      info	[Changelog]   - Added Type Alias ManagedDatabaseAdvancedThreatProtectionSettingsListByDatabaseResponse
      info	[Changelog]   - Added Type Alias ManagedInstanceAdvancedThreatProtection
      info	[Changelog]   - Added Type Alias ManagedInstanceAdvancedThreatProtectionSettingsCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias ManagedInstanceAdvancedThreatProtectionSettingsGetResponse
      info	[Changelog]   - Added Type Alias ManagedInstanceAdvancedThreatProtectionSettingsListByInstanceNextResponse
      info	[Changelog]   - Added Type Alias ManagedInstanceAdvancedThreatProtectionSettingsListByInstanceResponse
      info	[Changelog]   - Added Type Alias ManagedInstanceDtc
      info	[Changelog]   - Added Type Alias ManagedInstanceDtcsCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias ManagedInstanceDtcsGetResponse
      info	[Changelog]   - Added Type Alias ManagedInstanceDtcsListByManagedInstanceNextResponse
      info	[Changelog]   - Added Type Alias ManagedInstanceDtcsListByManagedInstanceResponse
      info	[Changelog]   - Added Type Alias ManagedServerDnsAlias
      info	[Changelog]   - Added Type Alias ManagedServerDnsAliasesAcquireResponse
      info	[Changelog]   - Added Type Alias ManagedServerDnsAliasesCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias ManagedServerDnsAliasesGetResponse
      info	[Changelog]   - Added Type Alias ManagedServerDnsAliasesListByManagedInstanceNextResponse
      info	[Changelog]   - Added Type Alias ManagedServerDnsAliasesListByManagedInstanceResponse
      info	[Changelog]   - Added Type Alias ReplicationLinksFailoverAllowDataLossResponse
      info	[Changelog]   - Added Type Alias ReplicationLinksFailoverResponse
      info	[Changelog]   - Added Type Alias ReplicationMode
      info	[Changelog]   - Added Type Alias ServerAdvancedThreatProtection
      info	[Changelog]   - Added Type Alias ServerAdvancedThreatProtectionSettingsCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias ServerAdvancedThreatProtectionSettingsGetResponse
      info	[Changelog]   - Added Type Alias ServerAdvancedThreatProtectionSettingsListByServerNextResponse
      info	[Changelog]   - Added Type Alias ServerAdvancedThreatProtectionSettingsListByServerResponse
      info	[Changelog]   - Added Type Alias ServerTrustCertificate
      info	[Changelog]   - Added Type Alias ServerTrustCertificatesCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias ServerTrustCertificatesGetResponse
      info	[Changelog]   - Added Type Alias ServerTrustCertificatesListByInstanceNextResponse
      info	[Changelog]   - Added Type Alias ServerTrustCertificatesListByInstanceResponse
      info	[Changelog]   - Added Type Alias SyncGroupsType
      info	[Changelog]   - Interface ElasticPoolUpdate has a new optional parameter highAvailabilityReplicaCount
      info	[Changelog]   - Interface ReplicationLinksDeleteOptionalParams has a new optional parameter resumeFrom
      info	[Changelog]   - Interface ReplicationLinksDeleteOptionalParams has a new optional parameter updateIntervalInMs
      info	[Changelog]   - Class SqlManagementClient has a new parameter databaseAdvancedThreatProtectionSettings
      info	[Changelog]   - Class SqlManagementClient has a new parameter distributedAvailabilityGroups
      info	[Changelog]   - Class SqlManagementClient has a new parameter endpointCertificates
      info	[Changelog]   - Class SqlManagementClient has a new parameter iPv6FirewallRules
      info	[Changelog]   - Class SqlManagementClient has a new parameter managedDatabaseAdvancedThreatProtectionSettings
      info	[Changelog]   - Class SqlManagementClient has a new parameter managedInstanceAdvancedThreatProtectionSettings
      info	[Changelog]   - Class SqlManagementClient has a new parameter managedInstanceDtcs
      info	[Changelog]   - Class SqlManagementClient has a new parameter managedServerDnsAliases
      info	[Changelog]   - Class SqlManagementClient has a new parameter serverAdvancedThreatProtectionSettings
      info	[Changelog]   - Class SqlManagementClient has a new parameter serverTrustCertificates
      info	[Changelog]   - Type Alias Database has a new parameter sourceResourceId
      info	[Changelog]   - Type Alias DatabaseBlobAuditingPolicy has a new parameter isManagedIdentityInUse
      info	[Changelog]   - Type Alias ElasticPool has a new parameter highAvailabilityReplicaCount
      info	[Changelog]   - Type Alias ExtendedDatabaseBlobAuditingPolicy has a new parameter isManagedIdentityInUse
      info	[Changelog]   - Type Alias ExtendedServerBlobAuditingPolicy has a new parameter isManagedIdentityInUse
      info	[Changelog]   - Type Alias ServerBlobAuditingPolicy has a new parameter isManagedIdentityInUse
      info	[Changelog]   - Added Enum KnownAdvancedThreatProtectionName
      info	[Changelog]   - Added Enum KnownDtcName
      info	[Changelog]   - Added Enum KnownReplicationMode
      info	[Changelog]   - Added Enum KnownSyncGroupsType
      info	[Changelog]   - Enum KnownReplicationLinkType has a new value Standby
      info	[Changelog]   - Enum KnownSecondaryType has a new value Standby
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Removed operation group OperationsHealthOperations
      info	[Changelog]   - Removed operation ReplicationLinks.beginUnlink
      info	[Changelog]   - Removed operation ReplicationLinks.beginUnlinkAndWait
      info	[Changelog]   - Removed operation ReplicationLinks.delete
      info	[Changelog]   - Operation SyncGroups.listLogs has a new signature
      info	[Changelog]   - Interface DatabaseIdentity no longer has parameter delegatedResources
      info	[Changelog]   - Interface DatabaseUpdate no longer has parameter primaryDelegatedIdentityClientId
      info	[Changelog]   - Class SqlManagementClient no longer has parameter operationsHealthOperations
      info	[Changelog]   - Type Alias Database no longer has parameter primaryDelegatedIdentityClientId
      info	[Changelog]   - Removed Enum KnownEnum60
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from b55607c. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from b55607c. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @subhrob, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @subhrob
    Copy link
    Contributor Author

    subhrob commented Jul 22, 2022

    I am working on the reason of broken SDK changes with Daisy

    @ericshape
    Copy link
    Contributor

    I am working on the reason of broken SDK changes with Daisy

    please ask assignee to review and merge

    @subhrob
    Copy link
    Contributor Author

    subhrob commented Jul 23, 2022

    @raych1 , could you please review and merge, Thanks

    @subhrob subhrob changed the title Adding Databases APIs for SQL DB on v5 tag for 2022-02-01-preview Adding Databases ReplicationLinks APIs for SQL DB on v5 tag for 2022-02-01 Jul 23, 2022
    @subhrob subhrob changed the title Adding Databases ReplicationLinks APIs for SQL DB on v5 tag for 2022-02-01 Adding Databases, ReplicationLinks APIs for SQL DB on v5 tag for 2022-02-01 Jul 23, 2022
    @raych1 raych1 merged commit b55607c into Azure:main Jul 27, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants