Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.HealthcareApis to add version stable/2022-06-01 #20116

Conversation

PTaladay
Copy link
Contributor

@PTaladay PTaladay commented Aug 4, 2022

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

…reviously approved change for previous versions. This version was published while the approval was pending so it didn't get updated at that time.
@openapi-workflow-bot
Copy link

Hi, @PTaladay Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 4, 2022

    Swagger Validation Report

    ️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.2)] new version base version
    healthcare-apis.json 2022-06-01(52fa9f3) 2022-06-01(main)
    Rule Message
    1036 - ConstraintChanged The new version has a different 'maximum' value than the previous one.
    New: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L2366:9
    Old: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L2366:9
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-2022-06 package-2022-06(52fa9f3) package-2022-06(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ResourceNameRestriction The resource name parameter 'resourceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L37
    CreateOperationAsyncResponseValidation An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L78
    PatchIdentityProperty The patch operation body parameter schema should contains property 'identity'.
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L162
    LroPatch202 The async patch operation should return 202.
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L172
    DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L187
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L214
    ResourceNameRestriction The resource name parameter 'resourceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L355
    ResourceNameRestriction The resource name parameter 'resourceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L400
    ResourceNameRestriction The resource name parameter 'privateEndpointConnectionName' should be defined with a 'pattern' restriction.
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L400
    CreateOperationAsyncResponseValidation An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L444
    CreateOperationAsyncResponseValidation An async PUT operation must return 201.
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L476
    DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L497
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L524
    ResourceNameRestriction The resource name parameter 'resourceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L545
    ResourceNameRestriction The resource name parameter 'resourceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L587
    ResourceNameRestriction The resource name parameter 'groupName' should be defined with a 'pattern' restriction.
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L587
    ResourceNameRestriction The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L717
    CreateOperationAsyncResponseValidation An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L758
    CreateOperationAsyncResponseValidation Only 201 is the supported response code for PUT async response.
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L806
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L806
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L862
    DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L876
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L906
    ResourceNameRestriction The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L921
    ResourceNameRestriction The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L966
    ResourceNameRestriction The resource name parameter 'dicomServiceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L966
    CreateOperationAsyncResponseValidation An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L1010
    CreateOperationAsyncResponseValidation Only 201 is the supported response code for PUT async response.
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L1061
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L1061
    ParametersOrder The parameters:resourceGroupName,dicomServiceName,workspaceName should be kept in the same order as they present in the path.
    Location: Microsoft.HealthcareApis/stable/2022-06-01/healthcare-apis.json#L1075
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️~[Staging] SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 4, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking





    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from e9370a0. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] npm notice
      cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.2 -> 9.1.3
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.1.3>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.1.3` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-healthcareapis [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Model DicomService has a new parameter cors_configuration
      info	[Changelog]   - Model FhirService has a new parameter import_configuration
      info	[Changelog]   - Model MetricSpecification has a new parameter enable_regional_mdm_account
      info	[Changelog]   - Model MetricSpecification has a new parameter is_internal
      info	[Changelog]   - Model MetricSpecification has a new parameter metric_filter_pattern
      info	[Changelog]   - Model MetricSpecification has a new parameter resource_id_dimension_name_override
      info	[Changelog]   - Model MetricSpecification has a new parameter source_mdm_account
      info	[Changelog]   - Model ServicesProperties has a new parameter import_configuration
    ️⚠️ azure-sdk-for-java warning [Detail]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from e9370a0. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/healthcareapis/armhealthcareapis [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New struct `CorsConfiguration`
      info	[Changelog] - New struct `FhirServiceImportConfiguration`
      info	[Changelog] - New struct `ServiceImportConfigurationInfo`
      info	[Changelog] - New field `CorsConfiguration` in struct `DicomServiceProperties`
      info	[Changelog] - New field `ImportConfiguration` in struct `FhirServiceProperties`
      info	[Changelog] - New field `EnableRegionalMdmAccount` in struct `MetricSpecification`
      info	[Changelog] - New field `IsInternal` in struct `MetricSpecification`
      info	[Changelog] - New field `MetricFilterPattern` in struct `MetricSpecification`
      info	[Changelog] - New field `ResourceIDDimensionNameOverride` in struct `MetricSpecification`
      info	[Changelog] - New field `SourceMdmAccount` in struct `MetricSpecification`
      info	[Changelog] - New field `ImportConfiguration` in struct `ServicesProperties`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 10 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from e9370a0. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-healthcareapis [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added Interface CorsConfiguration
      info	[Changelog]   - Added Interface FhirServiceImportConfiguration
      info	[Changelog]   - Added Interface ServiceImportConfigurationInfo
      info	[Changelog]   - Interface DicomService has a new optional parameter corsConfiguration
      info	[Changelog]   - Interface FhirService has a new optional parameter importConfiguration
      info	[Changelog]   - Interface MetricSpecification has a new optional parameter enableRegionalMdmAccount
      info	[Changelog]   - Interface MetricSpecification has a new optional parameter isInternal
      info	[Changelog]   - Interface MetricSpecification has a new optional parameter metricFilterPattern
      info	[Changelog]   - Interface MetricSpecification has a new optional parameter resourceIdDimensionNameOverride
      info	[Changelog]   - Interface MetricSpecification has a new optional parameter sourceMdmAccount
      info	[Changelog]   - Interface ServicesProperties has a new optional parameter importConfiguration
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from e9370a0. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️healthcareapis [View full logs]  [Release Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from e9370a0. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.healthcareapis [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 4, 2022

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/healthcareapis/armhealthcareapis Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Python track2_azure-mgmt-healthcareapis Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Java azure-resourcemanager-healthcareapis Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    .Net Azure.ResourceManager.HealthcareApis Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    JavaScript @azure/arm-healthcareapis Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

    @PTaladay
    Copy link
    Contributor Author

    PTaladay commented Aug 4, 2022

    @ruowan Please see this previous approval for this change on all our other stable api versions. This version was published while the review was still pending. https://msazure.visualstudio.com/One/_workitems/edit/14708787

    @openapi-workflow-bot
    Copy link

    Hi @PTaladay, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @PTaladay
    Copy link
    Contributor Author

    PTaladay commented Aug 4, 2022

    @PTaladay
    Copy link
    Contributor Author

    PTaladay commented Aug 8, 2022

    @ruowan It looks like there is something going on with the build pipeline that is preventing this PR from merging. Is anybody taking a look at it?

    @ghost
    Copy link

    ghost commented Aug 28, 2022

    Hi, @PTaladay. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost
    Copy link

    ghost commented Sep 18, 2022

    Hi, @PTaladay. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost
    Copy link

    ghost commented Oct 16, 2022

    Hi, @PTaladay. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost ghost added the no-recent-activity label Oct 16, 2022
    @PTaladay
    Copy link
    Contributor Author

    PTaladay commented Dec 1, 2022

    @ruowan The swagger model validation is incorrectly flagging issues with response not containing id in the examples. There is an ongoing conversation with those on the Swagger Validation team, but this isn't related to my change and was existing before my PR. Is there any way to bypass this so my PR can get completed? We are out of compliance because this PR never got committed.

    @ruowan ruowan merged commit e9370a0 into Azure:main Dec 2, 2022
    ghost pushed a commit to Azure/azure-resource-manager-schemas that referenced this pull request Dec 2, 2022
    anandanthony pushed a commit to anandMicro/azure-rest-api-specs that referenced this pull request Dec 16, 2022
    …rsion stable/2022-06-01 (Azure#20116)
    
    * Removed maximum constraint for offerThroughput to keep aligned with previously approved change for previous versions. This version was published while the approval was pending so it didn't get updated at that time.
    
    * Fixes for model validation errors related to LRO_Response_HEADER.
    
    * Added incorrect change to resolve LRO model validation. Updated.
    
    * Another LRO fix.
    
    * Fix formatting issue.
    
    * Removing Resource header tag.
    kayousef-zz pushed a commit to kayousef-zz/azure-rest-api-specs that referenced this pull request Dec 21, 2022
    …rsion stable/2022-06-01 (Azure#20116)
    
    * Removed maximum constraint for offerThroughput to keep aligned with previously approved change for previous versions. This version was published while the approval was pending so it didn't get updated at that time.
    
    * Fixes for model validation errors related to LRO_Response_HEADER.
    
    * Added incorrect change to resolve LRO model validation. Updated.
    
    * Another LRO fix.
    
    * Fix formatting issue.
    
    * Removing Resource header tag.
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required FixS360 resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants