added java sdk generation for reservations api (Microsoft.Capacity) #20130

dennis-menge · 2022-08-05T12:35:06Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature (Adding java sdk readme)
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2022-08-05T12:35:08Z

Hi, @dennis-menge Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2022-08-05T12:35:09Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

compared tags (via openapi-validator v1.13.0)	new version	base version
default	default(fd37405)	default(main)

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/reservations/resource-manager/readme.md tag: specification/reservations/resource-manager/readme.md#tag-package-2022-03

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-08-05T12:35:10Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️✔️azure-sdk-for-go - armreservations - 1.0.1
️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-reservations - 2.0.0

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 7547c9e. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
warn	File azure-sdk-for-net_tmp/initOutput.json not found to read
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.Reservations [View full logs] [Release SDK Changes]
- Azure.ResourceManager.Reservations.1.0.0-alpha.20220817.1.nupkg
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 7547c9e. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]  global `--global`, `--local` are deprecated. Use `--location=global` instead.

️✔️track2_azure-mgmt-reservations [View full logs] [Release SDK Changes]
- azure_mgmt_reservations-1.0.0b1-py3-none-any.whl
- azure-mgmt-reservations-1.0.0b1.zip
```
info	[Changelog]
```

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 7547c9e. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️armreservations [View full logs] [Release SDK Changes]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 7547c9e. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
cmderr	[automation_generate.sh] [ERROR] Cannot generate changelog because the codes of local and npm may be the same.

️✔️@azure/arm-reservations [View full logs] [Release SDK Changes]
- azure-arm-reservations-7.1.1.tgz
```
info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
```

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 7547c9e. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation

️✔️reservations [View full logs]

️️✔️ azure-powershell succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 7547c9e. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

️✔️Az.ReservationApi [View full logs] [Release SDK Changes]
- Az.ReservationApi.0.1.0.nupkg

️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 7547c9e. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-reservations [View full logs] [Release SDK Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-08-05T12:35:10Z

Generated ApiView

Language	Package Name	ApiView Link
Python	track2_azure-mgmt-reservations	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
Java	azure-resourcemanager-reservations	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
.Net	Azure.ResourceManager.Reservations	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
JavaScript	@azure/arm-reservations	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

weidongxu-microsoft · 2022-08-10T07:15:52Z

@dennis-menge

You might consider switch go SDK to track2. If you have question, you can ask @tadelesh

The failed "SDK azure-sdk-for-go" is track1, but it blocks PR merge...

tadelesh · 2022-08-11T02:09:48Z

/azp run

azure-pipelines · 2022-08-11T02:09:56Z

Azure Pipelines successfully started running 1 pipeline(s).

tadelesh · 2022-08-11T02:20:23Z

@dennis-menge

You might consider switch go SDK to track2. If you have question, you can ask @tadelesh

The failed "SDK azure-sdk-for-go" is track1, but it blocks PR merge...

Fixed for Go SDK automation.

dennis-menge · 2022-08-15T06:14:21Z

Are there any additional open topics regarding this PR, or can we merge it?
Thank you!

openapi-assignment-bot bot assigned weidongxu-microsoft Aug 5, 2022

dennis-menge added the resource-manager label Aug 5, 2022

dennis-menge force-pushed the main branch from eac569c to 4712cde Compare August 8, 2022 08:18

added java sdk generation for reservations api (Microsoft.Capacity)

fd37405

dennis-menge force-pushed the main branch from 4712cde to fd37405 Compare August 8, 2022 08:30

azure-sdk mentioned this pull request Aug 8, 2022

[AutoPR azure-resourcemanager-reservations] added java sdk generation for reservations api (Microsoft.Capacity) azure-sdk/azure-sdk-for-java#1293

Closed

dennis-menge requested a review from dolauli August 8, 2022 09:45

dennis-menge changed the title ~~added java readme for reservations api (Microsoft.Capacity)~~ added java sdk generation for reservations api (Microsoft.Capacity) Aug 8, 2022

weidongxu-microsoft approved these changes Aug 10, 2022

View reviewed changes

weidongxu-microsoft added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Aug 10, 2022

azure-sdk mentioned this pull request Aug 11, 2022

[AutoPR armreservations] added java sdk generation for reservations api (Microsoft.Capacity) azure-sdk/azure-sdk-for-go#2036

Closed

weidongxu-microsoft merged commit 7547c9e into Azure:main Aug 17, 2022

This was referenced Aug 17, 2022

[ReleasePR Azure.ResourceManager.Reservations] Add update for location in order to support patch Azure/azure-sdk-for-net#28760

Closed

[ReleasePR Az.ReservationApi] Patch reservations microsoft.capacity 2022 11 01 Azure/azure-powershell#17957

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added java sdk generation for reservations api (Microsoft.Capacity) #20130

added java sdk generation for reservations api (Microsoft.Capacity) #20130

dennis-menge commented Aug 5, 2022 •

edited

Loading

openapi-workflow-bot bot commented Aug 5, 2022

openapi-pipeline-app bot commented Aug 5, 2022 •

edited

Loading

openapi-pipeline-app bot commented Aug 5, 2022 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Aug 5, 2022 •

edited

Loading

weidongxu-microsoft commented Aug 10, 2022

tadelesh commented Aug 11, 2022

azure-pipelines bot commented Aug 11, 2022

tadelesh commented Aug 11, 2022

dennis-menge commented Aug 15, 2022

added java sdk generation for reservations api (Microsoft.Capacity) #20130

added java sdk generation for reservations api (Microsoft.Capacity) #20130

Conversation

dennis-menge commented Aug 5, 2022 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Aug 5, 2022

openapi-pipeline-app bot commented Aug 5, 2022 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Aug 5, 2022 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Aug 5, 2022 • edited Loading

Generated ApiView

weidongxu-microsoft commented Aug 10, 2022

tadelesh commented Aug 11, 2022

azure-pipelines bot commented Aug 11, 2022

tadelesh commented Aug 11, 2022

dennis-menge commented Aug 15, 2022

dennis-menge commented Aug 5, 2022 •

edited

Loading

openapi-pipeline-app bot commented Aug 5, 2022 •

edited

Loading

openapi-pipeline-app bot commented Aug 5, 2022 •

edited

Loading

openapi-pipeline-app bot commented Aug 5, 2022 •

edited

Loading