Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add property: maxInactiveRevisions #20334

Merged
merged 3 commits into from
Aug 30, 2022
Merged

add property: maxInactiveRevisions #20334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2168c72
add property: maxInactiveRevisions
njuCZ Aug 23, 2022
4f0dce4
update
njuCZ Aug 29, 2022
85ab983
update
njuCZ Aug 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...fication/app/resource-manager/Microsoft.App/preview/2022-06-01-preview/ContainerApps.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,6 +454,11 @@
"dapr": {
"$ref": "#/definitions/Dapr",
"description": "Dapr configuration for the Container App."
},
"maxInactiveRevisions": {
njuCZ marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have default value for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not have a default value here. Because we have a cluster level config, which is disabled for now. Displaying a default value can be misleading for users.

"format": "int32",
"description": "Optional. Max inactive revisions a Container App can have.",
"type": "integer"
}
}
},
Expand Down
3 changes: 2 additions & 1 deletion ...nager/Microsoft.App/preview/2022-06-01-preview/examples/ContainerApps_CreateOrUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@
"httpMaxRequestSize": 10,
"logLevel": "debug",
"enableApiLogging": true
}
},
"maxInactiveRevisions": 10
},
"template": {
"containers": [
Expand Down
3 changes: 2 additions & 1 deletion ...resource-manager/Microsoft.App/preview/2022-06-01-preview/examples/ContainerApps_Get.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,8 @@
"httpMaxRequestSize": 10,
"logLevel": "debug",
"enableApiLogging": true
}
},
"maxInactiveRevisions": 10
},
"template": {
"containers": [
Expand Down
3 changes: 2 additions & 1 deletion .../Microsoft.App/preview/2022-06-01-preview/examples/ContainerApps_ListByResourceGroup.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@
"httpMaxRequestSize": 10,
"logLevel": "debug",
"enableApiLogging": true
}
},
"maxInactiveRevisions": 10
},
"template": {
"containers": [
Expand Down
3 changes: 2 additions & 1 deletion ...r/Microsoft.App/preview/2022-06-01-preview/examples/ContainerApps_ListBySubscription.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,8 @@
"httpMaxRequestSize": 10,
"logLevel": "debug",
"enableApiLogging": true
}
},
"maxInactiveRevisions": 10
},
"template": {
"containers": [
Expand Down
3 changes: 2 additions & 1 deletion ...source-manager/Microsoft.App/preview/2022-06-01-preview/examples/ContainerApps_Patch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@
"httpMaxRequestSize": 10,
"logLevel": "debug",
"enableApiLogging": true
}
},
"maxInactiveRevisions": 10
},
"template": {
"containers": [
Expand Down