[Hub Generated] Review request for Microsoft.AlertsManagement to add version stable/2019-03-01 #20680

khaledaboasbe · 2022-09-12T13:42:46Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

…ent-2019-03-01

…-01' of https://github.com/khaledaboasbe/azure-rest-api-specs into dev-alertsmanagement-Microsoft.AlertsManagement-2019-03-01

openapi-workflow-bot · 2022-09-12T13:42:51Z

Hi, @khaledaboasbe Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2022-09-12T13:42:53Z

Swagger Validation Report

️⚠️BreakingChange: 2 Warnings warning [Detail]

compared swaggers (via Oad v0.9.7)]	new version	base version
AlertsManagement.json	2019-05-05-preview(227939f)	2019-05-05-preview(main)
AlertsManagement.json	2019-03-01(227939f)	2019-03-01(main)

Rule	Message
⚠️ 1026 - TypeChanged	The new version has a different type 'object' than the previous one 'string'. New: Microsoft.AlertsManagement/preview/2019-05-05-preview/AlertsManagement.json#L236:9 Old: Microsoft.AlertsManagement/preview/2019-05-05-preview/AlertsManagement.json#L236:9
⚠️ 1026 - TypeChanged	The new version has a different type 'object' than the previous one 'string'. New: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L230:9 Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L230:9

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 5 Warnings warning [Detail]

compared tags (via openapi-validator v1.13.0)	new version	base version
package-2021-04-only	package-2021-04-only(227939f)	package-2021-04-only(main)
package-2019-03	package-2019-03(227939f)	package-2019-03(main)
package-2021-08	package-2021-08(227939f)	package-2021-08(main)
package-preview-2021-08	package-preview-2021-08(227939f)	package-preview-2021-08(main)
package-2019-06-preview	package-2019-06-preview(227939f)	package-2019-06-preview(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule	Message	Related RPC [For API reviewers]
⚠️ R4021 - DescriptionAndTitleMissing	'comments' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/AlertsManagement.json#L859
⚠️ R4021 - DescriptionAndTitleMissing	'comments' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/AlertsManagement.json#L859
⚠️ R4021 - DescriptionAndTitleMissing	'comments' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/AlertsManagement.json#L859
⚠️ R4021 - DescriptionAndTitleMissing	'comments' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L897
⚠️ R4021 - DescriptionAndTitleMissing	'comments' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L897

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` R2018 - XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L707
`❌` R2018 - XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L707
`❌` R4010 - RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L42
`❌` R4010 - RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L42
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L636
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L636
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L1242
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L1242
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L1246
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L1246
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L1271
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L1271
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L1350
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L1350
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L1464
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L1464
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.AlertsManagement/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/AlertsManagement.json#L30
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.AlertsManagement/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/AlertsManagement.json#L30
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.AlertsManagement/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/AlertsManagement.json#L30
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.AlertsManagement/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L30
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.AlertsManagement/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L30
`❌` R4037 - MissingTypeObject	The schema 'operation' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/AlertsManagement.json#L702
`❌` R4037 - MissingTypeObject	The schema 'operation' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/AlertsManagement.json#L702
`❌` R4037 - MissingTypeObject	The schema 'operation' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/AlertsManagement.json#L702
`❌` R4037 - MissingTypeObject	The schema 'operationsList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/AlertsManagement.json#L737
`❌` R4037 - MissingTypeObject	The schema 'operationsList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/AlertsManagement.json#L737
`❌` R4037 - MissingTypeObject	The schema 'operationsList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/AlertsManagement.json#L737
`❌` R4037 - MissingTypeObject	The schema 'errorResponse' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/AlertsManagement.json#L756
`❌` R4037 - MissingTypeObject	The schema 'errorResponse' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/AlertsManagement.json#L756
`❌` R4037 - MissingTypeObject	The schema 'errorResponse' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/AlertsManagement.json#L756

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/alertsmanagement/resource-manager/readme.md tag: specification/alertsmanagement/resource-manager/readme.md#tag-package-2021-08

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️❌~[Staging] ServiceAPIReadinessTest: 22 Errors, 0 Warnings failed [Detail]

Tag package-2021-08; Prod region: Deployed

Test run on region: westcentralus; Operation coverage: total: 17, untested: 0, failed: 11, passed: 6

Service API Readiness Test failed. Check pipeline artifact for detail report.

Rule	Message
`❌` CLIENT_ERROR	"statusCode: 400, errorCode: LocationNotAvailableForResourceType, errorMessage: The provided location 'westcentralus' is not available for resource type 'Microsoft.AlertsManagement/actionRules'. List of available regions for the resource type is 'global'."
`❌` ASSERTION_ERROR	"expected response code to be 2XX but found 400"
`❌` CLIENT_ERROR	"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.AlertsManagement/actionRules/alertprocedyg9nc' under resource group 'apiTest-UCEfcj-20680' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
`❌` ASSERTION_ERROR	"expected response code to be 2XX but found 404"
`❌` CLIENT_ERROR	"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.AlertsManagement/actionRules/alertprocedyg9nc' under resource group 'apiTest-UCEfcj-20680' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
`❌` ASSERTION_ERROR	"expected response code to be 2XX but found 404"
`❌` CLIENT_ERROR	"statusCode: 400, errorCode: ApiVersionNotRegistered, errorMessage: The ApiVersion '2019-05-05-preview' is not registered for ResourceType 'Microsoft.AlertsManagement/alertsMetaData'. Valid Api Versions are: '2019-03-01-preview'."
`❌` ASSERTION_ERROR	"expected response code to be 2XX but found 400"
`❌` CLIENT_ERROR	"statusCode: 404, errorCode: NotFound, errorMessage: Unable to find the input alert"
`❌` ASSERTION_ERROR	"expected response code to be 2XX but found 404"
`❌` CLIENT_ERROR	"statusCode: 404, errorCode: NotFound, errorMessage: Unable to find the input alert"
`❌` ASSERTION_ERROR	"expected response code to be 2XX but found 404"
`❌` CLIENT_ERROR	"statusCode: 404, errorCode: NotFound, errorMessage: Unable to find the input alert"
`❌` ASSERTION_ERROR	"expected response code to be 2XX but found 404"
`❌` CLIENT_ERROR	"statusCode: 429, errorCode: 429, errorMessage: Too many requests."
`❌` ASSERTION_ERROR	"expected response code to be 2XX but found 429"
`❌` CLIENT_ERROR	"statusCode: 404, errorCode: NotFound, errorMessage: Unable to find the input smart group"
`❌` ASSERTION_ERROR	"expected response code to be 2XX but found 404"
`❌` CLIENT_ERROR	"statusCode: 404, errorCode: NotFound, errorMessage: Unable to find the input smart group"
`❌` ASSERTION_ERROR	"expected response code to be 2XX but found 404"
`❌` CLIENT_ERROR	"statusCode: 404, errorCode: NotFound, errorMessage: Unable to find the input smart group"
`❌` ASSERTION_ERROR	"expected response code to be 2XX but found 404"

️❌~[Staging] TrafficValidation: 0 Errors, 0 Warnings failed [Detail]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️❌SDK Track2 Validation: 8 Errors, 0 Warnings failed [Detail]

The following tags are being changed in this PR

"https://github.com/Azure/azure-rest-api-specs/blob/227939f9c5c6ec8f0a71f154dba41bd927441323/specification/alertsmanagement/resource-manager/readme.md#tag-package-2021-08">alertsmanagement/resource-manager/readme.md#package-2021-08
"https://github.com/Azure/azure-rest-api-specs/blob/227939f9c5c6ec8f0a71f154dba41bd927441323/specification/alertsmanagement/resource-manager/readme.md#tag-package-preview-2021-08">alertsmanagement/resource-manager/readme.md#package-preview-2021-08
"https://github.com/Azure/azure-rest-api-specs/blob/227939f9c5c6ec8f0a71f154dba41bd927441323/specification/alertsmanagement/resource-manager/readme.md#tag-package-2021-04-only">alertsmanagement/resource-manager/readme.md#package-2021-04-only
"https://github.com/Azure/azure-rest-api-specs/blob/227939f9c5c6ec8f0a71f154dba41bd927441323/specification/alertsmanagement/resource-manager/readme.md#tag-package-2019-06-preview">alertsmanagement/resource-manager/readme.md#package-2019-06-preview
"https://github.com/Azure/azure-rest-api-specs/blob/227939f9c5c6ec8f0a71f154dba41bd927441323/specification/alertsmanagement/resource-manager/readme.md#tag-package-2019-03">alertsmanagement/resource-manager/readme.md#package-2019-03
"https://github.com/Azure/azure-rest-api-specs/blob/227939f9c5c6ec8f0a71f154dba41bd927441323/specification/alertsmanagement/resource-manager/readme.md#tag-package-preview-2019-05">alertsmanagement/resource-manager/readme.md#package-preview-2019-05

The following errors/warnings are introduced by current PR:

Rule	Message
`❌` PreCheck/DuplicateSchema	"readme":"alertsmanagement/resource-manager/readme.md", "tag":"package-2021-08", "details":"Duplicate Schema named 'errorResponse' (1 differences):\n - properties.error.$ref: "#/components/schemas/schemas:3" => "#/components/schemas/schemas:186"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌` PreCheck/DuplicateSchema	"readme":"alertsmanagement/resource-manager/readme.md", "tag":"package-2021-08", "details":"Duplicate Schema named 'errorResponseBody' (1 differences):\n - properties.details.$ref: "#/components/schemas/schemas:7" => "#/components/schemas/schemas:190"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌` PreCheck/DuplicateSchema	"readme":"alertsmanagement/resource-manager/readme.md", "tag":"package-preview-2021-08", "details":"Duplicate Schema named 'errorResponse' (1 differences):\n - properties.error.$ref: "#/components/schemas/schemas:3" => "#/components/schemas/schemas:186"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌` PreCheck/DuplicateSchema	"readme":"alertsmanagement/resource-manager/readme.md", "tag":"package-preview-2021-08", "details":"Duplicate Schema named 'errorResponseBody' (1 differences):\n - properties.details.$ref: "#/components/schemas/schemas:7" => "#/components/schemas/schemas:190"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌` PreCheck/DuplicateSchema	"readme":"alertsmanagement/resource-manager/readme.md", "tag":"package-2019-06-preview", "details":"Duplicate Schema named 'errorResponse' (1 differences):\n - properties.error.$ref: "#/components/schemas/schemas:13" => "#/components/schemas/schemas:192"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌` PreCheck/DuplicateSchema	"readme":"alertsmanagement/resource-manager/readme.md", "tag":"package-2019-06-preview", "details":"Duplicate Schema named 'errorResponseBody' (1 differences):\n - properties.details.$ref: "#/components/schemas/schemas:17" => "#/components/schemas/schemas:196"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌` PreCheck/DuplicateSchema	"readme":"alertsmanagement/resource-manager/readme.md", "tag":"package-preview-2019-05", "details":"Duplicate Schema named 'errorResponse' (1 differences):\n - properties.error.$ref: "#/components/schemas/schemas:13" => "#/components/schemas/schemas:192"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌` PreCheck/DuplicateSchema	"readme":"alertsmanagement/resource-manager/readme.md", "tag":"package-preview-2019-05", "details":"Duplicate Schema named 'errorResponseBody' (1 differences):\n - properties.details.$ref: "#/components/schemas/schemas:17" => "#/components/schemas/schemas:196"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` PreCheck/DuplicateSchema	"readme":"alertsmanagement/resource-manager/readme.md", "tag":"package-2021-08", "details":"Duplicate Schema named 'errorResponse' (1 differences):\n - properties.error.$ref: "#/components/schemas/schemas:3" => "#/components/schemas/schemas:101"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌` PreCheck/DuplicateSchema	"readme":"alertsmanagement/resource-manager/readme.md", "tag":"package-2021-08", "details":"Duplicate Schema named 'errorResponseBody' (1 differences):\n - properties.details.$ref: "#/components/schemas/schemas:7" => "#/components/schemas/schemas:105"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌`	"readme":"alertsmanagement/resource-manager/readme.md", "tag":"package-2021-08", "details":"Error: 4 errors occured -- cannot continue."
`❌` PreCheck/DuplicateSchema	"readme":"alertsmanagement/resource-manager/readme.md", "tag":"package-preview-2021-08", "details":"Duplicate Schema named 'errorResponse' (1 differences):\n - properties.error.$ref: "#/components/schemas/schemas:3" => "#/components/schemas/schemas:101"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌` PreCheck/DuplicateSchema	"readme":"alertsmanagement/resource-manager/readme.md", "tag":"package-preview-2021-08", "details":"Duplicate Schema named 'errorResponseBody' (1 differences):\n - properties.details.$ref: "#/components/schemas/schemas:7" => "#/components/schemas/schemas:105"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌`	"readme":"alertsmanagement/resource-manager/readme.md", "tag":"package-preview-2021-08", "details":"Error: 4 errors occured -- cannot continue."
`❌` PreCheck/DuplicateSchema	"readme":"alertsmanagement/resource-manager/readme.md", "tag":"package-2019-06-preview", "details":"Duplicate Schema named 'errorResponse' (1 differences):\n - properties.error.$ref: "#/components/schemas/schemas:13" => "#/components/schemas/schemas:107"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌` PreCheck/DuplicateSchema	"readme":"alertsmanagement/resource-manager/readme.md", "tag":"package-2019-06-preview", "details":"Duplicate Schema named 'errorResponseBody' (1 differences):\n - properties.details.$ref: "#/components/schemas/schemas:17" => "#/components/schemas/schemas:111"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌`	"readme":"alertsmanagement/resource-manager/readme.md", "tag":"package-2019-06-preview", "details":"Error: 4 errors occured -- cannot continue."
`❌` PreCheck/DuplicateSchema	"readme":"alertsmanagement/resource-manager/readme.md", "tag":"package-preview-2019-05", "details":"Duplicate Schema named 'errorResponse' (1 differences):\n - properties.error.$ref: "#/components/schemas/schemas:13" => "#/components/schemas/schemas:107"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌` PreCheck/DuplicateSchema	"readme":"alertsmanagement/resource-manager/readme.md", "tag":"package-preview-2019-05", "details":"Duplicate Schema named 'errorResponseBody' (1 differences):\n - properties.details.$ref: "#/components/schemas/schemas:17" => "#/components/schemas/schemas:111"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌`	"readme":"alertsmanagement/resource-manager/readme.md", "tag":"package-preview-2019-05", "details":"Error: 4 errors occured -- cannot continue."
⚠️ PreCheck/EmptyParentSchemaWarning	"readme":"alertsmanagement/resource-manager/readme.md", "tag":"package-2021-08", "details":"Schema 'MonitorServiceList' has an allOf list with an empty object schema as a parent, removing it."
⚠️ PreCheck/EmptyParentSchemaWarning	"readme":"alertsmanagement/resource-manager/readme.md", "tag":"package-preview-2021-08", "details":"Schema 'MonitorServiceList' has an allOf list with an empty object schema as a parent, removing it."
⚠️ PreCheck/EmptyParentSchemaWarning	"readme":"alertsmanagement/resource-manager/readme.md", "tag":"package-2021-04-only", "details":"Schema 'MonitorServiceList' has an allOf list with an empty object schema as a parent, removing it."
⚠️ UnkownSecurityScheme	"readme":"alertsmanagement/resource-manager/readme.md", "tag":"package-2021-04-only", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous"
⚠️ PreCheck/EmptyParentSchemaWarning	"readme":"alertsmanagement/resource-manager/readme.md", "tag":"package-2019-06-preview", "details":"Schema 'MonitorServiceList' has an allOf list with an empty object schema as a parent, removing it."
⚠️ PreCheck/EmptyParentSchemaWarning	"readme":"alertsmanagement/resource-manager/readme.md", "tag":"package-2019-03", "details":"Schema 'MonitorServiceList' has an allOf list with an empty object schema as a parent, removing it."
⚠️ UnkownSecurityScheme	"readme":"alertsmanagement/resource-manager/readme.md", "tag":"package-2019-03", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous"
⚠️ PreCheck/EmptyParentSchemaWarning	"readme":"alertsmanagement/resource-manager/readme.md", "tag":"package-preview-2019-05", "details":"Schema 'MonitorServiceList' has an allOf list with an empty object schema as a parent, removing it."

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-09-12T13:42:53Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - sdk/resourcemanager/alertsmanagement/armalertsmanagement - Approved - 0.8.0

+	Type of `AlertsClientChangeStateOptions.Comment` has been changed from `*string` to `*Comments`

️❌ azure-sdk-for-net failed [Detail]

❌Failed [Logs]Release - Generate from 280a506. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/alertsmanagement/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] No usable version of the libssl was found
cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
warn	Skip package processing as generation is failed

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 280a506. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-alertsmanagement [View full logs] [Release SDK Changes]
- azure_mgmt_alertsmanagement-1.0.0b1-py3-none-any.whl
- azure-mgmt-alertsmanagement-1.0.0b1.zip
```
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added model Comments
```

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 280a506. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/alertsmanagement/armalertsmanagement [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `AlertsClientChangeStateOptions.Comment` has been changed from `*string` to `*Comments`
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New struct `Comments`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 2 additive change(s).

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 280a506. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation

️✔️alertsmanagement [View full logs]

️❌ azure-powershell failed [Detail]

❌Failed [Logs]Release - Generate from 280a506. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

❌Az.alertsmanagement [View full logs] [Release SDK Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-09-12T13:42:54Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/alertsmanagement/armalertsmanagement	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
Python	track2_azure-mgmt-alertsmanagement	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

openapi-workflow-bot · 2022-09-13T11:54:48Z

Hi @khaledaboasbe, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

...nagement/resource-manager/Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json

openapi-workflow-bot · 2022-09-20T08:34:13Z

Hi @khaledaboasbe, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

mikekistler

Need to revert the unnecessary changes.

mikekistler · 2022-09-20T11:59:54Z

package-lock.json

@@ -3696,4 +3696,4 @@
      "dev": true
    }
  }
-}


Please revert this change.

mikekistler · 2022-09-20T12:00:32Z

...resource-manager/Microsoft.AlertsManagement/preview/2019-05-05-preview/AlertsManagement.json

@@ -247,7 +247,7 @@
            "$ref": "#/parameters/newState"
          },
          {
-            "$ref": "#/parameters/comment"


This change is not necessary -- please revert.

mikekistler · 2022-09-20T12:00:53Z

...resource-manager/Microsoft.AlertsManagement/preview/2019-05-05-preview/AlertsManagement.json

-    "comment": {
+    "comments": {
      "description": "reason of change alert state",
-      "name": "comment",
+      "name": "comments",


These changes are not needed -- please revert.

...nagement/resource-manager/Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json

changlong-liu · 2022-09-21T02:05:38Z

Hi @khaledaboasbe , would you please fix R2024 Lint issues following https://github.com/Azure/azure-rest-api-specs/pull/20680/checks?check_run_id=8459441206 .

changlong-liu · 2022-09-21T08:59:28Z

Hi @tadelesh , would you take a look whether the reported GoLang breaking change blocks this PR?

mikekistler · 2022-09-21T22:52:58Z

@khaledaboasbe As discussed in the breaking changes office hours, I will sign off on this change with the understanding that this matches the actual behavior of the service. Please test to make sure this is correct before merging.

tadelesh · 2022-09-22T01:44:27Z

Hi @tadelesh , would you take a look whether the reported GoLang breaking change blocks this PR?

Approved.

changlong-liu · 2022-09-22T02:03:42Z

Hi @khaledaboasbe , the PR looks good as swagger now.
Ping me please if you want this merge and this change does be the service behaviour.

khaledaboasbe · 2022-09-22T07:59:54Z

merge request

khaledaboasbe · 2022-09-22T08:06:05Z

@khaledaboasbe As discussed in the breaking changes office hours, I will sign off on this change with the understanding that this matches the actual behavior of the service. Please test to make sure this is correct before merging.

approved

Khaled Abo Asbe and others added 22 commits April 10, 2022 14:13

Add comment to Change state parameters

d57bc32

fix error

22ac797

fix error

834ac0b

fix

9a4e6f4

fix

d873e9e

fix error

f69eff1

fix validations

6a0aa9c

Merge branch 'main' into dev-alertsmanagement-Microsoft.AlertsManagem…

d3d35ae

…ent-2019-03-01

add example for operation list command

7ebf9df

Merge branch 'dev-alertsmanagement-Microsoft.AlertsManagement-2019-03…

53e8fbc

…-01' of https://github.com/khaledaboasbe/azure-rest-api-specs into dev-alertsmanagement-Microsoft.AlertsManagement-2019-03-01

fix example

b701dc0

fix example

112af15

fix

656afe5

fix

0d5b1ff

delete json file

4beeaec

add origin parameter to operation defenition

b11a37b

fix

9156c65

fix

1ef1936

fix

1f5078e

delete unneccesary files

f61f91a

revert packege-lock.json file changes

8145b84

fix comment parameter to be comments

482351b

ghost added the Alerts Management label Sep 12, 2022

khaledaboasbe marked this pull request as ready for review September 12, 2022 13:57

khaledaboasbe requested review from ofirmanor and orieldar as code owners September 12, 2022 13:57

changlong-liu added the BreakingChangeReviewRequired label Sep 13, 2022

mikekistler reviewed Sep 19, 2022

View reviewed changes

...nagement/resource-manager/Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json Show resolved Hide resolved

fix comments object

413cb66

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Sep 20, 2022

AzureRestAPISpecReview added the SuppressionReviewRequired label Sep 20, 2022

Khaled Abo Asbe added 2 commits September 20, 2022 11:41

run prettier

ebe529d

fix

1308b5d

mikekistler reviewed Sep 20, 2022

View reviewed changes

revert unncessary changes

2fedfc1

LintdiffFix

4bbf1d6

AzureRestAPISpecReview added the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Sep 21, 2022

run prettier

227939f

mikekistler added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Sep 21, 2022

tadelesh added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Sep 22, 2022

changlong-liu approved these changes Sep 26, 2022

View reviewed changes

changlong-liu merged commit 280a506 into Azure:main Sep 26, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.AlertsManagement to add version stable/2019-03-01 #20680

[Hub Generated] Review request for Microsoft.AlertsManagement to add version stable/2019-03-01 #20680

khaledaboasbe commented Sep 12, 2022

openapi-workflow-bot bot commented Sep 12, 2022

openapi-pipeline-app bot commented Sep 12, 2022 •

edited

Loading

openapi-pipeline-app bot commented Sep 12, 2022 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Sep 12, 2022 •

edited

Loading

openapi-workflow-bot bot commented Sep 13, 2022

openapi-workflow-bot bot commented Sep 20, 2022

mikekistler left a comment

mikekistler Sep 20, 2022

mikekistler Sep 20, 2022

mikekistler Sep 20, 2022

changlong-liu commented Sep 21, 2022

changlong-liu commented Sep 21, 2022

mikekistler commented Sep 21, 2022

tadelesh commented Sep 22, 2022

changlong-liu commented Sep 22, 2022

khaledaboasbe commented Sep 22, 2022

khaledaboasbe commented Sep 22, 2022

[Hub Generated] Review request for Microsoft.AlertsManagement to add version stable/2019-03-01 #20680

[Hub Generated] Review request for Microsoft.AlertsManagement to add version stable/2019-03-01 #20680

Conversation

khaledaboasbe commented Sep 12, 2022

ARM API Information (Control Plane)

Changelog

Contribution checklist (MS Employees Only):

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Sep 12, 2022

openapi-pipeline-app bot commented Sep 12, 2022 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Sep 12, 2022 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Sep 12, 2022 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Sep 13, 2022

openapi-workflow-bot bot commented Sep 20, 2022

mikekistler left a comment

Choose a reason for hiding this comment

mikekistler Sep 20, 2022

Choose a reason for hiding this comment

mikekistler Sep 20, 2022

Choose a reason for hiding this comment

mikekistler Sep 20, 2022

Choose a reason for hiding this comment

changlong-liu commented Sep 21, 2022

changlong-liu commented Sep 21, 2022

mikekistler commented Sep 21, 2022

tadelesh commented Sep 22, 2022

changlong-liu commented Sep 22, 2022

khaledaboasbe commented Sep 22, 2022

khaledaboasbe commented Sep 22, 2022

openapi-pipeline-app bot commented Sep 12, 2022 •

edited

Loading

openapi-pipeline-app bot commented Sep 12, 2022 •

edited

Loading

openapi-pipeline-app bot commented Sep 12, 2022 •

edited

Loading