DataBox API version upgrade to 2022-09-01 #20717

ashoknailwal · 2022-09-14T11:20:39Z

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2022-09-14T11:20:42Z

Hi, @ashoknailwal Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-workflow-bot · 2022-09-14T11:20:44Z

Hi, @ashoknailwal your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

openapi-pipeline-app · 2022-09-14T11:20:44Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

compared swaggers (via Oad v0.10.2)]	new version	base version
databox.json	2022-09-01(2e5edf4)	2022-02-01(main)
databox.json	2022-09-01(2e5edf4)	2021-08-01-preview(main)

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 2 Warnings warning [Detail]

compared tags (via openapi-validator v2.0.0)	new version	base version
package-2022-09	package-2022-09(2e5edf4)	default(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule	Message	Related RPC [For API reviewers]
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.DataBox/stable/2022-09-01/databox.json#L5279
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.DataBox/stable/2022-09-01/databox.json#L6250

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` ParametersOrder	The parameters:jobName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBox/stable/2022-09-01/databox.json#L113
`❌` ParametersOrder	The parameters:jobName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBox/stable/2022-09-01/databox.json#L167
`❌` CreateOperationAsyncResponseValidation	An async PUT operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.DataBox/stable/2022-09-01/databox.json#L567
`❌` CreateOperationAsyncResponseValidation	An async PUT operation must return 201. Location: Microsoft.DataBox/stable/2022-09-01/databox.json#L602
`❌` CreateOperationAsyncResponseValidation	Only 201 is the supported response code for PUT async response. Location: Microsoft.DataBox/stable/2022-09-01/databox.json#L609
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.DataBox/stable/2022-09-01/databox.json#L609
`❌` DeleteOperationAsyncResponseValidation	An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.DataBox/stable/2022-09-01/databox.json#L638
`❌` PatchSkuProperty	The patch operation body parameter schema should contains property 'sku'. Location: Microsoft.DataBox/stable/2022-09-01/databox.json#L725
`❌` ConsistentPatchProperties	The property 'properties.details.returnToCustomerPackageDetails' in the request body either not apppear in the resource model or has the wrong level. Location: Microsoft.DataBox/stable/2022-09-01/databox.json#L730
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.DataBox/stable/2022-09-01/databox.json#L1084
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.DataBox/stable/2022-09-01/databox.json#L1160
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.DataBox/stable/2022-09-01/databox.json#L1299
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.DataBox/stable/2022-09-01/databox.json#L1383
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.DataBox/stable/2022-09-01/databox.json#L1395
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.DataBox/stable/2022-09-01/databox.json#L1446
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.DataBox/stable/2022-09-01/databox.json#L2163
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.DataBox/stable/2022-09-01/databox.json#L2197
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.DataBox/stable/2022-09-01/databox.json#L2838
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.DataBox/stable/2022-09-01/databox.json#L2889
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.DataBox/stable/2022-09-01/databox.json#L2959
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.DataBox/stable/2022-09-01/databox.json#L2983
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.DataBox/stable/2022-09-01/databox.json#L3008
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.DataBox/stable/2022-09-01/databox.json#L3021
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.DataBox/stable/2022-09-01/databox.json#L3044
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.DataBox/stable/2022-09-01/databox.json#L3068
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.DataBox/stable/2022-09-01/databox.json#L3107
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.DataBox/stable/2022-09-01/databox.json#L3120
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.DataBox/stable/2022-09-01/databox.json#L3237
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.DataBox/stable/2022-09-01/databox.json#L3244
`❌` DefinitionsPropertiesNamesCamelCase	Property name should be camel case. Location: Microsoft.DataBox/stable/2022-09-01/databox.json#L3355

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️❌~[Staging] ServiceAPIReadinessTest: 13 Errors, 0 Warnings failed [Detail]

Tag package-2022-09; Prod region: Deployed

Test run on region: westeurope; Operation coverage: total: 18, untested: 0, failed: 13, passed: 5

Service API Readiness Test failed. Check pipeline artifact for detail report.

Rule	Message
`❌` CLIENT_ERROR	"statusCode: 403, errorCode: LinkedAuthorizationFailed, errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' has permission to perform action 'Microsoft.DataBox/jobs/write' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-phqaKW-20717/providers/Microsoft.DataBox/jobs/jobnameeonwrh'; however, it does not have permission to perform action 'write' on the linked scope(s) '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourcegroups/databoxbvt/providers/Microsoft.Storage/storageAccounts/databoxbvttestaccount' or the linked scope(s) are invalid."
`❌` CLIENT_ERROR	"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataBox/jobs/jobnameeonwrh' under resource group 'apiTest-phqaKW-20717' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
`❌` CLIENT_ERROR	"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataBox/jobs/jobnameeonwrh' under resource group 'apiTest-phqaKW-20717' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
`❌` CLIENT_ERROR	"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataBox/jobs/jobnameeonwrh' under resource group 'apiTest-phqaKW-20717' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
`❌` CLIENT_ERROR	"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataBox/jobs/jobnameeonwrh' under resource group 'apiTest-phqaKW-20717' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
`❌` CLIENT_ERROR	"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataBox/jobs/jobnameeonwrh' under resource group 'apiTest-phqaKW-20717' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
`❌` CLIENT_ERROR	"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataBox/jobs/jobnameeonwrh' under resource group 'apiTest-phqaKW-20717' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
`❌` CLIENT_ERROR	"statusCode: 403, errorCode: AuthorizationFailed, errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'Microsoft.DataBox/locations/regionConfiguration/action' over scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5' or the scope is invalid. If access was recently granted, please refresh your credentials."
`❌` CLIENT_ERROR	"statusCode: 403, errorCode: AuthorizationFailed, errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'Microsoft.DataBox/locations/validateAddress/action' over scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5' or the scope is invalid. If access was recently granted, please refresh your credentials."
`❌` CLIENT_ERROR	"statusCode: 403, errorCode: AuthorizationFailed, errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'Microsoft.DataBox/locations/validateInputs/action' over scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5' or the scope is invalid. If access was recently granted, please refresh your credentials."
`❌` CLIENT_ERROR	"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataBox/jobs/jobnameeonwrh' under resource group 'apiTest-phqaKW-20717' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
`❌` SERVER_ERROR	"statusCode: 500, errorCode: RestApiInternalError, errorMessage: "
`❌` SERVER_ERROR	"statusCode: 500, errorCode: TransportGenericNonRetryableError, errorMessage: "

️️✔️~[Staging] SwaggerAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-09-14T11:20:45Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-python-track2 - track2_azure-mgmt-databox - Approved - 1.0.0

+	Model DataBoxDiskJobDetails no longer has parameter expected_data_size_in_terabytes
+	Model DataBoxHeavyJobDetails no longer has parameter expected_data_size_in_terabytes
+	Model DataBoxJobDetails no longer has parameter expected_data_size_in_terabytes
+	Model DiskScheduleAvailabilityRequest has a new required parameter expected_data_size_in_tera_bytes
+	Model DiskScheduleAvailabilityRequest no longer has parameter expected_data_size_in_terabytes
+	Model JobDetails no longer has parameter expected_data_size_in_terabytes

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed [Logs]Release - Generate from 9d00bb9. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
warn	File azure-sdk-for-net_tmp/initOutput.json not found to read
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:611
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m 611 | �[0m         �[96mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m     | �[91m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91m�[96m     | �[91mFailed to build sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m

❌Azure.ResourceManager.DataBox [View full logs] [Release SDK Changes] Breaking Change Detected

Azure.ResourceManager.DataBox.1.1.0-alpha.20221115.1.nupkg

info	[Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Nullable<Azure.ResourceManager.DataBox.Models.TransportShipmentType> Azure.ResourceManager.DataBox.Models.DataBoxValidateAddressContent.TransportPreferencesPreferredShipmentType.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/databox/Azure.ResourceManager.DataBox/src/Azure.ResourceManager.DataBox.csproj],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public void Azure.ResourceManager.DataBox.Models.DataBoxValidateAddressContent.TransportPreferencesPreferredShipmentType.set(System.Nullable<Azure.ResourceManager.DataBox.Models.TransportShipmentType>)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/databox/Azure.ResourceManager.DataBox/src/Azure.ResourceManager.DataBox.csproj],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.DataBox/Debug/netstandard2.0/Azure.ResourceManager.DataBox.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/databox/Azure.ResourceManager.DataBox/src/Azure.ResourceManager.DataBox.csproj]

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 9d00bb9. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.2 -> 9.1.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.1.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.1.1` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-databox [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation JobsOperations.mark_devices_shipped
info	[Changelog]   - Added operation group DataBoxManagementClientOperationsMixin
info	[Changelog]   - Model DataBoxDiskJobDetails has a new parameter actions
info	[Changelog]   - Model DataBoxDiskJobDetails has a new parameter data_center_code
info	[Changelog]   - Model DataBoxDiskJobDetails has a new parameter datacenter_address
info	[Changelog]   - Model DataBoxDiskJobDetails has a new parameter device_erasure_details
info	[Changelog]   - Model DataBoxDiskJobDetails has a new parameter expected_data_size_in_tera_bytes
info	[Changelog]   - Model DataBoxDiskJobDetails has a new parameter granular_copy_log_details
info	[Changelog]   - Model DataBoxDiskJobDetails has a new parameter granular_copy_progress
info	[Changelog]   - Model DataBoxDiskJobDetails has a new parameter last_mitigation_action_on_job
info	[Changelog]   - Model DataBoxDiskJobDetails has a new parameter reverse_shipping_details
info	[Changelog]   - Model DataBoxHeavyJobDetails has a new parameter actions
info	[Changelog]   - Model DataBoxHeavyJobDetails has a new parameter data_center_code
info	[Changelog]   - Model DataBoxHeavyJobDetails has a new parameter datacenter_address
info	[Changelog]   - Model DataBoxHeavyJobDetails has a new parameter device_erasure_details
info	[Changelog]   - Model DataBoxHeavyJobDetails has a new parameter expected_data_size_in_tera_bytes
info	[Changelog]   - Model DataBoxHeavyJobDetails has a new parameter last_mitigation_action_on_job
info	[Changelog]   - Model DataBoxHeavyJobDetails has a new parameter reverse_shipping_details
info	[Changelog]   - Model DataBoxJobDetails has a new parameter actions
info	[Changelog]   - Model DataBoxJobDetails has a new parameter data_center_code
info	[Changelog]   - Model DataBoxJobDetails has a new parameter datacenter_address
info	[Changelog]   - Model DataBoxJobDetails has a new parameter device_erasure_details
info	[Changelog]   - Model DataBoxJobDetails has a new parameter expected_data_size_in_tera_bytes
info	[Changelog]   - Model DataBoxJobDetails has a new parameter last_mitigation_action_on_job
info	[Changelog]   - Model DataBoxJobDetails has a new parameter reverse_shipping_details
info	[Changelog]   - Model DataImportDetails has a new parameter log_collection_level
info	[Changelog]   - Model JobDetails has a new parameter actions
info	[Changelog]   - Model JobDetails has a new parameter data_center_code
info	[Changelog]   - Model JobDetails has a new parameter datacenter_address
info	[Changelog]   - Model JobDetails has a new parameter device_erasure_details
info	[Changelog]   - Model JobDetails has a new parameter expected_data_size_in_tera_bytes
info	[Changelog]   - Model JobDetails has a new parameter last_mitigation_action_on_job
info	[Changelog]   - Model JobDetails has a new parameter reverse_shipping_details
info	[Changelog]   - Model JobResource has a new parameter reverse_shipping_details_update
info	[Changelog]   - Model JobResource has a new parameter reverse_transport_preference_update
info	[Changelog]   - Model JobResource has a new parameter system_data
info	[Changelog]   - Model Preferences has a new parameter reverse_transport_preferences
info	[Changelog]   - Model Preferences has a new parameter storage_account_access_tier_preferences
info	[Changelog]   - Model RegionConfigurationRequest has a new parameter datacenter_address_request
info	[Changelog]   - Model RegionConfigurationResponse has a new parameter datacenter_address_response
info	[Changelog]   - Model SkuInformation has a new parameter countries_within_commerce_boundary
info	[Changelog]   - Model TransportPreferences has a new parameter is_updated
info	[Changelog]   - Model UpdateJobDetails has a new parameter preferences
info	[Changelog]   - Model UpdateJobDetails has a new parameter return_to_customer_package_details
info	[Changelog]   - Model UpdateJobDetails has a new parameter reverse_shipping_details
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Model DataBoxDiskJobDetails no longer has parameter expected_data_size_in_terabytes
info	[Changelog]   - Model DataBoxHeavyJobDetails no longer has parameter expected_data_size_in_terabytes
info	[Changelog]   - Model DataBoxJobDetails no longer has parameter expected_data_size_in_terabytes
info	[Changelog]   - Model DiskScheduleAvailabilityRequest has a new required parameter expected_data_size_in_tera_bytes
info	[Changelog]   - Model DiskScheduleAvailabilityRequest no longer has parameter expected_data_size_in_terabytes
info	[Changelog]   - Model JobDetails no longer has parameter expected_data_size_in_terabytes

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 9d00bb9. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-databox [View full logs] [Release SDK Changes]

azure-arm-databox-5.0.0.tgz

info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 9d00bb9. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/databox/armdatabox [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Field `AccountName` of struct `DiskGranularCopyLogDetails` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `ReverseShippingDetailsEditStatusEnabled`
info	[Changelog] - New const `ReverseTransportPreferenceEditStatusEnabled`
info	[Changelog] - New const `ReverseTransportPreferenceEditStatusNotSupported`
info	[Changelog] - New const `ReverseShippingDetailsEditStatusNotSupported`
info	[Changelog] - New const `ReverseShippingDetailsEditStatusDisabled`
info	[Changelog] - New const `ReverseTransportPreferenceEditStatusDisabled`
info	[Changelog] - New type alias `ReverseTransportPreferenceEditStatus`
info	[Changelog] - New type alias `ReverseShippingDetailsEditStatus`
info	[Changelog] - New function `PossibleReverseTransportPreferenceEditStatusValues() []ReverseTransportPreferenceEditStatus`
info	[Changelog] - New function `PossibleReverseShippingDetailsEditStatusValues() []ReverseShippingDetailsEditStatus`
info	[Changelog] - New struct `ContactInfo`
info	[Changelog] - New struct `ReverseShippingDetails`
info	[Changelog] - New field `AccountID` in struct `DiskGranularCopyLogDetails`
info	[Changelog] - New field `GranularCopyLogDetails` in struct `DiskJobDetails`
info	[Changelog] - New field `ReverseShippingDetails` in struct `DiskJobDetails`
info	[Changelog] - New field `ReverseShippingDetails` in struct `CommonJobDetails`
info	[Changelog] - New field `ReverseShippingDetails` in struct `HeavyJobDetails`
info	[Changelog] - New field `ReverseShippingDetailsUpdate` in struct `JobProperties`
info	[Changelog] - New field `ReverseTransportPreferenceUpdate` in struct `JobProperties`
info	[Changelog] - New field `Preferences` in struct `UpdateJobDetails`
info	[Changelog] - New field `ReverseShippingDetails` in struct `UpdateJobDetails`
info	[Changelog] - New field `ReverseTransportPreferences` in struct `Preferences`
info	[Changelog] - New field `CountriesWithinCommerceBoundary` in struct `SKUProperties`
info	[Changelog] - New field `ReverseShippingDetails` in struct `CustomerDiskJobDetails`
info	[Changelog] - New field `ReverseShippingDetails` in struct `JobDetails`
info	[Changelog] - New field `IsUpdated` in struct `TransportPreferences`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 25 additive change(s).

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 9d00bb9. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
warn	No file changes detected after generation
warn	No package detected after generation

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 9d00bb9. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️databox [View full logs] [Release Schema Changes]

️️✔️ azure-powershell succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 9d00bb9. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

️✔️Az.DataBox [View full logs] [Release SDK Changes]
- Az.DataBox.0.1.0.nupkg

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-09-14T11:20:46Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/databox/armdatabox	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
Python	track2_azure-mgmt-databox	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
.Net	Azure.ResourceManager.DataBox	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
JavaScript	@azure/arm-databox	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

rkmanda · 2022-09-18T06:17:43Z

        "type": "string"

enum of country names?

Refers to: specification/databox/resource-manager/Microsoft.DataBox/stable/2022-09-01/databox.json:5869 in 78d5947. [](commit_id = 78d5947, deletion_comment = False)

ashoknailwal · 2022-09-18T10:59:22Z

        "type": "string"
enum of country names?

Refers to: specification/databox/resource-manager/Microsoft.DataBox/stable/2022-09-01/databox.json:5869 in 78d5947. [](commit_id = 78d5947, deletion_comment = False)

Hi @rkmanda, Currently we have the commerce boundary and country list map as part of a json config, after deserialization we have kept it as strings, similar to DataLocationToServiceLocationMap, that is an existing design choice. Here we are simply exposing the values from the map. So keeping them as strings is intentional as of now.

ghost · 2022-10-02T16:03:18Z

Hi, @ashoknailwal. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

openapi-workflow-bot · 2022-10-28T10:52:59Z

Hi, @ashoknailwal, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline

This reverts commit 215f002.

openapi-workflow-bot · 2022-11-02T05:41:52Z

Hi @ashoknailwal, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

…api version

Create to sync Azure/azure-rest-api-specs#20717 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...azure-sdk:sdkAuto/databox?expand=1)

* Initial commit - copy files from previous version * Changes for v2022-09-01 * Remove unnecessary properties and add description and fix CI issues * Update databox.json * Revert "Update databox.json" This reverts commit 215f002. * add account id changes, fixed in previous api version * fix swagger validation issues and account id changes as per previous api version * fix swagger modelvalidation issue for location header Co-authored-by: Aakash Saini <rockmyinboxx@gmail.com>

ashoknailwal added 3 commits September 13, 2022 13:23

Initial commit - copy files from previous version

5ac78ec

Changes for v2022-09-01

642825f

Remove unnecessary properties and add description and fix CI issues

78d5947

ashoknailwal requested review from msyyc, BigCat20196 and ArcturusZhang as code owners September 14, 2022 11:20

openapi-assignment-bot bot assigned ruowan Sep 14, 2022

openapi-workflow-bot bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 14, 2022

openapi-pipeline-app bot added resource-manager CI-BreakingChange-Python-Track2 labels Sep 15, 2022

rkmanda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Sep 18, 2022

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 18, 2022

ghost added no-recent-activity and removed no-recent-activity labels Oct 2, 2022

Merge branch 'Azure:main' into ashoknailwal/databox-v-2022-09-01

c411990

rkmanda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Oct 19, 2022

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 19, 2022

Merge branch 'Azure:main' into ashoknailwal/databox-v-2022-09-01

0240f1d

AzureRestAPISpecReview added CI-MissingBaseCommit new-api-version labels Oct 28, 2022

azure-sdk mentioned this pull request Oct 28, 2022

[AutoPR Azure.ResourceManager.DataBox] DataBox API version upgrade to 2022-09-01 azure-sdk/azure-sdk-for-net#1317

Closed

Revert "Update databox.json"

e6ccd46

This reverts commit 215f002.

AzureRestAPISpecReview added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Nov 2, 2022

add account id changes, fixed in previous api version

6038d6c

openapi-pipeline-app bot added the CI-BreakingChange-Go label Nov 2, 2022

fix swagger validation issues and account id changes as per previous …

46cc4e8

…api version

AzureRestAPISpecReview removed the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Nov 2, 2022

msyyc added the Approved-SdkBreakingChange-Python label Nov 10, 2022

fix swagger modelvalidation issue for location header

2e5edf4

AzureRestAPISpecReview removed the CI-FixRequiredOnFailure label Nov 14, 2022

ruowan approved these changes Nov 15, 2022

View reviewed changes

ruowan merged commit 9d00bb9 into Azure:main Nov 15, 2022

This was referenced Nov 15, 2022

[ReleasePR Azure.ResourceManager.DataBox] Add new API version 2023-03-01 for databox Azure/azure-sdk-for-net#32112

Closed

[ReleasePR Az.DataBox] Fix S360 items related to swagger. Azure/azure-powershell#17931

Closed

tadelesh mentioned this pull request Jan 28, 2023

Add new API version for databox 2022-10-01 #22049

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DataBox API version upgrade to 2022-09-01 #20717

DataBox API version upgrade to 2022-09-01 #20717

ashoknailwal commented Sep 14, 2022

openapi-workflow-bot bot commented Sep 14, 2022

openapi-workflow-bot bot commented Sep 14, 2022

openapi-pipeline-app bot commented Sep 14, 2022 •

edited

Loading

openapi-pipeline-app bot commented Sep 14, 2022 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Sep 14, 2022 •

edited

Loading

rkmanda commented Sep 18, 2022

ashoknailwal commented Sep 18, 2022

ghost commented Oct 2, 2022

openapi-workflow-bot bot commented Oct 28, 2022

openapi-workflow-bot bot commented Nov 2, 2022

DataBox API version upgrade to 2022-09-01 #20717

DataBox API version upgrade to 2022-09-01 #20717

Conversation

ashoknailwal commented Sep 14, 2022

ARM API Information (Control Plane)

Changelog

Contribution checklist (MS Employees Only):

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Sep 14, 2022

openapi-workflow-bot bot commented Sep 14, 2022

openapi-pipeline-app bot commented Sep 14, 2022 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Sep 14, 2022 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Sep 14, 2022 • edited Loading

Generated ApiView

rkmanda commented Sep 18, 2022

ashoknailwal commented Sep 18, 2022

ghost commented Oct 2, 2022

openapi-workflow-bot bot commented Oct 28, 2022

openapi-workflow-bot bot commented Nov 2, 2022

openapi-pipeline-app bot commented Sep 14, 2022 •

edited

Loading

openapi-pipeline-app bot commented Sep 14, 2022 •

edited

Loading

openapi-pipeline-app bot commented Sep 14, 2022 •

edited

Loading