[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 #20855

kbharucha · 2022-09-23T20:48:13Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2022-09-23T20:48:15Z

Hi, @kbharucha Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2022-09-23T20:48:15Z

Swagger Validation Report

️❌BreakingChange: 9 Errors, 2 Warnings failed [Detail]

compared swaggers (via Oad v0.9.7)]	new version	base version
consumption.json	2019-10-01(784952d)	2019-10-01(main)

Rule	Message
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.Consumption/stable/2019-10-01/consumption.json#L5278:9 Old: Microsoft.Consumption/stable/2019-10-01/consumption.json#L5351:9
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.Consumption/stable/2019-10-01/consumption.json#L5278:9 Old: Microsoft.Consumption/stable/2019-10-01/consumption.json#L5351:9
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.Consumption/stable/2019-10-01/consumption.json#L5278:9 Old: Microsoft.Consumption/stable/2019-10-01/consumption.json#L5351:9
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'marketplaceCharges' renamed or removed? New: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4584:7 Old: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4584:7
`❌` 1040 - AddedReadOnlyPropertyInResponse	The new version has a new read-only property 'tags' in response that was not found in the old version. New: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4543:7 Old: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4543:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'azureMarketplaceCharges' that was not found in the old version. New: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4584:7 Old: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4584:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'tags' that was not found in the old version. New: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4565:7 Old: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4565:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'subscriptionId' that was not found in the old version. New: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4648:7 Old: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4648:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'tags' that was not found in the old version. New: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4629:7 Old: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4629:7
⚠️ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4528:11 Old: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4528:11
⚠️ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4534:5 Old: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4534:5

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v1.13.0)	new version	base version
package-2019-10	package-2019-10(784952d)	package-2019-10(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` R3021 - PathResourceTypeNameCamelCase	Resource type naming must follow camel case. Path: '/providers/Microsoft.Management/managementGroups/{managementGroupId}/providers/Microsoft.Billing/billingPeriods/{billingPeriodName}/Microsoft.Consumption/aggregatedCost' Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L1557
`❌` R3030 - PathResourceProviderMatchNamespace	The last resource provider 'Microsoft.Management, Microsoft.Billing' doesn't match the namespace. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L1557
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L424
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.Consumption/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L1477
`❌` R4037 - MissingTypeObject	The schema 'MeterDetails' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L1742
`❌` R4037 - MissingTypeObject	The schema 'UsageDetailsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L1821
`❌` R4037 - MissingTypeObject	The schema 'LegacyUsageDetailProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L1859
`❌` R4037 - MissingTypeObject	The schema 'ModernUsageDetailProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L2102
`❌` R4037 - MissingTypeObject	The schema 'TagProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L3855
`❌` R4037 - MissingTypeObject	The schema 'Tag' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L3877
`❌` R4037 - MissingTypeObject	The schema 'BudgetsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L3893
`❌` R4037 - MissingTypeObject	The schema 'BudgetProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L3927
`❌` R4037 - MissingTypeObject	The schema 'BudgetTimePeriod' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L3998
`❌` R4037 - MissingTypeObject	The schema 'BudgetFilter' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4016
`❌` R4037 - MissingTypeObject	The schema 'BudgetFilterProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4041
`❌` R4037 - MissingTypeObject	The schema 'BudgetComparisonExpression' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4054
`❌` R4037 - MissingTypeObject	The schema 'CurrentSpend' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4087
`❌` R4037 - MissingTypeObject	The schema 'ForecastSpend' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4103
`❌` R4037 - MissingTypeObject	The schema 'Notification' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4119
`❌` R4037 - MissingTypeObject	The schema 'PriceSheetModel' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4236
`❌` R4037 - MissingTypeObject	The schema 'DownloadProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4259
`❌` R4037 - MissingTypeObject	The schema 'PriceSheetProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4274
`❌` R4037 - MissingTypeObject	The schema 'ChargesListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4521
`❌` R4037 - MissingTypeObject	The schema 'MeterDetailsResponse' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4711
`❌` R4037 - MissingTypeObject	The schema 'ErrorDetails' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4741
`❌` R4037 - MissingTypeObject	The schema 'HighCasedErrorDetails' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4756
`❌` R4037 - MissingTypeObject	The schema 'display' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4805
`❌` R4037 - MissingTypeObject	The schema 'OperationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4832
`❌` R4037 - MissingTypeObject	The schema 'Events' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4850
`❌` R4037 - MissingTypeObject	The schema 'EventProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4884

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

API Test is not triggered due to precheck failure. Check pipeline log for details.

️❌ModelValidation: 2 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` XMS_EXAMPLE_NOTFOUND_ERROR	x-ms-example not found in Operations_List. Url: Microsoft.Consumption/stable/2019-10-01/consumption.json#L1478:14
`❌` XMS_EXAMPLE_NOTFOUND_ERROR	x-ms-example not found in Operations_List. Url: Microsoft.Consumption/stable/2019-10-01/consumption.json#L1478:14

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️⚠️SDK Track2 Validation: 0 Warnings warning [Detail]

The following tags are being changed in this PR

"https://github.com/Azure/azure-rest-api-specs/blob/784952d6aa577abca026925fed9c2a9483923d30/specification/consumption/resource-manager/readme.md#tag-package-2019-10">consumption/resource-manager/readme.md#package-2019-10

The following errors/warnings exist before current PR submission:

Rule	Message
⚠️ PreCheck/PropertyRedeclarationWarning	"readme":"consumption/resource-manager/readme.md", "tag":"package-2019-10", "details":"Schema 'LegacyReservationTransaction' has a property 'properties' that is already declared the parent schema 'ReservationTransaction' but isn't significantly different. The property has been removed from LegacyReservationTransaction"
⚠️ UnkownSecurityScheme	"readme":"consumption/resource-manager/readme.md", "tag":"package-2019-10", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous"

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-09-23T20:48:16Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - sdk/resourcemanager/consumption/armconsumption - Approved - 2.0.0

+	Field `Etag` of struct `CreditSummary` has been removed
+	Field `Tags` of struct `CreditSummary` has been removed

❌azure-sdk-for-python-track2 - track2_azure-mgmt-consumption - Approved - 10.0.0

+	Model CreditSummary no longer has parameter etag
+	Model CreditSummary no longer has parameter tags

❌azure-sdk-for-js - @azure/arm-consumption - Approved - 10.0.0

+	Interface BudgetFilter no longer has parameter not
+	Interface CreditSummary no longer has parameter eTag
+	Interface LegacyChargeSummary no longer has parameter kind
+	Interface LegacyReservationRecommendation no longer has parameter kind
+	Interface LegacyUsageDetail no longer has parameter kind
+	Interface ModernChargeSummary no longer has parameter kind
+	Interface ModernReservationRecommendation no longer has parameter kind
+	Interface ModernUsageDetail no longer has parameter kind
+	Operation ReservationRecommendationDetails.get has a new signature

️❌ azure-sdk-for-net failed [Detail]

❌Failed [Logs]Release - Generate from 2a4a286. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/consumption/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] No usable version of the libssl was found
cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
warn	Skip package processing as generation is failed

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 2a4a286. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/consumption/armconsumption [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Field `Tags` of struct `CreditSummary` has been removed
info	[Changelog] - Field `Etag` of struct `CreditSummary` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `EventTypeCreditExpired`
info	[Changelog] - New field `ETag` in struct `CreditSummary`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 2 additive change(s).

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 2a4a286. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.15.0 -> 8.19.2
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.19.2>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.19.2` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-consumption [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Model CreditSummary has a new parameter e_tag_properties_e_tag
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Model CreditSummary no longer has parameter etag
info	[Changelog]   - Model CreditSummary no longer has parameter tags

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 2a4a286. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] [ForkJoinPool-1-worker-3] INFO com.azure.core.test.implementation.TestingHelpers - Environment variable 'AZURE_TEST_MODE' has not been set yet. Using 'Playback' mode.

️✔️azure-resourcemanager-consumption [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 2a4a286. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-consumption [View full logs] [Release SDK Changes] Breaking Change Detected

azure-arm-consumption-10.0.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation LotsOperations.listByCustomer
info	[Changelog]   - Added Interface LotsListByCustomerNextOptionalParams
info	[Changelog]   - Added Interface LotsListByCustomerOptionalParams
info	[Changelog]   - Added Type Alias LotsListByCustomerNextResponse
info	[Changelog]   - Added Type Alias LotsListByCustomerResponse
info	[Changelog]   - Interface CreditSummary has a new optional parameter eTagPropertiesETag
info	[Changelog]   - Interface LegacyUsageDetail has a new optional parameter benefitId
info	[Changelog]   - Interface LegacyUsageDetail has a new optional parameter benefitName
info	[Changelog]   - Enum KnownEventType has a new value CreditExpired
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Operation ReservationRecommendationDetails.get has a new signature
info	[Changelog]   - Interface BudgetFilter no longer has parameter not
info	[Changelog]   - Interface CreditSummary no longer has parameter eTag
info	[Changelog]   - Interface LegacyChargeSummary no longer has parameter kind
info	[Changelog]   - Interface LegacyReservationRecommendation no longer has parameter kind
info	[Changelog]   - Interface LegacyUsageDetail no longer has parameter kind
info	[Changelog]   - Interface ModernChargeSummary no longer has parameter kind
info	[Changelog]   - Interface ModernReservationRecommendation no longer has parameter kind
info	[Changelog]   - Interface ModernUsageDetail no longer has parameter kind

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 2a4a286. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation

️✔️consumption [View full logs]

️️✔️ azure-powershell succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 2a4a286. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

️✔️Az.Consumption [View full logs] [Release SDK Changes]
- Az.Consumption.0.1.0.nupkg

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-09-23T20:48:17Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/consumption/armconsumption	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
Python	track2_azure-mgmt-consumption	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
Java	azure-resourcemanager-consumption	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
JavaScript	@azure/arm-consumption	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

openapi-workflow-bot · 2022-09-23T20:51:04Z

Hi @kbharucha, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

openapi-workflow-bot · 2022-09-23T20:51:09Z

NewApiVersionRequired reason:

A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

kbharucha · 2022-09-30T22:27:28Z

@msyyc can you pls take a look at this PR?

msyyc · 2022-10-10T04:45:26Z

Hi @kbharucha Please fix ModelValidation with detailed info https://github.com/Azure/azure-rest-api-specs/pull/20855/checks?check_run_id=8522713652

msyyc · 2022-10-10T04:45:55Z

Hi @qiaozha @ArcturusZhang Please help review SDK breaking

openapi-workflow-bot · 2022-10-10T18:13:12Z

Hi @kbharucha, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

kbharucha · 2022-10-10T19:43:52Z

Hi @kbharucha Please fix ModelValidation with detailed info https://github.com/Azure/azure-rest-api-specs/pull/20855/checks?check_run_id=8522713652

@msyyc: I've fixed the JSON files causing model validation failures. However, can we get an exemption for the open item(x-ms-example not found in Operations_List) as we haven't changed anything that could cause the failure? Appreciate the help as we are nearing our SLA for this fix.

tadelesh · 2022-10-12T03:09:17Z

Go breaking is from this PR and has already been approved: #19768.

…on stable/2019-10-01 (Azure#20855) * swagger correctness changes * fix json files to pass model validation * using RevisedResource instead of Resource

swagger correctness changes

ec2241f

kbharucha requested a review from kjeur as a code owner September 23, 2022 20:48

openapi-assignment-bot bot assigned msyyc Sep 23, 2022

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Sep 23, 2022

openapi-pipeline-app bot added the NewApiVersionRequired label Sep 23, 2022

azure-sdk mentioned this pull request Sep 23, 2022

[AutoPR sdk/resourcemanager/consumption/armconsumption] [Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 azure-sdk/azure-sdk-for-go#3095

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Sep 23, 2022

AzureRestAPISpecReview added the resource-manager label Sep 23, 2022

azure-sdk mentioned this pull request Sep 23, 2022

[AutoPR track2_azure-mgmt-consumption] [Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 azure-sdk/azure-sdk-for-python#1577

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Sep 23, 2022

azure-sdk mentioned this pull request Sep 23, 2022

[AutoPR @azure/arm-consumption] [Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 azure-sdk/azure-sdk-for-js#2303

Closed

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Sep 23, 2022

AzureRestAPISpecReview removed the NewApiVersionRequired label Sep 28, 2022

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Sep 29, 2022

openapi-workflow-bot bot added the FixS360 label Sep 30, 2022

msyyc added the Approved-SdkBreakingChange-Python label Oct 10, 2022

fix json files to pass model validation

06c612f

AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required NewApiVersionRequired labels Oct 10, 2022

using RevisedResource instead of Resource

784952d

tadelesh added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Oct 12, 2022

qiaozha added the Approved-SdkBreakingChange-JavaScript label Oct 12, 2022

msyyc approved these changes Oct 12, 2022

View reviewed changes

msyyc added the Approved-ModelValidation label Oct 12, 2022

msyyc merged commit 2a4a286 into Azure:main Oct 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 #20855

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 #20855

kbharucha commented Sep 23, 2022 •

edited

Loading

openapi-workflow-bot bot commented Sep 23, 2022

openapi-pipeline-app bot commented Sep 23, 2022 •

edited

Loading

openapi-pipeline-app bot commented Sep 23, 2022 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Sep 23, 2022 •

edited

Loading

openapi-workflow-bot bot commented Sep 23, 2022

openapi-workflow-bot bot commented Sep 23, 2022

kbharucha commented Sep 30, 2022

msyyc commented Oct 10, 2022

msyyc commented Oct 10, 2022

openapi-workflow-bot bot commented Oct 10, 2022

kbharucha commented Oct 10, 2022

tadelesh commented Oct 12, 2022

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 #20855

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 #20855

Conversation

kbharucha commented Sep 23, 2022 • edited Loading

ARM API Information (Control Plane)

Changelog

Contribution checklist (MS Employees Only):

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Sep 23, 2022

openapi-pipeline-app bot commented Sep 23, 2022 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Sep 23, 2022 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Sep 23, 2022 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Sep 23, 2022

openapi-workflow-bot bot commented Sep 23, 2022

kbharucha commented Sep 30, 2022

msyyc commented Oct 10, 2022

msyyc commented Oct 10, 2022

openapi-workflow-bot bot commented Oct 10, 2022

kbharucha commented Oct 10, 2022

tadelesh commented Oct 12, 2022

kbharucha commented Sep 23, 2022 •

edited

Loading

openapi-pipeline-app bot commented Sep 23, 2022 •

edited

Loading

openapi-pipeline-app bot commented Sep 23, 2022 •

edited

Loading

openapi-pipeline-app bot commented Sep 23, 2022 •

edited

Loading