Service Fabric Managed Clusters - api version 2022-10-01-preview

[a-santamaria]

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

1. What's the purpose of the update?
   • new service onboarding
   • new API version
   • update existing version for new feature
   • update existing version to fix swagger quality issue in s360
   • Other, please clarify
2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
   10/29/2022
3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
   10/31/2022
4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

• I commit to follow the Breaking Change Policy of "no breaking changes"
• I have reviewed the documentation for the workflow.
• Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

• Change to data plane APIs
• Adding new properties
• All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

• Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

  • [] Adding a new service
  • [] Adding new API(s)
  • Adding a new API version
    -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

• Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

• If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

[openapi-workflow-bot]

Hi, @a-santamaria Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

[openapi-pipeline-app]

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️❌Breaking Change(Cross-Version): 5 Errors, 1 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
managedapplication.json	2022-10-01-preview(116ca3e)	2022-01-01(main)
managedapplication.json	2022-10-01-preview(116ca3e)	2022-08-01-preview(main)
managedcluster.json	2022-10-01-preview(116ca3e)	2022-01-01(main)
managedcluster.json	2022-10-01-preview(116ca3e)	2022-08-01-preview(main)
nodetype.json	2022-10-01-preview(116ca3e)	2022-01-01(main)
nodetype.json	2022-10-01-preview(116ca3e)	2022-08-01-preview(main)

The following breaking changes are detected by comparison with the latest stable version:

Rule	Message
❌ 1025 - RequiredStatusChange	The 'required' status changed from the old version('True') to the new version('False'). New: Microsoft.ServiceFabric/preview/2022-10-01-preview/nodetype.json#L712:7 Old: Microsoft.ServiceFabric/stable/2022-01-01/nodetype.json#L671:7
❌ 1048 - AddedXmsEnum	The new version adds a x-ms-enum extension. New: Microsoft.ServiceFabric/preview/2022-10-01-preview/managedcluster.json#L1243:11 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1178:11
❌ 1048 - AddedXmsEnum	The new version adds a x-ms-enum extension. New: Microsoft.ServiceFabric/preview/2022-10-01-preview/managedcluster.json#L1337:9 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1261:9
❌ 1048 - AddedXmsEnum	The new version adds a x-ms-enum extension. New: Microsoft.ServiceFabric/preview/2022-10-01-preview/managedcluster.json#L762:5 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L719:5
❌ 1048 - AddedXmsEnum	The new version adds a x-ms-enum extension. New: Microsoft.ServiceFabric/preview/2022-10-01-preview/managedcluster.json#L1427:5 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1311:5

The following breaking changes are detected by comparison with the latest preview version:

Rule	Message
⚠️ 1025 - RequiredStatusChange	The 'required' status changed from the old version('True') to the new version('False'). New: Microsoft.ServiceFabric/preview/2022-10-01-preview/nodetype.json#L712:7 Old: Microsoft.ServiceFabric/preview/2022-08-01-preview/nodetype.json#L712:7

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.0.0)	new version	base version
package-2022-10-preview	package-2022-10-preview(116ca3e)	default(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
❌ ResourceNameRestriction	The resource name parameter 'clusterName' should be defined with a 'pattern' restriction. Location: Microsoft.ServiceFabric/preview/2022-10-01-preview/managedapplication.json#L37
❌ ResourceNameRestriction	The resource name parameter 'applicationTypeName' should be defined with a 'pattern' restriction. Location: Microsoft.ServiceFabric/preview/2022-10-01-preview/managedapplication.json#L37
❌ LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.ServiceFabric/preview/2022-10-01-preview/managedapplication.json#L223
❌ ResourceNameRestriction	The resource name parameter 'clusterName' should be defined with a 'pattern' restriction. Location: Microsoft.ServiceFabric/preview/2022-10-01-preview/managedapplication.json#L241
❌ ResourceNameRestriction	The resource name parameter 'clusterName' should be defined with a 'pattern' restriction. Location: Microsoft.ServiceFabric/preview/2022-10-01-preview/managedapplication.json#L287
❌ ResourceNameRestriction	The resource name parameter 'applicationTypeName' should be defined with a 'pattern' restriction. Location: Microsoft.ServiceFabric/preview/2022-10-01-preview/managedapplication.json#L287
❌ CreateOperationAsyncResponseValidation	An async PUT operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'azure-async-operation' on 'x-ms-long-running-operation-options' Location: Microsoft.ServiceFabric/preview/2022-10-01-preview/managedapplication.json#L335
❌ CreateOperationAsyncResponseValidation	An async PUT operation must return 201. Location: Microsoft.ServiceFabric/preview/2022-10-01-preview/managedapplication.json#L381
❌ CreateOperationAsyncResponseValidation	Only 201 is the supported response code for PUT async response. Location: Microsoft.ServiceFabric/preview/2022-10-01-preview/managedapplication.json#L388
❌ LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.ServiceFabric/preview/2022-10-01-preview/managedapplication.json#L388
❌ LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.ServiceFabric/preview/2022-10-01-preview/managedapplication.json#L495
❌ ResourceNameRestriction	The resource name parameter 'clusterName' should be defined with a 'pattern' restriction. Location: Microsoft.ServiceFabric/preview/2022-10-01-preview/managedapplication.json#L513
❌ ResourceNameRestriction	The resource name parameter 'applicationTypeName' should be defined with a 'pattern' restriction. Location: Microsoft.ServiceFabric/preview/2022-10-01-preview/managedapplication.json#L513
❌ ResourceNameRestriction	The resource name parameter 'clusterName' should be defined with a 'pattern' restriction. Location: Microsoft.ServiceFabric/preview/2022-10-01-preview/managedapplication.json#L562
❌ ResourceNameRestriction	The resource name parameter 'applicationName' should be defined with a 'pattern' restriction. Location: Microsoft.ServiceFabric/preview/2022-10-01-preview/managedapplication.json#L562
❌ CreateOperationAsyncResponseValidation	An async PUT operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'azure-async-operation' on 'x-ms-long-running-operation-options' Location: Microsoft.ServiceFabric/preview/2022-10-01-preview/managedapplication.json#L607
❌ CreateOperationAsyncResponseValidation	An async PUT operation must return 201. Location: Microsoft.ServiceFabric/preview/2022-10-01-preview/managedapplication.json#L653
❌ CreateOperationAsyncResponseValidation	Only 201 is the supported response code for PUT async response. Location: Microsoft.ServiceFabric/preview/2022-10-01-preview/managedapplication.json#L660
❌ LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.ServiceFabric/preview/2022-10-01-preview/managedapplication.json#L660
❌ PatchIdentityProperty	The patch operation body parameter schema should contains property 'identity'. Location: Microsoft.ServiceFabric/preview/2022-10-01-preview/managedapplication.json#L697
❌ LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.ServiceFabric/preview/2022-10-01-preview/managedapplication.json#L761
❌ ResourceNameRestriction	The resource name parameter 'clusterName' should be defined with a 'pattern' restriction. Location: Microsoft.ServiceFabric/preview/2022-10-01-preview/managedapplication.json#L779
❌ ResourceNameRestriction	The resource name parameter 'clusterName' should be defined with a 'pattern' restriction. Location: Microsoft.ServiceFabric/preview/2022-10-01-preview/managedapplication.json#L825
❌ ResourceNameRestriction	The resource name parameter 'applicationName' should be defined with a 'pattern' restriction. Location: Microsoft.ServiceFabric/preview/2022-10-01-preview/managedapplication.json#L825
❌ ResourceNameRestriction	The resource name parameter 'serviceName' should be defined with a 'pattern' restriction. Location: Microsoft.ServiceFabric/preview/2022-10-01-preview/managedapplication.json#L825
❌ CreateOperationAsyncResponseValidation	An async PUT operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'azure-async-operation' on 'x-ms-long-running-operation-options' Location: Microsoft.ServiceFabric/preview/2022-10-01-preview/managedapplication.json#L873
❌ CreateOperationAsyncResponseValidation	An async PUT operation must return 201. Location: Microsoft.ServiceFabric/preview/2022-10-01-preview/managedapplication.json#L922
❌ CreateOperationAsyncResponseValidation	Only 201 is the supported response code for PUT async response. Location: Microsoft.ServiceFabric/preview/2022-10-01-preview/managedapplication.json#L929
❌ LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.ServiceFabric/preview/2022-10-01-preview/managedapplication.json#L929
❌ LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.ServiceFabric/preview/2022-10-01-preview/managedapplication.json#L1036

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️❌~[Staging] ServiceAPIReadinessTest: 49 Errors, 0 Warnings failed [Detail]

Tag package-2022-10-preview; Prod region: Deployed

Test run on region: westcentralus; Operation coverage: total: 45, untested: 0, failed: 39, passed: 6

Service API Readiness Test failed. Check pipeline artifact for detail report.

Only 30 items are listed, please refer to log for more details.

Rule	Message
❌ CLIENT_ERROR	statusCode: 400, errorCode: InvalidParameter, errorMessage: Value cannot be null. Parameter name: Sku Source: runtime OperationId: ManagedClusters_CreateOrUpdate
❌ CLIENT_ERROR	statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.ServiceFabric/managedclusters/clusterno9nhuc' under resource group 'apiTest-tBOVNS-21033' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: ManagedClusters_Get
❌ CLIENT_ERROR	statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.ServiceFabric/managedclusters/clusterno9nhuc' under resource group 'apiTest-tBOVNS-21033' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: ManagedClusters_Update
❌ CLIENT_ERROR	statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc' not found. Source: runtime OperationId: Applications_CreateOrUpdate
❌ CLIENT_ERROR	statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc' not found. Source: runtime OperationId: Applications_List
❌ CLIENT_ERROR	statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc' not found. Source: runtime OperationId: Applications_Get
❌ CLIENT_ERROR	statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc' not found. Source: runtime OperationId: Applications_Update
❌ CLIENT_ERROR	statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc' not found. Source: runtime OperationId: ApplicationTypes_CreateOrUpdate
❌ CLIENT_ERROR	statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc' not found. Source: runtime OperationId: ApplicationTypes_List
❌ CLIENT_ERROR	statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc' not found. Source: runtime OperationId: ApplicationTypes_Get
❌ CLIENT_ERROR	statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc' not found. Source: runtime OperationId: ApplicationTypes_Update
❌ CLIENT_ERROR	statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc' not found. Source: runtime OperationId: NodeTypes_CreateOrUpdate
❌ CLIENT_ERROR	statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc' not found. Source: runtime OperationId: NodeTypes_Get
❌ CLIENT_ERROR	statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc' not found. Source: runtime OperationId: NodeTypes_ListByManagedClusters
❌ CLIENT_ERROR	statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc' not found. Source: runtime OperationId: NodeTypes_Update
❌ CLIENT_ERROR	statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc' not found. Source: runtime OperationId: NodeTypes_Reimage
❌ CLIENT_ERROR	statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc' not found. Source: runtime OperationId: NodeTypes_DeleteNode
❌ CLIENT_ERROR	statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc' not found. Source: runtime OperationId: NodeTypes_Restart
❌ CLIENT_ERROR	statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc/applicatu0e4fu' not found. Source: runtime OperationId: ApplicationTypeVersions_CreateOrUpdate
❌ CLIENT_ERROR	statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc/applicatu0e4fu' not found. Source: runtime OperationId: ApplicationTypeVersions_ListByApplicationTypes
❌ CLIENT_ERROR	statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc/applicatu0e4fu' not found. Source: runtime OperationId: ApplicationTypeVersions_Get
❌ CLIENT_ERROR	statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc/applicatu0e4fu' not found. Source: runtime OperationId: ApplicationTypeVersions_Update
❌ CLIENT_ERROR	statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc/applicats1yvwf' not found. Source: runtime OperationId: Services_CreateOrUpdate
❌ CLIENT_ERROR	statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc/applicats1yvwf' not found. Source: runtime OperationId: Services_ListByApplications
❌ CLIENT_ERROR	statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc/applicats1yvwf' not found. Source: runtime OperationId: Services_Get
❌ CLIENT_ERROR	statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc/applicats1yvwf' not found. Source: runtime OperationId: Services_Update
❌ CLIENT_ERROR	statusCode: 400, errorCode: InvalidRequestFormat, errorMessage: Cannot parse the request. Source: runtime OperationId: ManagedClusterVersion_ListByEnvironment
❌ OBJECT_ADDITIONAL_PROPERTIES	Additional properties not allowed: details Source: response OperationId: ManagedClusterVersion_ListByEnvironment
❌ CLIENT_ERROR	statusCode: 400, errorCode: InvalidRequestFormat, errorMessage: Cannot parse the request. Source: runtime OperationId: ManagedClusterVersion_GetByEnvironment
❌ OBJECT_ADDITIONAL_PROPERTIES	Additional properties not allowed: details Source: response OperationId: ManagedClusterVersion_GetByEnvironment

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

[openapi-pipeline-app]

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account. 

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

• ️✔️Succeeded [Logs]Release - Generate from ccdee2b. SDK Automation 14.0.0

  command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
  command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

• ️✔️Azure.ResourceManager.ServiceFabricManagedClusters [View full logs]  [Release SDK Changes]
  • Azure.ResourceManager.ServiceFabricManagedClusters.1.1.0-alpha.20230207.1.nupkg

  info	[Changelog]

️⚠️ azure-sdk-for-python-track2 warning [Detail]

• ⚠️Warning [Logs]Release - Generate from ccdee2b. SDK Automation 14.0.0

  command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
  cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
  command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  cmderr	[automation_generate.sh] npm notice
  cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.3 -> 9.4.1
  cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.4.1>
  cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.4.1` to update!
  cmderr	[automation_generate.sh] npm notice

• ️✔️track2_azure-mgmt-servicefabricmanagedclusters [View full logs]  [Release SDK Changes]
  • azure-mgmt-servicefabricmanagedclusters-0.1.0.zip
  • azure_mgmt_servicefabricmanagedclusters-0.1.0-py3-none-any.whl

  info	[Changelog] ### Features Added
  info	[Changelog]
  info	[Changelog]   - Model ManagedCluster has a new parameter use_custom_vnet
  info	[Changelog]   - Model ManagedCluster has a new parameter zonal_update_mode
  info	[Changelog]   - Model NodeType has a new parameter subnet_id
  info	[Changelog]   - Model NodeType has a new parameter vm_setup_actions
  info	[Changelog]   - Model NodeTypeActionParameters has a new parameter update_type
  info	[Changelog]   - Model ServiceResourceProperties has a new parameter service_dns_name
  info	[Changelog]   - Model StatefulServiceProperties has a new parameter service_dns_name
  info	[Changelog]   - Model StatelessServiceProperties has a new parameter service_dns_name

️⚠️ azure-resource-manager-schemas warning [Detail]

• ⚠️Warning [Logs]Release - Generate from ccdee2b. Schema Automation 14.0.0

  command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
  cmderr	[initScript.sh]  old lockfile
  cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
  cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
  cmderr	[initScript.sh] npm WARN old lockfile
  cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
  cmderr	[initScript.sh] npm WARN old lockfile
  warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
  command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

• ️✔️servicefabricmanagedclusters [View full logs]  [Release Schema Changes]

️❌ azure-powershell failed [Detail]

• ❌Failed [Logs]Release - Generate from ccdee2b. SDK Automation 14.0.0

  command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
  command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

• ❌Az.servicefabricmanagedclusters [View full logs]  [Release SDK Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

[openapi-pipeline-app]

Generated ApiView

Language	Package Name	ApiView Link
.Net	Azure.ResourceManager.ServiceFabricManagedClusters	There is no API change compared with the previous version

[openapi-workflow-bot]

Hi @a-santamaria, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

[openapi-workflow-bot]

Hi, @a-santamaria your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

[raosuhas]

consider modelling this as an enum :

https://armwiki.azurewebsites.net/rp_onboarding/process/api_review_best_practices.html#common-issues-found-in-review

Replace boolean/switch properties with better enum
A Boolean will forever have two valid values (true or false). A string enum type is always preferred. Also, properties should always provide better values just than True and False. For example two switches "isTypeA" and "isTypeB" should be replaced with one enum "type": [A, B, DefaultType]. Even if you still believe [True, False] are the correct values for a property, you should use a string enum with values [True, False] instead of boolean. Enums are always a more flexible and future proof option because they allow additional values to be added in the future in a non-breaking way, e.g. [True, False, Unknown].

[a-santamaria]

ok, thanks fore the suggestion. fixed

[a-santamaria]

@raosuhas please take a look again with the change suggested

[a-santamaria]

@raosuhas please review again

[openapi-workflow-bot]

Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested

[a-santamaria]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ghost]

Hi, @a-santamaria. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

[ghost]

Hi, @a-santamaria. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

[a-santamaria]

app deployment will finish by the end of this week and we will start the RP manifest upgrade next week

[a-santamaria]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[a-santamaria]

@live1206 can you please merge the pr? the RP manifest is already deployed.

[live1206]

@a-santamaria There are some errors for staging Service API Readiness Test, it would be great if you can fix them even it does not block the merge. The details can be found via #21033 (comment)

[a-santamaria]

@a-santamaria There are some errors for staging Service API Readiness Test, it would be great if you can fix them even it does not block the merge. The details can be found via #21033 (comment)

@live1206 I tried to do it by I reverted the change; it's going to take longer so we'll make those fixes on the next version. We need to generate the documentation for this version