Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix naming consistency of recoveryservicessiterecovery@2022-09-10 #21207

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

ziyeqf
Copy link
Contributor

@ziyeqf ziyeqf commented Oct 20, 2022

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
      rename a user-segment from "replicationProtectedItemName" to "replicatedProtectedItemName" to keep naming consistency.
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
    This pr not related to deployment.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
    Once the PR merged.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.
    this modification only affects user-segment name, and without refreshing the existing SDKs could work fine.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @ziyeqf Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Oct 20, 2022

    Swagger Validation Report

    ️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.1)] new version base version
    service.json 2022-09-10(c597723) 2022-09-10(main)
    Rule Message
    1009 - RemovedRequiredParameter The required parameter 'replicationProtectedItemName' was removed in the new version.
    Old: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L4504:11
    1010 - AddingRequiredParameter The required parameter 'replicatedProtectedItemName' was added in the new version.
    New: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L4504:11
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 1 Warnings warning [Detail]
    compared tags (via openapi-validator v1.13.0) new version base version
    package-2022-09 package-2022-09(c597723) package-2022-09(main)

    [must fix]The following errors/warnings are introduced by current PR:

    Rule Message Related RPC [For API reviewers]
    ⚠️ R2010 - LongRunningOperationsOptionsValidator A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled.
    Location: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L4463


    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L8131
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L8138
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L8296
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L8303
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L8490
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L8497
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L9120
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L9127
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L9134
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L9185
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L9357
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L9364
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L9476
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L9515
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L9522
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L9693
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L9978
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L10078
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L10223
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L10316
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L10392
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L10515
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L10593
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L10707
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L10714
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L11026
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L11231
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L11542
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L11670
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L11773
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️❌ModelValidation: 63 Errors, 0 Warnings failed [Detail]

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L631:22
    ExampleUrl: stable/2022-09-10/examples/ReplicationFabrics_Purge.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L679:22
    ExampleUrl: stable/2022-09-10/examples/ReplicationFabrics_CheckConsistency.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L727:22
    ExampleUrl: stable/2022-09-10/examples/ReplicationFabrics_MigrateToAad.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L787:22
    ExampleUrl: stable/2022-09-10/examples/ReplicationFabrics_ReassociateGateway.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L835:22
    ExampleUrl: stable/2022-09-10/examples/ReplicationFabrics_Delete.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L895:22
    ExampleUrl: stable/2022-09-10/examples/ReplicationFabrics_RenewCertificate.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L1356:22
    ExampleUrl: stable/2022-09-10/examples/ReplicationNetworkMappings_Delete.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L1428:22
    ExampleUrl: stable/2022-09-10/examples/ReplicationNetworkMappings_Update.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L1670:22
    ExampleUrl: stable/2022-09-10/examples/ReplicationProtectionContainers_DiscoverProtectableItem.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L1725:22
    ExampleUrl: stable/2022-09-10/examples/ReplicationProtectionContainers_Delete.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L2003:22
    ExampleUrl: stable/2022-09-10/examples/ReplicationMigrationItems_Delete.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L2075:22
    ExampleUrl: stable/2022-09-10/examples/ReplicationMigrationItems_Update.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L2152:22
    ExampleUrl: stable/2022-09-10/examples/ReplicationMigrationItems_Migrate.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L2359:22
    ExampleUrl: stable/2022-09-10/examples/ReplicationMigrationItems_PauseReplication.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L2436:22
    ExampleUrl: stable/2022-09-10/examples/ReplicationMigrationItems_ResumeReplication.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L2513:22
    ExampleUrl: stable/2022-09-10/examples/ReplicationMigrationItems_Resync.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L2590:22
    ExampleUrl: stable/2022-09-10/examples/ReplicationMigrationItems_TestMigrate.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L2667:22
    ExampleUrl: stable/2022-09-10/examples/ReplicationMigrationItems_TestMigrateCleanup.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L3060:22
    ExampleUrl: stable/2022-09-10/examples/ReplicationProtectedItems_Purge.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L3132:22
    ExampleUrl: stable/2022-09-10/examples/ReplicationProtectedItems_Update.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L3209:22
    ExampleUrl: stable/2022-09-10/examples/ReplicationProtectedItems_AddDisks.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L3286:22
    ExampleUrl: stable/2022-09-10/examples/ReplicationProtectedItems_ApplyRecoveryPoint.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L3351:22
    ExampleUrl: stable/2022-09-10/examples/ReplicationProtectedItems_FailoverCancel.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L3416:22
    ExampleUrl: stable/2022-09-10/examples/ReplicationProtectedItems_FailoverCommit.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L3493:22
    ExampleUrl: stable/2022-09-10/examples/ReplicationProtectedItems_PlannedFailover.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L3699:22
    ExampleUrl: stable/2022-09-10/examples/ReplicationProtectedItems_Delete.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L3773:22
    ExampleUrl: stable/2022-09-10/examples/ReplicationProtectedItems_RemoveDisks.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L3838:22
    ExampleUrl: stable/2022-09-10/examples/ReplicationProtectedItems_RepairReplication.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L3915:22
    ExampleUrl: stable/2022-09-10/examples/ReplicationProtectedItems_Reprotect.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.RecoveryServices/stable/2022-09-10/service.json#L3992:22
    ExampleUrl: stable/2022-09-10/examples/ReplicationProtectedItems_ResolveHealthErrors.json
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Oct 20, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking


    azure-sdk-for-python-track2 - track2_azure-mgmt-recoveryservicessiterecovery - Approved - 1.0.0b1
    +	Operation ReplicationProtectedItemsOperations.begin_update_mobility_service has a new parameter replicated_protected_item_name
    +	Operation ReplicationProtectedItemsOperations.begin_update_mobility_service no longer has parameter replication_protected_item_name

    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 3be3d0f. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      warn	File azure-sdk-for-net_tmp/initOutput.json not found to read
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    • ️✔️Azure.ResourceManager.RecoveryServicesSiteRecovery [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️❌ azure-sdk-for-python-track2 failed [Detail]
    • Failed [Logs]Release - Generate from 3be3d0f. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] npm notice
      cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.2 -> 9.1.1
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.1.1>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.1.1` to update!
      cmderr	[automation_generate.sh] npm notice
      cmdout	[automation_generate.sh] [Autorest] info    |    Installed AutoRest extension '@autorest/python' (6.2.1->6.2.1)
      cmdout	[automation_generate.sh] [Autorest] warning | OutdatedExtension | Semantic violation: Extension 'x-ms-code-generation-settings' is not supported in Autorest V3. It will just be ignored. (info > x-ms-code-generation-settings)
      cmdout	[automation_generate.sh] [Autorest]     - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2022-09-10/service.json:6:5
      cmdout	[automation_generate.sh] [Autorest] warning | PreCheck/CheckDuplicateSchemas | Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
      cmdout	[automation_generate.sh] [Autorest] warning | SecurityDefinedSpecAndConfig | OpenAPI spec has a security definition but autorest security config is defined. Security config from autorest will be used.
      cmdout	[automation_generate.sh] [Autorest] error   | [autorest.codegen.serializers.serialize_and_writesample:564] error happens in sample Update the mobility service on a protected item.: fail to find required param named replicatedProtectedItemName in example file Update the mobility service on a protected item.
      cmdout	[automation_generate.sh] [Autorest] Error: ENAMETOOLONG: name too long, open '/mnt/vss/_work/1/s/azure-sdk-for-python/sdk/recoveryservices/azure-mgmt-recoveryservicessiterecovery/generated_samples/deletes_provider_from_fabric._note:_deleting_provider_for_any_fabric_other_than_single_host_is_unsupported._to_maintain_backward_compatibility_for_released_clients_the_object_"delete_rsp_input"_is_used_(if_the_object_is_empty_we_assume_that_it_is_old_client_and_continue_the_old_behavior)..py'
      cmdout	[automation_generate.sh] [Autorest] info    |    Loading AutoRest extension '@autorest/python' (6.2.1->6.2.1)
      cmdout	[automation_generate.sh] [Autorest] warning | OutdatedExtension | Semantic violation: Extension 'x-ms-code-generation-settings' is not supported in Autorest V3. It will just be ignored. (info > x-ms-code-generation-settings)
      cmdout	[automation_generate.sh] [Autorest]     - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2022-09-10/service.json:6:5
      cmdout	[automation_generate.sh] [Autorest] warning | PreCheck/CheckDuplicateSchemas | Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
      cmdout	[automation_generate.sh] [Autorest] warning | SecurityDefinedSpecAndConfig | OpenAPI spec has a security definition but autorest security config is defined. Security config from autorest will be used.
      cmdout	[automation_generate.sh] [Autorest] error   | [autorest.codegen.serializers.serialize_and_writesample:564] error happens in sample Update the mobility service on a protected item.: fail to find required param named replicatedProtectedItemName in example file Update the mobility service on a protected item.
      cmdout	[automation_generate.sh] [Autorest] Error: ENAMETOOLONG: name too long, open '/mnt/vss/_work/1/s/azure-sdk-for-python/sdk/recoveryservices/azure-mgmt-recoveryservicessiterecovery/generated_samples/deletes_provider_from_fabric._note:_deleting_provider_for_any_fabric_other_than_single_host_is_unsupported._to_maintain_backward_compatibility_for_released_clients_the_object_"delete_rsp_input"_is_used_(if_the_object_is_empty_we_assume_that_it_is_old_client_and_continue_the_old_behavior)..py'
      cmdout	[automation_generate.sh] [Autorest]/mnt/vss/_work/1/s/azure-sdk-for-python_tmp/venv-sdk/auto_temp.json does not exist!!!Error happened during codegen
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-python]: sh scripts/automation_generate.sh
      warn	Skip package processing as generation is failed
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 3be3d0f. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      warn	No file changes detected after generation
      warn	No package detected after generation
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 3be3d0f. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `MigrationStateMigrationCompletedWithInformation`
      info	[Changelog] - New const `MigrationItemOperationResumeReplication`
      info	[Changelog] - New const `MigrationStateProtectionSuspended`
      info	[Changelog] - New const `MigrationItemOperationPauseReplication`
      info	[Changelog] - New const `MigrationStateMigrationPartiallySucceeded`
      info	[Changelog] - New const `MigrationStateResumeInitiated`
      info	[Changelog] - New const `MigrationStateResumeInProgress`
      info	[Changelog] - New const `TestMigrationStateTestMigrationPartiallySucceeded`
      info	[Changelog] - New const `MigrationStateSuspendingProtection`
      info	[Changelog] - New const `TestMigrationStateTestMigrationCompletedWithInformation`
      info	[Changelog] - New function `*ResumeReplicationProviderSpecificInput.GetResumeReplicationProviderSpecificInput() *ResumeReplicationProviderSpecificInput`
      info	[Changelog] - New function `*ReplicationMigrationItemsClient.BeginPauseReplication(context.Context, string, string, string, PauseReplicationInput, *ReplicationMigrationItemsClientBeginPauseReplicationOptions) (*runtime.Poller[ReplicationMigrationItemsClientPauseReplicationResponse], error)`
      info	[Changelog] - New function `*VMwareCbtResumeReplicationInput.GetResumeReplicationProviderSpecificInput() *ResumeReplicationProviderSpecificInput`
      info	[Changelog] - New function `*ReplicationMigrationItemsClient.BeginResumeReplication(context.Context, string, string, string, ResumeReplicationInput, *ReplicationMigrationItemsClientBeginResumeReplicationOptions) (*runtime.Poller[ReplicationMigrationItemsClientResumeReplicationResponse], error)`
      info	[Changelog] - New struct `CriticalJobHistoryDetails`
      info	[Changelog] - New struct `PauseReplicationInput`
      info	[Changelog] - New struct `PauseReplicationInputProperties`
      info	[Changelog] - New struct `ReplicationMigrationItemsClientBeginPauseReplicationOptions`
      info	[Changelog] - New struct `ReplicationMigrationItemsClientBeginResumeReplicationOptions`
      info	[Changelog] - New struct `ReplicationMigrationItemsClientPauseReplicationResponse`
      info	[Changelog] - New struct `ReplicationMigrationItemsClientResumeReplicationResponse`
      info	[Changelog] - New struct `ResumeReplicationInput`
      info	[Changelog] - New struct `ResumeReplicationInputProperties`
      info	[Changelog] - New struct `ResumeReplicationProviderSpecificInput`
      info	[Changelog] - New struct `VMwareCbtResumeReplicationInput`
      info	[Changelog] - New field `PerformSQLBulkRegistration` in struct `VMwareCbtEnableMigrationInput`
      info	[Changelog] - New field `LastMigrationTime` in struct `MigrationItemProperties`
      info	[Changelog] - New field `LastMigrationStatus` in struct `MigrationItemProperties`
      info	[Changelog] - New field `RecoveryServicesProviderID` in struct `MigrationItemProperties`
      info	[Changelog] - New field `ReplicationStatus` in struct `MigrationItemProperties`
      info	[Changelog] - New field `CriticalJobHistory` in struct `MigrationItemProperties`
      info	[Changelog] - New field `SeedBlobURI` in struct `InMageRcmProtectedDiskDetails`
      info	[Changelog] - New field `StorageAccountID` in struct `InMageRcmReplicationDetails`
      info	[Changelog] - New field `RoleSizeToNicCountMap` in struct `VMwareCbtProtectionContainerMappingDetails`
      info	[Changelog] - New field `SeedBlobURI` in struct `VMwareCbtProtectedDiskDetails`
      info	[Changelog] - New field `TargetBlobURI` in struct `VMwareCbtProtectedDiskDetails`
      info	[Changelog] - New field `TestNetworkID` in struct `VMwareCbtMigrationDetails`
      info	[Changelog] - New field `StorageAccountID` in struct `VMwareCbtMigrationDetails`
      info	[Changelog] - New field `ResumeProgressPercentage` in struct `VMwareCbtMigrationDetails`
      info	[Changelog] - New field `ResumeRetryCount` in struct `VMwareCbtMigrationDetails`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 44 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 3be3d0f. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-recoveryservices-siterecovery [View full logs]  [Release SDK Changes]
      Only show 120 items here, please refer to log for details.
      info	[Changelog]   - Added Interface InMageRcmPolicyDetails
      info	[Changelog]   - Added Interface InMageRcmProtectionContainerMappingDetails
      info	[Changelog]   - Added Interface InMageRcmRecoveryPointDetails
      info	[Changelog]   - Added Interface InMageRcmReplicationDetails
      info	[Changelog]   - Added Interface InMageRcmReprotectInput
      info	[Changelog]   - Added Interface InMageRcmTestFailoverInput
      info	[Changelog]   - Added Interface InMageRcmUnplannedFailoverInput
      info	[Changelog]   - Added Interface InMageRcmUpdateApplianceForReplicationProtectedItemInput
      info	[Changelog]   - Added Interface InMageRcmUpdateContainerMappingInput
      info	[Changelog]   - Added Interface InMageRcmUpdateReplicationProtectedItemInput
      info	[Changelog]   - Added Interface InMageReplicationDetails
      info	[Changelog]   - Added Interface InMageReprotectInput
      info	[Changelog]   - Added Interface InMageTestFailoverInput
      info	[Changelog]   - Added Interface InMageUnplannedFailoverInput
      info	[Changelog]   - Added Interface Job
      info	[Changelog]   - Added Interface JobStatusEventDetails
      info	[Changelog]   - Added Interface JobTaskDetails
      info	[Changelog]   - Added Interface LogicalNetwork
      info	[Changelog]   - Added Interface ManualActionTaskDetails
      info	[Changelog]   - Added Interface MigrationItem
      info	[Changelog]   - Added Interface MigrationRecoveryPoint
      info	[Changelog]   - Added Interface Network
      info	[Changelog]   - Added Interface NetworkMapping
      info	[Changelog]   - Added Interface NewProtectionProfile
      info	[Changelog]   - Added Interface NewRecoveryVirtualNetwork
      info	[Changelog]   - Added Interface PauseReplicationInput
      info	[Changelog]   - Added Interface PauseReplicationInputProperties
      info	[Changelog]   - Added Interface Policy
      info	[Changelog]   - Added Interface ProtectableItem
      info	[Changelog]   - Added Interface ProtectionContainer
      info	[Changelog]   - Added Interface ProtectionContainerMapping
      info	[Changelog]   - Added Interface RecoveryPlan
      info	[Changelog]   - Added Interface RecoveryPlanA2ADetails
      info	[Changelog]   - Added Interface RecoveryPlanA2AFailoverInput
      info	[Changelog]   - Added Interface RecoveryPlanA2AInput
      info	[Changelog]   - Added Interface RecoveryPlanAutomationRunbookActionDetails
      info	[Changelog]   - Added Interface RecoveryPlanGroupTaskDetails
      info	[Changelog]   - Added Interface RecoveryPlanHyperVReplicaAzureFailbackInput
      info	[Changelog]   - Added Interface RecoveryPlanHyperVReplicaAzureFailoverInput
      info	[Changelog]   - Added Interface RecoveryPlanInMageAzureV2FailoverInput
      info	[Changelog]   - Added Interface RecoveryPlanInMageFailoverInput
      info	[Changelog]   - Added Interface RecoveryPlanInMageRcmFailbackFailoverInput
      info	[Changelog]   - Added Interface RecoveryPlanInMageRcmFailoverInput
      info	[Changelog]   - Added Interface RecoveryPlanManualActionDetails
      info	[Changelog]   - Added Interface RecoveryPlanScriptActionDetails
      info	[Changelog]   - Added Interface RecoveryPlanShutdownGroupTaskDetails
      info	[Changelog]   - Added Interface RecoveryPoint
      info	[Changelog]   - Added Interface RecoveryServicesProvider
      info	[Changelog]   - Added Interface ReplicationGroupDetails
      info	[Changelog]   - Added Interface ReplicationMigrationItemsPauseReplicationOptionalParams
      info	[Changelog]   - Added Interface ReplicationMigrationItemsResumeReplicationOptionalParams
      info	[Changelog]   - Added Interface ReplicationProtectedItem
      info	[Changelog]   - Added Interface ReplicationProtectionIntent
      info	[Changelog]   - Added Interface ResumeReplicationInput
      info	[Changelog]   - Added Interface ResumeReplicationInputProperties
      info	[Changelog]   - Added Interface ResumeReplicationProviderSpecificInput
      info	[Changelog]   - Added Interface ScriptActionTaskDetails
      info	[Changelog]   - Added Interface StorageClassification
      info	[Changelog]   - Added Interface StorageClassificationMapping
      info	[Changelog]   - Added Interface SupportedOperatingSystems
      info	[Changelog]   - Added Interface SwitchProtectionJobDetails
      info	[Changelog]   - Added Interface TestFailoverJobDetails
      info	[Changelog]   - Added Interface VaultHealthDetails
      info	[Changelog]   - Added Interface VaultSetting
      info	[Changelog]   - Added Interface VCenter
      info	[Changelog]   - Added Interface VirtualMachineTaskDetails
      info	[Changelog]   - Added Interface VmmDetails
      info	[Changelog]   - Added Interface VmmToAzureCreateNetworkMappingInput
      info	[Changelog]   - Added Interface VmmToAzureNetworkMappingSettings
      info	[Changelog]   - Added Interface VmmToAzureUpdateNetworkMappingInput
      info	[Changelog]   - Added Interface VmmToVmmCreateNetworkMappingInput
      info	[Changelog]   - Added Interface VmmToVmmNetworkMappingSettings
      info	[Changelog]   - Added Interface VmmToVmmUpdateNetworkMappingInput
      info	[Changelog]   - Added Interface VmmVirtualMachineDetails
      info	[Changelog]   - Added Interface VmNicUpdatesTaskDetails
      info	[Changelog]   - Added Interface VMwareCbtContainerCreationInput
      info	[Changelog]   - Added Interface VMwareCbtContainerMappingInput
      info	[Changelog]   - Added Interface VMwareCbtEnableMigrationInput
      info	[Changelog]   - Added Interface VMwareCbtEventDetails
      info	[Changelog]   - Added Interface VMwareCbtMigrateInput
      info	[Changelog]   - Added Interface VMwareCbtMigrationDetails
      info	[Changelog]   - Added Interface VMwareCbtPolicyCreationInput
      info	[Changelog]   - Added Interface VmwareCbtPolicyDetails
      info	[Changelog]   - Added Interface VMwareCbtProtectionContainerMappingDetails
      info	[Changelog]   - Added Interface VMwareCbtResumeReplicationInput
      info	[Changelog]   - Added Interface VMwareCbtResyncInput
      info	[Changelog]   - Added Interface VMwareCbtTestMigrateInput
      info	[Changelog]   - Added Interface VMwareCbtUpdateMigrationItemInput
      info	[Changelog]   - Added Interface VMwareDetails
      info	[Changelog]   - Added Interface VMwareV2FabricCreationInput
      info	[Changelog]   - Added Interface VMwareV2FabricSpecificDetails
      info	[Changelog]   - Added Interface VMwareVirtualMachineDetails
      info	[Changelog]   - Added Type Alias ReplicationMigrationItemsPauseReplicationResponse
      info	[Changelog]   - Added Type Alias ReplicationMigrationItemsResumeReplicationResponse
      info	[Changelog]   - Added Type Alias ResumeReplicationProviderSpecificInputUnion
      info	[Changelog]   - Interface InMageRcmProtectedDiskDetails has a new optional parameter seedBlobUri
      info	[Changelog]   - Interface MigrationItemProperties has a new optional parameter criticalJobHistory
      info	[Changelog]   - Interface MigrationItemProperties has a new optional parameter lastMigrationStatus
      info	[Changelog]   - Interface MigrationItemProperties has a new optional parameter lastMigrationTime
      info	[Changelog]   - Interface MigrationItemProperties has a new optional parameter recoveryServicesProviderId
      info	[Changelog]   - Interface MigrationItemProperties has a new optional parameter replicationStatus
      info	[Changelog]   - Interface VMwareCbtNicDetails has a new optional parameter testIPAddress
      info	[Changelog]   - Interface VMwareCbtNicDetails has a new optional parameter testIPAddressType
      info	[Changelog]   - Interface VMwareCbtNicDetails has a new optional parameter testNetworkId
      info	[Changelog]   - Interface VMwareCbtNicDetails has a new optional parameter testSubnetName
      info	[Changelog]   - Interface VMwareCbtNicInput has a new optional parameter testStaticIPAddress
      info	[Changelog]   - Interface VMwareCbtNicInput has a new optional parameter testSubnetName
      info	[Changelog]   - Interface VMwareCbtProtectedDiskDetails has a new optional parameter seedBlobUri
      info	[Changelog]   - Interface VMwareCbtProtectedDiskDetails has a new optional parameter targetBlobUri
      info	[Changelog]   - Interface VMwareCbtUpdateDiskInput has a new optional parameter isOSDisk
      info	[Changelog]   - Enum KnownMigrationItemOperation has a new value PauseReplication
      info	[Changelog]   - Enum KnownMigrationItemOperation has a new value ResumeReplication
      info	[Changelog]   - Enum KnownMigrationState has a new value MigrationCompletedWithInformation
      info	[Changelog]   - Enum KnownMigrationState has a new value MigrationPartiallySucceeded
      info	[Changelog]   - Enum KnownMigrationState has a new value ProtectionSuspended
      info	[Changelog]   - Enum KnownMigrationState has a new value ResumeInitiated
      info	[Changelog]   - Enum KnownMigrationState has a new value ResumeInProgress
      info	[Changelog]   - Enum KnownMigrationState has a new value SuspendingProtection
      info	[Changelog]   - Enum KnownTestMigrationState has a new value TestMigrationCompletedWithInformation
      info	[Changelog]   - Enum KnownTestMigrationState has a new value TestMigrationPartiallySucceeded
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 3be3d0f. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • ️✔️recoveryservicessiterecovery [View full logs
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 3be3d0f. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.SiteRecovery [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Oct 20, 2022

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    .Net Azure.ResourceManager.RecoveryServicesSiteRecovery Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    JavaScript @azure/arm-recoveryservices-siterecovery Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

    @ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Oct 20, 2022
    @ghost
    Copy link

    ghost commented Oct 20, 2022

    Thank you for your contribution ziyeqf! We will review the pull request and get back to you soon.

    @AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-FixRequiredOnFailure resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 20, 2022
    @openapi-workflow-bot
    Copy link

    Hi @ziyeqf, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @openapi-workflow-bot
    Copy link

    Hi @ziyeqf, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @@ -4460,7 +4460,7 @@
    }
    }
    },
    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicationProtectedItemName}/updateMobilityService": {
    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicatedProtectedItemName}/updateMobilityService": {
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    subscriptions

    please get the breaking change approved after which ARM can sign off

    Copy link
    Contributor

    @magodo magodo Oct 24, 2022

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    @rkmanda From what I know, this is not a breakinge change from API's perspective, could you please double confirm?

    Ping @leni-msft

    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    @JeffreyRichter could you check if renaming path parameter is breaking change from API's perspective?

    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    This is potentially breaking in C# SDKs but is so unlikely that we consider it non-breaking.

    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    @rkmanda Any update on this PR? I saw there is another similar PR got merged month ago: #20588.

    @rkmanda rkmanda added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Oct 21, 2022
    @openapi-workflow-bot
    Copy link

    Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested

    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 21, 2022
    @leni-msft leni-msft added the LintRuleCandidate Lint Rule Candidate label Oct 24, 2022
    @ziyeqf ziyeqf requested a review from rkmanda November 2, 2022 02:40
    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Nov 11, 2022
    @msyyc
    Copy link
    Member

    msyyc commented Nov 14, 2022

    The ModelValidation error is not caused by this PR

    @msyyc
    Copy link
    Member

    msyyc commented Nov 14, 2022

    some discussion is in e-mail RE: Azure Recovery Service Site Recovery CLI PLR

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-ModelValidation Approved-SdkBreakingChange-Python ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-FixRequiredOnFailure customer-reported Issues that are reported by GitHub users external to the Azure organization. LintRuleCandidate Lint Rule Candidate Recovery Services Site-Recovery resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    7 participants