Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workloads - Sap Virtual Instance] #21284

Merged
merged 1 commit into from
Oct 28, 2022
Merged

[Workloads - Sap Virtual Instance] #21284

merged 1 commit into from
Oct 28, 2022

Conversation

dmadiraju1
Copy link
Contributor

@dmadiraju1 dmadiraju1 commented Oct 26, 2022 •
edited by openapi-workflow-bot bot
Loading

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@dmadiraju1
[Workloads - Sap Virtual Instance]
a304b2a 
-Adds SAP software detection feature on a VIS
-Changes were already checked-in to private repo in the PR:
 Azure/azure-rest-api-specs-pr#8871
 The changes were verified. This commit just ports the same
 to the public repo.
@openapi-workflow-bot
Copy link

Hi, @dmadiraju1 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Oct 26, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    compared swaggers (via Oad v0.10.1)] new version base version
    SAPVirtualInstance.json 2021-12-01-preview(a304b2a) 2021-12-01-preview(main)
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v1.13.0) new version base version
    package-2021-12-01-preview package-2021-12-01-preview(a304b2a) package-2021-12-01-preview(main)

    The following errors/warnings exist before current PR submission:

    Rule Message
    ⚠️ R1003 - ListInOperationName Since operation 'SAPSupportedSku' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L99
    ⚠️ R1003 - ListInOperationName Since operation 'SAPDiskConfigurations' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L155
    ⚠️ R1003 - ListInOperationName Since operation 'SAPAvailabilityZoneDetails' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L205
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L1750
    ⚠️ R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'getsizingrecommendations' in:'SAPSizingRecommendations'. Consider updating the operationId
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L43
    ⚠️ R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'getsapsupportedsku' in:'SAPSupportedSku'. Consider updating the operationId
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L99
    ⚠️ R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'getdiskconfigurations' in:'SAPDiskConfigurations'. Consider updating the operationId
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L155
    ⚠️ R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'getavailabilityzonedetails' in:'SAPAvailabilityZoneDetails'. Consider updating the operationId
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L205
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'applicationInstances' with immediate parent 'SAPVirtualInstance', must have a list by immediate parent operation.
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L3004
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'centralInstances' with immediate parent 'SAPVirtualInstance', must have a list by immediate parent operation.
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L3216
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'databaseInstances' with immediate parent 'SAPVirtualInstance', must have a list by immediate parent operation.
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L3279
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: disablePasswordAuthentication
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L1888
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isAppServerCertified
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2110
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDatabaseCertified
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2114
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: hardStop
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2604
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isSecondaryIpEnabled
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L3298
    ⚠️ R4021 - DescriptionAndTitleMissing 'virtualMachineId' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2748
    ⚠️ R4021 - DescriptionAndTitleMissing 'virtualMachineId' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2758
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️❌ModelValidation: 6 Errors, 0 Warnings failed [Detail]
    Rule Message
    ❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L473:22
    ExampleUrl: 2021-12-01-preview/examples/sapvirtualinstances/SAPVirtualInstances_Delete.json
    ❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L783:22
    ExampleUrl: 2021-12-01-preview/examples/sapvirtualinstances/SAPCentralInstances_Delete.json
    ❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L1057:22
    ExampleUrl: 2021-12-01-preview/examples/sapvirtualinstances/SAPDatabaseInstances_Delete.json
    ❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L1331:22
    ExampleUrl: 2021-12-01-preview/examples/sapvirtualinstances/SAPApplicationServerInstances_Delete.json
    ❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L1431:22
    ExampleUrl: 2021-12-01-preview/examples/sapvirtualinstances/SAPVirtualInstances_Start.json
    ❌ LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L1491:22
    ExampleUrl: 2021-12-01-preview/examples/sapvirtualinstances/SAPVirtualInstances_Stop.json
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand] 
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Oct 26, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ❌azure-sdk-for-go - sdk/resourcemanager/workloads/armworkloads - Approved - 0.3.0
    +	Function `*SAPApplicationServerInstancesClient.BeginCreate` parameter(s) have been changed from `(context.Context, string, string, string, SAPApplicationServerInstance, *SAPApplicationServerInstancesClientBeginCreateOptions)` to `(context.Context, string, string, string, *SAPApplicationServerInstancesClientBeginCreateOptions)`
+	Function `*SAPApplicationServerInstancesClient.BeginUpdate` parameter(s) have been changed from `(context.Context, string, string, string, UpdateSAPApplicationInstanceRequest, *SAPApplicationServerInstancesClientBeginUpdateOptions)` to `(context.Context, string, string, string, *SAPApplicationServerInstancesClientBeginUpdateOptions)`
+	Function `*SAPCentralInstancesClient.BeginCreate` parameter(s) have been changed from `(context.Context, string, string, string, SAPCentralServerInstance, *SAPCentralInstancesClientBeginCreateOptions)` to `(context.Context, string, string, string, *SAPCentralInstancesClientBeginCreateOptions)`
+	Function `*SAPCentralInstancesClient.BeginUpdate` parameter(s) have been changed from `(context.Context, string, string, string, UpdateSAPCentralInstanceRequest, *SAPCentralInstancesClientBeginUpdateOptions)` to `(context.Context, string, string, string, *SAPCentralInstancesClientBeginUpdateOptions)`
+	Function `*SAPDatabaseInstancesClient.BeginCreate` parameter(s) have been changed from `(context.Context, string, string, string, SAPDatabaseInstance, *SAPDatabaseInstancesClientBeginCreateOptions)` to `(context.Context, string, string, string, *SAPDatabaseInstancesClientBeginCreateOptions)`
+	Function `*SAPDatabaseInstancesClient.BeginUpdate` parameter(s) have been changed from `(context.Context, string, string, string, UpdateSAPDatabaseInstanceRequest, *SAPDatabaseInstancesClientBeginUpdateOptions)` to `(context.Context, string, string, string, *SAPDatabaseInstancesClientBeginUpdateOptions)`
+	Function `*SAPVirtualInstancesClient.BeginCreate` parameter(s) have been changed from `(context.Context, string, string, SAPVirtualInstance, *SAPVirtualInstancesClientBeginCreateOptions)` to `(context.Context, string, string, *SAPVirtualInstancesClientBeginCreateOptions)`
+	Function `*SAPVirtualInstancesClient.Update` parameter(s) have been changed from `(context.Context, string, string, UpdateSAPVirtualInstanceRequest, *SAPVirtualInstancesClientUpdateOptions)` to `(context.Context, string, string, *SAPVirtualInstancesClientUpdateOptions)`


    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 6f5e3fc. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-workloads [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Model Monitor has a new parameter zone_redundancy_preference
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 6f5e3fc. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/workloads/armworkloads [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `*SAPDatabaseInstancesClient.BeginCreate` parameter(s) have been changed from `(context.Context, string, string, string, SAPDatabaseInstance, *SAPDatabaseInstancesClientBeginCreateOptions)` to `(context.Context, string, string, string, *SAPDatabaseInstancesClientBeginCreateOptions)`
info	[Changelog] - Function `*SAPApplicationServerInstancesClient.BeginCreate` parameter(s) have been changed from `(context.Context, string, string, string, SAPApplicationServerInstance, *SAPApplicationServerInstancesClientBeginCreateOptions)` to `(context.Context, string, string, string, *SAPApplicationServerInstancesClientBeginCreateOptions)`
info	[Changelog] - Function `*SAPVirtualInstancesClient.BeginCreate` parameter(s) have been changed from `(context.Context, string, string, SAPVirtualInstance, *SAPVirtualInstancesClientBeginCreateOptions)` to `(context.Context, string, string, *SAPVirtualInstancesClientBeginCreateOptions)`
info	[Changelog] - Function `*SAPDatabaseInstancesClient.BeginUpdate` parameter(s) have been changed from `(context.Context, string, string, string, UpdateSAPDatabaseInstanceRequest, *SAPDatabaseInstancesClientBeginUpdateOptions)` to `(context.Context, string, string, string, *SAPDatabaseInstancesClientBeginUpdateOptions)`
info	[Changelog] - Function `*SAPApplicationServerInstancesClient.BeginUpdate` parameter(s) have been changed from `(context.Context, string, string, string, UpdateSAPApplicationInstanceRequest, *SAPApplicationServerInstancesClientBeginUpdateOptions)` to `(context.Context, string, string, string, *SAPApplicationServerInstancesClientBeginUpdateOptions)`
info	[Changelog] - Function `*SAPCentralInstancesClient.BeginUpdate` parameter(s) have been changed from `(context.Context, string, string, string, UpdateSAPCentralInstanceRequest, *SAPCentralInstancesClientBeginUpdateOptions)` to `(context.Context, string, string, string, *SAPCentralInstancesClientBeginUpdateOptions)`
info	[Changelog] - Function `*SAPVirtualInstancesClient.Update` parameter(s) have been changed from `(context.Context, string, string, UpdateSAPVirtualInstanceRequest, *SAPVirtualInstancesClientUpdateOptions)` to `(context.Context, string, string, *SAPVirtualInstancesClientUpdateOptions)`
info	[Changelog] - Function `*SAPCentralInstancesClient.BeginCreate` parameter(s) have been changed from `(context.Context, string, string, string, SAPCentralServerInstance, *SAPCentralInstancesClientBeginCreateOptions)` to `(context.Context, string, string, string, *SAPCentralInstancesClientBeginCreateOptions)`
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `SAPSoftwareInstallationTypeExternal`
info	[Changelog] - New const `SAPVirtualInstanceStateSoftwareDetectionFailed`
info	[Changelog] - New const `SAPVirtualInstanceStateSoftwareDetectionInProgress`
info	[Changelog] - New function `*ExternalInstallationSoftwareConfiguration.GetSoftwareConfiguration() *SoftwareConfiguration`
info	[Changelog] - New struct `ExternalInstallationSoftwareConfiguration`
info	[Changelog] - New field `Body` in struct `SAPDatabaseInstancesClientBeginUpdateOptions`
info	[Changelog] - New field `Body` in struct `SAPCentralInstancesClientBeginUpdateOptions`
info	[Changelog] - New field `Body` in struct `SAPVirtualInstancesClientUpdateOptions`
info	[Changelog] - New field `Body` in struct `SAPVirtualInstancesClientBeginCreateOptions`
info	[Changelog] - New field `ZoneRedundancyPreference` in struct `MonitorProperties`
info	[Changelog] - New field `Body` in struct `SAPApplicationServerInstancesClientBeginCreateOptions`
info	[Changelog] - New field `Body` in struct `SAPDatabaseInstancesClientBeginCreateOptions`
info	[Changelog] - New field `Body` in struct `SAPApplicationServerInstancesClientBeginUpdateOptions`
info	[Changelog] - New field `Body` in struct `SAPCentralInstancesClientBeginCreateOptions`
info	[Changelog]
info	[Changelog] Total 8 breaking change(s), 15 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 6f5e3fc. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-workloads [View full logs]  [Release SDK Changes] 
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Interface ExternalInstallationSoftwareConfiguration
info	[Changelog]   - Interface Monitor has a new optional parameter zoneRedundancyPreference
info	[Changelog]   - Enum KnownSAPSoftwareInstallationType has a new value External
info	[Changelog]   - Enum KnownSAPVirtualInstanceState has a new value SoftwareDetectionFailed
info	[Changelog]   - Enum KnownSAPVirtualInstanceState has a new value SoftwareDetectionInProgress
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 6f5e3fc. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/workloads/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Workloads [View full logs]  [Release SDK Changes] 
      warn	Skip artifact folder because it doesn't exist: artifacts/packages
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 6f5e3fc. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️workloads [View full logs]  [Release Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Oct 26, 2022 •
    edited
    Loading

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/workloads/armworkloads Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Python track2_azure-mgmt-workloads Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Java azure-resourcemanager-workloads Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    JavaScript @azure/arm-workloads Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

    @openapi-workflow-bot
    Copy link

    Hi @dmadiraju1, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
     If you need further help, please feedback via swagger feedback.

    This was referenced Oct 26, 2022
    Closed
    Closed
    This was referenced Oct 26, 2022
    Closed
    Closed
    Closed
    Closed
    @lirenhe
    Copy link
    Member

    lirenhe commented Oct 27, 2022

    The model validation error is not related to this change.

    @lirenhe
    Copy link
    Member

    lirenhe commented Oct 27, 2022

    @tadelesh, could you help to check the SDK breaking change in GO?

    @tadelesh
    Copy link
    Member

    Approve for Go breakings as all come from lack of -alwaysSetBodyParamRequired flag. cc @Alancere

    @tadelesh tadelesh added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Oct 27, 2022
    @lirenhe lirenhe merged commit 6f5e3fc into Azure:main Oct 28, 2022
    This was referenced Oct 28, 2022
    Closed
    Merged
    Closed
    Closed
    ghost pushed a commit to Azure/azure-resource-manager-schemas that referenced this pull request Oct 28, 2022
    [ReleasePR workloads] [Workloads - Sap Virtual Instance] (#2629)
    e414e2d 
    Create to sync Azure/azure-rest-api-specs#21284
[ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...azure-sdk:sdkAuto/workloads?expand=1)
    @azure-sdk azure-sdk mentioned this pull request Oct 28, 2022
    Closed
    @azure-sdk azure-sdk mentioned this pull request Oct 28, 2022
    Closed
    akning-ms added a commit that referenced this pull request Dec 13, 2022
    @yanfa317 @audunn
    @austintolani @Alancere @us6193 @kbharucha @heaths @ChhabraAnshul @joshdmcc @ruowan @mikekistler @soma-ms @AzureRestAPISpecReview @sparatala @aim-for-better @kamusta-msft @fengzhou-msft @xiaoxuqi-ms @solankisamir @Hardell @seandkim @markcowl @annaji-msft @tomkerkhove @DeagleGross @LFZ96 @Mielek @malincrist @GuanchenIntern @VatsaPatel @agapovm @najian @AmirGeorge @roslynlu @srivatsasinha @hiaga @pratimaupadhyay02 @dw511214992 @msyyc @Sandido @vineetmimrot @FumingZhang @UtheMan @matthchr @wedaly @zarvd @serbrech @yungezz @kazrael2119 @docschmidt @dedgems @maorleger @maddiemlucas @jlichwa @gubalasu @dramuy @npotrebich @shavital7 @giakas @tianxchen-ms @nickdepinet @Y-Sindo @richardcho-msft @juntuchen-msft @arupdutta-msft @cochi2 @williamzhao87 @yyw-msft @mayankagg9722 @sri- @jianyexi @The-DevBlog @andrsmith149 @ambrahma @DaeunYim @lmazuel @jr-MS @bidisha-c @leni-msft @supriyajha-ms @gregoks @seanmcc-msft @vimauro @soniaab @niteshvijay1995 @niteshvijay-ms @amchandn @karataliu @cvvz @Sherylueen @Jingshu923 @divya-jay @divyajay @juliawelborn @tjprescott @wiboris @tombuildsstuff @ashoknailwal @abatishchev @vicancy @dagoroz @navba-MSFT @imsiddhartha @chrissmiller @dmadiraju1 @tadelesh @wangyuantao @yuantao-wang @harneetvirk @davsta90 @stevemunk @msftabdayal @RickWinter @kayousef @yang-hai-feng @scottmacchia-msft @msaranga @yibirnba @nreisch @alanenriqueo @paterasMSFT @dpwatrous @danielthank @yinqchen @mssfang @mattgotteiner @pednekarpraj @jayati-tehri @utkarshjain1508 @xuubin @Arkanayan @JocelynBerrendonner @nickghardwick @rakshith91 @srnagar @asmaskar @JackTn @Wzb123456789 @sushil490023 @minkefusiji @tejitpabari99 @tejitpabari-microsoft @ryanosh @htippanaboya @honghr @sbhosalemsft @raych1 @akshaym6 @MikhailTryakhov @mchakka @Yiyao-MS @fnuarnav @saprakas @jnlycklama @irrogozh @libronsh @moshemal @anat-gilenson @Vaspate @dosegal @dulikvor @yuc-Li @ChenglongLiu @zhuofudeng @zhoufenqin @yuwzho @sougatac @anuragc617 @TimLovellSmith @andreasjl @aditimalladi @hilalevi170 @Juliehzl @DhruvSehgal @aurghob @ehunter1878 @Charan000 @bojunehsu @YalinLi0312 @archanac866 @priyankajayaswal1 @j-zhong-ms @bexxx @Arif-lakhani @nikkomiu @abhayohri @venkatr21 @HimanshuChhabra @JatinKhatri03 @prabhavgupta @prabgupta @gaoyp830 @akning-ms @ziyeqf @meghanagupta95 @pathuang-sia @vishal-kadam @aeweston-msft @aakash049 @aditdalvi @touchdreamer @krishna1s @Harshan01 @robga @Shiwani-K @IshitaAsthana @omaremadeldin @kristapratico @jaimeva-msft @qianwens @xfz11 @Anandaraj-Selvam @jungph808 @dosiso @dejimarquis @KalpeshChavan12 @RakeshMohanMSFT @shesamian @sbhat9 @paulgmiller @wenxuan0923 @InduSridhar @ZhichengYang-MS @houk-ms @dindurkhya @damodaravadhani @msyache @aronip @yareyes @malpaniHMC @yanjungao718 @PTaladay @tongwu-sh @catalinaperalta @weidongxu-microsoft @pshao25 @diyellap @ZianWang02 @oravital7 @minnieliu @pansharm-ms @gauravgupta2 @chlowell
    Release Master to branch 2022-06-01-preview (#21767)
    9646392 
    * [NetAppFiles] Bugfix Add missing api-version parameter (#20993)

* Add missing api-version parameter

* update vg examples

* update vg examples2

* remove x-ms-external tag for 2022-06-01 API version (#21004)

* [Go] redis add directive (#21094)

* Fixing examples on 2020-05-01 to fix s360 linting alert. (#21099)

* Fixing examples on 2020-05-01 to fix s360 linting alert.

* Added example for Get_operations api

* correction

* fixed dates

Co-authored-by: Umang Shah <umangshah@microsoft.com>

* [Hub Generated] Review request for Microsoft.Consumption to add version stable/2021-10-01 (#20856)

* swagger correctness changes

* fix json files to pass model validation

* Add heaths to Cog. Lang. and Key Vault services (#21120)

* [Hub Generated] Review request for Microsoft.InstanceMetadataService to add version stable/2021-11-01 (#20999)

* Adds base for updating Microsoft.InstanceMetadataService from version stable/2021-10-01 to version 2021-11-01

* Updates readme

* Updates API version in new specs and examples

* update

* update

* update

* prettier

* updating tag

* Update specification/imds/data-plane/readme.md

Co-authored-by: Joshua McCarthy <joshdmccarthy@gmail.com>

Co-authored-by: Joshua McCarthy <joshdmccarthy@gmail.com>

* Update fabricbot.json (#20763)

* Update fabricbot.json

* Update .github/fabricbot.json

Co-authored-by: Mike Kistler <mikekistler@microsoft.com>

Co-authored-by: Mike Kistler <mikekistler@microsoft.com>

* [AutoSync] 85cfdeadd7 corrected the description (#21095)

Co-authored-by: swagger-automation <swagger@microsoft.com>

* Fix lint error (#21061)

* Fix lint error

* Fix model validation error

* Fix model validation error

* Fix lint error

* Fix R4030 - UniqueXmsExample

* Fix ROUNDTRIP_INCONSISTENT_PROPERTY error

* Made prettier

* Resolve lint error

* Fix Semantic Model validation error (#21102)

* {HDInsight} Fix Linter errors (#21043)

* Fix operation missed example and duration value is invalid format in example linter errors

* Update example file to fix schema issue

Co-authored-by: Zhenyu Zhou <zhezhou@microsoft.com>

* [BUG] Compute ProtectedSettingsFromKeyVault (#20101)

* init

* folder fix

* model fixes

* Add back net sdk track 1 config for network (#21103)

* revert common types v3/types.json (#21125)

Co-authored-by: QI， XIAOXU <xqiab@connect.ust.hk>

* [2022-04-01-preview] Add New Api-version for Microsoft.ApiManagement (#20399)

* Adds base for updating Microsoft.ApiManagement from version preview/2021-12-01-preview to version 2022-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* APIM Auth Servers (#19234)

* APIM Auth Servers

* adding x-ms-identifiers

* removing some weird, invisible special char

* formatting

* oAuth2AuthenticationSettings moved to AuthSettings

* Formatting

Co-authored-by: Milan Zolota <mizolota@microsoft.com>

* API Management Authorization Endpoints (#19615)

* Add blockchain to latest profile

* Add additional types

* add authorizations definitions

* authorizations operations

* add examples

* update readme

* fix examples

* fix linter delete errors

* address CI validation errors

* prettier fix

* update to 2022-04

* fix readme

* Update specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2022-04-01-preview/apimauthorizationproviders.json

Co-authored-by: Sean Kim <seaki@microsoft.com>

* update versions

* Apply suggestions from code review

Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Co-authored-by: Annaji Sharma Ganti <anganti@microsoft.com>
Co-authored-by: Annaji Sharma Ganti <42851022+annaji-msft@users.noreply.github.com>

* Move Long running Create Operation from Location based to Azure-AsyncOperation Header (#19733)

* azure-asyncOperation

* prettier

* fix(apim): Add missing 'metrics' property to diagnostics contract in 2022-04-01-preview (#20317)

* apim /PUT apis import add translateRequiredQueryParameters (#20333)

* [2022-04-01-preview] Replace resource with proxyresource and TrackedResource (#20461)

* replace resource with proxyresource

* revert to proxyresource

* Add type object to authorization definitions (#20631)

Authorization definitions were missing "type": "object", and this change adds that key/value pair

* Add type object to policy fragment definition (#20585)

* APIM Open ID Connect providers (#20622)

* APIM Open ID Connect providers

* added new proeprties for update

* prettier

* [APIM] Add Nat Gateway (#19990)

* Update apimdeployment.json

* Create ApiManagementCreateServiceWithNatGatewayEnabled.json

* fix typo in file

* Change Nat Gateway property to enum

* modify type of natgateway state

* update property name

* add example reference

* small fix in example

* rename to  outboundPublicIPAddresses

Co-authored-by: Samir Solanki <samirsolanki@outlook.com>

* [2022-04-01-preview] MIgrate2Stv2 API (#20504)

* migrate2stv2

* updated to post

* 202 and location

* add body to 202

* remove body from 202

Co-authored-by: Vatsa Patel <vatsapatel@microsoft.com>
Co-authored-by: Samir Solanki <samirsolanki@outlook.com>
Co-authored-by: vatsapatel@microsoft.colm <vatsapatel@microsoft.colm>

* Address Authorizations MissingTypeObject errors (#20919)

* Add forgotten If-Match header (#20920)

* Add forgotten If-Match header

`If-Match` header for the `DeleteAuthorizationAccessPolicy.json file` was forgotten. This change adds the wildcard character for the `If-Match` header for that file.

* Update ApiManagementDeleteAuthorization.json

* Use common types for specs and count as readonly (#21023)

* common types

* count readonly

* Sasolank/more review comments (#21025)

* XML

* proxy to gateway

* Update Authorizations Spec (#21027)

* Update definitions.json

Update wording for PostGetLoginLink endpoint description

* Update apimauthorizationproviders.json

Add 201 response to all Authorization PUT requests

* Updated examples and fixed formatting

There was a formatting issue within apimauthorizationproviders.json, and the Authorization examples needed to be updated with the new 201 responses for creating/updating Authorization entities.

* Add long-running-operation key/value

Added x-ms-long-running-operation: true to Authorization PUT requests

* Remove long-running-operations

* readonly revert (#21050)

* Set  SchemaContract.Document as required. (#20110)

* Updated documentation of the SchemaContract. Server use to return code 500 in case SchemaContract.Document is null. That issue was fixed in the APIM and server will return proper response code.

* Fix AzureApiValidation

* update field with properties

* revert remaining readonly on collection (#21051)

* Change to camel casing for "accesspolicies" (#21070)

* Change to camel casing for "accesspolicies"

* More camel casing updates for access policies

* list example fixed (#21089)

* fix definition (#21110)

* upgrade to v3 for common types (#21109)

* upgrade to v3

* Space

* revert to v2 proxyResource

Co-authored-by: Milan Zolota <Hardell@users.noreply.github.com>
Co-authored-by: Milan Zolota <mizolota@microsoft.com>
Co-authored-by: Sean D Kim <seandkim14@gmail.com>
Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Co-authored-by: Annaji Sharma Ganti <anganti@microsoft.com>
Co-authored-by: Annaji Sharma Ganti <42851022+annaji-msft@users.noreply.github.com>
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Co-authored-by: Korolev Dmitry <deagle.gross@gmail.com>
Co-authored-by: Logan Zipkes <44794089+LFZ96@users.noreply.github.com>
Co-authored-by: Rafał Mielowski <mielex@gmail.com>
Co-authored-by: malincrist <92857141+malincrist@users.noreply.github.com>
Co-authored-by: GuanchenIntern <109827715+GuanchenIntern@users.noreply.github.com>
Co-authored-by: VatsaPatel <vatsapatel13@gmail.com>
Co-authored-by: Vatsa Patel <vatsapatel@microsoft.com>
Co-authored-by: vatsapatel@microsoft.colm <vatsapatel@microsoft.colm>
Co-authored-by: Maxim Agapov <103097563+agapovm@users.noreply.github.com>

* [fix S360] add missing property to REVISIONS/REPLICAS/ (#21037)

* [fix S360] add missing property to REVISIONS/REPLICAS/

fix s360 https://portal.azure-devex-tools.com/amekpis/correctness/detail?errorId=6F43822E-1FAA-4D7C-BCFE-9B8816F67241

* add 200 response for patch action to fix s360

* add example of patch200

* Update ManagedEnvironments_GetAuthToken.json

Co-authored-by: Nan Jiang <naji@microsoft.com>

* Update pull_request_assignment.yml (#21131)

* Language Authoring 2022-10-01-preview (#21068)

* Adding Language Authoring 2022-10-01-preview to the specification folder

* fixes for PR checks

* prettier fixes

* PR comments

* Update specification/cognitiveservices/data-plane/Language/preview/2022-10-01-preview/analyzeconversations-authoring.json

* Update specification/cognitiveservices/data-plane/Language/preview/2022-10-01-preview/analyzeconversations-authoring.json

Co-authored-by: Heath Stewart <heaths@outlook.com>

* [Hub Generated] Review request for Microsoft.StreamAnalytics to add version preview/2021-10-01-preview (#20733)

* Add blockchain to latest profile

* Add additional types

* update enum name

* update cluster max size and add default values

* add gateway message bus

* tenantId and principalId to readonly

* add blobpathprefix

* add file ref input

* add missed example files

* add 200 response code to scale

* add to 2020GA version

Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Co-authored-by: Roslyn Lu <roslu@microsoft.com>

* Updated description of the script source to remove inline from the list (#21133)

Co-authored-by: Srivatsa Sinha <srsinha@microsoft.com>

* Fix RoundTrip error (#21116)

* Fix RoundTrip error

* Fix model validation error

* Fix missing definition ManagedIntegrationRuntime

* Fix Invalid_Type error

* Revert "Fix Invalid_Type error"

This reverts commit 3216774d9c40b33a4837f579b3b6aeef5fa35fa3.

* Release recoveryservicesbackup microsoft.recovery services 2022 09 01 preview (#21142)

* Updating version

* Update

* Update specification/recoveryservicesbackup/resource-manager/readme.md

Co-authored-by: Wei Dong <40835867+dw511214992@users.noreply.github.com>

* Update readme.python.md

* Update readme.md

* Update readme.python.md

* Update specification/recoveryservicesbackup/resource-manager/readme.md

Co-authored-by: Wei Dong <40835867+dw511214992@users.noreply.github.com>

* Update readme.python.md

Co-authored-by: Pratima Upadhyay <pratima.upadhyay02@gmail.com>
Co-authored-by: Wei Dong <40835867+dw511214992@users.noreply.github.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* Update RestorePointCollections_Update_MaximumSet_Gen.json (#20769)

removing admin password

* [Hub Generated] Review request for Microsoft.Network to add version preview/2021-02-01-preview (#21040)

* NSP Link API changes

* minor fix

* fix errors

* fix error

* fix error

* fix lint error

* skip location from proxy resource

* fix sdk error

* fix linter check

* immutability flag changes

* removed v2 properties.

* minor fix

* removed default value as it is not supported by swagger

* make outbound profile read only

* minor change

* add x-ms-long-running-operation-options

* Fix review comments

* minor fix

* Review request for Microsoft.ContainerService to add version 2022-09-02-preview (#21038)

* Adds base for updating Microsoft.ContainerService from version preview/2022-08-03-preview to version 2022-09-02-preview

* Updates readme

* Updates API version in new specs and examples

* Custom CA Trust updates for 20220902 preview version (#20995)

* add create managed cluster example with certs

* add description of custom ca certs in managed cluster security profile json

* better phrasing

* Use dummy base64 encoded values for examples, set format: byte for cert array

* Update specification/containerservice/resource-manager/Microsoft.ContainerService/preview/2022-09-02-preview/managedClusters.json

Co-authored-by: Matthew Christopher <matthchr@users.noreply.github.com>

* update description

* add exception for linter camel case

Co-authored-by: Mikolaj Umanski <mumanski@microsoft.com>
Co-authored-by: Matthew Christopher <matthchr@users.noreply.github.com>

* Containerservice 2022 09 02 preview fleet (#20939)

* Fleet swagger 09-02 api

* Add to README

* Wrong ref

* Add options per lint diff err

* Add headers per lint feedbacks

* Add min and max length

* Add networkProfile.ebpfDataplane field to 20220902preview API (#20955)

* Add HostNetwork NSG Control fields (#20949)

* Update readmes for the 2022-09-02-preview dev branch of container service (#20951)

* update readmes

* undo go readme

* fix tag for python sdk (#21057)

* [containerservice-dev] Revert "Containerservice 2022 09 02 preview fleet (#20939)" (#21073)

* Revert "Containerservice 2022 09 02 preview fleet (#20939)"

This reverts commit 7f9780381fb7d1140cd2a3ff6d3d2dc13d59f900.

* add fleet previous version to readme to pass CI

* Add fleet 0702 base for change comparison (#21093)

* add 07-02-fleet-base

* bump apiversion reference

Co-authored-by: Stephane Erbrech <stephane.erbrech@gmail.com>

* Fleet swagger 09-02 api (#21104)

Co-authored-by: nguyenmin <mnguyenn@protonmail.com>

Co-authored-by: Mikołaj Umański <mik.umanski@gmail.com>
Co-authored-by: Mikolaj Umanski <mumanski@microsoft.com>
Co-authored-by: Matthew Christopher <matthchr@users.noreply.github.com>
Co-authored-by: Minh Nguyen <mnguyenn@protonmail.com>
Co-authored-by: Will Daly <wedaly@users.noreply.github.com>
Co-authored-by: ccc <jialun.cai@pm.me>
Co-authored-by: Stéphane Erbrech <stephane.erbrech@gmail.com>

* add custom word (#21146)

* modify folder name in typescript.md (#21151)

* Release Key Vault 7.4-preview.1 (#21123)

* Adds base for updating Microsoft.KeyVault from version preview/7.3-preview to version 7.4-preview

* Updates readme

* Updates API version in new specs and examples

* Key Vault 7.4-preview to 7.4-preview.1 (#15900)

* KeyVault 7.4-preview to 7.4-preview.1

* Fix spelling error for subsequent KV versions

* Key Vault keys API: Add OKP key type and EdDSA digital signature (#15989)

* Add OKP key type and EdDSA digital signature

* Address feedback

* Fix validation error

* dedge/api entityid (#17854)

* Add EntityId to the API definitions for secrets, keys, and certificates

* fixed typos on entity ID

* added entityId to the api samples

* fixed examples

* [keyvault] - sync 7.3 stable changes to 7.4-preview.1 (#18649)

* [keyvault] - sync 7.3 stable changes to 7.4-preview.1

* remove export sample

* add x-ms-client-name for targetAttestationToken

* settings-specs (#20937)

* settings-specs

* my embarrassing typo errors

* pr feedback changes

* description change

* setting name param

* type specifier

* modelAsString

* only support at

* reference in readme

* prettier fixes

* fixes

* prettier

* lint fixes

* ran prettier

* lint fix

* prettier on common.json

* remove from common.json

* make all APIVersionParams equal

* fix breaking change

* setting name

* setting name param

* Make ApiVersionParameter global

* Merge securitydomain.json changes from stable/7.3

Co-authored-by: Heath Stewart <heaths@microsoft.com>

* Remove entity id (#21092)

* Update certificates.json

* Update keys.json

* Update secrets.json

* Update CreateKey-example.json

* Update GetCertificate-example.json

* Update GetCertificateVersions-example.json

* Update GetCertificates-example.json

* Update GetKey-example.json

* Update GetKeys-example.json

* Update GetSecret-example.json

* Update GetSecrets-example.json

* Update GetCertificateVersions-example.json

* Sync operation and attributes descriptions with 7.3 (#21119)

* Sync operation and attributes descriptions with 7.3

* Update certificates.json

* Update secrets.json

* Update storage.json

* Update keys.json

* Update keys.json

* Remove duplicate double quotes

* Remove duplicate description from certificates.json

Co-authored-by: Heath Stewart <heaths@microsoft.com>

* Change order of parameters in DeleteRoleDefinition-example.json

* Fix azure-sdk-for-go build issue

Co-authored-by: Alexander Schmidt <aschmidt@microsoft.com>
Co-authored-by: dedgems <99688216+dedgems@users.noreply.github.com>
Co-authored-by: Maor Leger <maorleger@users.noreply.github.com>
Co-authored-by: Maddie Lucas <85301813+maddiemlucas@users.noreply.github.com>
Co-authored-by: Jack Lichwa <52512203+jlichwa@users.noreply.github.com>

* Fix swagger issues for cdn preview version (#20903)

* Fix swagger issues for cdn preview version

* Updates

* Updates

* [Hub Generated] Review request for Microsoft.ManagedServices to add version stable/2022-10-01 (#20778)

* Adds base for updating Microsoft.ManagedServices from version preview/2022-01-01-preview to version 2022-10-01

* Updates readme

* Updates API version in new specs and examples

* [Hub Generated] Review request for Microsoft.ResourceGraph to add version stable/2022-10-01 (#20792)

* Adds base for updating Microsoft.ResourceGraph from version preview/2021-06-01-preview to version 2022-10-01

* Updates readme

* Updates API version in new specs and examples

* Add ResourceHistoryRequestResponse type

* Spell check fix

* Remove resourcehistory.json. Update readme.

* Update readme

* Revert "Update readme"

This reverts commit d8c5ee2a7b6fa1606cf0398b7dc8f3b33305ff9c.

* Update readme

* Update readme

* Add Cmk Payload to Common Types (#20144)

* add cmk payload to common types

* rename enum value for delegated identity type

* use arm-id format for cmk identity resource id

* Add CODEOWNERS entry for FarmBeats (#20292)

* Add entry to CODEOWNERS for Code Signing and Purview service (#20646)

* Add entry to CODEOWNERS for Code Signing service

* Add entry to CODEOWNERS for Purview service

* Update CODEOWNERS

* Update ContentKeyPolicies.json (#21155)

* add role assignment (#21078)

Co-authored-by: Tianxiang Chen <tianxchen@microsoft.com>

* S360 swagger correctness - added missing property totalCount (#21091)

Co-authored-by: Umang Shah <umangshah@microsoft.com>

* add or modify files (#21171)

* Fix breaking change azureADOnlyAuthentication property from read only… (#21076)

* Fix breaking change azureADOnlyAuthentication property from read only to read, write

* Removed x-ms-mutability

* Add 2022-08-01-preview version to Microsoft.SignalRService/SignalR (#20272)

* Adds base for updating Microsoft.SignalRService from version stable/2022-02-01 to version 2022-08-01-preview

* Update readme.md

* Update swagger and examples

* Updates

* revert adding 200 response code to put custom domain

* [Communication - Calling Server] 2022 04 07 preview (#19409)

* Added 2022-04-07-preview

* Adds base for updating CallingServer from version preview/2021-08-30-preview to version 2022-04-07-preview

* Updates readme

* Updates API version in new specs and examples

* public refresh swagger

* fix prettier

* fix route path

* remove transferToCall API

* updated swagger file

* updated swagger

* address review comments

* update swagger

* updated swagger

* Add play example

* Remove non-2xx codes from Play example

* swagger update

* Adding play elements

* Adding Recording

* add operations endpoints for review

* fix swagger

* update swagger

* Update Play API PlaySource model and example

* Add missing summary

* Added events

* Adding new swagger version

* Adding new Recording Play Events

* Update content routes

* update model names to drop dto suffix

* Updating swagger with recognize events

* fix lint issues

* fix linting errors

* remove nonexistent example

* update latest swagger

* fix spellcheck

* fix some linting errors

* fix modelValidation

* fix linting

* fix structure

* fix call automation examples

* add content examples

* prettier fix

* fix merge errors

* fix structure

* fix another example structure

* fix examples

* fix enum type

* remove additional properties

* make examples realistic

* Adding latest swagger

* Fixing typos

* Fixing route

* Fixing empty line at the end

* fix example format

* add back description

* prettier fix

* update events. hide internal events fields.

* update sameple name

* fix prettier

* Update communicationservicescallingserver.json

* undo whitespace

* address lint error

* add type and format and default responses

* fix validation errors

* fix again

* I don't know what they want

* .

* fixed some pipeline issues

* Remove channel affinity based on ARB feedback, add latest swagger

* Fix CI - prettier

* rename service

* .

* update readme

* test validation

* add back url format

Co-authored-by: Juntu Chen <juntuchen@microsoft.com>
Co-authored-by: Juntu Chen <95723208+juntuchen-msft@users.noreply.github.com>
Co-authored-by: Arup Dutta <arupdutta@microsoft.com>
Co-authored-by: arupdutta-msft <87995153+arupdutta-msft@users.noreply.github.com>
Co-authored-by: Franko Morales <fmorales@microsoft.com>
Co-authored-by: Franko Morales <67804607+cochi2@users.noreply.github.com>
Co-authored-by: williamzhao87 <williamzhao87@gmail.com>
Co-authored-by: Yingying Wu <98626395+yyw-msft@users.noreply.github.com>
Co-authored-by: williamzhao87 <williamzhao87@users.noreply.github.com>

* Adding new API version 2022-10-01-preview (base stable 2022-05-01) (#20967)

* Base commit stable 2022-05-01

* Changes for 2022-10-01-preview api

* changes for readme

* changes for latest readme tag

* changes for comments

* changes in readme for package-preview-2022-10

* readme changes for package-preview-2022-09

* Sri/recommendation details (#21175)

* Add blockchain to latest profile

* Add additional types

* Clarifying definitions of recommendation details properties.

* Updating some more definitions.

Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>

* Update comment.yml (#21077)

* [Hub Generated] Publish private branch 'eventListener' (#20467)

* Adds base for updating Microsoft.SignalRService from version stable/2021-10-01 to version 2022-08-01-preview

* Updates readme

* Updates API version in new specs and examples

* "ot" -> "or"

* Update swagger

* max listener count = 10
* Add custom cert and custom domain

* Add examples

* Add fina-state-via for delete

* Fix markdown format

* Rename discriminator and enum type

* Add x-ms-identifier

* Update markdown settings

* Fix 204 description

* Add 200 to custom domain PUT

* Revert adding 200 response code to put

* try fix readiness test

1. change default tire to premium
2. remove private endpoint

* Fix incorrect ID path (#21213)

Co-authored-by: andrew <andrsmith@microsoft.com>

* [Go] update readme.go.md (#21219)

* Dev postgresql microsoft.d bfor postgre sql 2022 03 08 preview (#20212)

* Adds base for updating Microsoft.DBforPostgreSQL from version preview/2022-01-20-preview to version 2022-03-08-preview

* Updates readme

* Updates API version in new specs and examples

* Splitted the swagger api changes to smaller chunks for easy readbility and find

* Add administrators api and corresponding examples

* Fix sematic validation errors by running oav tool

* Fix model validation errors by running oav tool for  validate example

* Fix lint errors using prettier

* Fix some automated review comments

* Fix lint diff errors

* Fix ARM Id annotations for postgres

* Remove duplicate operation

* Remove changes from existing preview version api

* Use systemData for read only properties required for PUT and Patch operations

* Revert systemData changes

* Include changes for PasswordAuthEnabled

* Remoe azure resource tag from ActiveDirectoryAdministrator object

* Fix the validation errors

* Update swagger for CMK propertiesData encryption properties

* Fix spell check and reference errors

* Update swagger for GeoRestore

* Update swagger for Replica

* Update swagger for MVU

* Fix prettier errors

* Update readme and rename postgresql.json to a different file

* Fix validation errors

* Remove private preview version for 2022-03-08 from readme.md

* Fix linter issue and add fast provisioning properties

* Fixed review comments for Backups and CheckNameAvailability

* Uodated duplicate Id for check name availability and undo the changes to remove empty id identifier

* Add 2022-03 preview and private preview versions for readme.go.md

* Pass default value of true for passwordAuthEnabled

* pass true instead of "true"

* Added subnetName as id identifier for array obkect for DelegatedSubnetUsage

* Updated x-ms-identifiers to not be an empty array for all objects in 2022-08-08-preview

* Add missing x-ms-identifier

* Add support for supportedVersionsToUpgrade property in lication capabilitities

* Fix validation issue

* Fix validation error related to Server Versions

* Add new property for Capabilities api

* Fix validation errors

* Fix LroLocationHeader and ResourceNameRestrcition errors

* Fix validation error x-ms-long-running-operation-options

* Try to match the new version with stable version

* Revert changes to stable api version

* Reanme Databases.json to Database.json

* Fix reference error

* Add minLength validation for ServerNameParameter

* Add minLength for LocationNameParameter

* Fix ResourceNameRestriction for ServerNameParameter

* Fix ResourceNameRestriction for LocationNameParameter

* python config

* Fix few staging validations

* Fix few validation errors for name restriction

* Fix few validation errors for name restriction and duplicated model validation

* Fix validation errors for configurations api

* Fix model validation error

* Remove location property for Server Update

* Fix validation error

* Fix model validation

* Fix validation errors for administrators api

* Fix errors

* Fix validation errors for Database and Configuration

* Fix validation errors

* Fix review comment to utilize common parameter and definitions

* Fix path for systemData

* remove get cached server name API

* Update readme file to remove non-existing reference and fix review comment for systemData

* Fix review comments

* Fix review comments to rename operationId to remove Execute

* Fix review comment

* Fix unresolved reference

* Added pattern validation for charset and collation

* Add backupType as enum as a string

* Fix enum case error for backup type

* Revert name of Database.json back to Databases.json

* Add Databases.json in readme file

* Remove 202 for Administrators PUT call

* Update name for Identity object to differentitate it from common type

* Renamed Sku to have different name then the one in comman types as the corresponding properties are different

* Revert operationId change to avoid SDK and CLI impact to end users

* Update operation id for consistency across mysql and postgres and to avoid conditions in CLI

Co-authored-by: Daeun Yim <69321306+DaeunYim@users.noreply.github.com>
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>

* Fix ApiVersion for Anomaly Detector (#21215)

* Fix ApiVersion for Anomaly Detector

* Update MultivariateAnomalyDetector.json

Change operationId

* Update operationId in Univariate Anomaly Detection

Co-authored-by: jr-MS <81400625+jr-MS@users.noreply.github.com>

* Rename the operation ID for /:analyze-conversations path (#21030)

* Rename the operation ID for /:analyze-conversations path for supporting better organization of documents

* Transpose /authoring back into endpoints

Fixes lintdiff validation error, which is tracked in Azure/azure-sdk-tools#4419

Co-authored-by: Heath Stewart <heaths@microsoft.com>

* Update comment.yml (#21208)

* Disable purge protection in examples (#21182)

* Update ManagedHsm_CreateOrUpdate.json

* Update ManagedHsm_Get.json

* Update ManagedHsm_Update.json

* disable purge protection in examples

* Network Watcher S360 Correctness Fix (#20804)

* Adding runningOperationIds and Error

* prettier fix

* Search api data plane suggestions facets (#20825)

* Added search data-plane

* added marketplace catalog resource manager

* fixed readme

* Fixed Spec Linter validations

* fixed all validation tools

* fixed avo

* fixed prettier check

* fixed spelling

* Added search data-plane

* added marketplace catalog resource manager

* Fixed Spec Linter validations

* fixed all validation tools

* fixed avo

* fixed prettier check

* fixed spelling

* Removed search stable folder

* Added facets

* Added suggestions API

* fixed

* added missing new line

* fixed prettier

* Added 2022-09-25-preview version

* updated default 2022-09-25-preview

* removed space

* made product types description by ab

* fixed description

* revert search previous version

* removed decimal format

* fixed code review

* fixed facets possible values

* allow "all" in market

* fixed vm fields

* fixed api version in examples

* fixed description

Co-authored-by: Greg Oks <gregoks@microsoft.com>

* Storage STG 85/86 (#21167)

* Added 2021-12-02 service version for blobs (#20280)

* fixed ErrorCode typo

* Files 2021-12-02 version (#20439)

* Files invalid XML (#20480)

* ADLS Gen 2 Append and Flush Lease Operations (#20607)

* Added Blob Cold Tier (#20281)

* [Hub Generated] Review request for Microsoft.ConfidentialLedger to add version preview/2022-09-08-preview (#20647)

* Adds base for updating Microsoft.ConfidentialLedger from version stable/2022-05-13 to version 2022-09-08-preview

* Updates readme

* Updates API version in new specs and examples

* Initial MCCF setup

* Fixed CI errors

* updated title

* removed operations

* fixed LintDiff errors

* fixed tags lint

* more lintdiff fixes

* removed checknameavailability from mccf

* addressed PR comments

* Added member identity certificate

* restored confidentialledger as GA version

* fixed codestyle

* addressed pr comments

* Updated ManagedCCF RT and Examples

* fixed lint diff errors

* updated memberidentitycertificates

* Added encryptionkey custom word

* renamed ManagedCCF into ManagedCCFs

* addressed reviewer feedback

* switched parameters of ACL to v3

* addedd azure-asyncoperation header

* [Hub Generated] Publish private branch 'RPSaaSMaster-easm-data-plane' (#20294)

* add or modify files

* Added missing EASM references.

Co-authored-by: Brian Zak <brianzak@microsoft.com>

* Update operation IDs for Key Vault settings (#21230)

* Update operation IDs for Key Vault settings

* revert model change

* Use UpdateSettingsResult to match operation

Co-authored-by: Heath Stewart <heaths@microsoft.com>

* Add CosmosDBMongo enum (#21199)

Co-authored-by: Nitesh Vijay <niteshvijay@microsoft.com>

* [Hub Generated] Review request for Microsoft.RecoveryServices to add version preview/2022-09-30-preview (#20934)

* Adds base for updating Microsoft.RecoveryServices from version stable/2022-08-01 to version 2022-10-02-preview

* Updates readme

* Updates API version in new specs and examples

* Using parameters from v3 common

* swagger changes

* Example changes

* Removing unused parameters

* Using parameters from v3 common

* Adding suppression for Lint errors

* Renaming resource definitions back

* Revert "Removing unused parameters"

This reverts commit 8d35d76c834501ee707ea60d99eb0a05d3c859fd.

* Adding back parameters

* Removing suppressions

* Version change to 2022-09-30-preview

* readme fix

* example fix

* Review request for Microsoft.ContainerService to add version 2022-09-01 (#21148)

* Adds base for updating Microsoft.ContainerService from version stable/2022-07-01 to version 2022-09-01

* Updates readme

* Updates API version in new specs and examples

* AKS add oidc feature swagger to 2022-09-01 (#20930)

* AKS add oidc feature swagger to 2022-09-01

* fixup! AKS add oidc feature swagger to 2022-09-01

* fixup! fixup! AKS add oidc feature swagger to 2022-09-01

* fixup! fixup! fixup! AKS add oidc feature swagger to 2022-09-01

* fixup! fixup! fixup! fixup! AKS add oidc feature swagger to 2022-09-01

* fixup! fixup! fixup! fixup! fixup! AKS add oidc feature swagger to 2022-09-01

* blob csi driver 0901 (#20947)

* Update readmes for the 2022-09-01 dev branch of container service (#20952)

* update readmes

* undo go readme

Co-authored-by: Dong Liu <doliu@microsoft.com>
Co-authored-by: weizhi <weizhichen@microsoft.com>

* Release appcomplianceautomation microsoft.app compliance automation 2022 11 16 preview 1 (#21074)

* add appcomplianceautomation specs

* update appcomplianceautomation specs for 2022-11-16-preview

* remove privatepreview and beta (#21124)

Co-authored-by: Yanwen Liu <yanwenliu@microsoft.com>

* Release appcomplianceautomation microsoft.app compliance automation 2022 11 16 preview resolve comments 2 (#21152)

* fix comments

* remove duplicate in body

* resolve comments

* edit examples to match schema

* fix failure

* fix model validation

* change passed to passedCount

* add x-ms-enum to isPass

* change delete 200 description

Co-authored-by: Yanwen Liu <yanwenliu@microsoft.com>

* set sasUri x-ms-secret to true (#21161)

Co-authored-by: Yanwen Liu <yanwenliu@microsoft.com>

* remove properties from download request body (#21184)

* remove properties from download request body

* remove properties in snapshot_resourcelist_download.json

* keep statuscode 201 and 202 in patch report response, due to RPSaas will change 202 to 201

* add body in patch report 201 response

Co-authored-by: Yanwen Liu <yanwenliu@microsoft.com>

* change ProvisioningState Cancelled to Canceled, and some descriptions (#21237)

* change ProvisioningState Cancelled to Canceled, and some descriptions

* add x-ms-enum extension to ComplianceState

Co-authored-by: Yanwen Liu <yanwenliu@microsoft.com>

Co-authored-by: Yanwen Liu <yanwenliu@microsoft.com>

* [AutoSync] 91b7e73401 add (#21255)

Co-authored-by: swagger-automation <swagger@microsoft.com>

* add providerhub (#21254)

* Add specs for microsoft.monitor RP (#20026)

* Add specs for microsoft.monitor RP

* Split up operations API spec

* Prettier fixes

* Fix avocado warning

* Delete unused example

* Attempt to fix ServiceAPIReadiness

* Fix name of body parameter in examples

* Updates based on PR comments

* Remove second reference to systemData

* Switch operations api-version

* Empty commit to re-trigger build

* Fix description

* Fix SDK APIs

* Add Canceled to possible values of provisioning state

Co-authored-by: Divya Jayaraman <divyaj@microsoft.com>

* Enable validator for CostManagement (#21009)

* Add alert definition navigation property to alert configuration (#21249)

* Cadl repo structure guidelines (#20893)

* [Hub Generated] Review request for Microsoft.Batch to add version stable/2022-10-01 (#21195)

* Adds base for updating Microsoft.Batch from version stable/2022-06-01 to version 2022-10-01

* Adding in development changes

* devhub: fixing the constant name to be unique (#20868)

* [Hub Generated] Publish private branch 'RPSaaSMaster-easm' (#20293)

* add or modify files

* Removing EASM from custom-words

* Adding EASM to custom-words

* Rejiggered EASM references to fix merge conflicts.

* Updated delete operations to show synchronous example.

* Added 202 response code with appropriate header.

Co-authored-by: Sonia Burney <soniaburney@Sonias-MacBook-Pro.local>
Co-authored-by: Brian Zak <brianzak@microsoft.com>
Co-authored-by: Ruoxuan Wang <52271048+ruowan@users.noreply.github.com>

* Update comment.yml (#21257)

* Update comment.yml (#21283)

* fix s360 for accountId in databox-v2022-02-01 (#21060)

* fix s360 for accountId in databox-v2022-02-01

* fix s360 for account Id in databox-v2021-12-01

* fix accountId for DataBoxDiskGranularCopyLogDetails in databox-v2021-12-01

* [Hub Generated] Review request for Microsoft.InstanceMetadataService to add version stable/2021-11-15 (#21201)

* Adds base for updating Microsoft.InstanceMetadataService from version stable/2021-11-01 to version 2021-11-15

* Updates readme

* Updates API version in new specs and examples

* update with payload

* correcting changes

* formatting

* update

* update

* to pascal case

* Created common type v4 where changed string to uuid (#19934)

* Add files via upload

* Update types.json

* Update types.json

* Update types.json

* Update types.json

* Update types.json

* Update types.json

* Update privatelinks.json

* Bumped version to 4.0

* [Azure Web PubSub] Release 2022-11-01 (#20762)

* Adding 2022-10-01-preview

* prettier

* reorder

* resolve comments and add $filter

* fix format

* Update webpubsub.json

* Resolve comments and change to stable version

* Update readme.md

* [Hub Generated] Review request for Microsoft.Batch to add version stable/2022-10-01.16.0 (#21214)

* Adds base for updating Microsoft.Batch from version stable/2022-01-01.15.0 to version 2022-10-01.16.0

* Adding in development changes

* removing deperation of certificates

* Add missing properties to 2022-04-01 files (#21250)

* add info on new properties

* prettier

* Fix location header (#21153)

* S360 issue: Adding missing properties in Recommendations API (#21231)

* Add blockchain to latest profile

* Add additional types

* Adding missing properties in Recommendations API

* updating previous versions

* fixing examples

* addressing validation errors

* addressing validation errors

* fixing validation errors

* fixing examples

* fixing example

Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>

* {AzureRecoveryServices} fixes Azure/azure-rest-api-specs#21000 (#21305)

fixes Azure/azure-rest-api-specs#21000

missing description for policyType as seen in the link below.
https://learn.microsoft.com/en-us/azure/templates/microsoft.recoveryservices/vaults/backuppolicies?pivots=deployment-language-arm-template#:~:text=int-,policyType,-%27Invalid%27%0A%27V1

* [Hub Generated] Publish private branch 'release-trafficmanager-Microsoft.Network-2022-04-01-preview' (#21308)

* Adds base for updating Microsoft.Network from version stable/2018-08-01 to version 2022-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* Add new property AlwaysServer for endpoints.

* Fix examples, update swagger to sdk in the readme.

* Added a new example for alwaysServe

* Use parameters like SubsId and apiVersion from common-types/v3

* Use parameter ResourceGroupNameParameter from common-types/v3

* Use ErrorDetail obj from common-types/v3 and remove CloudErrorObject.

* Revert breaking changes: Use ErrorDetail obj from common-types/v3 and remove CloudErrorObject.

* AD APIVersion Swagger (#21298)

* AD APIVersion Swagger

* Don't forget the rename

* [Azure DevCenter] Update operation groups to improve SDK codegen (#21086)

* Update operation groups

* Fix pattern

* Fix operation name for stop

* [Workloads - Sap Virtual Instance] (#21284)

-Adds SAP software detection feature on a VIS
-Changes were already checked-in to private repo in the PR:
 Azure/azure-rest-api-specs-pr#8871
 The changes were verified. This commit just ports the same
 to the public repo.

* Update readme.python.md (#21321)

* Migrate to net track2 for some resource-manager readmes batch 3 (#21241)

* migrate to track 2

* revert configs for machinelearning and managementgroups

* resolve Go SDK automation failure

Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>

* remove phraseControl (#21329)

Co-authored-by: Yuantao Wang <yuantw@microsoft.com>

* Updating the basic tags to Oct 2022 stable APIs for SDK GA release. (#21297)

* [Hub Generated] Review request for Creator to add version preview/2022-09-01-preview (#20516)

* added routeset for v 2022-08-01

* updated to final version
s Please enter the commit message for your changes. Lines starting

* added routeset delete API-help

* completed (but not proofed) routeset documentation

* completed wayfind json

* updates

* Brandon's review

* Update routeset.json

* Update wayfinding.json

* Updates to parameters and descriptions

* Update wayfinding.json

* Updates primarily based on our (Dev, PM, Tech Writer) discussion on 8/22/2022.

* proofing changes

* moved files under proper version folder

* json\swagger fix

* fix Swagger Avocado errors

* fix Swagger validation errors

* changes made by Prettier

* fixed json parsing error

* fixed validate-spec errors

* add custom-words.txt to address spell check errors

* more Prettier changes

* spelling errors

* fixes for validation-examples

* added wayfinding custom words
Please enter the commit message for your changes. Lines starting

* wagger Avocado fix

* undoing meerge from main with validaiton errors

* more validation fixes

* more validation fixes

* revised width param description

* default errors

* refactored according to API Rev Board feedback

* validation fixes after API review changes

* prettier changes on common types

* model validaiton fixes

* fixing validation errors

* validation fixes

* more validation fixes

* more validaiton fixes

* added pageable prop to routeset enumeration api

* trying to fix lint error

* trying to fix linter error

* reworded to remove ambiguity: wayfind only works with locations within the same facility

* another linter validaiton fix

* more validation fixes

* per linter error and other services: removed subscription-key parameter from definition and examples

* xms-enum for avoidFeatures

* trying to fix xms-enum validation problem

* removed misleading comment

* restoring package-lock.json to match master

* fix from PR review comment

* comments from PR

Co-authored-by: SteveMunk <33468793+stevemunk@users.noreply.github.com>

* [Hub Generated] Review request for Microsoft.Peering to add version stable/2022-10-01 (#21196)

* Adds base for updating Microsoft.Peering from version stable/2022-06-01 to version 2022-10-01

* Updates readme

* Updates API version in new specs and examples

* update peering api version

* update peering api version

* fixing resource inheritance

* making readme.md consistent with previous versions

* lint diff fix

* fixing serialization for examples

* [App Configuration] Fix the swagger to reduce duplicate enums (#21216)

* Fix the swagger to reduce duplicate enums

* Merge Language 2022-10-01-preview back to main:dev/ creating 2023-05-01 (#21236)

* Merge Language 2022-10-01-preview back to main:dev/ creating 2023-05-01

* Update all host templates to /language instead of /language/authoring

* fix api version in samples

* replace literal {api-version}

Co-authored-by: Yuantao Wang <yuantw@microsoft.com>

* IoT Central 2022-10-31-preview release (#20981)

* Create 2022-10-31-preview release based on 2022-06-30-preview

* Add IoT Central 2022-10-31-preview release

* fix linter error

* fix cross version break changes

* remove readonly from device type, add maxpagesize parameter for device relationships

* fix description for odata parameters and remove extra content-type from deployment manifest update

* fix review comments

* add if-match header parameter to patch operations, fix some odata descriptions in previous versions

* fix patch content type to merge-patch+json only

* Azure Databricks - Managed Disk Encryption - Critical API Version Cha… (#21274)

* Azure Databricks - Managed Disk Encryption - Critical API Version Changes

* Updated json files with prettier

* Updated Readme and fixed header issues in two files

* Fixed remaining response header issues and fixed OperationListResult

* Removed explicit type declarations and updated python sdk title

* Reverted back to non camel case to avoid breaking changes

* Fixing Swagger validation errors

* Update readme.python.md

* Address review comments by

* Updated SDK client name

* Removed minor difference between ErrorInfo models

Co-authored-by: Mahender Sarangam <nsarang@microsoft.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* [Security] Add directive definition to csharp to avoid .Net conflicts (#21206)

* [Security] Add directive definition to csharp to avoid .net conflicts

* Add declaration

* Fix

* Add second renaming

* Fix Applications.json enum values

* Rename x-ms-parameter-location value for not breaking the .net sdk

* fix types path

* asclocation path

* [Hub Generated] Publish private branch 'nreisch-componentPolicyStates-Microsoft.PolicyInsights-2022-04-01' (#20802)

* Adds base for updating Microsoft.PolicyInsights from version stable/2019-10-01 to version 2022-04-01

* Updates readme

* Updates API version in new specs and examples

* Clean 2022-04-01

* Add ComponentPolicyStates API

* Remove pageable

* Fix CI 1

* Fix CI 2

* Fix CI 3

* CI Fix 4

* Fix CI 5

* Fix CI 6

* Fix CI

* Fix CI

* Fix CI

* Fix CI

* FIX CI

* Fix CI

* Fix CI

* Fix CI

* Fix CI

* Fix CI

* Fix CI

* Fix CI

* Fix CI

* Fix CI

* Fix CI

* Fix CI

* Fix CI

* Fix CI

* Fix CI

* Fix CI

* Fix CI

* Fix CI

* Fix CI

* Fix CI:

* Fix CI

* Fix

* Fix

* Fix contract

* Address comments 1

* Add to readme

* Address comments

* Remove operations api

* Remove operations api from 2022-04-01

* Add back operations api

* Address comments

* Fix

* Fix CI

* Fix CI

* Fix CI

* Remove x-ms-parameter-grouping

* Rename parameters

* Whitespace fix

* whitespace fix

* Fix params

* Fix CI

* Update PolicyEvaluationDetails example

* Fix space

* Fixes

* Suppress resource name restriction

* Add pattern

* Fix pattern

* Suppress LRO_RESPONSE_HEADER for 2019 api

* Update resource name pattern

* Remove isDataAction from later api-version

* Add back operations api

* Remove suppression

* Fix LRO

* Fix example

* Fixes to 2022-03-08-preview for PostgreSQL flexible server (#21234)

* Add 202 response to server create and fix Sku definition

* Add 202 response to examples

* Batch 2022-10-01 control plane fix (#21316)

* Revert removal of required properties.

* Add x-ms-secret for secret properties.

Removed secrets from examples

* Fix model validation

Co-authored-by: David Watrous <dave.watrous@microsoft.com>

* Updating Microsoft.Maps/DataRegistry from version preview/2.0 to preview/2022-12-01 (#19272)

* Add DataRegistry 2022-12-01

* Add hard delete

* Use Register instead of Create, Unregister instead of Delete

* Fix ModelValidationFail

* Add more examples and fix description

* Fix prettier

* Change POST to PUT for register per azure api guidelines

* Return dataRegistry in register, update, and patch

* Fix metadata naming

* Align with LRO guideline

* Add validity check in metadata

* Fix error code

* Add GUID pattern

* Add MapsAccountGeographicResourceLocation

* Fix policheck

* Fix policheck

* PATCH should be sync operation

* Provide more information to customer for LRO operation

* Another example in GetMetadata

* Add example and fix description

* Fix GetOperation

* Remove update API

* Add scope in connection object for extensibility

* Fix ModelValidation

* Change default of linkedReousrce

* Fix issues identified by spectral

* Fix GUID

* Tweak

* Fix review issues

* Fix review issues

* Add required field in data registry model

* Revisit readOnly and required

* Change error model to prevent from breaking change

* Change version from stable to preview

* Fix RequiredReadOnlyProperties error

* Fix path

* Fix udid description

* Fix common error response to align with current Azure Maps

* Use relo

* Add more error codes

* Fix examples

* Fix description

* Fix example

* Fix example

* Remove non-2xx error code. Add nextLink

* Follow LRO guideline

* Add Retry-After integer format

* Rename DataRegistryList field to value

* Fix review comment

* Fix unregister

* Change dataRegistry resource structure

* Tweak

* Tweak

* Tweak description of msiClientId

* Better naming for get data registry example

Co-authored-by: Danny Chin <danielchin@microsoft.com>

* Hotfix for adding timex property to TemporalSpanResolution object in October preview API (#21360)

* adding timex property to TemporalSpan resolutions

* adding timex to specification and dev folders

* fixing a typo

* [Public/Global - Microsoft Azure Attestation Service] Adding September 2022 preview Microsoft Attestation API version (#21028)

* rest api update for tcb baseine

* address pr comments

* update examples

* address pr comments

* add format date-time for tcbrelease date

* remove space

* update format

* update description

* update case for azure

* [Language] Rename DocumentType to HealthcareDocumentType (#21114)

* Update analyzetext.json

DocumentType is only for FHIR which is only healthcare feature related. Is possible to rename to add prefix "healthcare" to the type name

* Update dev/cognitiveservices/data-plane/Language/analyzetext.json

* Fix summarization result definition name for document generation, fix api-version in samples (#21378)

* name allOf

* abs dev

* api version

* literal

* pretty

Co-authored-by: Yuantao Wang <yuantw@microsoft.com>

* [Language] Rename DocumentType to HealthcareDocumentType (#21382)

* Fixing completeness from 2022-09-01-preview (#21204)

* Adds base for updating Microsoft.DataProtection from version preview/2022-09-01-preview to version 2022-10-01-preview

Updates readme

Updates API version in new specs and examples

* Fixing completeness from 2022-09-01-preview

* reverted readme

* resolved prettier

* fixed model validation issues

Co-authored-by: Himanshu Agarwal <himanshu.123j@gmail.com>

* Add examples for operations list api in 2020-03-13, 2020-08-01 (#21318)

* Add blockchain to latest profile

* Add additional types

* add examples to Operations List

* update examples

* fix examples

* prettier fix

Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>

* update readme for python for containerservice (#21365)

* Release cost management microsoft.cost management 2022 10 01 (#21380)

* Adds base for updating Microsoft.CostManagement from version stable/2022-05-01 to version 2022-10-01

* Updates readme

* Updates API version in new specs and examples

* Upgrading Scheduled Actions API to GA (#20964)

* Upgrading Scheduled Actions API to GA

* First commit:- upgrading existing API to GA version

* Upgraded api-version

* Adding Operations API in common-types

* upgrading api-version in Operations example

* referencing common operation def

* removing reference to common Operation as it caused multiple validation
errors

* renaming Operation to CostManagementOperation and referencing Operation from V3 types

* fixing csv

* SavingsPlan GA changes (#20776)

* SavingsPlan GA changes

Fix validation errors

Rebase with shared branch

Correct version in the common-types file

Review comments

Review comments

Refer grain enum in parameter

Correct enum type

Review comments

More improvements

* Fix duplicated model lint diff error

* Use common types v2

* Move to v2 types.json

* Corrected examples

* Sri/release cost management microsoft.cost management 2022 10 01 (#21036)

* First commit - copying cost management and exports API from 2021-10-01

* Upgrading version

* Adding costmanagement.generatedetailedcostreport.json

* fixing validation errors

* fixing validation errors

* fixing validation errors

* reverting parameter order update

* Reverting CostManagementProxyResource and CostManagementResource changes after breaking changes office hours discussion

* ddressing review comments

* Resolving code review comments

* Qualifying Resource and ProxyResource with CostManagement prefix

Please enter the commit message for your changes. Lines starting

* Addressing review comments

* fixing example file names

* fixing linter error

* updated operationResults description

* Reverting breaking changes in exports API

* fixing validation error

* Rebasing with latest

* fixing billingAccountIdParameter definition conflict

* fixing billing profile id parameter conflict

* Addressing code review comment

* fixing model validation errors

* Jatehr/cost management pricesheets (#20958)

* Create costmanagement.pricesheets.json

* Create PricesheetDownload.json

* Create PricesheetDownloadByBillingProfile.json

* Create OperationList.json

* Update readme.md

* Update readme.md

* Update costmanagement.pricesheets.json

* Update costmanagement.pricesheets.json

* Update costmanagement.pricesheets.json

* Update costmanagement.pricesheets.json

* Update PricesheetDownload.json

* Update PricesheetDownloadByBillingProfile.json

* Update costmanagement.pricesheets.json

* Update costmanagement.pricesheets.json

* Update costmanagement.pricesheets.json

* Update costmanagement.pricesheets.json

* Update costmanagement.pricesheets.json

* Delete OperationList.json

* Update costmanagement.pricesheets.json

* Update costmanagement.pricesheets.json

* Update PricesheetDownload.json

* Update PricesheetDownloadByBillingProfile.json

* Update PricesheetDownload.json

* Update PricesheetDownloadByBillingProfile.json

* Update PricesheetDownloadByBillingProfile.json

* Update costmanagement.pricesheets.json

* Update costmanagement.pricesheets.json

* Update costmanagement.pricesheets.json

* resolve Go SDK stuttering issue

* Update costmanagement.pricesheets.json

* Update readme.md

* Update costmanagement.pricesheets.json

* Update costmanagement.pricesheets.json

* Update costmanagement.pricesheets.json

* Update PricesheetDownload.json

* Update PricesheetDownloadByBillingProfile.json

* Delete BenefitRecommendationsByRecommendationId.json

* Update costmanagement.benefits.json

* Update costmanagement.pricesheets.json

* Update costmanagement.pricesheets.json

* Update common-types.json

* Update costmanagement.pricesheets.json

* Update costmanagement.generatedetailedcostreport.json

* Update common-types.json

* Update common-types.json

* Update common-types.json

* Update common-types.json

* Update common-types.json

* resolve Go SDK naming collision

Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>

* Update descriptions (#21364)

* Update descriptions

* Fix lint errors

Co-authored-by: srilatha inavolu <sri@microsoft.com>
Co-authored-by: Jayati Tehri <72947097+jayati-tehri@users.noreply.github.com>
Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>

* Utkarshjain/elastic private repo sync 09 2022 (#20791)

* Base commit 1

* Added version 2022-05-05-preview

* base commit 2

* Added version 2022-07-01-preview

* Updating readme

* Updating default tag

* Fix CI isssues

* Revert "Fix CI isssues"

This reverts commit d41723396e473d7b207ae14ebfc85180dddbf07e.

* Update readme.md

* Update readme.python.md

* fixing version in examples

* Arm change request 1

Co-authored-by: Utkarsh Jain <utkarshjain@microsoft.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* Update specificationRepositoryConfiguration.json (#21388)

* Add autoIoScaling property in MySQL get/update payload (#21039)

Co-authored-by: Bin Xu <bixu@microsoft.com>

* Publish Microsoft.AzureStackHCI 2021-07-01-preview (#18152)

* Adds base for updating Microsoft.AzureStackHCI from version preview/2021-01-01-preview to version 2021-07-01-preview

* Updates readme

* Updates API version in new specs and examples

* Publishing the 2021-07-01-preview API for self-service VM on HCI

* Fix some linter errors

* Update readme to include 2021-07

* Fix errors and run prettier

* Fix readme.go.md

* Fix SSH description

* Set provisioningState as enum

* Use common-types TrackedResource

* Change vmSize type to enum

* Set adminPassword mutability to [create]

* Set osType as Enum

* Set networkType as enum

* Some changes based on feedback

* Remove storagecontainers

* Add MocVirtualMachineStatus object

* Fix provisioningState enum

* Fix networkinterface id description

* Fix provisioningState in all the resources

* Update description of ipConfigurationReferences.ID

* Add typed status object

* Use common-types v3/types.json objects

* Remove 201 response from update apis

* Add enum PrivateIPAllocationMethod

* Add additional provisioningState enum variants

* Fix typo

* Remove MOC reference from object definitions

* Set provisioningState as read only

* Mark Statuses as readOnly

* Change description of routeTable ID

* Put extended location definition in a common file

* Change description of route.ID

* Fix customLocation enum types

* Remove storageContainers examples

StorageContainer is not published in this version

* Fix swagger lintdiff

* Remove 201 response from update examples

fixes RESPONSE_STATUS_CODE_NOT_IN_SPEC [https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/Semantic-and-Model-Violations-Reference.md\#RESPONSE_STATUS_CODE_NOT_IN_SPEC]

* Fix PrettierCheck on common.json

* Set long running operation options final state to location

* Add operations examples

* Fix model validation errors

* Fix git merge

Co-authored-by: Jocelyn Berrendonner [MSFT] <Jocelynb@microsoft.com>

* Add API Doc for Schema Registry Version 2022-10 API (#21170)

* Add Swagger for 2022-10 API

* Update readme file with latest api version

* Prettier fix

* Re-add 2021-10 version in readme

* Address comments on spelling, accept headers

* Address comments

* Address comments, revert breaking change

* Fix typo

* Revert operation id

* Add x-ms-pageable to data list operations

* Change "value" to "itemName" in pageable object

* ✨Fix PrettierCheck

* Address comment on adding x-ms-client-names

* Add standardized content types for Json and custom

* Update examples with new content types

* Change Json to lowercase

* fix conv doc gen (#21398)

Co-authored-by: Yuantao Wang <yuantw@microsoft.com>

* Resource centric query for logs (#18141)

* Resource centric query

* update

* more params

* lint

* prettier

* add Get

* lint

* comments

* lint

* Update specification/operationalinsights/data-plane/Microsoft.OperationalInsights/preview/2021-05-19_Preview/OperationalInsights.json

Co-authored-by: Srikanta <51379715+srnagar@users.noreply.github.com>

* Apply suggestions from code review

* Update specification/operationalinsights/data-plane/Microsoft.OperationalInsights/preview/2021-05-19_Preview/examples/oms-get-resource-centric-example.json

* comments

* Update specification/operationalinsights/data-plane/Microsoft.OperationalInsights/preview/2021-05-19_Preview/OperationalInsights.json

* revert /

* fix resourceId

* x-ms-paths

* lint

* avocado

* fix

* lint

* remove path

* remove x-ms-path

* lint

* Update specification/operationalinsights/data-plane/Microsoft.OperationalInsights/preview/2022-10-27_Preview/OperationalInsights.json

* remove bc

* avocado

* remove breakinc changes

* add format

* missing type object

Co-authored-by: Srikanta <51379715+srnagar@users.noreply.github.com>

* [NetAppFiles] Update example files (#21377)

* Update example files

* lro headers

* lro headers2

* lro headers

* lro subvolumeMetadata

* [Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2022-04-01 (#20821)

* Adds base for updating Microsoft.RecoveryServices from version stable/2022-03-01 to version 2022-04-01

* Updates readme

* Updates API version in new specs and examples

* Update readme.md

* Update TriggerRestore_RestoreDisks_IaasVMRestoreRequest_IdentityBasedRestoreDetails.json

* Update TriggerRestore_ALR_IaasVMRestoreRequest_IdentityBasedRestoreDetails.json

* Update ValidateOperation_RestoreDisk_IdentityBasedRestoreDetails.json

* fix bug when the reference has been exist (#21395)

* Azure Relay - added missing publicNetworkAccess at NetwrokRuleSet level (#20745)

* Update NetworkRuleSets.json Revised

Customer wanted to disable publicNetworkAccess via ARM template. Doc is not updated. I have tested it locally and found that publicNetworkAccess property should be part of NetworkRuleSet
{

      "type": "Microsoft.Relay/namespaces/networkRuleSets",

      "apiVersion": "2021-11-01",

      "name": "samplehyb1232434/default",

      "location": "East US",

      "dependsOn": [

        "[resourceId('Microsoft.Relay/namespaces', 'samplehyb1232434')]"

      ],

      "properties": {

        "defaultAction": "Allow",

        "ipRules": [

          {}

        ],

       "publicNetworkAccess": "Disabled"

      }

    }

* fixed lint and prettier

* updated readme for typescript

* updated description

Co-authored-by: Ajit Maruti Navasare (MINDTREE LIMITED) <v-ajnav@microsoft.com>

* Update QuickStart.md (#21405)

* Update QuickStart.md

* Update QuickStart.md

* [Security] update Readme (#21407)

* update Readme

* Update readme.python.md

* Update readme.python.md

* Update readme.python.md

Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <v-zhenbwei@microsoft.com>

* Added Response Schema for Runbook Operation (#21128)

* Added Response Schema for Runbook Operation

* Update resopnse of Runbook Operation

* Updated example to fix Avacado errors

* Update resopnse of Runbook Operation

* Updated example to fix Avacado errors

* Fix Lint diff errors

* Fix Avacado errors

* Fix Avacado errors

Co-authored-by: Sushil Upadhyay <supadhyay@microsoft.com>

* Remove lro flag (#21410)

* Remove lro flag

* Prettier for mvad swagger

* Adding a how to link for creating dataset with GeoJSON (#21299)

* Adding a how to link for creating dataset with GeoJSON
Spell-correct geojson to GeoJSON

* Updating Dataset List example Version

Co-authored-by: tejitpabari <tejitpabari@microsoft.com>

* Release desktopvirtualization microsoft.desktop virtualization 2022 09 09 (#20683)

* Adds base for updating Microsoft.DesktopVirtualization from version preview/2022-04-01-preview to version 2022-09-09

* Updates readme

* Updates API version in new specs and examples

* remove privateLink references

* add agentUpdate back to hostPool

* remove migrationRequest property

* add paginationHelper to workspace

* update pagination helper to be in query

* fix iconContent examples to be base64

* update byte strings to be actual encoded strings so they pass validation

* Networking 2022-07-01 release (#21400)

* Adds base for updating Microsoft.Network from version stable/2022-05-01 to version 2022-07-01

* Updates readme

* Updates API version in new specs and examples

* Adds a SaaS NVA swagger changes (#20973)

* add saas nva swagger changes

* add saas nva put example

* add arm-id format

* minor change

* address review comments

* add custom words

* Sync python sdk config change from main (#21129)

* 12997638: Custom Block Response support for AppGW WAF (#21113)

* 12997638: Custom Block Response support for AppGW WAF

* 12997638: CustomBlockresponse for Appgw WAF - added example

* 12997638: Custom Block Response for AppGW WAF lint fix

Co-authored-by:…
    anandanthony pushed a commit to anandMicro/azure-rest-api-specs that referenced this pull request Dec 16, 2022
    @dmadiraju1 @anandanthony
    [Workloads - Sap Virtual Instance] (Azure#21284)
    e7bc7f3 
    -Adds SAP software detection feature on a VIS
-Changes were already checked-in to private repo in the PR:
 Azure/azure-rest-api-specs-pr#8871
 The changes were verified. This commit just ports the same
 to the public repo.
    kayousef-zz pushed a commit to kayousef-zz/azure-rest-api-specs that referenced this pull request Dec 21, 2022
    @dmadiraju1 @kayousef
    [Workloads - Sap Virtual Instance] (Azure#21284)
    16f0363 
    -Adds SAP software detection feature on a VIS
-Changes were already checked-in to private repo in the PR:
 Azure/azure-rest-api-specs-pr#8871
 The changes were verified. This commit just ports the same
 to the public repo.
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @lirenhe lirenhe lirenhe approved these changes

    Assignees

    @lirenhe lirenhe

    Labels
    Approved-ModelValidation Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go CI-BreakingChange-Go CI-FixRequiredOnFailure resource-manager RPaaS
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    4 participants
    @dmadiraju1 @lirenhe @tadelesh @AzureRestAPISpecReview