Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Publish private branch 'release-alertsmanagement-Microsoft.AlertsManagement-2021-07-22-preview' #21307

Merged
merged 30 commits into from
Nov 7, 2022
Merged

[Hub Generated] Publish private branch 'release-alertsmanagement-Microsoft.AlertsManagement-2021-07-22-preview' #21307

merged 30 commits into from
Nov 7, 2022

Conversation

moshemal
Copy link
Member

@moshemal moshemal commented Oct 27, 2022 •
edited
Loading

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

moshemal and others added 28 commits August 30, 2022 19:18
@moshemal
Adds base for updating Microsoft.AlertsManagement from version previe…
5f40430 
…w/2021-08-08-preview to version 2021-07-22-preview
@moshemal
Updates readme
5f9ecab
@moshemal
Updates API version in new specs and examples
7a4f050
add prometheusRuleGroup
ae5b188
update readme
d09531b
reorder
7d045ef
add prometheuse to default tag
1a047c7
remove location
0a64135
add example
3081056
update example name
c9420e0
Merge branch 'main' into release-alertsmanagement-Microsoft.AlertsMan…
1e725d3 
…agement-2021-07-22-preview
fix name
69c477a
fix name
72eaa44
remove operations
4d50454
remove patch
40c59e4
remove example
659a9d3
update patch
5928398
fix typo
63e031d
add type
cda6c37
wip
4ab09b7
prettier
e49a39d
add operations api example
797a724
fix operations api example issue
7ea54e0
add prometheus to default tag
1483315
put should be able to return 201 for newly created resources, as well…
b4d1c7e 
… as 200 for updates
remove redundant
2e94ba0
remove provisioning state
a184c96
improve description
e5dc0fd
@raych1
Copy link
Member

raych1 commented Oct 31, 2022

@moshemal , please fix model validation failures.

@jianyexi , can you confirm on the lintDiff errors in this PR? I saw the previous PR in private repo has approved-lintDiff label.

@moshemal moshemal closed this Nov 2, 2022
@moshemal moshemal reopened this Nov 2, 2022
@azure-sdk azure-sdk mentioned this pull request Nov 2, 2022
Closed
@moshemal
Copy link
Member Author

moshemal commented Nov 2, 2022

/azp run unifiedPipeline

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@raych1 raych1 added the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Nov 3, 2022
@raych1 raych1 removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Nov 7, 2022
@openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 7, 2022
@raych1
Copy link
Member

raych1 commented Nov 7, 2022

Hi, can you mark the change log properly, so we know how to review the PR? Also please take a look at your pipeline error. When it's ready to be reviewed by ARM, please add back WaitForARMFeedback label. Thanks.

@zizw123 The private repo original PR had a long review process and was approved: Azure/azure-rest-api-specs-pr#8591

Please merge.

This PR was approved by ARM in private repo review process and no extra review need.

@raych1 raych1 removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review labels Nov 7, 2022
@raych1 raych1 merged commit bf08c36 into main Nov 7, 2022
@raych1 raych1 deleted the published/moshemal/azure-rest-api-specs-pr/release-alertsmanagement-Microsoft.AlertsManagement-2021-07-22-preview branch November 7, 2022 09:06
@openapi-pipeline-app openapi-pipeline-app bot added the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Nov 7, 2022
This was referenced Nov 7, 2022
Merged
Closed
Closed
Closed
ghost pushed a commit to Azure/azure-resource-manager-schemas that referenced this pull request Nov 7, 2022
[ReleasePR alertsmanagement] [Hub Generated] Publish private branch '…
e412fb4 
…release-alertsmanagement-Microsoft.AlertsManagement-2021-07-22-preview' (#2652)

Create to sync Azure/azure-rest-api-specs#21307
[ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...azure-sdk:sdkAuto/alertsmanagement?expand=1)
@azure-sdk azure-sdk mentioned this pull request Nov 7, 2022
Closed
anandanthony pushed a commit to anandMicro/azure-rest-api-specs that referenced this pull request Dec 16, 2022
@moshemal @anandanthony
[Hub Generated] Publish private branch 'release-alertsmanagement-Micr…
793048d 
…osoft.AlertsManagement-2021-07-22-preview' (Azure#21307)

* Adds base for updating Microsoft.AlertsManagement from version preview/2021-08-08-preview to version 2021-07-22-preview

* Updates readme

* Updates API version in new specs and examples

* add prometheusRuleGroup

* update readme

* reorder

* add prometheuse to default tag

* remove location

* add example

* update example name

* fix name

* fix name

* remove operations

* remove patch

* remove example

* update patch

* fix typo

* add type

* wip

* prettier

* add operations api example

* fix operations api example issue

* add prometheus to default tag

* put should be able to return 201 for newly created resources, as well as 200 for updates

* remove redundant

* remove provisioning state

* improve description

* add 201 to create or update example

* change api version

Co-authored-by: Moshe Malka <momalka@microsoft.com>
kayousef-zz pushed a commit to kayousef-zz/azure-rest-api-specs that referenced this pull request Dec 21, 2022
@moshemal @kayousef
[Hub Generated] Publish private branch 'release-alertsmanagement-Micr…
faafeaa 
…osoft.AlertsManagement-2021-07-22-preview' (Azure#21307)

* Adds base for updating Microsoft.AlertsManagement from version preview/2021-08-08-preview to version 2021-07-22-preview

* Updates readme

* Updates API version in new specs and examples

* add prometheusRuleGroup

* update readme

* reorder

* add prometheuse to default tag

* remove location

* add example

* update example name

* fix name

* fix name

* remove operations

* remove patch

* remove example

* update patch

* fix typo

* add type

* wip

* prettier

* add operations api example

* fix operations api example issue

* add prometheus to default tag

* put should be able to return 201 for newly created resources, as well as 200 for updates

* remove redundant

* remove provisioning state

* improve description

* add 201 to create or update example

* change api version

Co-authored-by: Moshe Malka <momalka@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raych1 raych1 raych1 approved these changes

@ofirmanor ofirmanor Awaiting requested review from ofirmanor

@orieldar orieldar Awaiting requested review from orieldar

Assignees

@raych1 raych1

Labels
Alerts Management Approved-LintDiff ARMReview CI-BreakingChange-Go CI-FixRequiredOnFailure new-api-version resource-manager Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@moshemal @zizw123 @raych1 @AzureRestAPISpecReview @jianyexi