Adding various operations and examples for Budget APIs #2144

asarkar84 · 2017-12-13T03:29:45Z

Adding various operations and examples for Budget APIs

Operation to Get the List of Budgets for a subscription.
Operation to Get the specific budget by name for a subscription.
Operation to Create or Update a budget.
Operation to Delete an existing budget.
Examples for Create, Update, Delete, Get and List budgets.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Adding various operations for Budget APIs

…ined roles. Updated the contact roles to be a free text field to support user defined roles.

fearthecowboy

Do not move the file common-types file; please reference it where it is.

ie, do not rename or copy the file :

/specification/common-types/resource-management/v1/types.json

fearthecowboy · 2017-12-13T21:46:44Z

...ation/consumption/resource-manager/Microsoft.Consumption/2017-12-30-preview/consumption.json

+  "swagger": "2.0",
+  "info": {
+    "version": "2017-12-30-preview",
+    "title": "ConsumptionManagementClient",


title should just be "Consumption Management"

I think last time when it was changed @lmazuel Suggested it this way due to the requirement on the SDK to generate the client name correctly.

@fearthecowboy Again, this is a C# behavior. Please move this "auto Client suffixing" to the modeler if you wish this behavior for everybody. In the meantime, changing that will break Python (at least, but probably not only)

@lmazuel Right!

@sandeepnl - leave it for now, I gotta go fix the modeler/input first, and I'll have add a warning of the superflous suffix, so that in the future we can slowly clean them up.

Sure! We will leave it as is. Thanks!

fearthecowboy · 2017-12-13T21:50:36Z

...ation/consumption/resource-manager/Microsoft.Consumption/2017-12-30-preview/consumption.json

+        "tags": [
+          "Budget"
+        ],
+        "operationId": "Budget_Get",


the prefix on operationId is generally plural; so should be budgets_...

fearthecowboy · 2017-12-13T21:52:54Z

...ation/consumption/resource-manager/Microsoft.Consumption/2017-12-30-preview/consumption.json

+        }
+      }
+    },
+    "Resource": {


Resource should be referenced from the common-types file, not copied

fearthecowboy · 2017-12-13T22:04:30Z

...ation/consumption/resource-manager/Microsoft.Consumption/2017-12-30-preview/consumption.json

+          }
+        },
+        "x-ms-pageable": {
+          "nextLinkName": "null"


So your nextLink Property Name is "null" ?

hint: if you have { "null", or "false", or "true" } in quotes, that's usually a bad thing 😆

fearthecowboy

I've added a few bits of feedback; I'll add more in a bit...

fearthecowboy · 2017-12-13T22:17:01Z

Adding @ravbhatnagar for ARM review of new APIS

Updated with review comments.

Added required fields

Incorporated ARM review comments

Added min and max lengths for EmailContacts and Notifications

Renamed to ProxyResource

asarkar84 · 2017-12-14T05:08:40Z

I could not find the eTag property for ProxyResource in common-types. Shall I go ahead and add the eTag property there and refer it in this file?

fearthecowboy · 2017-12-14T18:29:07Z

I could not find the eTag property for ProxyResource in common-types. Shall I go ahead and add the eTag property there and refer it in this file?

I just had this same discovery with another RP this morning.

For today, can you just add the etag property into your resource model(s) ; I think we have to have a second version of some of these (for older RPs that don't have all the fields).

We'll circle back once I can go bang on a few doors.

sandeepnl

Let us rename this to "Budget-PREVIEW" as we want this name to show up in the Rest Documentation.

sandeepnl · 2017-12-14T00:14:29Z

...ation/consumption/resource-manager/Microsoft.Consumption/2017-12-30-preview/consumption.json

+    "/subscriptions/{subscriptionId}/providers/Microsoft.Consumption/budgets": {
+      "get": {
+        "tags": [
+          "Budgets"


Let us rename this to "Budget-PREVIEW" as we want this name to show up in the Rest Documentation.
@fearthecowboy Please comment if this is not recommended as per the standards

Sure! I am going to rename the tag to Budgets-Preview @fearthecowboy Please let me know if this is OK.

fearthecowboy · 2017-12-14T20:56:09Z

You have some errors in validation:
https://travis-ci.org/Azure/azure-rest-api-specs/jobs/316251192
https://travis-ci.org/Azure/azure-rest-api-specs/jobs/316251191

Notably;
eTag vs etag

fearthecowboy · 2017-12-14T21:07:42Z

Rather than have ProxyResource , just add an eTag property at https://github.com/asarkar84/azure-rest-api-specs/blob/79f3e9378bc86d6dc7cb338d983cc5db3a202e96/specification/consumption/resource-manager/Microsoft.Consumption/2017-12-30-preview/consumption.json#L260 and have Budget reference Resource from the common file?

Added Preview in Tag name to specify the Preview version

Incorporated review comments

Fixed validation errors

azuresdkciprbot · 2017-12-14T22:27:14Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/consumption/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

Updated the example for CreateOrUpdateBudget

azuresdkciprbot · 2017-12-15T00:31:04Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/consumption/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

AutorestCI · 2017-12-15T14:35:23Z

Azure/azure-sdk-for-ruby#1190

AutorestCI · 2017-12-15T14:35:41Z

Azure/azure-sdk-for-python#1717

* update comment and fixed enum typo * fixed indentation * revert indentation change * fixed indentation Co-authored-by: Feng Wu <xuefwu@microsoft.com>

Adding various operations for Budget APIs

11f6706

Adding various operations for Budget APIs

azuresdkci assigned fearthecowboy Dec 13, 2017

asarkar84 added 2 commits December 12, 2017 19:36

Updated the contact roles to be a free text field to support user def…

84bcad0

…ined roles. Updated the contact roles to be a free text field to support user defined roles.

Updated descriptions based on review comments.

fe7e5fc

fearthecowboy suggested changes Dec 13, 2017

View reviewed changes

fearthecowboy reviewed Dec 13, 2017

View reviewed changes

fearthecowboy suggested changes Dec 13, 2017

View reviewed changes

fearthecowboy assigned ravbhatnagar Dec 13, 2017

asarkar84 added 5 commits December 13, 2017 15:49

Updated with review comments.

bed8c81

Updated with review comments.

Added required fields

5993ec2

Added required fields

Incorporated ARM review comments

d6efe0c

Incorporated ARM review comments

Added min and max lengths for EmailContacts and Notifications

5fc0a8e

Added min and max lengths for EmailContacts and Notifications

Renamed to ProxyResource

79f3e93

Renamed to ProxyResource

sandeepnl suggested changes Dec 14, 2017

View reviewed changes

asarkar84 added 3 commits December 14, 2017 13:09

Added Preview in Tag name to specify the Preview version

eba971b

Added Preview in Tag name to specify the Preview version

Incorporated review comments

f2bee77

Incorporated review comments

Fixed validation errors

0786df8

Fixed validation errors

sandeepnl approved these changes Dec 15, 2017

View reviewed changes

Updated the example for CreateOrUpdateBudget

0c5a82f

Updated the example for CreateOrUpdateBudget

fearthecowboy approved these changes Dec 15, 2017

View reviewed changes

fearthecowboy merged commit 61f06ea into Azure:current Dec 15, 2017

AutorestCI mentioned this pull request Dec 15, 2017

Automatic PR from RestAPI-PR2144 Azure/azure-sdk-for-ruby#1190

Closed

AutorestCI mentioned this pull request Dec 15, 2017

Automatic PR from RestAPI-PR2144 Azure/azure-sdk-for-python#1717

Closed

bgsky mentioned this pull request Jan 23, 2018

Create a new version of consumption, with preview budget merge with usage detail and reservation #2289

Merged

10 tasks

mccleanp pushed a commit that referenced this pull request Mar 23, 2022

update comment and fixed enum typo (#2144)

3828621

* update comment and fixed enum typo * fixed indentation * revert indentation change * fixed indentation Co-authored-by: Feng Wu <xuefwu@microsoft.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding various operations and examples for Budget APIs #2144

Adding various operations and examples for Budget APIs #2144

asarkar84 commented Dec 13, 2017 •

edited

Loading

fearthecowboy left a comment

fearthecowboy Dec 13, 2017

sandeepnl Dec 13, 2017

lmazuel Dec 14, 2017

fearthecowboy Dec 14, 2017 •

edited

Loading

asarkar84 Dec 14, 2017

fearthecowboy Dec 13, 2017

fearthecowboy Dec 13, 2017

fearthecowboy Dec 13, 2017 •

edited

Loading

fearthecowboy left a comment

fearthecowboy commented Dec 13, 2017

asarkar84 commented Dec 14, 2017 •

edited

Loading

fearthecowboy commented Dec 14, 2017

sandeepnl left a comment

sandeepnl Dec 14, 2017

asarkar84 Dec 14, 2017

fearthecowboy commented Dec 14, 2017

fearthecowboy commented Dec 14, 2017

azuresdkciprbot commented Dec 14, 2017

azuresdkciprbot commented Dec 15, 2017

AutorestCI commented Dec 15, 2017

AutorestCI commented Dec 15, 2017

Adding various operations and examples for Budget APIs #2144

Adding various operations and examples for Budget APIs #2144

Conversation

asarkar84 commented Dec 13, 2017 • edited Loading

PR information

Quality of Swagger

fearthecowboy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fearthecowboy Dec 14, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fearthecowboy Dec 13, 2017 • edited Loading

Choose a reason for hiding this comment

fearthecowboy left a comment

Choose a reason for hiding this comment

fearthecowboy commented Dec 13, 2017

asarkar84 commented Dec 14, 2017 • edited Loading

fearthecowboy commented Dec 14, 2017

sandeepnl left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fearthecowboy commented Dec 14, 2017

fearthecowboy commented Dec 14, 2017

azuresdkciprbot commented Dec 14, 2017

azuresdkciprbot commented Dec 15, 2017

AutorestCI commented Dec 15, 2017

AutorestCI commented Dec 15, 2017

asarkar84 commented Dec 13, 2017 •

edited

Loading

fearthecowboy Dec 14, 2017 •

edited

Loading

fearthecowboy Dec 13, 2017 •

edited

Loading

asarkar84 commented Dec 14, 2017 •

edited

Loading