Fix for Swagger Correctness issue in DataProtection 2022-10-01-preview version #21452

Charan000 · 2022-11-07T09:32:29Z

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2022-11-07T09:32:33Z

Hi, @Charan000 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2022-11-07T09:32:38Z

Swagger Validation Report

️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.1)]	new version	base version
dataprotection.json	2022-10-01-preview(fe8518a)	2022-10-01-preview(main)
dataprotection.json	2022-05-01(fe8518a)	2022-05-01(main)

Rule	Message
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.DataProtection/preview/2022-10-01-preview/dataprotection.json#L4842:9 Old: Microsoft.DataProtection/preview/2022-10-01-preview/dataprotection.json#L4842:9
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.DataProtection/stable/2022-05-01/dataprotection.json#L4324:9 Old: Microsoft.DataProtection/stable/2022-05-01/dataprotection.json#L4324:9

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v1.13.0)	new version	base version
package-2022-10-preview	package-2022-10-preview(fe8518a)	package-2022-10-preview(main)
package-2022-05	package-2022-05(fe8518a)	package-2022-05(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` R4037 - MissingTypeObject	The schema 'AzureBackupFindRestorableTimeRangesRequestResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataProtection/preview/2022-10-01-preview/dataprotection.json#L4004
`❌` R4037 - MissingTypeObject	The schema 'AzureBackupFindRestorableTimeRangesResponseResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataProtection/preview/2022-10-01-preview/dataprotection.json#L4035
`❌` R4037 - MissingTypeObject	The schema 'AzureBackupRecoveryPointResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataProtection/preview/2022-10-01-preview/dataprotection.json#L4296
`❌` R4037 - MissingTypeObject	The schema 'BackupInstanceResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataProtection/preview/2022-10-01-preview/dataprotection.json#L4686
`❌` R4037 - MissingTypeObject	The schema 'BackupVaultResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataProtection/preview/2022-10-01-preview/dataprotection.json#L4854
`❌` R4037 - MissingTypeObject	The schema 'BaseBackupPolicyResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataProtection/preview/2022-10-01-preview/dataprotection.json#L4914
`❌` R4037 - MissingTypeObject	The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataProtection/preview/2022-10-01-preview/dataprotection.json#L5114
`❌` R4037 - MissingTypeObject	The schema 'Error' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataProtection/preview/2022-10-01-preview/dataprotection.json#L5726
`❌` R4037 - MissingTypeObject	The schema 'ErrorAdditionalInfo' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataProtection/preview/2022-10-01-preview/dataprotection.json#L5764
`❌` R4037 - MissingTypeObject	The schema 'additionalDetails' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataProtection/preview/2022-10-01-preview/dataprotection.json#L5986
`❌` R4037 - MissingTypeObject	The schema 'additionalDetails' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataProtection/preview/2022-10-01-preview/dataprotection.json#L6034
`❌` R4037 - MissingTypeObject	The schema 'AzureBackupFindRestorableTimeRangesRequestResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataProtection/stable/2022-05-01/dataprotection.json#L3549
`❌` R4037 - MissingTypeObject	The schema 'AzureBackupFindRestorableTimeRangesResponseResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataProtection/stable/2022-05-01/dataprotection.json#L3580
`❌` R4037 - MissingTypeObject	The schema 'AzureBackupRecoveryPointResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataProtection/stable/2022-05-01/dataprotection.json#L3841
`❌` R4037 - MissingTypeObject	The schema 'BackupInstanceResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataProtection/stable/2022-05-01/dataprotection.json#L4172
`❌` R4037 - MissingTypeObject	The schema 'BackupVaultResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataProtection/stable/2022-05-01/dataprotection.json#L4336
`❌` R4037 - MissingTypeObject	The schema 'BaseBackupPolicyResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataProtection/stable/2022-05-01/dataprotection.json#L4396
`❌` R4037 - MissingTypeObject	The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataProtection/stable/2022-05-01/dataprotection.json#L4596
`❌` R4037 - MissingTypeObject	The schema 'Error' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataProtection/stable/2022-05-01/dataprotection.json#L5095
`❌` R4037 - MissingTypeObject	The schema 'ErrorAdditionalInfo' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataProtection/stable/2022-05-01/dataprotection.json#L5133
`❌` R4037 - MissingTypeObject	The schema 'additionalDetails' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataProtection/stable/2022-05-01/dataprotection.json#L5355
`❌` R4037 - MissingTypeObject	The schema 'additionalDetails' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataProtection/stable/2022-05-01/dataprotection.json#L5403
`❌` R4039 - ParametersOrder	The parameters:operationId,location should be kept in the same order as they present in the path. Location: Microsoft.DataProtection/preview/2022-10-01-preview/dataprotection.json#L64
`❌` R4039 - ParametersOrder	The parameters:operationId,location should be kept in the same order as they present in the path. Location: Microsoft.DataProtection/stable/2022-05-01/dataprotection.json#L64
⚠️ R1001 - OperationIdNounVerb	Per the Noun_Verb convention for Operation Ids, the noun 'BackupInstances' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.DataProtection/preview/2022-10-01-preview/dataprotection.json#L1417
⚠️ R1001 - OperationIdNounVerb	Per the Noun_Verb convention for Operation Ids, the noun 'BackupInstances' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.DataProtection/preview/2022-10-01-preview/dataprotection.json#L2035
⚠️ R1001 - OperationIdNounVerb	Per the Noun_Verb convention for Operation Ids, the noun 'ResourceGuards' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.DataProtection/preview/2022-10-01-preview/dataprotection.json#L2968
⚠️ R1001 - OperationIdNounVerb	Per the Noun_Verb convention for Operation Ids, the noun 'ResourceGuards' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.DataProtection/preview/2022-10-01-preview/dataprotection.json#L3283
⚠️ R1001 - OperationIdNounVerb	Per the Noun_Verb convention for Operation Ids, the noun 'BackupInstances' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.DataProtection/stable/2022-05-01/dataprotection.json#L1375
⚠️ R1001 - OperationIdNounVerb	Per the Noun_Verb convention for Operation Ids, the noun 'BackupInstances' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.DataProtection/stable/2022-05-01/dataprotection.json#L1993

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

API Test is not triggered due to precheck failure. Check pipeline log for details.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-11-07T09:32:39Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed [Logs]Release - Generate from 20cdbec. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
warn	File azure-sdk-for-net_tmp/initOutput.json not found to read
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:611
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m 611 | �[0m         �[96mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m     | �[91m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91m�[96m     | �[91mFailed to build sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m

❌Azure.ResourceManager.DataProtectionBackup [View full logs] [Release SDK Changes] Breaking Change Detected
- Azure.ResourceManager.DataProtectionBackup.1.1.0-alpha.20221110.1.nupkg
```
info	[Changelog] Breaking Changes:
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 20cdbec. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.2 -> 9.1.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.1.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.1.1` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-dataprotection [View full logs] [Release SDK Changes]
- azure_mgmt_dataprotection-1.0.0b1-py3-none-any.whl
- azure-mgmt-dataprotection-1.0.0b1.zip
```
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Model PolicyParameters has a new parameter backup_datasource_parameters_list
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 20cdbec. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
warn	No file changes detected after generation
warn	No package detected after generation

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 20cdbec. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/dataprotection/armdataprotection [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `ResourceGuard.ProvisioningState` has been changed from `*ProvisioningState` to `*ResourceGuardProvisioningState`
info	[Changelog] - Struct `CloudError` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `ImmutabilityStateDisabled`
info	[Changelog] - New const `ImmutabilityStateLocked`
info	[Changelog] - New const `PersistentVolumeRestoreModeRestoreWithVolumeData`
info	[Changelog] - New const `ImmutabilityStateUnlocked`
info	[Changelog] - New const `PersistentVolumeRestoreModeRestoreWithoutVolumeData`
info	[Changelog] - New const `ExistingResourcePolicyPatch`
info	[Changelog] - New const `ResourceGuardProvisioningStateFailed`
info	[Changelog] - New const `ResourceGuardProvisioningStateUnknown`
info	[Changelog] - New const `SoftDeleteStateOn`
info	[Changelog] - New const `ResourceGuardProvisioningStateSucceeded`
info	[Changelog] - New const `StorageSettingTypesZoneRedundant`
info	[Changelog] - New const `SoftDeleteStateAlwaysOn`
info	[Changelog] - New const `ResourceGuardProvisioningStateUpdating`
info	[Changelog] - New const `SoftDeleteStateOff`
info	[Changelog] - New const `ExistingResourcePolicySkip`
info	[Changelog] - New const `ResourceGuardProvisioningStateProvisioning`
info	[Changelog] - New type alias `PersistentVolumeRestoreMode`
info	[Changelog] - New type alias `SoftDeleteState`
info	[Changelog] - New type alias `ExistingResourcePolicy`
info	[Changelog] - New type alias `ResourceGuardProvisioningState`
info	[Changelog] - New type alias `ImmutabilityState`
info	[Changelog] - New function `*DppResourceGuardProxyClient.NewListPager(string, string, *DppResourceGuardProxyClientListOptions) *runtime.Pager[DppResourceGuardProxyClientListResponse]`
info	[Changelog] - New function `NewDppResourceGuardProxyClient(string, azcore.TokenCredential, *arm.ClientOptions) (*DppResourceGuardProxyClient, error)`
info	[Changelog] - New function `PossibleSoftDeleteStateValues() []SoftDeleteState`
info	[Changelog] - New function `*DppResourceGuardProxyClient.Delete(context.Context, string, string, string, *DppResourceGuardProxyClientDeleteOptions) (DppResourceGuardProxyClientDeleteResponse, error)`
info	[Changelog] - New function `*DeletedBackupInstancesClient.NewListPager(string, string, *DeletedBackupInstancesClientListOptions) *runtime.Pager[DeletedBackupInstancesClientListResponse]`
info	[Changelog] - New function `PossibleExistingResourcePolicyValues() []ExistingResourcePolicy`
info	[Changelog] - New function `*DppResourceGuardProxyClient.Get(context.Context, string, string, string, *DppResourceGuardProxyClientGetOptions) (DppResourceGuardProxyClientGetResponse, error)`
info	[Changelog] - New function `*BackupInstancesExtensionRoutingClient.NewListPager(string, *BackupInstancesExtensionRoutingClientListOptions) *runtime.Pager[BackupInstancesExtensionRoutingClientListResponse]`
info	[Changelog] - New function `*KubernetesClusterBackupDatasourceParameters.GetBackupDatasourceParameters() *BackupDatasourceParameters`
info	[Changelog] - New function `*DeletedBackupInstancesClient.Get(context.Context, string, string, string, *DeletedBackupInstancesClientGetOptions) (DeletedBackupInstancesClientGetResponse, error)`
info	[Changelog] - New function `NewDeletedBackupInstancesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*DeletedBackupInstancesClient, error)`
info	[Changelog] - New function `NewBackupInstancesExtensionRoutingClient(azcore.TokenCredential, *arm.ClientOptions) (*BackupInstancesExtensionRoutingClient, error)`
info	[Changelog] - New function `*BackupDatasourceParameters.GetBackupDatasourceParameters() *BackupDatasourceParameters`
info	[Changelog] - New function `*DppResourceGuardProxyClient.Put(context.Context, string, string, string, ResourceGuardProxyBaseResource, *DppResourceGuardProxyClientPutOptions) (DppResourceGuardProxyClientPutResponse, error)`
info	[Changelog] - New function `*DeletedBackupInstancesClient.BeginUndelete(context.Context, string, string, string, *DeletedBackupInstancesClientBeginUndeleteOptions) (*runtime.Poller[DeletedBackupInstancesClientUndeleteResponse], error)`
info	[Changelog] - New function `PossiblePersistentVolumeRestoreModeValues() []PersistentVolumeRestoreMode`
info	[Changelog] - New function `*DppResourceGuardProxyClient.UnlockDelete(context.Context, string, string, string, UnlockDeleteRequest, *DppResourceGuardProxyClientUnlockDeleteOptions) (DppResourceGuardProxyClientUnlockDeleteResponse, error)`
info	[Changelog] - New function `PossibleImmutabilityStateValues() []ImmutabilityState`
info	[Changelog] - New function `PossibleResourceGuardProvisioningStateValues() []ResourceGuardProvisioningState`
info	[Changelog] - New function `*KubernetesClusterRestoreCriteria.GetItemLevelRestoreCriteria() *ItemLevelRestoreCriteria`
info	[Changelog] - New struct `BackupDatasourceParameters`
info	[Changelog] - New struct `BackupInstancesExtensionRoutingClient`
info	[Changelog] - New struct `BackupInstancesExtensionRoutingClientListOptions`
info	[Changelog] - New struct `BackupInstancesExtensionRoutingClientListResponse`
info	[Changelog] - New struct `DeletedBackupInstance`
info	[Changelog] - New struct `DeletedBackupInstanceResource`
info	[Changelog] - New struct `DeletedBackupInstanceResourceList`
info	[Changelog] - New struct `DeletedBackupInstancesClient`
info	[Changelog] - New struct `DeletedBackupInstancesClientBeginUndeleteOptions`
info	[Changelog] - New struct `DeletedBackupInstancesClientGetOptions`
info	[Changelog] - New struct `DeletedBackupInstancesClientGetResponse`
info	[Changelog] - New struct `DeletedBackupInstancesClientListOptions`
info	[Changelog] - New struct `DeletedBackupInstancesClientListResponse`
info	[Changelog] - New struct `DeletedBackupInstancesClientUndeleteResponse`
info	[Changelog] - New struct `DeletionInfo`
info	[Changelog] - New struct `DppProxyResource`
info	[Changelog] - New struct `DppResourceGuardProxyClient`
info	[Changelog] - New struct `DppResourceGuardProxyClientDeleteOptions`
info	[Changelog] - New struct `DppResourceGuardProxyClientDeleteResponse`
info	[Changelog] - New struct `DppResourceGuardProxyClientGetOptions`
info	[Changelog] - New struct `DppResourceGuardProxyClientGetResponse`
info	[Changelog] - New struct `DppResourceGuardProxyClientListOptions`
info	[Changelog] - New struct `DppResourceGuardProxyClientListResponse`
info	[Changelog] - New struct `DppResourceGuardProxyClientPutOptions`
info	[Changelog] - New struct `DppResourceGuardProxyClientPutResponse`
info	[Changelog] - New struct `DppResourceGuardProxyClientUnlockDeleteOptions`
info	[Changelog] - New struct `DppResourceGuardProxyClientUnlockDeleteResponse`
info	[Changelog] - New struct `ImmutabilitySettings`
info	[Changelog] - New struct `KubernetesClusterBackupDatasourceParameters`
info	[Changelog] - New struct `KubernetesClusterRestoreCriteria`
info	[Changelog] - New struct `ResourceGuardOperationDetail`
info	[Changelog] - New struct `ResourceGuardProxyBase`
info	[Changelog] - New struct `ResourceGuardProxyBaseResource`
info	[Changelog] - New struct `ResourceGuardProxyBaseResourceList`
info	[Changelog] - New struct `SecuritySettings`
info	[Changelog] - New struct `SoftDeleteSettings`
info	[Changelog] - New struct `UnlockDeleteRequest`
info	[Changelog] - New struct `UnlockDeleteResponse`
info	[Changelog] - New field `BackupDatasourceParametersList` in struct `PolicyParameters`
info	[Changelog] - New field `SecuritySettings` in struct `PatchBackupVaultInput`
info	[Changelog] - New field `SecuritySettings` in struct `BackupVault`
info	[Changelog] - New field `IsVaultProtectedByResourceGuard` in struct `BackupVault`
info	[Changelog] - New field `Tags` in struct `BackupInstanceResource`
info	[Changelog]
info	[Changelog] Total 3 breaking change(s), 122 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 20cdbec. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-dataprotectionplatform [View full logs] [Release SDK Changes]
- azure-arm-dataprotectionplatform-1.0.0-beta.1.tgz
```
info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
```

️❌ azure-powershell failed [Detail]

❌Failed [Logs]Release - Generate from 20cdbec. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

❌Az.dataprotection [View full logs] [Release SDK Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-11-07T09:32:39Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/dataprotection/armdataprotection	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
Python	track2_azure-mgmt-dataprotection	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
JavaScript	@azure/arm-dataprotectionplatform	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
.Net	Azure.ResourceManager.DataProtectionBackup	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

openapi-workflow-bot · 2022-11-07T09:38:12Z

Hi @Charan000, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

…w version (Azure#21452) * manual swagger fix * adding change to newer version * swagger fix * Empty-Commit * adding isVaultProtectedByResourceGuard in backupVault * swagger fix * adding readOnly flag for IsVaultProtectedByResourceGuard property * adding the fix for 2022-05-01 Co-authored-by: Charan MVS <smadu@microsoft.com>

Charan MVS and others added 16 commits May 4, 2022 11:32

manual swagger fix

a4b0758

Merge branch 'Azure:main' into main

143b773

adding change to newer version

d2bdfd9

swagger fix

65cc20c

Empty-Commit

2783869

Merge branch 'Azure:main' into main

b1879e0

Merge branch 'Azure:main' into main

91b7c6b

adding isVaultProtectedByResourceGuard in backupVault

bc369f1

Merge branch 'Azure:main' into main

b808c40

Merge branch 'Azure:main' into main

eafd042

Merge branch 'Azure:main' into main

09f5db5

Merge branch 'Azure:main' into main

fbe462c

swagger fix

b977c76

Merge branch 'Azure:main' into main

2f7a339

Merge branch 'Azure:main' into main

c3a36f7

adding readOnly flag for IsVaultProtectedByResourceGuard property

b4a3ff4

openapi-assignment-bot bot assigned xiaoxuqi-ms Nov 7, 2022

AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required resource-manager labels Nov 7, 2022

xiaoxuqi-ms approved these changes Nov 8, 2022

View reviewed changes

adding the fix for 2022-05-01

fe8518a

mikekistler added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Nov 9, 2022

xiaoxuqi-ms approved these changes Nov 10, 2022

View reviewed changes

xiaoxuqi-ms merged commit 20cdbec into Azure:main Nov 10, 2022

azure-sdk mentioned this pull request Nov 10, 2022

[ReleasePR sdk/resourcemanager/dataprotection/armdataprotection] Dev dataprotection microsoft.data protection 2023 08 01 Azure/azure-sdk-for-go#19017

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Nov 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix for Swagger Correctness issue in DataProtection 2022-10-01-preview version #21452

Fix for Swagger Correctness issue in DataProtection 2022-10-01-preview version #21452

Charan000 commented Nov 7, 2022 •

edited by openapi-workflow-bot bot

Loading

openapi-workflow-bot bot commented Nov 7, 2022

openapi-pipeline-app bot commented Nov 7, 2022 •

edited

Loading

openapi-pipeline-app bot commented Nov 7, 2022 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Nov 7, 2022 •

edited

Loading

openapi-workflow-bot bot commented Nov 7, 2022

Fix for Swagger Correctness issue in DataProtection 2022-10-01-preview version #21452

Fix for Swagger Correctness issue in DataProtection 2022-10-01-preview version #21452

Conversation

Charan000 commented Nov 7, 2022 • edited by openapi-workflow-bot bot Loading

ARM API Information (Control Plane)

Changelog

Contribution checklist (MS Employees Only):

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Nov 7, 2022

openapi-pipeline-app bot commented Nov 7, 2022 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Nov 7, 2022 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Nov 7, 2022 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Nov 7, 2022

Charan000 commented Nov 7, 2022 •

edited by openapi-workflow-bot bot

Loading

openapi-pipeline-app bot commented Nov 7, 2022 •

edited

Loading

openapi-pipeline-app bot commented Nov 7, 2022 •

edited

Loading

openapi-pipeline-app bot commented Nov 7, 2022 •

edited

Loading