Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AppState property as we decided to postpone it #21484

Merged
merged 9 commits into from
Nov 10, 2022
Merged

Remove AppState property as we decided to postpone it #21484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2c8c41c
Remove AppState property as we decided to postpone it
ruslany Nov 8, 2022
e2fcbdd
Fix swagger issues
ruslany Nov 9, 2022
39d9d70
fix swagger issues
ruslany Nov 9, 2022
f3631e9
More swagger fixes
ruslany Nov 9, 2022
5dc43bf
Swagger fixes
ruslany Nov 9, 2022
92fed37
additional fix
ruslany Nov 9, 2022
09db6b2
Even more swagger fixes - where does this come from?
ruslany Nov 9, 2022
588047b
Fix other swagger issues
ruslany Nov 9, 2022
483f876
fixing remaining swagger issues
ruslany Nov 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...tion/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/CommonDefinitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,8 @@
"maxReplicas": {
"format": "int32",
"description": "Optional. Maximum number of container replicas. Defaults to 10 if not set.",
"type": "integer"
"type": "integer",
"default": 10
},
"rules": {
"description": "Scaling rules.",
Expand Down
11 changes: 8 additions & 3 deletions ...fication/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/ContainerApps.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,6 +482,7 @@
"Single"
],
"type": "string",
"default": "Single",
"x-ms-enum": {
"name": "ActiveRevisionsMode",
"modelAsString": true
Expand Down Expand Up @@ -591,7 +592,7 @@
"$ref": "./CommonDefinitions.json#/definitions/Template",
"description": "Container App versioned application definition."
},
"outboundIPAddresses": {
"outboundIpAddresses": {
"description": "Outbound IP Addresses for container app.",
"type": "array",
"items": {
Expand Down Expand Up @@ -636,7 +637,8 @@
"properties": {
"enabled": {
"description": "Boolean indicating if the Dapr side car is enabled",
"type": "boolean"
"type": "boolean",
"default": false
},
"appId": {
"description": "Dapr application identifier",
Expand All @@ -649,6 +651,7 @@
"grpc"
],
"type": "string",
"default": "http",
"x-ms-enum": {
"name": "appProtocol",
"modelAsString": true
Expand Down Expand Up @@ -722,6 +725,7 @@
"tcp"
],
"type": "string",
"default": "auto",
"x-ms-enum": {
"name": "IngressTransportMethod",
"modelAsString": true
Expand Down Expand Up @@ -749,7 +753,8 @@
},
"allowInsecure": {
"description": "Bool indicating if HTTP connections to is allowed. If set to false HTTP connections are automatically redirected to HTTPS connections",
"type": "boolean"
"type": "boolean",
"default": false
},
"ipSecurityRestrictions": {
"description": "Rules to restrict incoming IP address.",
Expand Down
2 changes: 1 addition & 1 deletion ...Microsoft.App/preview/2022-11-01-preview/examples/ManagedEnvironments_CreateOrUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"customDomainConfiguration": {
"dnsSuffix": "www.my-name.com",
"certificateValue": "Y2VydA==",
"certificatePassword": "private key password"
"certificatePassword": "Y2VydA=="
},
"workloadProfiles": [
{
Expand Down
2 changes: 1 addition & 1 deletion ...app/resource-manager/Microsoft.App/preview/2022-11-01-preview/examples/Replicas_List.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"resourceGroupName": "workerapps-rg-xj",
"containerAppName": "myapp",
"revisionName": "myapp--0wlqy09",
"api-version": "2021-02-01"
"api-version": "2022-11-01-preview"
},
"responses": {
"200": {
Expand Down
2 changes: 1 addition & 1 deletion ...app/resource-manager/Microsoft.App/preview/2022-11-01-preview/examples/Revisions_Get.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"resourceGroupName": "rg",
"containerAppName": "testcontainerApp0",
"revisionName": "testcontainerApp0-pjxhsye",
"api-version": "2021-02-01"
"api-version": "2022-11-01-preview"
},
"responses": {
"200": {
Expand Down
2 changes: 1 addition & 1 deletion ...pp/resource-manager/Microsoft.App/preview/2022-11-01-preview/examples/Revisions_List.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"subscriptionId": "34adfa4f-cedf-4dc0-ba29-b6d1a69ab345",
"resourceGroupName": "rg",
"containerAppName": "testcontainerApp0",
"api-version": "2021-02-01"
"api-version": "2022-11-01-preview"
},
"responses": {
"200": {
Expand Down
2 changes: 1 addition & 1 deletion ...resource-manager/Microsoft.App/preview/2022-11-01-preview/examples/Revisions_Restart.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"resourceGroupName": "rg",
"containerAppName": "testStaticSite0",
"revisionName": "testcontainerApp0-pjxhsye",
"api-version": "2021-02-01"
"api-version": "2022-11-01-preview"
},
"responses": {
"200": {}
Expand Down
3 changes: 2 additions & 1 deletion specification/app/resource-manager/Microsoft.App/stable/2022-10-01/CommonDefinitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,7 +485,8 @@
"maxReplicas": {
"format": "int32",
"description": "Optional. Maximum number of container replicas. Defaults to 10 if not set.",
"type": "integer"
"type": "integer",
"default": 10
},
"rules": {
"description": "Scaling rules.",
Expand Down
14 changes: 1 addition & 13 deletions specification/app/resource-manager/Microsoft.App/stable/2022-10-01/ContainerApps.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,18 +569,6 @@
"$ref": "./CommonDefinitions.json#/definitions/WorkloadProfileType",
"description": "Workload profile type to pin for container app execution."
},
"appState": {
"description": "Current state of the app. Controls if the app is enabled or disabled.",
"enum": [
"Enabled",
"Disabled"
],
"type": "string",
"x-ms-enum": {
"name": "AppState",
"modelAsString": true
}
},
"latestRevisionName": {
"description": "Name of the latest revision of the Container App.",
"type": "string",
Expand Down Expand Up @@ -609,7 +597,7 @@
"$ref": "./CommonDefinitions.json#/definitions/Template",
"description": "Container App versioned application definition."
},
"outboundIPAddresses": {
"outboundIpAddresses": {
"description": "Outbound IP Addresses for container app.",
"type": "array",
"items": {
Expand Down
2 changes: 1 addition & 1 deletion ...resource-manager/Microsoft.App/stable/2022-10-01/examples/Certificate_CreateOrUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"location": "East US",
"properties": {
"password": "private key password",
"value": "PFX-or-PEM-blob"
"value": "Y2VydA=="
}
}
},
Expand Down
3 changes: 0 additions & 3 deletions ...source-manager/Microsoft.App/stable/2022-10-01/examples/ContainerApps_CreateOrUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
"properties": {
"environmentId": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourceGroups/rg/providers/Microsoft.App/managedEnvironments/demokube",
"workloadProfileType": "GeneralPurpose",
"appState": "Enabled",
"configuration": {
"ingress": {
"external": true,
Expand Down Expand Up @@ -131,7 +130,6 @@
"provisioningState": "Succeeded",
"managedEnvironmentId": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourceGroups/rg/providers/Microsoft.App/managedEnvironments/demokube",
"workloadProfileType": "GeneralPurpose",
"appState": "Enabled",
"latestRevisionName": "testcontainerApp0-pjxhsye",
"latestReadyRevisionName": "testcontainerApp0-pjxhsye",
"latestRevisionFqdn": "testcontainerApp0-pjxhsye.demokube-t24clv0g.eastus.containerApps.k4apps.io",
Expand Down Expand Up @@ -260,7 +258,6 @@
"properties": {
"provisioningState": "InProgress",
"managedEnvironmentId": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourceGroups/rg/providers/Microsoft.App/managedEnvironments/demokube",
"appState": "Enabled",
"latestRevisionName": "testcontainerApp0-pjxhsye",
"latestReadyRevisionName": "testcontainerApp0-pjxhsye",
"latestRevisionFqdn": "testcontainerApp0-pjxhsye.demokube-t24clv0g.eastus.containerApps.k4apps.io",
Expand Down
1 change: 0 additions & 1 deletion ...tion/app/resource-manager/Microsoft.App/stable/2022-10-01/examples/ContainerApps_Get.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
"provisioningState": "Succeeded",
"managedEnvironmentId": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourceGroups/rg/providers/Microsoft.App/managedEnvironments/demokube",
"workloadProfileType": "GeneralPurpose",
"appState": "Enabled",
"latestRevisionName": "testcontainerApp0-pjxhsye",
"latestReadyRevisionName": "testcontainerApp0-pjxhsye",
"latestRevisionFqdn": "testcontainerApp0-pjxhsye.demokube-t24clv0g.eastus.containerApps.k4apps.io",
Expand Down
2 changes: 1 addition & 1 deletion ...resource-manager/Microsoft.App/stable/2022-10-01/examples/ContainerApps_GetAuthToken.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"subscriptionId": "651f8027-33e8-4ec4-97b4-f6e9f3dc8744",
"resourceGroupName": "rg",
"containerAppName": "testcontainerApp0",
"api-version": "2022-05-01"
"api-version": "2022-10-01"
},
"responses": {
"200": {
Expand Down
1 change: 0 additions & 1 deletion ...e-manager/Microsoft.App/stable/2022-10-01/examples/ContainerApps_ListByResourceGroup.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
"provisioningState": "Succeeded",
"managedEnvironmentId": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourceGroups/rg/providers/Microsoft.App/managedEnvironments/demokube",
"workloadProfileType": "GeneralPurpose",
"appState": "Enabled",
"latestRevisionName": "testcontainerApp0-pjxhsye",
"latestReadyRevisionName": "testcontainerApp0-pjxhsye",
"latestRevisionFqdn": "testcontainerApp0-pjxhsye.demokube-t24clv0g.eastus.containerApps.k4apps.io",
Expand Down
1 change: 0 additions & 1 deletion ...ce-manager/Microsoft.App/stable/2022-10-01/examples/ContainerApps_ListBySubscription.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
"provisioningState": "Succeeded",
"managedEnvironmentId": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourceGroups/rg/providers/Microsoft.App/managedEnvironments/demokube",
"workloadProfileType": "GeneralPurpose",
"appState": "Enabled",
"latestRevisionName": "testcontainerApp0-pjxhsye",
"latestReadyRevisionName": "testcontainerApp0-pjxhsye",
"latestRevisionFqdn": "testcontainerApp0-pjxhsye.demokube-t24clv0g.eastus.containerApps.k4apps.io",
Expand Down
1 change: 0 additions & 1 deletion ...on/app/resource-manager/Microsoft.App/stable/2022-10-01/examples/ContainerApps_Patch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
"tag2": "value2"
},
"properties": {
"appState": "Enabled",
"configuration": {
"ingress": {
"external": true,
Expand Down
2 changes: 0 additions & 2 deletions ...manager/Microsoft.App/stable/2022-10-01/examples/ContainerApps_TcpApp_CreateOrUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@
"properties": {
"provisioningState": "Succeeded",
"managedEnvironmentId": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourceGroups/rg/providers/Microsoft.App/managedEnvironments/demokube",
"appState": "Enabled",
"latestRevisionName": "testcontainerAppTcp-pjxhsye",
"latestReadyRevisionName": "testcontainerAppTcp-pjxhsye",
"latestRevisionFqdn": "testcontainerAppTcp-pjxhsye.demokube-t24clv0g.eastus.containerApps.k4apps.io",
Expand Down Expand Up @@ -140,7 +139,6 @@
"properties": {
"provisioningState": "InProgress",
"managedEnvironmentId": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourceGroups/rg/providers/Microsoft.App/managedEnvironments/demokube",
"appState": "Enabled",
"latestRevisionName": "testcontainerAppTcp-pjxhsye",
"latestReadyRevisionName": "testcontainerAppTcp-pjxhsye",
"latestRevisionFqdn": "testcontainerAppTcp-pjxhsye.demokube-t24clv0g.eastus.containerApps.k4apps.io",
Expand Down
4 changes: 2 additions & 2 deletions ...-manager/Microsoft.App/stable/2022-10-01/examples/ManagedEnvironments_CreateOrUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@
},
"customDomainConfiguration": {
"dnsSuffix": "www.my-name.com",
"certificateValue": "PFX-or-PEM-blob",
"certificatePassword": "private key password"
"certificateValue": "Y2VydA==",
"certificatePassword": "Y2VydA=="
},
"workloadProfiles": [
{
Expand Down
6 changes: 5 additions & 1 deletion ...resource-manager/Microsoft.App/stable/2022-10-01/examples/ManagedEnvironments_Delete.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,11 @@
},
"responses": {
"200": {},
"202": {},
"202": {
"headers": {
"location": "https://management.azure.com/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/providers/Microsoft.App/localtions/eastus/operationResults/00000"
}
},
"204": {}
}
}
5 changes: 2 additions & 3 deletions ...ce-manager/Microsoft.App/stable/2022-10-01/examples/ManagedEnvironments_GetAuthToken.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"subscriptionId": "651f8027-33e8-4ec4-97b4-f6e9f3dc8744",
"resourceGroupName": "rg",
"environmentName": "testenv",
"api-version": "2022-05-01"
"api-version": "2022-10-01"
},
"responses": {
"200": {
Expand All @@ -18,7 +18,6 @@
"expires": "2022-07-14T19:22:50.3080223Z"
}
}
},
"404": {}
}
}
}
2 changes: 1 addition & 1 deletion ...fication/app/resource-manager/Microsoft.App/stable/2022-10-01/examples/Replicas_List.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"resourceGroupName": "workerapps-rg-xj",
"containerAppName": "myapp",
"revisionName": "myapp--0wlqy09",
"api-version": "2021-02-01"
"api-version": "2022-10-01"
},
"responses": {
"200": {
Expand Down
2 changes: 1 addition & 1 deletion ...fication/app/resource-manager/Microsoft.App/stable/2022-10-01/examples/Revisions_Get.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"resourceGroupName": "rg",
"containerAppName": "testcontainerApp0",
"revisionName": "testcontainerApp0-pjxhsye",
"api-version": "2021-02-01"
"api-version": "2022-10-01"
},
"responses": {
"200": {
Expand Down
2 changes: 1 addition & 1 deletion ...ication/app/resource-manager/Microsoft.App/stable/2022-10-01/examples/Revisions_List.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"subscriptionId": "34adfa4f-cedf-4dc0-ba29-b6d1a69ab345",
"resourceGroupName": "rg",
"containerAppName": "testcontainerApp0",
"api-version": "2021-02-01"
"api-version": "2022-10-01"
},
"responses": {
"200": {
Expand Down
2 changes: 1 addition & 1 deletion ...tion/app/resource-manager/Microsoft.App/stable/2022-10-01/examples/Revisions_Restart.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"resourceGroupName": "rg",
"containerAppName": "testStaticSite0",
"revisionName": "testcontainerApp0-pjxhsye",
"api-version": "2021-02-01"
"api-version": "2022-10-01"
},
"responses": {
"200": {}
Expand Down