Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resourceconnector : Remove stable folder for go sdk output #21513

Merged
merged 1 commit into from
Nov 11, 2022
Merged

Resourceconnector : Remove stable folder for go sdk output #21513

merged 1 commit into from
Nov 11, 2022

Conversation

aditimalladi
Copy link
Contributor

##Description
Update typo in the go SDK output folder for recently merged API

@openapi-workflow-bot
Copy link

Hi, @aditimalladi Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Nov 10, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️LintDiff succeeded [Detail] [Expand] 
    Validation passes for LintDiff.
    compared tags (via openapi-validator v2.0.0) new version base version
    default default(2d191be) default(main)
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand] 
    Validation passes for ServiceAPIReadinessTest.
    ️️✔️~[Staging] SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand] 
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Nov 10, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ❌azure-sdk-for-go - sdk/resourcemanager/resourceconnector/armresourceconnector - 1.0.0
    +	Function `*AppliancesClient.ListClusterCustomerUserCredential` has been removed
+	Struct `ApplianceListClusterCustomerUserCredentialResults` has been removed
+	Struct `AppliancesClientListClusterCustomerUserCredentialOptions` has been removed
+	Struct `AppliancesClientListClusterCustomerUserCredentialResponse` has been removed
    ❌azure-sdk-for-python-track2 - track2_azure-mgmt-resourceconnector - 1.0.0b2
    +	Removed operation AppliancesOperations.list_cluster_customer_user_credential
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from c89cab3. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.2 -> 9.1.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.1.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.1.1` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-resourceconnector [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation AppliancesOperations.get_telemetry_config
info	[Changelog]   - Added operation AppliancesOperations.list_keys
info	[Changelog]   - Model Resource has a new parameter system_data
info	[Changelog]   - Model SSHKey has a new parameter certificate
info	[Changelog]   - Model SSHKey has a new parameter creation_time_stamp
info	[Changelog]   - Model SSHKey has a new parameter expiration_time_stamp
info	[Changelog]   - Model TrackedResource has a new parameter system_data
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Removed operation AppliancesOperations.list_cluster_customer_user_credential
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from c89cab3. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
warn	No file changes detected after generation
warn	No package detected after generation
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from c89cab3. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/resourceconnector/armresourceconnector [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `*AppliancesClient.ListClusterCustomerUserCredential` has been removed
info	[Changelog] - Struct `ApplianceListClusterCustomerUserCredentialResults` has been removed
info	[Changelog] - Struct `AppliancesClientListClusterCustomerUserCredentialOptions` has been removed
info	[Changelog] - Struct `AppliancesClientListClusterCustomerUserCredentialResponse` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `SSHKeyTypeLogsKey`
info	[Changelog] - New const `StatusImageProvisioning`
info	[Changelog] - New const `StatusImagePending`
info	[Changelog] - New const `StatusImageDeprovisioning`
info	[Changelog] - New const `StatusImageProvisioned`
info	[Changelog] - New const `SSHKeyTypeScopedAccessKey`
info	[Changelog] - New const `StatusImageDownloading`
info	[Changelog] - New const `SSHKeyTypeManagementCAKey`
info	[Changelog] - New const `ArtifactTypeLogsArtifactType`
info	[Changelog] - New const `StatusImageDownloaded`
info	[Changelog] - New const `StatusUpgradingKVAIO`
info	[Changelog] - New const `StatusWaitingForKVAIO`
info	[Changelog] - New const `StatusImageUnknown`
info	[Changelog] - New type alias `ArtifactType`
info	[Changelog] - New function `PossibleArtifactTypeValues() []ArtifactType`
info	[Changelog] - New function `*AppliancesClient.ListKeys(context.Context, string, string, *AppliancesClientListKeysOptions) (AppliancesClientListKeysResponse, error)`
info	[Changelog] - New function `*AppliancesClient.GetTelemetryConfig(context.Context, *AppliancesClientGetTelemetryConfigOptions) (AppliancesClientGetTelemetryConfigResponse, error)`
info	[Changelog] - New struct `ApplianceGetTelemetryConfigResult`
info	[Changelog] - New struct `ApplianceListKeysResults`
info	[Changelog] - New struct `AppliancesClientGetTelemetryConfigOptions`
info	[Changelog] - New struct `AppliancesClientGetTelemetryConfigResponse`
info	[Changelog] - New struct `AppliancesClientListKeysOptions`
info	[Changelog] - New struct `AppliancesClientListKeysResponse`
info	[Changelog] - New struct `ArtifactProfile`
info	[Changelog] - New field `SystemData` in struct `TrackedResource`
info	[Changelog] - New field `Certificate` in struct `SSHKey`
info	[Changelog] - New field `CreationTimeStamp` in struct `SSHKey`
info	[Changelog] - New field `ExpirationTimeStamp` in struct `SSHKey`
info	[Changelog] - New field `SystemData` in struct `Resource`
info	[Changelog]
info	[Changelog] Total 7 breaking change(s), 34 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from c89cab3. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-resourceconnector [View full logs]  [Release SDK Changes] 
      info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from c89cab3. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.Appliances [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Nov 10, 2022 •
    edited
    Loading

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/resourceconnector/armresourceconnector Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Python track2_azure-mgmt-resourceconnector Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    JavaScript @azure/arm-resourceconnector Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

    @azure-sdk azure-sdk mentioned this pull request Nov 10, 2022
    Closed
    @azure-sdk azure-sdk mentioned this pull request Nov 10, 2022
    Closed
    This was referenced Nov 10, 2022
    Closed
    Closed
    @raych1 raych1 merged commit c89cab3 into main Nov 11, 2022
    @raych1 raych1 deleted the amalladi/fix-appliance-go-output-dir branch November 11, 2022 03:02
    This was referenced Nov 11, 2022
    Closed
    Closed
    Closed
    Closed
    anandanthony pushed a commit to anandMicro/azure-rest-api-specs that referenced this pull request Dec 16, 2022
    @aditimalladi @anandanthony
    Remove stable folder for go sdk output (Azure#21513)
    8e67aa4
    kayousef-zz pushed a commit to kayousef-zz/azure-rest-api-specs that referenced this pull request Dec 21, 2022
    @aditimalladi @kayousef
    Remove stable folder for go sdk output (Azure#21513)
    509ce7b
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @tadelesh tadelesh tadelesh approved these changes

    @raych1 raych1 raych1 approved these changes

    @ArcturusZhang ArcturusZhang Awaiting requested review from ArcturusZhang

    Assignees

    @raych1 raych1

    Labels
    CI-BreakingChange-Go resource-manager
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    4 participants
    @aditimalladi @tadelesh @raych1 @AzureRestAPISpecReview