Sticky Sessions Swagger PR #21521

tdaroly · 2022-11-11T08:04:41Z

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2022-11-11T08:04:44Z

Hi, @tdaroly Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2022-11-11T08:04:45Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️❌Breaking Change(Cross-Version): 1 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.2)]	new version	base version
ContainerApps.json	2022-11-01-preview(a80795d)	2022-10-01(main)
ContainerApps.json	2022-11-01-preview(a80795d)	2022-06-01-preview(main)

The following breaking changes are detected by comparison with the latest stable version:

Rule	Message
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'latestReadyRevisionName' renamed or removed? New: Microsoft.App/preview/2022-11-01-preview/ContainerApps.json#L541:11 Old: Microsoft.App/stable/2022-10-01/ContainerApps.json#L541:11

️❌LintDiff: 12 Errors, 25 Warnings failed [Detail]

compared tags (via openapi-validator v2.0.0)	new version	base version
package-preview-2022-11	package-preview-2022-11(a80795d)	package-preview-2022-11(release-app-Microsoft.App-2022-11-01-preview)

[must fix]The following errors/warnings are introduced by current PR:

Only 30 items are listed, please refer to log for more details.

Rule	Message	Related RPC [For API reviewers]
`❌` ResourceNameRestriction	The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2022-11-01-preview/ContainerApps.json#L99	RPC-V2-URI-5
`❌` CreateOperationAsyncResponseValidation	An async PUT operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.App/preview/2022-11-01-preview/ContainerApps.json#L148	RPC-V2-ASYNC-1
`❌` DeleteOperationAsyncResponseValidation	An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.App/preview/2022-11-01-preview/ContainerApps.json#L212	RPC-V2-ASYNC-9
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.App/preview/2022-11-01-preview/ContainerApps.json#L241	RPC-V2-ASYNC-7
`❌` UnSupportedPatchProperties	The patch operation body parameter schema should not contains property name. Location: Microsoft.App/preview/2022-11-01-preview/ContainerApps.json#L282
`❌` UnSupportedPatchProperties	The patch operation body parameter schema should not contains property type. Location: Microsoft.App/preview/2022-11-01-preview/ContainerApps.json#L282
`❌` UnSupportedPatchProperties	The patch operation body parameter schema should not contains property location. Location: Microsoft.App/preview/2022-11-01-preview/ContainerApps.json#L282
`❌` PatchBodyParametersSchema	Properties of a PATCH request body must not be required, property:location. Location: Microsoft.App/preview/2022-11-01-preview/ContainerApps.json#L287	RPC-V2-Patch-10
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.App/preview/2022-11-01-preview/ContainerApps.json#L302	RPC-V2-ASYNC-7
`❌` ResourceNameRestriction	The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2022-11-01-preview/ContainerApps.json#L320	RPC-V2-URI-5
`❌` ResourceNameRestriction	The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2022-11-01-preview/ContainerApps.json#L372	RPC-V2-URI-5
`❌` ResourceNameRestriction	The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2022-11-01-preview/ContainerApps.json#L418	RPC-V2-URI-5
⚠️ ParameterNotDefinedInGlobalParameters	Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.App/preview/2022-11-01-preview/ContainerApps.json#L25
⚠️ ParameterNotDefinedInGlobalParameters	Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.App/preview/2022-11-01-preview/ContainerApps.json#L64
⚠️ ParameterNotDefinedInGlobalParameters	Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.App/preview/2022-11-01-preview/ContainerApps.json#L106
⚠️ SummaryAndDescriptionMustNotBeSame	The summary and description values should not be same. Location: Microsoft.App/preview/2022-11-01-preview/ContainerApps.json#L148
⚠️ XmsLongRunningOperationOptions	The x-ms-long-running-operation-options should be specified explicitly to indicate the type of response header to track the async operation. Location: Microsoft.App/preview/2022-11-01-preview/ContainerApps.json#L148
⚠️ ParameterNotDefinedInGlobalParameters	Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.App/preview/2022-11-01-preview/ContainerApps.json#L155
⚠️ SummaryAndDescriptionMustNotBeSame	The summary and description values should not be same. Location: Microsoft.App/preview/2022-11-01-preview/ContainerApps.json#L212
⚠️ XmsLongRunningOperationOptions	The x-ms-long-running-operation-options should be specified explicitly to indicate the type of response header to track the async operation. Location: Microsoft.App/preview/2022-11-01-preview/ContainerApps.json#L212
⚠️ ParameterNotDefinedInGlobalParameters	Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.App/preview/2022-11-01-preview/ContainerApps.json#L219
⚠️ XmsLongRunningOperationOptions	The x-ms-long-running-operation-options should be specified explicitly to indicate the type of response header to track the async operation. Location: Microsoft.App/preview/2022-11-01-preview/ContainerApps.json#L261
⚠️ ParameterNotDefinedInGlobalParameters	Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.App/preview/2022-11-01-preview/ContainerApps.json#L268
⚠️ ParameterNotDefinedInGlobalParameters	Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.App/preview/2022-11-01-preview/ContainerApps.json#L327
⚠️ ParameterNotDefinedInGlobalParameters	Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.App/preview/2022-11-01-preview/ContainerApps.json#L379
⚠️ ParameterNotDefinedInGlobalParameters	Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.App/preview/2022-11-01-preview/ContainerApps.json#L425
⚠️ AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2022-11-01-preview/ContainerApps.json#L541
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.App/preview/2022-11-01-preview/ContainerApps.json#L644
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.App/preview/2022-11-01-preview/ContainerApps.json#L695
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.App/preview/2022-11-01-preview/ContainerApps.json#L710

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️~[Staging] SwaggerAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-11-11T08:04:46Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️⚠️SDK Breaking Change Tracking warning [Detail]

Breaking Changes Tracking

⚠️azure-sdk-for-go - sdk/resourcemanager/appcontainers/armappcontainers - 2.0.0-beta.2

+	Type of `CustomDomainConfiguration.CertificatePassword` has been changed from `[]byte` to `*string`
+	Type of `DaprSecretsCollection.Value` has been changed from `[]*Secret` to `[]*DaprSecret`

⚠️azure-sdk-for-js - @azure/arm-appcontainers - 2.0.0-beta.3

+	Class ContainerAppsAPIClient has a new required parameter availableWorkloadProfiles
+	Class ContainerAppsAPIClient has a new required parameter billingMeters
+	Class ContainerAppsAPIClient has a new required parameter connectedEnvironments
+	Class ContainerAppsAPIClient has a new required parameter connectedEnvironmentsCertificates
+	Class ContainerAppsAPIClient has a new required parameter connectedEnvironmentsDaprComponents
+	Class ContainerAppsAPIClient has a new required parameter connectedEnvironmentsStorages
+	Class ContainerAppsAPIClient has a new required parameter containerAppsDiagnostics
+	Class ContainerAppsAPIClient has a new required parameter managedCertificates
+	Class ContainerAppsAPIClient has a new required parameter managedEnvironmentDiagnostics
+	Class ContainerAppsAPIClient has a new required parameter managedEnvironmentsDiagnostics
+	Interface ContainerAppsRevisionsListRevisionsNextOptionalParams no longer has parameter filter
+	Type of parameter customDomainVerificationFailureInfo of interface CustomHostnameAnalysisResult is changed from DefaultErrorResponse to CustomHostnameAnalysisResultCustomDomainVerificationFailureInfo
+	Type of parameter value of interface DaprSecretsCollection is changed from Secret[] to DaprSecret[]

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs] Generate from 294896770731b42365bf7feb7c55ed4db9a38399. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.2 -> 9.2.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.2.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.2.0` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-appcontainers [View full logs] [Preview SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation group ManagedCertificatesOperations
info	[Changelog]   - Model Ingress has a new parameter client_certificate_mode
info	[Changelog]   - Model Ingress has a new parameter cors_policy
info	[Changelog]   - Model Ingress has a new parameter sticky_sessions
info	[Changelog]   - Model ManagedEnvironment has a new parameter kind
info	[Changelog]   - Model VnetConfiguration has a new parameter control_plane_subnet_id

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from 294896770731b42365bf7feb7c55ed4db9a38399. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-appcontainers [View full logs] [Preview SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 294896770731b42365bf7feb7c55ed4db9a38399. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/appcontainers/armappcontainers [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `CustomDomainConfiguration.CertificatePassword` has been changed from `[]byte` to `*string`
info	[Changelog] - Type of `DaprSecretsCollection.Value` has been changed from `[]*Secret` to `[]*DaprSecret`
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New type alias `Affinity` with values `AffinityNone`, `AffinitySticky`
info	[Changelog] - New type alias `IngressClientCertificateMode` with values `IngressClientCertificateModeAccept`, `IngressClientCertificateModeIgnore`, `IngressClientCertificateModeRequire`
info	[Changelog] - New type alias `ManagedCertificateDomainControlValidation` with values `ManagedCertificateDomainControlValidationCNAME`, `ManagedCertificateDomainControlValidationHTTP`, `ManagedCertificateDomainControlValidationTXT`
info	[Changelog] - New function `NewManagedCertificatesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ManagedCertificatesClient, error)`
info	[Changelog] - New function `*ManagedCertificatesClient.BeginCreateOrUpdate(context.Context, string, string, string, *ManagedCertificatesClientBeginCreateOrUpdateOptions) (*runtime.Poller[ManagedCertificatesClientCreateOrUpdateResponse], error)`
info	[Changelog] - New function `*ManagedCertificatesClient.Delete(context.Context, string, string, string, *ManagedCertificatesClientDeleteOptions) (ManagedCertificatesClientDeleteResponse, error)`
info	[Changelog] - New function `*ManagedCertificatesClient.Get(context.Context, string, string, string, *ManagedCertificatesClientGetOptions) (ManagedCertificatesClientGetResponse, error)`
info	[Changelog] - New function `*ManagedCertificatesClient.NewListPager(string, string, *ManagedCertificatesClientListOptions) *runtime.Pager[ManagedCertificatesClientListResponse]`
info	[Changelog] - New function `*ManagedCertificatesClient.Update(context.Context, string, string, string, ManagedCertificatePatch, *ManagedCertificatesClientUpdateOptions) (ManagedCertificatesClientUpdateResponse, error)`
info	[Changelog] - New struct `CorsPolicy`
info	[Changelog] - New struct `IngressStickySessions`
info	[Changelog] - New struct `ManagedCertificate`
info	[Changelog] - New struct `ManagedCertificateCollection`
info	[Changelog] - New struct `ManagedCertificatePatch`
info	[Changelog] - New struct `ManagedCertificateProperties`
info	[Changelog] - New struct `ManagedCertificatesClient`
info	[Changelog] - New struct `ManagedCertificatesClientCreateOrUpdateResponse`
info	[Changelog] - New struct `ManagedCertificatesClientListResponse`
info	[Changelog] - New anonymous field `ContainerApp` in struct `ContainerAppsClientUpdateResponse`
info	[Changelog] - New field `ClientCertificateMode` in struct `Ingress`
info	[Changelog] - New field `CorsPolicy` in struct `Ingress`
info	[Changelog] - New field `StickySessions` in struct `Ingress`
info	[Changelog] - New field `Kind` in struct `ManagedEnvironment`
info	[Changelog] - New anonymous field `ManagedEnvironment` in struct `ManagedEnvironmentsClientUpdateResponse`
info	[Changelog] - New field `ControlPlaneSubnetID` in struct `VnetConfiguration`
info	[Changelog]
info	[Changelog] Total 2 breaking change(s), 40 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 294896770731b42365bf7feb7c55ed4db9a38399. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-appcontainers [View full logs] [Preview SDK Changes] Breaking Change Detected

azure-arm-appcontainers-2.0.0-beta.3.tgz

Only show 120 items here, please refer to log for details.

info	[Changelog]   - Added Interface TcpScaleRule
info	[Changelog]   - Added Interface WorkloadProfile
info	[Changelog]   - Added Interface WorkloadProfileStates
info	[Changelog]   - Added Interface WorkloadProfileStatesCollection
info	[Changelog]   - Added Interface WorkloadProfileStatesProperties
info	[Changelog]   - Added Type Alias Action
info	[Changelog]   - Added Type Alias Affinity
info	[Changelog]   - Added Type Alias Applicability
info	[Changelog]   - Added Type Alias AvailableWorkloadProfilesGetNextResponse
info	[Changelog]   - Added Type Alias AvailableWorkloadProfilesGetResponse
info	[Changelog]   - Added Type Alias BillingMetersGetResponse
info	[Changelog]   - Added Type Alias Category
info	[Changelog]   - Added Type Alias ConnectedEnvironmentProvisioningState
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsCertificatesCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsCertificatesGetResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsCertificatesListNextResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsCertificatesListResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsCertificatesUpdateResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsCheckNameAvailabilityResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsDaprComponentsCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsDaprComponentsGetResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsDaprComponentsListNextResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsDaprComponentsListResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsDaprComponentsListSecretsResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsGetResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsListByResourceGroupNextResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsListByResourceGroupResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsListBySubscriptionNextResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsListBySubscriptionResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsStoragesCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsStoragesGetResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsStoragesListResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsUpdateResponse
info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsGetDetectorResponse
info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsGetRevisionResponse
info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsGetRootResponse
info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsListDetectorsNextResponse
info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsListDetectorsResponse
info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsListRevisionsNextResponse
info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsListRevisionsResponse
info	[Changelog]   - Added Type Alias ContainerAppsGetAuthTokenResponse
info	[Changelog]   - Added Type Alias ContainerAppsUpdateResponse
info	[Changelog]   - Added Type Alias ExtendedLocationTypes
info	[Changelog]   - Added Type Alias IngressClientCertificateMode
info	[Changelog]   - Added Type Alias LogLevel
info	[Changelog]   - Added Type Alias ManagedCertificateDomainControlValidation
info	[Changelog]   - Added Type Alias ManagedCertificatesCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias ManagedCertificatesGetResponse
info	[Changelog]   - Added Type Alias ManagedCertificatesListNextResponse
info	[Changelog]   - Added Type Alias ManagedCertificatesListResponse
info	[Changelog]   - Added Type Alias ManagedCertificatesUpdateResponse
info	[Changelog]   - Added Type Alias ManagedEnvironmentDiagnosticsGetDetectorResponse
info	[Changelog]   - Added Type Alias ManagedEnvironmentDiagnosticsListDetectorsResponse
info	[Changelog]   - Added Type Alias ManagedEnvironmentOutBoundType
info	[Changelog]   - Added Type Alias ManagedEnvironmentsDiagnosticsGetRootResponse
info	[Changelog]   - Added Type Alias ManagedEnvironmentsGetAuthTokenResponse
info	[Changelog]   - Added Type Alias ManagedEnvironmentsListWorkloadProfileStatesNextResponse
info	[Changelog]   - Added Type Alias ManagedEnvironmentsListWorkloadProfileStatesResponse
info	[Changelog]   - Added Type Alias ManagedEnvironmentsUpdateResponse
info	[Changelog]   - Added Type Alias SkuName
info	[Changelog]   - Interface CertificateProperties has a new optional parameter subjectAlternativeNames
info	[Changelog]   - Interface Configuration has a new optional parameter maxInactiveRevisions
info	[Changelog]   - Interface ContainerApp has a new optional parameter environmentId
info	[Changelog]   - Interface ContainerApp has a new optional parameter eventStreamEndpoint
info	[Changelog]   - Interface ContainerApp has a new optional parameter extendedLocation
info	[Changelog]   - Interface ContainerApp has a new optional parameter workloadProfileType
info	[Changelog]   - Interface CustomHostnameAnalysisResult has a new optional parameter conflictWithEnvironmentCustomDomain
info	[Changelog]   - Interface Dapr has a new optional parameter enableApiLogging
info	[Changelog]   - Interface Dapr has a new optional parameter httpMaxRequestSize
info	[Changelog]   - Interface Dapr has a new optional parameter httpReadBufferSize
info	[Changelog]   - Interface Dapr has a new optional parameter logLevel
info	[Changelog]   - Interface DaprComponent has a new optional parameter secretStoreComponent
info	[Changelog]   - Interface Ingress has a new optional parameter clientCertificateMode
info	[Changelog]   - Interface Ingress has a new optional parameter corsPolicy
info	[Changelog]   - Interface Ingress has a new optional parameter exposedPort
info	[Changelog]   - Interface Ingress has a new optional parameter ipSecurityRestrictions
info	[Changelog]   - Interface Ingress has a new optional parameter stickySessions
info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter customDomainConfiguration
info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter eventStreamEndpoint
info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter kind
info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter sku
info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter workloadProfiles
info	[Changelog]   - Interface ReplicaContainer has a new optional parameter execEndpoint
info	[Changelog]   - Interface ReplicaContainer has a new optional parameter logStreamEndpoint
info	[Changelog]   - Interface Revision has a new optional parameter lastActiveTime
info	[Changelog]   - Interface ScaleRule has a new optional parameter tcp
info	[Changelog]   - Interface Template has a new optional parameter initContainers
info	[Changelog]   - Interface VnetConfiguration has a new optional parameter controlPlaneSubnetId
info	[Changelog]   - Interface VnetConfiguration has a new optional parameter outboundSettings
info	[Changelog]   - Added Enum KnownAction
info	[Changelog]   - Added Enum KnownAffinity
info	[Changelog]   - Added Enum KnownApplicability
info	[Changelog]   - Added Enum KnownCategory
info	[Changelog]   - Added Enum KnownConnectedEnvironmentProvisioningState
info	[Changelog]   - Added Enum KnownExtendedLocationTypes
info	[Changelog]   - Added Enum KnownIngressClientCertificateMode
info	[Changelog]   - Added Enum KnownLogLevel
info	[Changelog]   - Added Enum KnownManagedCertificateDomainControlValidation
info	[Changelog]   - Added Enum KnownManagedEnvironmentOutBoundType
info	[Changelog]   - Added Enum KnownSkuName
info	[Changelog]   - Enum KnownContainerAppProvisioningState has a new value Deleting
info	[Changelog]   - Enum KnownIngressTransportMethod has a new value Tcp
info	[Changelog]   - Added function getContinuationToken
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Interface ContainerAppsRevisionsListRevisionsNextOptionalParams no longer has parameter filter
info	[Changelog]   - Type of parameter customDomainVerificationFailureInfo of interface CustomHostnameAnalysisResult is changed from DefaultErrorResponse to CustomHostnameAnalysisResultCustomDomainVerificationFailureInfo
info	[Changelog]   - Type of parameter value of interface DaprSecretsCollection is changed from Secret[] to DaprSecret[]
info	[Changelog]   - Class ContainerAppsAPIClient has a new required parameter availableWorkloadProfiles
info	[Changelog]   - Class ContainerAppsAPIClient has a new required parameter billingMeters
info	[Changelog]   - Class ContainerAppsAPIClient has a new required parameter connectedEnvironments
info	[Changelog]   - Class ContainerAppsAPIClient has a new required parameter connectedEnvironmentsCertificates
info	[Changelog]   - Class ContainerAppsAPIClient has a new required parameter connectedEnvironmentsDaprComponents
info	[Changelog]   - Class ContainerAppsAPIClient has a new required parameter connectedEnvironmentsStorages
info	[Changelog]   - Class ContainerAppsAPIClient has a new required parameter containerAppsDiagnostics
info	[Changelog]   - Class ContainerAppsAPIClient has a new required parameter managedCertificates
info	[Changelog]   - Class ContainerAppsAPIClient has a new required parameter managedEnvironmentDiagnostics
info	[Changelog]   - Class ContainerAppsAPIClient has a new required parameter managedEnvironmentsDiagnostics

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs] Generate from 294896770731b42365bf7feb7c55ed4db9a38399. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️app [View full logs] [Preview Schema Changes]

️️✔️ azure-powershell succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 294896770731b42365bf7feb7c55ed4db9a38399. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

️✔️Az.ContainerAppsApi [View full logs] [Preview SDK Changes]
- Az.ContainerAppsApi.0.1.0.nupkg

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-11-11T08:04:46Z

Generated ApiView

Language	Package Name	ApiView Link
swagger	Microsoft.App	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
Go	sdk/resourcemanager/appcontainers/armappcontainers	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
Java	azure-resourcemanager-appcontainers	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
JavaScript	@azure/arm-appcontainers	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

openapi-workflow-bot · 2022-11-11T08:10:54Z

Hi @tdaroly, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

ahmelsayed · 2022-11-14T17:59:47Z

specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/ContainerApps.json

+            "httpOnly": {
+              "description": "Sticky Session HttpOnly",
+              "type": "boolean"
+            },
+            "secure": {
+              "description": "Sticky Session secure",
+              "type": "boolean"
+            },
+            "sameSite": {
+              "description": "Sticky Session sameSite",
+              "type": "string"
+            }


These are not configurable, why add them to the ARM interface?

will remove and leave affinity only

specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/ContainerApps.json

ghost · 2022-12-04T16:02:47Z

Hi, @tdaroly. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

…olywala/sticky-sessions-swagger-pr

openapi-workflow-bot · 2022-12-14T03:18:16Z

Hi @tdaroly, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

add sticky sessions first commit

739e0b8

openapi-assignment-bot bot assigned leni-msft Nov 11, 2022

Taher Darolywala added 2 commits November 11, 2022 02:08

add examples

c80f4ef

fix semantic validation

a0e543b

azure-sdk mentioned this pull request Nov 11, 2022

[AutoPR app/resource-manager] add sticky sessions first commit azure-sdk/azure-resource-manager-schemas#1499

Draft

AzureRestAPISpecReview added CI-FixRequiredOnFailure resource-manager labels Nov 11, 2022

azure-sdk mentioned this pull request Nov 11, 2022

[AutoPR Az.app] add sticky sessions first commit azure-sdk/azure-powershell#3346

Closed

remove breaking sdk error's duplicates

2df4806

tdaroly changed the title ~~add sticky sessions first commit~~ Sticky Sessions Swagger PR Nov 11, 2022

azure-sdk mentioned this pull request Nov 11, 2022

[AutoPR sdk/resourcemanager/appcontainers/armappcontainers] Sticky Sessions Swagger PR azure-sdk/azure-sdk-for-go#3534

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Nov 11, 2022

fix camelCase error

c2c040e

jianyexi added the Approved-LintDiff label Nov 14, 2022

ahmelsayed reviewed Nov 14, 2022

View reviewed changes

remove extra attributes

4697e3f

jijohn14 requested changes Nov 15, 2022

View reviewed changes

specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/ContainerApps.json Show resolved Hide resolved

specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/ContainerApps.json Outdated Show resolved Hide resolved

change affinity property to a string enum

586f904

jijohn14 approved these changes Nov 15, 2022

View reviewed changes

ahmelsayed approved these changes Nov 15, 2022

View reviewed changes

ghost added no-recent-activity and removed no-recent-activity labels Dec 4, 2022

tdaroly added the no-recent-activity label Dec 4, 2022

ghost removed the no-recent-activity label Dec 4, 2022

tdaroly and others added 2 commits December 13, 2022 21:08

Merge branch 'release-app-Microsoft.App-2022-11-01-preview' into tdar…

bb15f24

…olywala/sticky-sessions-swagger-pr

change Sticky -> sticky

3c433d1

AzureRestAPISpecReview added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Dec 14, 2022

pretty errir

a80795d

azure-sdk mentioned this pull request Dec 14, 2022

[AutoPR azure-resourcemanager-appcontainers] Sticky Sessions Swagger PR azure-sdk/azure-sdk-for-java#3266

Closed

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Dec 14, 2022

leni-msft approved these changes Dec 14, 2022

View reviewed changes

leni-msft merged commit f34c7cc into release-app-Microsoft.App-2022-11-01-preview Dec 14, 2022

leni-msft deleted the tdarolywala/sticky-sessions-swagger-pr branch December 14, 2022 08:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sticky Sessions Swagger PR #21521

Sticky Sessions Swagger PR #21521

tdaroly commented Nov 11, 2022 •

edited by openapi-workflow-bot bot

Loading

openapi-workflow-bot bot commented Nov 11, 2022

openapi-pipeline-app bot commented Nov 11, 2022 •

edited

Loading

openapi-pipeline-app bot commented Nov 11, 2022 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Nov 11, 2022 •

edited

Loading

openapi-workflow-bot bot commented Nov 11, 2022

ahmelsayed Nov 14, 2022

tdaroly Nov 14, 2022

ghost commented Dec 4, 2022

openapi-workflow-bot bot commented Dec 14, 2022

Sticky Sessions Swagger PR #21521

Sticky Sessions Swagger PR #21521

Conversation

tdaroly commented Nov 11, 2022 • edited by openapi-workflow-bot bot Loading

ARM API Information (Control Plane)

Changelog

Contribution checklist (MS Employees Only):

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Nov 11, 2022

openapi-pipeline-app bot commented Nov 11, 2022 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Nov 11, 2022 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Nov 11, 2022 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Nov 11, 2022

ahmelsayed Nov 14, 2022

Choose a reason for hiding this comment

tdaroly Nov 14, 2022

Choose a reason for hiding this comment

ghost commented Dec 4, 2022

openapi-workflow-bot bot commented Dec 14, 2022

tdaroly commented Nov 11, 2022 •

edited by openapi-workflow-bot bot

Loading

openapi-pipeline-app bot commented Nov 11, 2022 •

edited

Loading

openapi-pipeline-app bot commented Nov 11, 2022 •

edited

Loading

openapi-pipeline-app bot commented Nov 11, 2022 •

edited

Loading