Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "ACSS Swagger Changes in PUT SVI API and child resources" #21662

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

ruowan
Copy link
Member

@ruowan ruowan commented Nov 28, 2022

Reverts #21604

@openapi-workflow-bot
Copy link

Hi, @ruowan Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Nov 28, 2022

    Swagger Validation Report

    ️❌BreakingChange: 16 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.2)] new version base version
    SAPVirtualInstance.json 2021-12-01-preview(fa9cde1) 2021-12-01-preview(main)
    Rule Message
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'DiskConfiguration' removed or renamed?
    New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L1511:3
    Old: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L1541:3
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'FileShareConfigurationType' removed or renamed?
    New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L1511:3
    Old: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L1541:3
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'SkipFileShareConfiguration' removed or renamed?
    New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L1511:3
    Old: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L1541:3
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'CreateAndMountFileShareConfiguration' removed or renamed?
    New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L1511:3
    Old: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L1541:3
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'MountFileShareConfiguration' removed or renamed?
    New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L1511:3
    Old: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L1541:3
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'FileShareConfiguration' removed or renamed?
    New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L1511:3
    Old: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L1541:3
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'StorageConfiguration' removed or renamed?
    New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L1511:3
    Old: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L1541:3
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'LoadBalancerDetails' removed or renamed?
    New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L1511:3
    Old: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L1541:3
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'loadBalancerDetails' renamed or removed?
    New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L3153:7
    Old: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L3395:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'storageDetails' renamed or removed?
    New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2743:7
    Old: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2958:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'loadBalancerDetails' renamed or removed?
    New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L3234:7
    Old: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L3481:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'storageDetails' renamed or removed?
    New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2757:7
    Old: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2981:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'storageDetails' renamed or removed?
    New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2928:7
    Old: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L3161:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'dbDiskConfiguration' renamed or removed?
    New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2306:7
    Old: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2395:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'diskConfiguration' renamed or removed?
    New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2356:7
    Old: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2449:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'storageConfiguration' renamed or removed?
    New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2428:7
    Old: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2619:7
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-2021-12-01-preview package-2021-12-01-preview(fa9cde1) package-2021-12-01-preview(main)

    The following errors/warnings exist before current PR submission:

    Rule Message
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L1750
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L1888
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2110
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2114
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2604
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L3298
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️~[Staging] SwaggerAPIView succeeded [Detail] [Expand]
    ️❌ModelValidation: 6 Errors, 0 Warnings failed [Detail]
    Rule Message
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L473:22
    ExampleUrl: 2021-12-01-preview/examples/sapvirtualinstances/SAPVirtualInstances_Delete.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L783:22
    ExampleUrl: 2021-12-01-preview/examples/sapvirtualinstances/SAPCentralInstances_Delete.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L1057:22
    ExampleUrl: 2021-12-01-preview/examples/sapvirtualinstances/SAPDatabaseInstances_Delete.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L1331:22
    ExampleUrl: 2021-12-01-preview/examples/sapvirtualinstances/SAPApplicationServerInstances_Delete.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L1431:22
    ExampleUrl: 2021-12-01-preview/examples/sapvirtualinstances/SAPVirtualInstances_Start.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L1491:22
    ExampleUrl: 2021-12-01-preview/examples/sapvirtualinstances/SAPVirtualInstances_Stop.json
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Nov 28, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking


    azure-sdk-for-go - sdk/resourcemanager/workloads/armworkloads - 0.3.0
    +	Function `*SAPApplicationServerInstancesClient.BeginCreate` parameter(s) have been changed from `(context.Context, string, string, string, SAPApplicationServerInstance, *SAPApplicationServerInstancesClientBeginCreateOptions)` to `(context.Context, string, string, string, *SAPApplicationServerInstancesClientBeginCreateOptions)`
    +	Function `*SAPApplicationServerInstancesClient.BeginUpdate` parameter(s) have been changed from `(context.Context, string, string, string, UpdateSAPApplicationInstanceRequest, *SAPApplicationServerInstancesClientBeginUpdateOptions)` to `(context.Context, string, string, string, *SAPApplicationServerInstancesClientBeginUpdateOptions)`
    +	Function `*SAPCentralInstancesClient.BeginCreate` parameter(s) have been changed from `(context.Context, string, string, string, SAPCentralServerInstance, *SAPCentralInstancesClientBeginCreateOptions)` to `(context.Context, string, string, string, *SAPCentralInstancesClientBeginCreateOptions)`
    +	Function `*SAPCentralInstancesClient.BeginUpdate` parameter(s) have been changed from `(context.Context, string, string, string, UpdateSAPCentralInstanceRequest, *SAPCentralInstancesClientBeginUpdateOptions)` to `(context.Context, string, string, string, *SAPCentralInstancesClientBeginUpdateOptions)`
    +	Function `*SAPDatabaseInstancesClient.BeginCreate` parameter(s) have been changed from `(context.Context, string, string, string, SAPDatabaseInstance, *SAPDatabaseInstancesClientBeginCreateOptions)` to `(context.Context, string, string, string, *SAPDatabaseInstancesClientBeginCreateOptions)`
    +	Function `*SAPDatabaseInstancesClient.BeginUpdate` parameter(s) have been changed from `(context.Context, string, string, string, UpdateSAPDatabaseInstanceRequest, *SAPDatabaseInstancesClientBeginUpdateOptions)` to `(context.Context, string, string, string, *SAPDatabaseInstancesClientBeginUpdateOptions)`
    +	Function `*SAPVirtualInstancesClient.BeginCreate` parameter(s) have been changed from `(context.Context, string, string, SAPVirtualInstance, *SAPVirtualInstancesClientBeginCreateOptions)` to `(context.Context, string, string, *SAPVirtualInstancesClientBeginCreateOptions)`
    +	Function `*SAPVirtualInstancesClient.Update` parameter(s) have been changed from `(context.Context, string, string, UpdateSAPVirtualInstanceRequest, *SAPVirtualInstancesClientUpdateOptions)` to `(context.Context, string, string, *SAPVirtualInstancesClientUpdateOptions)`
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 495363b. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.2 -> 9.1.2
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.1.2>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.1.2` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-workloads [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Model DB2ProviderInstanceProperties has a new parameter ssl_certificate_uri
      info	[Changelog]   - Model DB2ProviderInstanceProperties has a new parameter ssl_preference
      info	[Changelog]   - Model HanaDbProviderInstanceProperties has a new parameter ssl_certificate_uri
      info	[Changelog]   - Model HanaDbProviderInstanceProperties has a new parameter ssl_preference
      info	[Changelog]   - Model Monitor has a new parameter storage_account_arm_id
      info	[Changelog]   - Model Monitor has a new parameter zone_redundancy_preference
      info	[Changelog]   - Model MsSqlServerProviderInstanceProperties has a new parameter ssl_certificate_uri
      info	[Changelog]   - Model MsSqlServerProviderInstanceProperties has a new parameter ssl_preference
      info	[Changelog]   - Model PrometheusHaClusterProviderInstanceProperties has a new parameter ssl_certificate_uri
      info	[Changelog]   - Model PrometheusHaClusterProviderInstanceProperties has a new parameter ssl_preference
      info	[Changelog]   - Model PrometheusOSProviderInstanceProperties has a new parameter ssl_certificate_uri
      info	[Changelog]   - Model PrometheusOSProviderInstanceProperties has a new parameter ssl_preference
      info	[Changelog]   - Model SapNetWeaverProviderInstanceProperties has a new parameter ssl_certificate_uri
      info	[Changelog]   - Model SapNetWeaverProviderInstanceProperties has a new parameter ssl_preference
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 495363b. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-workloads [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 495363b. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/workloads/armworkloads [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Function `*SAPApplicationServerInstancesClient.BeginCreate` parameter(s) have been changed from `(context.Context, string, string, string, SAPApplicationServerInstance, *SAPApplicationServerInstancesClientBeginCreateOptions)` to `(context.Context, string, string, string, *SAPApplicationServerInstancesClientBeginCreateOptions)`
      info	[Changelog] - Function `*SAPApplicationServerInstancesClient.BeginUpdate` parameter(s) have been changed from `(context.Context, string, string, string, UpdateSAPApplicationInstanceRequest, *SAPApplicationServerInstancesClientBeginUpdateOptions)` to `(context.Context, string, string, string, *SAPApplicationServerInstancesClientBeginUpdateOptions)`
      info	[Changelog] - Function `*SAPCentralInstancesClient.BeginCreate` parameter(s) have been changed from `(context.Context, string, string, string, SAPCentralServerInstance, *SAPCentralInstancesClientBeginCreateOptions)` to `(context.Context, string, string, string, *SAPCentralInstancesClientBeginCreateOptions)`
      info	[Changelog] - Function `*SAPCentralInstancesClient.BeginUpdate` parameter(s) have been changed from `(context.Context, string, string, string, UpdateSAPCentralInstanceRequest, *SAPCentralInstancesClientBeginUpdateOptions)` to `(context.Context, string, string, string, *SAPCentralInstancesClientBeginUpdateOptions)`
      info	[Changelog] - Function `*SAPDatabaseInstancesClient.BeginCreate` parameter(s) have been changed from `(context.Context, string, string, string, SAPDatabaseInstance, *SAPDatabaseInstancesClientBeginCreateOptions)` to `(context.Context, string, string, string, *SAPDatabaseInstancesClientBeginCreateOptions)`
      info	[Changelog] - Function `*SAPDatabaseInstancesClient.BeginUpdate` parameter(s) have been changed from `(context.Context, string, string, string, UpdateSAPDatabaseInstanceRequest, *SAPDatabaseInstancesClientBeginUpdateOptions)` to `(context.Context, string, string, string, *SAPDatabaseInstancesClientBeginUpdateOptions)`
      info	[Changelog] - Function `*SAPVirtualInstancesClient.BeginCreate` parameter(s) have been changed from `(context.Context, string, string, SAPVirtualInstance, *SAPVirtualInstancesClientBeginCreateOptions)` to `(context.Context, string, string, *SAPVirtualInstancesClientBeginCreateOptions)`
      info	[Changelog] - Function `*SAPVirtualInstancesClient.Update` parameter(s) have been changed from `(context.Context, string, string, UpdateSAPVirtualInstanceRequest, *SAPVirtualInstancesClientUpdateOptions)` to `(context.Context, string, string, *SAPVirtualInstancesClientUpdateOptions)`
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `SAPSoftwareInstallationTypeExternal`
      info	[Changelog] - New const `SAPVirtualInstanceStateSoftwareDetectionFailed`
      info	[Changelog] - New const `SAPVirtualInstanceStateSoftwareDetectionInProgress`
      info	[Changelog] - New const `SSLPreferenceDisabled`
      info	[Changelog] - New const `SSLPreferenceRootCertificate`
      info	[Changelog] - New const `SSLPreferenceServerCertificate`
      info	[Changelog] - New type alias `SSLPreference`
      info	[Changelog] - New function `*ExternalInstallationSoftwareConfiguration.GetSoftwareConfiguration() *SoftwareConfiguration`
      info	[Changelog] - New function `PossibleSSLPreferenceValues() []SSLPreference`
      info	[Changelog] - New struct `ExternalInstallationSoftwareConfiguration`
      info	[Changelog] - New field `SSLCertificateURI` in struct `DB2ProviderInstanceProperties`
      info	[Changelog] - New field `SSLPreference` in struct `DB2ProviderInstanceProperties`
      info	[Changelog] - New field `SSLCertificateURI` in struct `HanaDbProviderInstanceProperties`
      info	[Changelog] - New field `SSLPreference` in struct `HanaDbProviderInstanceProperties`
      info	[Changelog] - New field `StorageAccountArmID` in struct `MonitorProperties`
      info	[Changelog] - New field `ZoneRedundancyPreference` in struct `MonitorProperties`
      info	[Changelog] - New field `SSLCertificateURI` in struct `MsSQLServerProviderInstanceProperties`
      info	[Changelog] - New field `SSLPreference` in struct `MsSQLServerProviderInstanceProperties`
      info	[Changelog] - New field `SSLCertificateURI` in struct `PrometheusHaClusterProviderInstanceProperties`
      info	[Changelog] - New field `SSLPreference` in struct `PrometheusHaClusterProviderInstanceProperties`
      info	[Changelog] - New field `SSLCertificateURI` in struct `PrometheusOSProviderInstanceProperties`
      info	[Changelog] - New field `SSLPreference` in struct `PrometheusOSProviderInstanceProperties`
      info	[Changelog] - New field `Body` in struct `SAPApplicationServerInstancesClientBeginCreateOptions`
      info	[Changelog] - New field `Body` in struct `SAPApplicationServerInstancesClientBeginUpdateOptions`
      info	[Changelog] - New field `Body` in struct `SAPCentralInstancesClientBeginCreateOptions`
      info	[Changelog] - New field `Body` in struct `SAPCentralInstancesClientBeginUpdateOptions`
      info	[Changelog] - New field `Body` in struct `SAPDatabaseInstancesClientBeginCreateOptions`
      info	[Changelog] - New field `Body` in struct `SAPDatabaseInstancesClientBeginUpdateOptions`
      info	[Changelog] - New field `Body` in struct `SAPVirtualInstancesClientBeginCreateOptions`
      info	[Changelog] - New field `Body` in struct `SAPVirtualInstancesClientUpdateOptions`
      info	[Changelog] - New field `SSLCertificateURI` in struct `SapNetWeaverProviderInstanceProperties`
      info	[Changelog] - New field `SSLPreference` in struct `SapNetWeaverProviderInstanceProperties`
      info	[Changelog]
      info	[Changelog] Total 8 breaking change(s), 26 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 495363b. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-workloads [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added Interface ExternalInstallationSoftwareConfiguration
      info	[Changelog]   - Added Type Alias SslPreference
      info	[Changelog]   - Interface DB2ProviderInstanceProperties has a new optional parameter sslCertificateUri
      info	[Changelog]   - Interface DB2ProviderInstanceProperties has a new optional parameter sslPreference
      info	[Changelog]   - Interface HanaDbProviderInstanceProperties has a new optional parameter sslCertificateUri
      info	[Changelog]   - Interface HanaDbProviderInstanceProperties has a new optional parameter sslPreference
      info	[Changelog]   - Interface Monitor has a new optional parameter storageAccountArmId
      info	[Changelog]   - Interface Monitor has a new optional parameter zoneRedundancyPreference
      info	[Changelog]   - Interface MsSqlServerProviderInstanceProperties has a new optional parameter sslCertificateUri
      info	[Changelog]   - Interface MsSqlServerProviderInstanceProperties has a new optional parameter sslPreference
      info	[Changelog]   - Interface PrometheusHaClusterProviderInstanceProperties has a new optional parameter sslCertificateUri
      info	[Changelog]   - Interface PrometheusHaClusterProviderInstanceProperties has a new optional parameter sslPreference
      info	[Changelog]   - Interface PrometheusOSProviderInstanceProperties has a new optional parameter sslCertificateUri
      info	[Changelog]   - Interface PrometheusOSProviderInstanceProperties has a new optional parameter sslPreference
      info	[Changelog]   - Interface SapNetWeaverProviderInstanceProperties has a new optional parameter sslCertificateUri
      info	[Changelog]   - Interface SapNetWeaverProviderInstanceProperties has a new optional parameter sslPreference
      info	[Changelog]   - Added Enum KnownSslPreference
      info	[Changelog]   - Enum KnownSAPSoftwareInstallationType has a new value External
      info	[Changelog]   - Enum KnownSAPVirtualInstanceState has a new value SoftwareDetectionFailed
      info	[Changelog]   - Enum KnownSAPVirtualInstanceState has a new value SoftwareDetectionInProgress
    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 495363b. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️workloads [View full logs]  [Release Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Nov 28, 2022

    Generated ApiView

    Language Package Name ApiView Link
    Python track2_azure-mgmt-workloads https://apiview.dev/Assemblies/Review/3ee33fd35e4b40959bbeeb44b4157196
    Go sdk/resourcemanager/workloads/armworkloads https://apiview.dev/Assemblies/Review/c3a064e3431648f89eb7f2c4cb942eaf
    .Net Azure.ResourceManager.Workloads https://apiview.dev/Assemblies/Review/ea07902b1a2e40f7a3a672f4e5bfce23
    Java azure-resourcemanager-workloads https://apiview.dev/Assemblies/Review/d0880627faf84110966d9a9949a50485
    JavaScript @azure/arm-workloads https://apiview.dev/Assemblies/Review/8fcc14d8bea74c4eae0a47ccd185354b

    @ruowan ruowan assigned ruowan and unassigned raych1 Nov 28, 2022
    @ruowan ruowan added Approved-ModelValidation Approved-SemanticValidation Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 labels Nov 28, 2022
    @AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-FixRequiredOnFailure resource-manager RPaaS labels Nov 28, 2022
    @openapi-workflow-bot
    Copy link

    Hi @ruowan, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @openapi-workflow-bot
    Copy link

    Hi @ruowan, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @ruowan ruowan merged commit 495363b into main Nov 28, 2022
    @ruowan ruowan deleted the revert-21604-dindurkhya/ACSS-Swagger-Changes branch November 28, 2022 06:44
    ruowan added a commit that referenced this pull request Nov 28, 2022
    ghost pushed a commit to Azure/azure-resource-manager-schemas that referenced this pull request Nov 28, 2022
    ruowan added a commit that referenced this pull request Dec 5, 2022
    anandanthony pushed a commit to anandMicro/azure-rest-api-specs that referenced this pull request Dec 16, 2022
    anandanthony pushed a commit to anandMicro/azure-rest-api-specs that referenced this pull request Dec 16, 2022
    kayousef-zz pushed a commit to kayousef-zz/azure-rest-api-specs that referenced this pull request Dec 21, 2022
    kayousef-zz pushed a commit to kayousef-zz/azure-rest-api-specs that referenced this pull request Dec 21, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-ModelValidation Approved-SemanticValidation BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go CI-FixRequiredOnFailure resource-manager RPaaS
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants