Added Files OAuth

[seanmcc-msft]

No description provided.

[openapi-workflow-bot]

Hi, @seanmcc-msft Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

[openapi-pipeline-app]

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️❌Breaking Change(Cross-Version): 75 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.2)]	new version	base version
file.json	2022-11-02(37d9a77)	2021-12-02(main)

The following breaking changes are detected by comparison with the latest preview version:

Only 30 items are listed, please refer to log for more details.

Rule	Message
❌ 1009 - RemovedRequiredParameter	The required parameter 'shareName' was removed in the new version. Old: Microsoft.FileStorage/preview/2021-12-02/file.json#L1946:9
❌ 1009 - RemovedRequiredParameter	The required parameter 'directory' was removed in the new version. Old: Microsoft.FileStorage/preview/2021-12-02/file.json#L2247:9
❌ 1009 - RemovedRequiredParameter	The required parameter 'directory' was removed in the new version. Old: Microsoft.FileStorage/preview/2021-12-02/file.json#L2487:9
❌ 1009 - RemovedRequiredParameter	The required parameter 'shareName' was removed in the new version. Old: Microsoft.FileStorage/preview/2021-12-02/file.json#L4570:9
❌ 1019 - RemovedEnumValue	The new version is removing enum value(s) '2021-12-02' from the old version. Old: Microsoft.FileStorage/preview/2021-12-02/file.json#L46:9
❌ 1019 - RemovedEnumValue	The new version is removing enum value(s) '2021-12-02' from the old version. Old: Microsoft.FileStorage/preview/2021-12-02/file.json#L93:9
❌ 1019 - RemovedEnumValue	The new version is removing enum value(s) '2021-12-02' from the old version. Old: Microsoft.FileStorage/preview/2021-12-02/file.json#L164:9
❌ 1019 - RemovedEnumValue	The new version is removing enum value(s) '2021-12-02' from the old version. Old: Microsoft.FileStorage/preview/2021-12-02/file.json#L240:9
❌ 1019 - RemovedEnumValue	The new version is removing enum value(s) '2021-12-02' from the old version. Old: Microsoft.FileStorage/preview/2021-12-02/file.json#L313:9
❌ 1019 - RemovedEnumValue	The new version is removing enum value(s) '2021-12-02' from the old version. Old: Microsoft.FileStorage/preview/2021-12-02/file.json#L491:9
❌ 1019 - RemovedEnumValue	The new version is removing enum value(s) '2021-12-02' from the old version. Old: Microsoft.FileStorage/preview/2021-12-02/file.json#L566:9
❌ 1019 - RemovedEnumValue	The new version is removing enum value(s) '2021-12-02' from the old version. Old: Microsoft.FileStorage/preview/2021-12-02/file.json#L689:9
❌ 1019 - RemovedEnumValue	The new version is removing enum value(s) '2021-12-02' from the old version. Old: Microsoft.FileStorage/preview/2021-12-02/file.json#L804:9
❌ 1019 - RemovedEnumValue	The new version is removing enum value(s) '2021-12-02' from the old version. Old: Microsoft.FileStorage/preview/2021-12-02/file.json#L927:9
❌ 1019 - RemovedEnumValue	The new version is removing enum value(s) '2021-12-02' from the old version. Old: Microsoft.FileStorage/preview/2021-12-02/file.json#L1047:9
❌ 1019 - RemovedEnumValue	The new version is removing enum value(s) '2021-12-02' from the old version. Old: Microsoft.FileStorage/preview/2021-12-02/file.json#L1175:9
❌ 1019 - RemovedEnumValue	The new version is removing enum value(s) '2021-12-02' from the old version. Old: Microsoft.FileStorage/preview/2021-12-02/file.json#L1271:9
❌ 1019 - RemovedEnumValue	The new version is removing enum value(s) '2021-12-02' from the old version. Old: Microsoft.FileStorage/preview/2021-12-02/file.json#L1331:9
❌ 1019 - RemovedEnumValue	The new version is removing enum value(s) '2021-12-02' from the old version. Old: Microsoft.FileStorage/preview/2021-12-02/file.json#L1413:9
❌ 1019 - RemovedEnumValue	The new version is removing enum value(s) '2021-12-02' from the old version. Old: Microsoft.FileStorage/preview/2021-12-02/file.json#L1510:9
❌ 1019 - RemovedEnumValue	The new version is removing enum value(s) '2021-12-02' from the old version. Old: Microsoft.FileStorage/preview/2021-12-02/file.json#L1601:9
❌ 1019 - RemovedEnumValue	The new version is removing enum value(s) '2021-12-02' from the old version. Old: Microsoft.FileStorage/preview/2021-12-02/file.json#L1665:9
❌ 1019 - RemovedEnumValue	The new version is removing enum value(s) '2021-12-02' from the old version. Old: Microsoft.FileStorage/preview/2021-12-02/file.json#L1756:9
❌ 1019 - RemovedEnumValue	The new version is removing enum value(s) '2021-12-02' from the old version. Old: Microsoft.FileStorage/preview/2021-12-02/file.json#L1847:9
❌ 1019 - RemovedEnumValue	The new version is removing enum value(s) '2021-12-02' from the old version. Old: Microsoft.FileStorage/preview/2021-12-02/file.json#L1946:9
❌ 1019 - RemovedEnumValue	The new version is removing enum value(s) '2021-12-02' from the old version. Old: Microsoft.FileStorage/preview/2021-12-02/file.json#L2068:9
❌ 1019 - RemovedEnumValue	The new version is removing enum value(s) '2021-12-02' from the old version. Old: Microsoft.FileStorage/preview/2021-12-02/file.json#L2178:9
❌ 1019 - RemovedEnumValue	The new version is removing enum value(s) '2021-12-02' from the old version. Old: Microsoft.FileStorage/preview/2021-12-02/file.json#L2247:9
❌ 1019 - RemovedEnumValue	The new version is removing enum value(s) '2021-12-02' from the old version. Old: Microsoft.FileStorage/preview/2021-12-02/file.json#L2396:9
❌ 1019 - RemovedEnumValue	The new version is removing enum value(s) '2021-12-02' from the old version. Old: Microsoft.FileStorage/preview/2021-12-02/file.json#L2487:9

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.0.0)	new version	base version
package-2022-11	package-2022-11(37d9a77)	package-2022-11(feature/storage/stg87base)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
❌ HostParametersValidation	The host parameter must be called 'endpoint'. Location: Microsoft.FileStorage/preview/2022-11-02/file.json#L16
❌ HostParametersValidation	The host parameter must be typed 'type 'string', format 'url''. Location: Microsoft.FileStorage/preview/2022-11-02/file.json#L16
❌ XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2022-11-02/file.json#L135
❌ XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2022-11-02/file.json#L145
❌ XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2022-11-02/file.json#L221
❌ IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.FileStorage/preview/2022-11-02/file.json#L361
❌ IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.FileStorage/preview/2022-11-02/file.json#L366
❌ IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.FileStorage/preview/2022-11-02/file.json#L371
❌ IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.FileStorage/preview/2022-11-02/file.json#L376
❌ IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.FileStorage/preview/2022-11-02/file.json#L387
❌ XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2022-11-02/file.json#L547
❌ XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2022-11-02/file.json#L644
❌ XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2022-11-02/file.json#L670
❌ XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2022-11-02/file.json#L759
❌ XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2022-11-02/file.json#L785
❌ XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2022-11-02/file.json#L882
❌ XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2022-11-02/file.json#L908
❌ XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2022-11-02/file.json#L1002
❌ XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2022-11-02/file.json#L1028
❌ IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.FileStorage/preview/2022-11-02/file.json#L1080
❌ XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2022-11-02/file.json#L1130
❌ XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2022-11-02/file.json#L1156
❌ XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2022-11-02/file.json#L1239
❌ XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2022-11-02/file.json#L1249
❌ XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2022-11-02/file.json#L1390
❌ XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2022-11-02/file.json#L1400
❌ XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2022-11-02/file.json#L1487
❌ XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2022-11-02/file.json#L1497
❌ XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2022-11-02/file.json#L1578
❌ XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2022-11-02/file.json#L1588

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

[openapi-pipeline-app]

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account. 

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

_{Posted by Swagger Pipeline | How to fix these errors?}

[openapi-pipeline-app]

Swagger pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

[JeffreyRichter]

This looks fine except for "description": "Valid value is backup". Obviously, 'none' is also a valid value, but this description doesn't describe at all what the purpose of this header is. So, I can't tell how good this change is since I have no clue as to what it's trying to accomplish. I also see that the enum is not modeled as a string; this is OK if the header is only ever a request header and never a response header. If the header is also a response header, then this enum really should be modeled as a string to allow for more enum values in the future without breaking existing customer scenarios.

I'll approve the PR but what I wrote above should be addressed/considered.

[ghost]

Hi, @seanmcc-msft. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

[ghost]

Hi, @seanmcc-msft. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

[openapi-workflow-bot]

Hi @seanmcc-msft, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.