Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ivalbert fix patch2 #22006

Conversation

ivaliyivanov
Copy link
Contributor

@ivaliyivanov ivaliyivanov commented Dec 28, 2022

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @ivaliyivanov Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Dec 28, 2022

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Dec 28, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    Swagger pipeline started successfully. If there is ApiView generated, it will be updated in this comment.

    @ivaliyivanov ivaliyivanov marked this pull request as ready for review December 28, 2022 20:08
    @ivaliyivanov ivaliyivanov merged commit eec0958 into machinelearningservices-Microsoft.MachineLearningServices-2022-12-01-preview Dec 28, 2022
    @ivaliyivanov ivaliyivanov deleted the ivalbert_fix_patch2 branch December 28, 2022 21:02
    ArcturusZhang pushed a commit that referenced this pull request Feb 1, 2023
    …1 preview (#21761)
    
    * Adds base for updating Microsoft.MachineLearningServices from version preview/2022-10-01-preview to version 2022-12-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Add Dec API Registries Swagger (#21419)
    
    * add december registries swagger + examples
    
    * add status code 202 in examples
    
    * fix 202 examples
    
    * fixes
    
    * fixes
    
    * fix
    
    * add 202 back in for put/patch
    
    Co-authored-by: Komal Yadav <komalyadav@microsoft.com>
    
    * remove location (#21430)
    
    Co-authored-by: Komal Yadav <komalyadav@microsoft.com>
    
    * remove readonly flag on schedules property for CI (#21653)
    
    Co-authored-by: Naman Agarwal <naagarw@microsoft.com>
    
    * add missing workspace properties (#21725)
    
    * December preview updating mfe.json specs (#21510)
    
    * December preview updating mfe.json specs
    
    * MFE Dec 2022 Preview API - Adding logbase
    
    * MFE 2022-12-01-preview swagger spec model validation fix
    
    * MFE 2022-12-01-preview swagger spec model validation fix, add missing location
    
    * MFE 2022-12-01-preview swagger spec model validation - typo fix
    
    * MFE 2022-12-01-preview swagger spec model validation - fix api version in automljob example
    
    * MFE 2022-12-01-preview swagger spec model validation - fix for multiselectenabled error
    
    * MFE 2022-12-01-preview swagger spec model validation - fix for multiselectenabled error
    
    * Fix  for 1006 - RemovedDefinition (RecurrenceTrigger,CronTrigger) (#21822)
    
    * fix ReadonlyPropertyChanged of MLC (#21814)
    
    Co-authored-by: Bingchen Li <bingchenli@microsoft.com>
    
    * fixed custom-words conflict (#21829)
    
    * fix custom-words conflict merge (#21830)
    
    * example fix (INVALID_REQUEST_PARAMETER) (#21832)
    
    Co-authored-by: Ivaliy Ivanov <ivaliyivanov@Ivaliys-MacBook-Air.local>
    
    * example fix, use correct api preview version  - (INVALID_REQUEST_PARAMETER) (#21833)
    
    Co-authored-by: Ivaliy Ivanov <ivaliyivanov@Ivaliys-MacBook-Air.local>
    
    * Revert breaking change for MLC swagger 2022-12-01-preview (#21885)
    
    Co-authored-by: Bingchen Li <bingchenli@microsoft.com>
    
    * Revert Connection Category back to enum. (#21939)
    
    * revert provisioning state change (#21940)
    
    * remove body (#21978)
    
    Co-authored-by: Komal Yadav <komalyadav@microsoft.com>
    
    * Addressed comments, added x-ms-long-running-operation to a patch call (#22005)
    
    * Addressed comments, added x-ms-long-running-operation to a patch call
    
    * fix examples for patch - remove body
    
    * fixed formatting
    
    * Ivalbert fix patch2 (#22006)
    
    * Addressed comments, added x-ms-long-running-operation to a patch call
    
    * fix examples for patch - remove body
    
    * fixed formatting
    
    * fixed formatting
    
    * Updated custom words (#22262)
    
    * Fixed prettier errors (#22237)
    
    * fixed examples for LRO_RESPONSE_HEADER check (#22293)
    
    * fixed examples for LRO_RESPONSE_HEADER check (#22294)
    
    * Example fix - OBJECT_MISSING_REQUIRED_PROPERTY - Missing required property: triggerType (#22317)
    
    ---------
    
    Co-authored-by: Komal Yadav <23komal.yadav23@gmail.com>
    Co-authored-by: Komal Yadav <komalyadav@microsoft.com>
    Co-authored-by: Naman Agarwal <namanag16@gmail.com>
    Co-authored-by: Naman Agarwal <naagarw@microsoft.com>
    Co-authored-by: ZhidaLiu <zhili@microsoft.com>
    Co-authored-by: libc16 <88697960+libc16@users.noreply.github.com>
    Co-authored-by: Bingchen Li <bingchenli@microsoft.com>
    Co-authored-by: Ivaliy Ivanov <ivaliyivanov@Ivaliys-MacBook-Air.local>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants